)]}'
{"id":"openocd~master~I36bc1ac6b6c036539f4175f1e65223ba10a35355","project":"openocd","branch":"master","hashtags":[],"change_id":"I36bc1ac6b6c036539f4175f1e65223ba10a35355","subject":"tcl: Support for Analog Devices ADSP-SC58x / ADSP-SC584-EZBRD","status":"MERGED","created":"2019-01-17 00:02:59.000000000","updated":"2019-01-26 22:32:10.000000000","submitted":"2019-01-26 22:32:10.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"4855-1548541930909-0b98e83d","meta_rev_id":"f499e046f0f6fef88fb02cf39c3b43c9c8a84734","_number":4855,"owner":{"_account_id":1000577,"name":"Peter Lawrence","email":"majbthrd@gmail.com","username":"majbthrd"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":1,"date":"2019-01-26 22:32:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"value":2,"date":"2019-01-26 22:32:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-01-18 22:18:52.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-01-26 22:32:10.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"3efac6642f6a1e29102db771f187e061035f73c0","author":{"_account_id":1000577,"name":"Peter Lawrence","email":"majbthrd@gmail.com","username":"majbthrd"},"real_author":{"_account_id":1000577,"name":"Peter Lawrence","email":"majbthrd@gmail.com","username":"majbthrd"},"date":"2019-01-17 00:02:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c579325a79f0efdebc0474b4c07ee88aeb8172f5","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2019-01-17 00:22:59.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/11022/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/10370/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"ac64e11a7b05c4f60b3aadce125d8fcde8e4bfd6","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2019-01-18 08:16:51.000000000","message":"Patch Set 1:\n\n(3 comments)\n\nPeter, thanks for the patch.\nJust minor remarks.","accounts_in_message":[],"_revision_number":1},{"id":"2938557580ad55c99ac1b33b45ebd1bb3681b954","author":{"_account_id":1000577,"name":"Peter Lawrence","email":"majbthrd@gmail.com","username":"majbthrd"},"real_author":{"_account_id":1000577,"name":"Peter Lawrence","email":"majbthrd@gmail.com","username":"majbthrd"},"date":"2019-01-18 21:27:55.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"22f6f5545c5696c58a8eebb6f066701cf117b3b2","author":{"_account_id":1000577,"name":"Peter Lawrence","email":"majbthrd@gmail.com","username":"majbthrd"},"real_author":{"_account_id":1000577,"name":"Peter Lawrence","email":"majbthrd@gmail.com","username":"majbthrd"},"date":"2019-01-18 21:40:17.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"e12f2ae289c8ff0be1502c0302034a27b9b35396","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2019-01-18 21:40:17.000000000","message":"Patch Set 2: Verified-1\n\nBuild Failed \n\nhttp://build.openocd.org/job/openocd-gerrit-build/10375/ : ABORTED\n\nhttp://build.openocd.org/job/openocd-gerrit/11027/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"55451a425ee5e6a420a7cd631a2a1956ac5ef6ec","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2019-01-18 22:18:52.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/11029/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/10377/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"5e0322cc55c2db20d3e2779ff9e0da201a465680","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2019-01-19 10:42:54.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"f499e046f0f6fef88fb02cf39c3b43c9c8a84734","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2019-01-26 22:32:10.000000000","message":"Change has been successfully cherry-picked as 8417a569fecf54e699e526259c9731ef747adb38 by Tomas Vanek","accounts_in_message":[],"_revision_number":4}],"current_revision":"8417a569fecf54e699e526259c9731ef747adb38","revisions":{"8417a569fecf54e699e526259c9731ef747adb38":{"kind":"REWORK","_number":4,"created":"2019-01-26 22:32:10.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/55/4855/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/55/4855/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/55/4855/4 \u0026\u0026 git checkout -b change-4855 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/55/4855/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/55/4855/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/55/4855/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/55/4855/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/55/4855/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f63b519385a8d6dca9b75f29f26d3144fd774bb4","subject":"jtag: cmsis-dap: use macro SWJ_PIN_SRST in place of magic value"}],"author":{"name":"Peter Lawrence","email":"majbthrd@gmail.com","date":"2019-01-17 00:00:34.000000000","tz":-360},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2019-01-26 22:32:10.000000000","tz":0},"subject":"tcl: Support for Analog Devices ADSP-SC58x / ADSP-SC584-EZBRD","message":"tcl: Support for Analog Devices ADSP-SC58x / ADSP-SC584-EZBRD\n\nThe original script was broken by changes to the Cortex-A code.  The\nrecent introduction of the mem_ap target provided a new mechanism to\nallow the script to be fixed.  This also adds an example board script\nfor the ADSP-SC584-EZBRD.\n\nChange-Id: I36bc1ac6b6c036539f4175f1e65223ba10a35355\nSigned-off-by: Peter Lawrence \u003cmajbthrd@gmail.com\u003e\nReviewed-on: http://openocd.zylin.com/4855\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"ddf96a363e828b0890694af6068c4ba06883e9b2":{"kind":"REWORK","_number":1,"created":"2019-01-17 00:02:59.000000000","uploader":{"_account_id":1000577,"name":"Peter Lawrence","email":"majbthrd@gmail.com","username":"majbthrd"},"ref":"refs/changes/55/4855/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/55/4855/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/55/4855/1 \u0026\u0026 git checkout -b change-4855 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/55/4855/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/55/4855/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/55/4855/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/55/4855/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/55/4855/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d140fb27c6afbfa1fe609b5f0db274d4a5273483","subject":"cortex_m: fix bug in poll() machine state (external resume awareness)"}],"author":{"name":"Peter Lawrence","email":"majbthrd@gmail.com","date":"2019-01-17 00:00:34.000000000","tz":-360},"committer":{"name":"Peter Lawrence","email":"majbthrd@gmail.com","date":"2019-01-17 00:00:34.000000000","tz":-360},"subject":"tcl: Support for Analog Devices ADSP-SC58x / ADSP-SC584-EZBRD","message":"tcl: Support for Analog Devices ADSP-SC58x / ADSP-SC584-EZBRD\n\nThe original script was broken by changes to the Cortex-A code.  The\nrecent introduction of the mem_ap target provided a new mechanism to\nallow the script to be fixed.  This also adds an example board script\nfor the ADSP-SC584-EZBRD.\n\nChange-Id: I36bc1ac6b6c036539f4175f1e65223ba10a35355\nSigned-off-by: Peter Lawrence \u003cmajbthrd@gmail.com\u003e\n"}},"c670d981912653bc3ad77bf8b8306341d2e60c3d":{"kind":"NO_CHANGE","_number":2,"created":"2019-01-18 21:27:55.000000000","uploader":{"_account_id":1000577,"name":"Peter Lawrence","email":"majbthrd@gmail.com","username":"majbthrd"},"ref":"refs/changes/55/4855/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/55/4855/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/55/4855/2 \u0026\u0026 git checkout -b change-4855 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/55/4855/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/55/4855/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/55/4855/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/55/4855/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/55/4855/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d140fb27c6afbfa1fe609b5f0db274d4a5273483","subject":"cortex_m: fix bug in poll() machine state (external resume awareness)"}],"author":{"name":"Peter Lawrence","email":"majbthrd@gmail.com","date":"2019-01-17 00:00:34.000000000","tz":-360},"committer":{"name":"Peter Lawrence","email":"majbthrd@gmail.com","date":"2019-01-18 21:27:38.000000000","tz":-360},"subject":"tcl: Support for Analog Devices ADSP-SC58x / ADSP-SC584-EZBRD","message":"tcl: Support for Analog Devices ADSP-SC58x / ADSP-SC584-EZBRD\n\nThe original script was broken by changes to the Cortex-A code.  The\nrecent introduction of the mem_ap target provided a new mechanism to\nallow the script to be fixed.  This also adds an example board script\nfor the ADSP-SC584-EZBRD.\n\nChange-Id: I36bc1ac6b6c036539f4175f1e65223ba10a35355\nSigned-off-by: Peter Lawrence \u003cmajbthrd@gmail.com\u003e\n"}},"bfb3946c29456b01c033d23c30fca5c7aec50c2f":{"kind":"REWORK","_number":3,"created":"2019-01-18 21:40:17.000000000","uploader":{"_account_id":1000577,"name":"Peter Lawrence","email":"majbthrd@gmail.com","username":"majbthrd"},"ref":"refs/changes/55/4855/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/55/4855/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/55/4855/3 \u0026\u0026 git checkout -b change-4855 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/55/4855/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/55/4855/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/55/4855/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/55/4855/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/55/4855/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d140fb27c6afbfa1fe609b5f0db274d4a5273483","subject":"cortex_m: fix bug in poll() machine state (external resume awareness)"}],"author":{"name":"Peter Lawrence","email":"majbthrd@gmail.com","date":"2019-01-17 00:00:34.000000000","tz":-360},"committer":{"name":"Peter Lawrence","email":"majbthrd@gmail.com","date":"2019-01-18 21:40:04.000000000","tz":-360},"subject":"tcl: Support for Analog Devices ADSP-SC58x / ADSP-SC584-EZBRD","message":"tcl: Support for Analog Devices ADSP-SC58x / ADSP-SC584-EZBRD\n\nThe original script was broken by changes to the Cortex-A code.  The\nrecent introduction of the mem_ap target provided a new mechanism to\nallow the script to be fixed.  This also adds an example board script\nfor the ADSP-SC584-EZBRD.\n\nChange-Id: I36bc1ac6b6c036539f4175f1e65223ba10a35355\nSigned-off-by: Peter Lawrence \u003cmajbthrd@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}