)]}'
{"id":"openocd~master~I88b2877517a18dac460253ae6d97f3dded054e6c","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001667":{"account":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"last_update":"2021-11-12 20:31:46.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2021-11-12 20:31:46.000000000","reason":"Change was submitted"},"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2021-11-06 10:17:15.000000000","reason":"Marc Schink replied on the change"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2021-11-04 08:00:48.000000000","reason":"removed on reply"},"1001036":{"account":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"last_update":"2021-11-12 20:31:46.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I88b2877517a18dac460253ae6d97f3dded054e6c","subject":"Update jtagspi driver for 1-, 2- and 4-byte addresses","status":"MERGED","created":"2019-01-28 10:25:15.000000000","updated":"2021-11-12 20:31:46.000000000","submitted":"2021-11-12 20:31:46.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":23,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"4876","meta_rev_id":"8a567fb79aee7638d181e0d1fedcbed04bbeced6","_number":4876,"owner":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"value":0,"_account_id":1001847,"name":"Jean-François Nguyen","email":"jf@lambdaconcept.com"},{"value":0,"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-12 20:31:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"value":0,"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-12 20:31:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"value":0,"_account_id":1001847,"name":"Jean-François Nguyen","email":"jf@lambdaconcept.com"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-12 20:31:46.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-11-12 20:31:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"value":0,"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"_account_id":1001847,"name":"Jean-François Nguyen","email":"jf@lambdaconcept.com"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-01-15 18:16:37.000000000","updated_by":{"_account_id":1001847,"name":"Jean-François Nguyen","email":"jf@lambdaconcept.com"},"reviewer":{"_account_id":1001847,"name":"Jean-François Nguyen","email":"jf@lambdaconcept.com"},"state":"REVIEWER"},{"updated":"2021-05-15 13:18:22.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2021-05-17 18:26:27.000000000","updated_by":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"reviewer":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"REVIEWER"},{"updated":"2021-07-26 17:59:26.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-07-27 06:06:50.000000000","updated_by":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"reviewer":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"state":"REVIEWER"},{"updated":"2021-11-01 11:41:28.000000000","updated_by":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"02379fdc9589305cd91ba0e081743af82cc03b35","author":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"real_author":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"date":"2019-01-28 10:25:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1ecf44bc146421c304a6829c78508322ce2de823","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2019-01-28 12:02:49.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/11072/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/10420/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"886550cdc8d4b866d3899a9128bd21bbe3d26694","author":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"real_author":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"date":"2019-02-16 17:49:42.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"c68ec712124f96e8d392dbcb3ea13fbed681bc0c","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2019-02-16 18:10:00.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/11186/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/10528/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"44948bd2f351ee63334cb7b2263ca840bd380595","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2019-04-04 22:04:32.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"a3e642876b2a61fb286595f09d62ccb6edae4de8","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2019-04-06 13:11:26.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"140e07a334f715a50545466315603c0727b4830e","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2019-04-06 13:39:34.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"49636145dc24ce25021419ad5b48122d5099bb40","author":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"real_author":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"date":"2019-08-17 09:24:11.000000000","message":"Patch Set 2:\n\n(5 comments)\n\njtagspi_cmd modified so that it can be used for \u0027jtagspi cmd\u0027 easily.","accounts_in_message":[],"_revision_number":2},{"id":"3a05f712b0ddb0ec6595f2c2bbe2ba3d6c5453b3","author":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"real_author":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"date":"2019-08-17 09:24:28.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"926944e1fed252ab999fc48db5fb785f257a326e","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2019-08-17 09:44:21.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/12033/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/11342/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"287bd3e8fbecf428ce5fc7a645575c5725291d03","author":{"_account_id":1001847,"name":"Jean-François Nguyen","email":"jf@lambdaconcept.com"},"real_author":{"_account_id":1001847,"name":"Jean-François Nguyen","email":"jf@lambdaconcept.com"},"date":"2021-01-15 18:16:37.000000000","message":"Patch Set 3:\n\n\u003e Uploaded patch set 3.\n\nI tested this patch set after rebasing it against master (aaa6110d9b027acd1d027ef27c723ec9cf2381a0) and it seems to have fixed the bug mentioned in http://openocd.zylin.com/#/c/4853/","accounts_in_message":[],"_revision_number":3},{"id":"aed0d60c5d9a442aa47aeeedbe56011238484202","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2021-03-09 18:48:24.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"336cf830ff725c51c435f37377595a12540c426e","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2021-03-09 18:55:54.000000000","message":"Patch Set 4: Code-Review+1\n\nThanks, Andreas, for this change. I\u0027ve rebased so that it is again merge-able.\n\nI have been using this patch with Spansion S25FL128S and S25FL256S SPI flash memories on Nexys A7 and Nexys Video FPGA boards by Digilent. Works fine.\n\nOthers, do you please have any further review comments? This would be a very useful improvement to jtagspi.","accounts_in_message":[],"_revision_number":4},{"id":"62d206599608c67f5c00c2938144637741a83506","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-03-09 21:55:45.000000000","message":"Patch Set 4: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14091/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/13354/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"c991e820b8378b338b804a7d26f7452bec012ef2","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-03-14 21:00:47.000000000","message":"Patch Set 4:\n\nAndreas, is Jan\u0027s rebase ok with you?","accounts_in_message":[],"_revision_number":4},{"id":"eeade504cd071773d89e1e15d78115314a55022c","author":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"real_author":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"date":"2021-03-15 15:39:38.000000000","message":"Patch Set 4: Code-Review+1\n\nOh, yes, that\u0027s fine with me. In fact, I already wanted to rebase it in in Feb., but somehow I simply forgot about that ...","accounts_in_message":[],"_revision_number":4},{"id":"7b7dc8a7f770dcaefde807b522422b8c91cd3e59","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-03-15 17:26:27.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"8e0f814626cdd3127f7f70af2959012c9361e42d","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2021-03-15 21:36:10.000000000","message":"Patch Set 4: Code-Review-2\n\n(2 comments)\n\nIf you encounter wrong data types, do not introduce new ones but fix the code.","accounts_in_message":[],"_revision_number":4},{"id":"332488f66e6c613bbb72436e7361ecf85dcc251e","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2021-04-19 18:19:14.000000000","message":"Patch Set 4: Code-Review-1\n\nMy comments still apply","accounts_in_message":[],"_revision_number":4},{"id":"f2ba54078c82308598b14224212c1761d23c0525","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-04-19 18:40:37.000000000","message":"Patch Set 4: -Code-Review\n\nThanks Marc!","accounts_in_message":[],"_revision_number":4},{"id":"50c6afb095f7a39b5cd6933b1893e7b750c377f3","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2021-05-14 15:02:38.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"98f31896b014ddf92b0173ffeb7becd1117d38ad","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2021-05-14 15:08:06.000000000","message":"Patch Set 5:\n\n(2 comments)\n\nThe remaining findings are now addressed (and few more items). I have retested the current code with s25fl128s and s25fl256s flash memories.\n\nDo you please have further comments?\n\nNote: I have rebased this on top of http://openocd.zylin.com/#/c/6182/ which is currently also pending a review.\n\nThanks.","accounts_in_message":[],"_revision_number":5},{"id":"4a6c267d065a5a6ead20fc03719dfe25c0f81463","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-05-14 15:33:00.000000000","message":"Patch Set 5: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14552/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/13805/ : SUCCESS","accounts_in_message":[],"_revision_number":5},{"id":"0a2cd43a502f0e3a73746d432a2d20210fbbb6c2","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2021-05-15 12:29:56.000000000","message":"Patch Set 5:\n\n(1 comment)\n\nThanks for the fixes, Jan!","accounts_in_message":[],"_revision_number":5},{"id":"ca5f949ce46dfb1f247602828f391465e4c3ae49","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-05-15 13:18:22.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"01d428fd7ee92f1a437ddbc1d348309d47b9246a","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2021-05-15 17:23:34.000000000","message":"Patch Set 5:\n\n\u003e There is no gain for the compiled code as the compiler knows it for good from its variable lifetime analysis.\n\nI know, I wouldn\u0027t argue about compiled code / performance / whatever but about code readability and maintainability.\n\n\u003e And IMO the code readability is not better because there is big difference between really constant static const and once assigned temporary variable. Unlike in java I would better avoid this kind of const in C.\n\nWhat exactly is the disadvantage? This construct is quite common and often used, for example, in the Linux kernel.","accounts_in_message":[],"_revision_number":5},{"id":"2702702ef93f0359c6e3c2191804f0f6c009813f","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2021-05-17 14:25:21.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"c41a29b7c3ae830c87fc9dacdeaba46aebeadf41","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2021-05-17 14:26:17.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"71837afad15f6d2e331a3761452616a1bcd9bdce","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2021-05-17 14:30:52.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"be3e2d6dfec978931f84dcb1bcaa33908683583a","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-05-17 14:59:09.000000000","message":"Patch Set 6: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14571/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/13823/ : SUCCESS","accounts_in_message":[],"_revision_number":6},{"id":"b4c9fcce5e56ea7193096860d8b596cc8837162f","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2021-05-17 18:26:27.000000000","message":"Patch Set 6: Code-Review+1\n\nThanks, Jan!","accounts_in_message":[],"_revision_number":6},{"id":"886bddb4e2890148083a23454d4beeda13b0074c","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2021-05-18 08:05:03.000000000","message":"Uploaded patch set 7: Patch Set 6 was rebased.","accounts_in_message":[],"_revision_number":7},{"id":"10cf664410ee5cb520c4cd2844346b8b557b0aa7","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2021-05-18 08:06:07.000000000","message":"Patch Set 7:\n\nI\u0027ve rebased this once more to make it independent on http://openocd.zylin.com/#/c/6193/","accounts_in_message":[],"_revision_number":7},{"id":"ea5aac180c2e858306acd96841e5061cd8ed3a44","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-05-18 09:01:29.000000000","message":"Patch Set 7: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14575/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/13827/ : SUCCESS","accounts_in_message":[],"_revision_number":7},{"id":"47cb45805034148827f4132bfb6a37342779df7f","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2021-05-28 07:46:24.000000000","message":"Uploaded patch set 8.","accounts_in_message":[],"_revision_number":8},{"id":"5d9c9ed048c5ed853d5222fe9d91bacbde04aa3e","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2021-05-28 07:47:22.000000000","message":"Patch Set 8:\n\nRebased on top of current http://openocd.zylin.com/#/c/6182","accounts_in_message":[],"_revision_number":8},{"id":"b97ecb7557be3f4cb58a7da6235c5e488b98390c","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2021-05-28 08:29:12.000000000","message":"Uploaded patch set 9.","accounts_in_message":[],"_revision_number":9},{"id":"d6dc3658563b0e3a051fc8ebd29c11da80af19d6","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-05-28 08:29:14.000000000","message":"Patch Set 8: Verified-1\n\nBuild Failed \n\nhttp://build.openocd.org/job/openocd-gerrit-build/13908/ : ABORTED\n\nhttp://build.openocd.org/job/openocd-gerrit/14658/ : SUCCESS","accounts_in_message":[],"_revision_number":8},{"id":"af98a717d5fd09e2608c6ad34f093e1e3ff4eded","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-05-28 09:01:01.000000000","message":"Patch Set 9: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14659/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/13909/ : SUCCESS","accounts_in_message":[],"_revision_number":9},{"id":"3f1953ce3268e747d48aa5f08fa0212276a1438f","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2021-06-14 05:20:23.000000000","message":"Uploaded patch set 10: Patch Set 9 was rebased.","accounts_in_message":[],"_revision_number":10},{"id":"653961c7008122588fb2578ab88cfb09c22b2364","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2021-06-14 05:23:47.000000000","message":"Patch Set 10:\n\nThe prerequisite http://openocd.zylin.com/#/c/6182/ is now merged, so I have rebased this change.\n\nAll the findings so far have been addressed and I have re-tested the change on s25fl128s and s25fl256s flash memories.\n\nIf there is more to do prior to approval, please let me know. Otherwise the change is ready from my point of view. Thank you.","accounts_in_message":[],"_revision_number":10},{"id":"c7937127c840e881e391765a42e45611a92f18c8","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-06-14 05:50:23.000000000","message":"Patch Set 10: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14751/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/13997/ : SUCCESS","accounts_in_message":[],"_revision_number":10},{"id":"072fce73ecc27ce4c60655e4019a2fdb1f6ed3a9","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2021-06-30 05:17:56.000000000","message":"Patch Set 10: Code-Review+1\n\nThere have been quite a lot of review iterations, and all findings addressed.\n\nThe change has been re-tested against hardware (s25fl128s, s25fl256s).\n\nDo you see any further changes to be done or can we proceed with merge? Thanks.","accounts_in_message":[],"_revision_number":10},{"id":"683fe7f94d2df55d9778af8006ebcd39f3214062","author":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"real_author":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"date":"2021-06-30 12:02:03.000000000","message":"Patch Set 10:\n\nAs it\u0027s still not merged I\u0027d suggest to add a minor point: Adesto\u0027s ATXP032/064/128 added an incompatibility even in SPI mode, i.e. 4-byte addressing for *all* commands except simple read (0x03), although the capacity does not exceed 16 MByte :-(\nI\u0027m going to add an \"always_4byte on/off\" override command for all but 0x03 to two other drivers, maybe you\u0027d like to add a similar one here?\nDon\u0027t know whether the ATXPs might be of interest here, but ...","accounts_in_message":[],"_revision_number":10},{"id":"c10986ef32191670d73886578f0f88433a1d4265","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2021-06-30 12:50:29.000000000","message":"Patch Set 10:\n\n\u003e As it\u0027s still not merged I\u0027d suggest to add a minor point: Adesto\u0027s\n \u003e ATXP032/064/128 added an incompatibility even in SPI mode, i.e.\n \u003e 4-byte addressing for *all* commands except simple read (0x03),\n \u003e although the capacity does not exceed 16 MByte :-(\n \u003e I\u0027m going to add an \"always_4byte on/off\" override command for all\n \u003e but 0x03 to two other drivers, maybe you\u0027d like to add a similar\n \u003e one here?\n \u003e Don\u0027t know whether the ATXPs might be of interest here, but ...\n\nThank you for pointing this out. I do not have any ATXPs around to test it, but it definitely sounds like a nice improvement.\n\nDo you prefer to add it to this merge request or to submit a subsequent change?","accounts_in_message":[],"_revision_number":10},{"id":"5a6a23152580097ccb0dccc0015a9c319ef248f9","author":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"real_author":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"date":"2021-06-30 13:05:17.000000000","message":"Patch Set 10:\n\nWell, in theory a separate patch would be good, but I\u0027m afraid it would lie around for another one or two years ...","accounts_in_message":[],"_revision_number":10},{"id":"a03fcc1da00ddbc729945ac6ad0cc6c100813b3e","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2021-07-23 06:15:40.000000000","message":"Patch Set 10:\n\n\u003e As it\u0027s still not merged I\u0027d suggest to add a minor point: Adesto\u0027s ATXP032/064/128 added an incompatibility even in SPI mode, i.e. 4-byte addressing for *all* commands except simple read (0x03), although the capacity does not exceed 16 MByte :-( I\u0027m going to add an \"always_4byte on/off\" override command for all but 0x03 to two other drivers, maybe you\u0027d like to add a similar one here?\n\nHi Andreas -\n\nhow is it going with the \"always_4byte on/off\" improvement that you have proposed above?\n\nIf you can append it to this change in say a week or two, please fell free and go ahead :)\n\nIf that would require more time, I recommend not to wait and proceed with the to merge. As is, this change is ready, reviewed and tested already.\n\nThanks.","accounts_in_message":[],"_revision_number":10},{"id":"ff729489f12eb9b663002716a8636a9989b62546","author":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"real_author":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"date":"2021-07-26 17:26:21.000000000","message":"Uploaded patch set 11.","accounts_in_message":[],"_revision_number":11},{"id":"bed4c56ecfa9f9cbd7ece5853ccc18bbe3ee71ae","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-07-26 17:59:26.000000000","message":"Patch Set 11: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14891/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/14137/ : SUCCESS","accounts_in_message":[],"_revision_number":11},{"id":"60c541b721d9f54ce7b7d4870a64ad465e8e296e","author":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"real_author":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"date":"2021-07-26 18:15:32.000000000","message":"Patch Set 11:\n\nHi Jan,\nthat was a misunderstanding ... I though you would like to add this. But anyway, it\u0027s now there. Please could you verify that this change doesn\u0027t break anything? I\u0027ve made some tests, but my hardware stock for this driver is rather limited: XCS6SLX16 with W25Q80 or W25Q256 only.","accounts_in_message":[],"_revision_number":11},{"id":"f0911bd76e9a5c4af5ec1b77013741e6c2927d74","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2021-07-27 06:06:50.000000000","message":"Patch Set 11:\n\nHi Andreas, thank you for the addition. \n\nI would be happy to re-test the change on the flash memories I have at hand (s25fl128s and s25fl256s) early next week.\n\nRegards,\nJan","accounts_in_message":[],"_revision_number":11},{"id":"7db90b146ad2f9581988a58a9d4ff3ecd7d7df78","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2021-11-01 10:01:56.000000000","message":"Uploaded patch set 12: Patch Set 11 was rebased.","accounts_in_message":[],"_revision_number":12},{"id":"2c08214fd2a8b91dfb8b4c9b5e44ce53ee4f21d4","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2021-11-01 10:04:06.000000000","message":"Patch Set 12:\n\n(1 comment)","accounts_in_message":[],"_revision_number":12},{"id":"c79b5b3b9dd99de4897e3061bfc85271da855ff1","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-11-01 10:15:31.000000000","message":"Patch Set 12: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15441/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14659/ : SUCCESS","accounts_in_message":[],"_revision_number":12},{"id":"3b7cc9494a74b2a5fd4736f01f86b9b672d27f5b","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2021-11-01 11:41:28.000000000","message":"Patch Set 12: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":12},{"id":"9279f52c7b112d112582d6ceca160379da79be79","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-03 20:30:36.000000000","message":"Patch Set 12: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":12},{"id":"9fc4b65421ac6b5fa700fc3c1731f52978207d33","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2021-11-04 07:18:57.000000000","message":"Uploaded patch set 13.","accounts_in_message":[],"_revision_number":13},{"id":"2e8dd22e6363ae5dc2fc75e46eb3863294357660","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2021-11-04 07:20:36.000000000","message":"Patch Set 13: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":13},{"id":"0a595cd0d3fe01ea4ebc018cf09e8c13a619730c","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-11-04 07:32:25.000000000","message":"Patch Set 13: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15447/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14665/ : SUCCESS","accounts_in_message":[],"_revision_number":13},{"id":"c0a1844188d9a7401fe70680c7b73c1036213cdc","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-04 08:00:48.000000000","message":"Patch Set 13: Code-Review+2","accounts_in_message":[],"_revision_number":13},{"id":"5c504903580487e647224016fb1cfb08d0c28d95","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2021-11-06 10:17:15.000000000","message":"Patch Set 13: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":13},{"id":"8a567fb79aee7638d181e0d1fedcbed04bbeced6","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-12 20:31:46.000000000","message":"Change has been successfully cherry-picked as be57b0ab847e8246b354ca9203024737cdec403b","accounts_in_message":[],"_revision_number":14}],"current_revision":"be57b0ab847e8246b354ca9203024737cdec403b","revisions":{"1d40c3c2d1765234348fa62e591d4eb5b2b5f2f0":{"kind":"REWORK","_number":6,"created":"2021-05-17 14:25:21.000000000","uploader":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"ref":"refs/changes/76/4876/6","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/76/4876/6","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/6 \u0026\u0026 git checkout -b change-4876 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/76/4876/6","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a88d861d674766a912814eceb1c7d25d9727567d","subject":"flash/nor: improved API of flash_driver.info \u0026 fixed buffer overruns"}],"author":{"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","date":"2019-01-28 09:37:53.000000000","tz":60},"committer":{"name":"Jan Matyas","email":"matyas@codasip.com","date":"2021-05-17 14:24:28.000000000","tz":120},"subject":"Update jtagspi driver for 1-, 2- and 4-byte addresses","message":"Update jtagspi driver for 1-, 2- and 4-byte addresses\n\njtagspi driver always used 3-byte addresses regardless of actual\ndevice capcity. Now select 1- to 4-byte addresses depending on\ndevice capacity.\nSome devices need a special command to activate the 4-byte address\nmode, a special command to accomplish this, and a further command\nfor setting device properties are added.\nAdditionally, restriction (start of range had to be page aligned)\nremoved.\nTested with XCS6SLX16 board and W25Q256FV in 3- and 4-byte address\nmodes.\n\nChange-Id: I88b2877517a18dac460253ae6d97f3dded054e6c\nSigned-off-by: Andreas Bolsch \u003chyphen0break@gmail.com\u003e\nSigned-off-by: Jan Matyas \u003cmatyas@codasip.com\u003e\n"}},"2f0a9eb409c35f08b9632dd91434aea645a74227":{"kind":"TRIVIAL_REBASE","_number":7,"created":"2021-05-18 08:05:03.000000000","uploader":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"ref":"refs/changes/76/4876/7","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/76/4876/7","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/7 \u0026\u0026 git checkout -b change-4876 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/76/4876/7","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/7 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"162370f131cf20454b5fd247a2aa693a96a60d5f","subject":"flash/nor: improved API of flash_driver.info \u0026 fixed buffer overruns"}],"author":{"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","date":"2019-01-28 09:37:53.000000000","tz":60},"committer":{"name":"Jan Matyas","email":"matyas@codasip.com","date":"2021-05-18 08:04:31.000000000","tz":120},"subject":"Update jtagspi driver for 1-, 2- and 4-byte addresses","message":"Update jtagspi driver for 1-, 2- and 4-byte addresses\n\njtagspi driver always used 3-byte addresses regardless of actual\ndevice capcity. Now select 1- to 4-byte addresses depending on\ndevice capacity.\nSome devices need a special command to activate the 4-byte address\nmode, a special command to accomplish this, and a further command\nfor setting device properties are added.\nAdditionally, restriction (start of range had to be page aligned)\nremoved.\nTested with XCS6SLX16 board and W25Q256FV in 3- and 4-byte address\nmodes.\n\nChange-Id: I88b2877517a18dac460253ae6d97f3dded054e6c\nSigned-off-by: Andreas Bolsch \u003chyphen0break@gmail.com\u003e\nSigned-off-by: Jan Matyas \u003cmatyas@codasip.com\u003e\n"}},"51e506c9e8280d13995d4c4d773c7f5555116c57":{"kind":"REWORK","_number":4,"created":"2021-03-09 18:48:24.000000000","uploader":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"ref":"refs/changes/76/4876/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/76/4876/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/4 \u0026\u0026 git checkout -b change-4876 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/76/4876/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4307d93eb00ac27373c62f08b8547b993b66fe82","subject":"Restore normal development cycle"}],"author":{"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","date":"2019-01-28 09:37:53.000000000","tz":60},"committer":{"name":"Jan Matyas","email":"matyas@codasip.com","date":"2021-03-09 18:46:14.000000000","tz":60},"subject":"Update jtagspi driver for 1-, 2- and 4-byte addresses","message":"Update jtagspi driver for 1-, 2- and 4-byte addresses\n\njtagspi driver always used 3-byte addresses regardless of actual\ndevice capcity. Now select 1- to 4-byte addresses depending on\ndevice capacity.\nSome devices need a special command to activate the 4-byte address\nmode, a special command to accomplish this, and a further command\nfor setting device properties are added.\nAdditionally, restriction (start of range had to be page aligned)\nremoved.\nTested with XCS6SLX16 board and W25Q256FV in 3- and 4-byte address\nmodes.\n\nChange-Id: I88b2877517a18dac460253ae6d97f3dded054e6c\nSigned-off-by: Andreas Bolsch \u003chyphen0break@gmail.com\u003e\nSigned-off-by: Jan Matyas \u003cmatyas@codasip.com\u003e\n"}},"dd66c85f932988af75a06d7a84ccffec2f52baba":{"kind":"REWORK","_number":5,"created":"2021-05-14 15:02:38.000000000","uploader":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"ref":"refs/changes/76/4876/5","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/76/4876/5","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/5 \u0026\u0026 git checkout -b change-4876 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/76/4876/5","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a88d861d674766a912814eceb1c7d25d9727567d","subject":"flash/nor: improved API of flash_driver.info \u0026 fixed buffer overruns"}],"author":{"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","date":"2019-01-28 09:37:53.000000000","tz":60},"committer":{"name":"Jan Matyas","email":"matyas@codasip.com","date":"2021-05-14 15:02:20.000000000","tz":120},"subject":"Update jtagspi driver for 1-, 2- and 4-byte addresses","message":"Update jtagspi driver for 1-, 2- and 4-byte addresses\n\njtagspi driver always used 3-byte addresses regardless of actual\ndevice capcity. Now select 1- to 4-byte addresses depending on\ndevice capacity.\nSome devices need a special command to activate the 4-byte address\nmode, a special command to accomplish this, and a further command\nfor setting device properties are added.\nAdditionally, restriction (start of range had to be page aligned)\nremoved.\nTested with XCS6SLX16 board and W25Q256FV in 3- and 4-byte address\nmodes.\n\nChange-Id: I88b2877517a18dac460253ae6d97f3dded054e6c\nSigned-off-by: Andreas Bolsch \u003chyphen0break@gmail.com\u003e\nSigned-off-by: Jan Matyas \u003cmatyas@codasip.com\u003e\n"}},"a9c408f184f001d81b07a1ba100f6c3f3a1e810c":{"kind":"REWORK","_number":2,"created":"2019-02-16 17:49:42.000000000","uploader":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"ref":"refs/changes/76/4876/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/76/4876/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/2 \u0026\u0026 git checkout -b change-4876 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/76/4876/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7345801b69d2511252d587159bb9758532797233","subject":"target: do not allow \u0027target create\u0027 after init"}],"author":{"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","date":"2019-01-28 09:37:53.000000000","tz":60},"committer":{"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","date":"2019-02-16 17:44:37.000000000","tz":60},"subject":"Update jtagspi driver for 1-, 2- and 4-byte addresses","message":"Update jtagspi driver for 1-, 2- and 4-byte addresses\n\njtagspi driver always used 3-byte addresses regardless of actual\ndevice capcity. Now select 1- to 4-byte addresses depending on\ndevice capacity.\nSome devices need a special command to activate the 4-byte address\nmode, a special command to accomplish this, and a further command\nfor setting device properties are added.\nTested with XCS6SLX16 board and W25Q256FV in 3- and 4-byte address\nmodes.\n\nChange-Id: I88b2877517a18dac460253ae6d97f3dded054e6c\nSigned-off-by: Andreas Bolsch \u003chyphen0break@gmail.com\u003e\n"}},"e679f37d315f82e6021cd21639ffa8be4003a743":{"kind":"REWORK","_number":3,"created":"2019-08-17 09:24:28.000000000","uploader":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"ref":"refs/changes/76/4876/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/76/4876/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/3 \u0026\u0026 git checkout -b change-4876 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/76/4876/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"16496488d10fc9f6c340b81446a85eef2c95ce00","subject":"flash/nor/core: fix some minor typo"}],"author":{"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","date":"2019-01-28 09:37:53.000000000","tz":60},"committer":{"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","date":"2019-08-16 08:47:17.000000000","tz":120},"subject":"Update jtagspi driver for 1-, 2- and 4-byte addresses","message":"Update jtagspi driver for 1-, 2- and 4-byte addresses\n\njtagspi driver always used 3-byte addresses regardless of actual\ndevice capcity. Now select 1- to 4-byte addresses depending on\ndevice capacity.\nSome devices need a special command to activate the 4-byte address\nmode, a special command to accomplish this, and a further command\nfor setting device properties are added.\nAdditionally, restriction (start of range had to be page aligned)\nremoved.\nTested with XCS6SLX16 board and W25Q256FV in 3- and 4-byte address\nmodes.\n\nChange-Id: I88b2877517a18dac460253ae6d97f3dded054e6c\nSigned-off-by: Andreas Bolsch \u003chyphen0break@gmail.com\u003e\n"}},"457606c194eb73291235d7d76926fa992eb617ec":{"kind":"REWORK","_number":1,"created":"2019-01-28 10:25:15.000000000","uploader":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"ref":"refs/changes/76/4876/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/76/4876/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/1 \u0026\u0026 git checkout -b change-4876 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/76/4876/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7345801b69d2511252d587159bb9758532797233","subject":"target: do not allow \u0027target create\u0027 after init"}],"author":{"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","date":"2019-01-28 09:37:53.000000000","tz":60},"committer":{"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","date":"2019-01-28 10:22:40.000000000","tz":60},"subject":"Update jtagspi driver for 1-, 2- and 4-byte addresses","message":"Update jtagspi driver for 1-, 2- and 4-byte addresses\n\nTHIS PATCH IS *COMPLETELY* UNTESTED!\njtagspi driver always used 3-byte addresses regardless of actual\ndevice capcity. Now select 1- to 4-byte addresses depending on\ndevice capacity.\nSome devices need a special command to activate the 4-byte address\nmode, this driver unfortunately has no provisions for doing this.\nHence devices with more than 16 MBytes can be used only if they\nhave special read / write / sector erase commands always supposing\n4-byte addresses *AND* these commands are hardcoded in spi.c.\nAlternatively 4-byte address mode might be activated via a (non-)\nvolatile setting in the flash chip (but again, this can\u0027t be done by\nthe driver).\n\nChange-Id: I88b2877517a18dac460253ae6d97f3dded054e6c\nSigned-off-by: Andreas Bolsch \u003chyphen0break@gmail.com\u003e\n"}},"be57b0ab847e8246b354ca9203024737cdec403b":{"kind":"REWORK","_number":14,"created":"2021-11-12 20:31:46.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/76/4876/14","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/76/4876/14","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/14 \u0026\u0026 git checkout -b change-4876 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/14 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/14 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/14 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/76/4876/14","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/14 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b2ab2241f20fd3da11c92f8edde4639ab8ce996f","subject":"jimtcl: revert temporary workaround for memory leak in jimtcl 0.80"}],"author":{"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","date":"2019-01-28 09:37:53.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-12 20:31:46.000000000","tz":0},"subject":"Update jtagspi driver for 1-, 2- and 4-byte addresses","message":"Update jtagspi driver for 1-, 2- and 4-byte addresses\n\njtagspi driver always used 3-byte addresses regardless of actual\ndevice capcity. Now select 1- to 4-byte addresses depending on\ndevice capacity.\nSome devices need a special command to activate the 4-byte address\nmode, a special command to accomplish this, and a further command\nfor setting device properties are added.\nAdditionally, restriction (start of range had to be page aligned)\nremoved.\nTested with XCS6SLX16 board and W25Q256FV in 3- and 4-byte address\nmodes.\n\nChange-Id: I88b2877517a18dac460253ae6d97f3dded054e6c\nSigned-off-by: Andreas Bolsch \u003chyphen0break@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/4876\nReviewed-by: Jan Matyas \u003cmatyas@codasip.com\u003e\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-by: zapb \u003cdev@zapb.de\u003e\nTested-by: jenkins\n"}},"3b7cea94ccfa155dbf8852cd152b7846dce81eed":{"kind":"TRIVIAL_REBASE","_number":12,"created":"2021-11-01 10:01:56.000000000","uploader":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"ref":"refs/changes/76/4876/12","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/76/4876/12","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/12 \u0026\u0026 git checkout -b change-4876 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/12 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/12 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/12 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/76/4876/12","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/12 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"97db87c22eec204edfebd55973ee1211a1dba6d3","subject":"jtag/core: remove unused variable"}],"author":{"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","date":"2019-01-28 09:37:53.000000000","tz":60},"committer":{"name":"Jan Matyas","email":"matyas@codasip.com","date":"2021-11-01 08:47:17.000000000","tz":60},"subject":"Update jtagspi driver for 1-, 2- and 4-byte addresses","message":"Update jtagspi driver for 1-, 2- and 4-byte addresses\n\njtagspi driver always used 3-byte addresses regardless of actual\ndevice capcity. Now select 1- to 4-byte addresses depending on\ndevice capacity.\nSome devices need a special command to activate the 4-byte address\nmode, a special command to accomplish this, and a further command\nfor setting device properties are added.\nAdditionally, restriction (start of range had to be page aligned)\nremoved.\nTested with XCS6SLX16 board and W25Q256FV in 3- and 4-byte address\nmodes.\n\nChange-Id: I88b2877517a18dac460253ae6d97f3dded054e6c\nSigned-off-by: Andreas Bolsch \u003chyphen0break@gmail.com\u003e\n"}},"7265d528b0f41cdfa34b4730ef24df26e4bb803d":{"kind":"REWORK","_number":13,"created":"2021-11-04 07:18:57.000000000","uploader":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"ref":"refs/changes/76/4876/13","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/76/4876/13","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/13 \u0026\u0026 git checkout -b change-4876 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/13 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/13 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/13 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/76/4876/13","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/13 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"97db87c22eec204edfebd55973ee1211a1dba6d3","subject":"jtag/core: remove unused variable"}],"author":{"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","date":"2019-01-28 09:37:53.000000000","tz":60},"committer":{"name":"Jan Matyas","email":"matyas@codasip.com","date":"2021-11-04 07:18:41.000000000","tz":60},"subject":"Update jtagspi driver for 1-, 2- and 4-byte addresses","message":"Update jtagspi driver for 1-, 2- and 4-byte addresses\n\njtagspi driver always used 3-byte addresses regardless of actual\ndevice capcity. Now select 1- to 4-byte addresses depending on\ndevice capacity.\nSome devices need a special command to activate the 4-byte address\nmode, a special command to accomplish this, and a further command\nfor setting device properties are added.\nAdditionally, restriction (start of range had to be page aligned)\nremoved.\nTested with XCS6SLX16 board and W25Q256FV in 3- and 4-byte address\nmodes.\n\nChange-Id: I88b2877517a18dac460253ae6d97f3dded054e6c\nSigned-off-by: Andreas Bolsch \u003chyphen0break@gmail.com\u003e\n"}},"0c5e33a928dba1f1e4b10686dd8ede7cb40e5174":{"kind":"TRIVIAL_REBASE","_number":10,"created":"2021-06-14 05:20:23.000000000","uploader":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"ref":"refs/changes/76/4876/10","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/76/4876/10","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/10 \u0026\u0026 git checkout -b change-4876 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/10 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/10 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/10 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/76/4876/10","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/10 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cb5d9e0098a62b388fcfc7c89ddb6cda2be77a38","subject":"armv4_5: do not read/write non-existent registers"}],"author":{"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","date":"2019-01-28 09:37:53.000000000","tz":60},"committer":{"name":"Jan Matyas","email":"matyas@codasip.com","date":"2021-06-14 05:18:15.000000000","tz":120},"subject":"Update jtagspi driver for 1-, 2- and 4-byte addresses","message":"Update jtagspi driver for 1-, 2- and 4-byte addresses\n\njtagspi driver always used 3-byte addresses regardless of actual\ndevice capcity. Now select 1- to 4-byte addresses depending on\ndevice capacity.\nSome devices need a special command to activate the 4-byte address\nmode, a special command to accomplish this, and a further command\nfor setting device properties are added.\nAdditionally, restriction (start of range had to be page aligned)\nremoved.\nTested with XCS6SLX16 board and W25Q256FV in 3- and 4-byte address\nmodes.\n\nChange-Id: I88b2877517a18dac460253ae6d97f3dded054e6c\nSigned-off-by: Andreas Bolsch \u003chyphen0break@gmail.com\u003e\nSigned-off-by: Jan Matyas \u003cmatyas@codasip.com\u003e\n"}},"d6e5121289d6572cb6e5c53adca65a415abd210a":{"kind":"REWORK","_number":11,"created":"2021-07-26 17:26:21.000000000","uploader":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"ref":"refs/changes/76/4876/11","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/76/4876/11","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/11 \u0026\u0026 git checkout -b change-4876 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/11 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/11 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/11 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/76/4876/11","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/11 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ae6de2f93d960c7d35e8d4c86d9c17dda17c561e","subject":"arm_adi_v5: Added Cortex-A76 identifiers"}],"author":{"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","date":"2019-01-28 09:37:53.000000000","tz":60},"committer":{"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","date":"2021-07-25 17:57:18.000000000","tz":120},"subject":"Update jtagspi driver for 1-, 2- and 4-byte addresses","message":"Update jtagspi driver for 1-, 2- and 4-byte addresses\n\njtagspi driver always used 3-byte addresses regardless of actual\ndevice capcity. Now select 1- to 4-byte addresses depending on\ndevice capacity.\nSome devices need a special command to activate the 4-byte address\nmode, a special command to accomplish this, and a further command\nfor setting device properties are added.\nAdditionally, restriction (start of range had to be page aligned)\nremoved.\nTested with XCS6SLX16 board and W25Q256FV in 3- and 4-byte address\nmodes.\n\nChange-Id: I88b2877517a18dac460253ae6d97f3dded054e6c\nSigned-off-by: Andreas Bolsch \u003chyphen0break@gmail.com\u003e\n"}},"1bd184f7850082f8f48874a75a3a7613b224da16":{"kind":"REWORK","_number":8,"created":"2021-05-28 07:46:24.000000000","uploader":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"ref":"refs/changes/76/4876/8","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/76/4876/8","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/8 \u0026\u0026 git checkout -b change-4876 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/76/4876/8","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/8 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"442163e009671e888696a148e752bf815cf62446","subject":"flash/nor: improved API of flash_driver.info \u0026 fixed buffer overruns"}],"author":{"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","date":"2019-01-28 09:37:53.000000000","tz":60},"committer":{"name":"Jan Matyas","email":"matyas@codasip.com","date":"2021-05-28 07:45:37.000000000","tz":120},"subject":"Update jtagspi driver for 1-, 2- and 4-byte addresses","message":"Update jtagspi driver for 1-, 2- and 4-byte addresses\n\njtagspi driver always used 3-byte addresses regardless of actual\ndevice capcity. Now select 1- to 4-byte addresses depending on\ndevice capacity.\nSome devices need a special command to activate the 4-byte address\nmode, a special command to accomplish this, and a further command\nfor setting device properties are added.\nAdditionally, restriction (start of range had to be page aligned)\nremoved.\nTested with XCS6SLX16 board and W25Q256FV in 3- and 4-byte address\nmodes.\n\nChange-Id: I88b2877517a18dac460253ae6d97f3dded054e6c\nSigned-off-by: Andreas Bolsch \u003chyphen0break@gmail.com\u003e\nSigned-off-by: Jan Matyas \u003cmatyas@codasip.com\u003e\n"}},"e06c2387badf436ecc98031b2cc9b3bef576c54e":{"kind":"REWORK","_number":9,"created":"2021-05-28 08:29:12.000000000","uploader":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"ref":"refs/changes/76/4876/9","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/76/4876/9","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/9 \u0026\u0026 git checkout -b change-4876 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/76/4876/9","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/76/4876/9 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"442163e009671e888696a148e752bf815cf62446","subject":"flash/nor: improved API of flash_driver.info \u0026 fixed buffer overruns"}],"author":{"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","date":"2019-01-28 09:37:53.000000000","tz":60},"committer":{"name":"Jan Matyas","email":"matyas@codasip.com","date":"2021-05-28 08:28:20.000000000","tz":120},"subject":"Update jtagspi driver for 1-, 2- and 4-byte addresses","message":"Update jtagspi driver for 1-, 2- and 4-byte addresses\n\njtagspi driver always used 3-byte addresses regardless of actual\ndevice capcity. Now select 1- to 4-byte addresses depending on\ndevice capacity.\nSome devices need a special command to activate the 4-byte address\nmode, a special command to accomplish this, and a further command\nfor setting device properties are added.\nAdditionally, restriction (start of range had to be page aligned)\nremoved.\nTested with XCS6SLX16 board and W25Q256FV in 3- and 4-byte address\nmodes.\n\nChange-Id: I88b2877517a18dac460253ae6d97f3dded054e6c\nSigned-off-by: Andreas Bolsch \u003chyphen0break@gmail.com\u003e\nSigned-off-by: Jan Matyas \u003cmatyas@codasip.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}