)]}'
{"id":"openocd~master~I5966aa25e7c81348f4ad4d6e7ce5d4dee44ea4c8","project":"openocd","branch":"master","topic":"Tcl_return_values","hashtags":[],"change_id":"I5966aa25e7c81348f4ad4d6e7ce5d4dee44ea4c8","subject":"target: use LOG_USER to print errors in events","status":"MERGED","created":"2019-04-07 04:25:12.000000000","updated":"2019-05-14 18:33:13.000000000","submitted":"2019-05-14 18:33:13.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"5049-1557858793916-f72a7c5f","meta_rev_id":"938daa42b466622df7d65b2e898f1c32e2db9ac8","_number":5049,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":1,"date":"2019-05-14 18:33:13.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"value":2,"date":"2019-05-14 18:33:13.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-04-07 06:49:27.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-05-14 18:33:13.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"01990b0833446fb83e335e73c33e7e105cc3353d","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2019-04-07 04:25:12.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f8429822b47301620d5991b8f39309251f38f84a","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2019-04-07 06:49:27.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/11482/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/10815/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"4d45b67ccda84ea5b202f1983ab80b633760148a","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2019-04-07 07:48:22.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"37e3b65fd66ee3a802b1ce369b0996b864957008","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2019-05-14 18:33:13.000000000","message":"Change has been successfully cherry-picked as b3ce5a0ae5453a879a36856b5d8453722ba0f9b5 by Tomas Vanek","accounts_in_message":[],"_revision_number":2}],"current_revision":"b3ce5a0ae5453a879a36856b5d8453722ba0f9b5","revisions":{"b3ce5a0ae5453a879a36856b5d8453722ba0f9b5":{"kind":"REWORK","_number":2,"created":"2019-05-14 18:33:13.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/49/5049/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/49/5049/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/49/5049/2 \u0026\u0026 git checkout -b change-5049 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/49/5049/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/49/5049/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/49/5049/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/49/5049/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/49/5049/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"74cd25a4d39d85caeb275f178c1c93b4ff334810","subject":"target: change prototype of target_process_reset()"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2019-04-01 08:34:25.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2019-05-14 18:33:13.000000000","tz":60},"subject":"target: use LOG_USER to print errors in events","message":"target: use LOG_USER to print errors in events\n\nEvents are supposed to be executed asynchronously and not linked\nwith any command, so it\u0027s incorrect printing out an eventual error\nusing command_print().\nEven in the case of events triggered by the command\n\t\u003ctarget\u003e invoke-event \u003cevent-name\u003e\nthe eventual error in the event handler is not propagated to the\ncommand, so the command_print() is still not appropriate.\n\nReplace command_print() with LOG_USER() in target_handle_event().\nAdd further info in the log to identify which event has generated\nthe error and its associated target.\nBefore return, clean-up the error message and the stacktrace from\nthe error already displayed, to avoid propagate them.\n\nChange-Id: I5966aa25e7c81348f4ad4d6e7ce5d4dee44ea4c8\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: http://openocd.zylin.com/5049\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"250d4f09ce63884c57e60a2956e89adf2e16a67e":{"kind":"REWORK","_number":1,"created":"2019-04-07 04:25:12.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/49/5049/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/49/5049/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/49/5049/1 \u0026\u0026 git checkout -b change-5049 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/49/5049/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/49/5049/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/49/5049/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/49/5049/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/49/5049/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b8489ee4a7c8cfb4922b0c3c3d5cebb044e033a0","subject":"target: change prototype of target_process_reset()"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2019-04-01 08:34:25.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2019-04-07 04:24:15.000000000","tz":120},"subject":"target: use LOG_USER to print errors in events","message":"target: use LOG_USER to print errors in events\n\nEvents are supposed to be executed asynchronously and not linked\nwith any command, so it\u0027s incorrect printing out an eventual error\nusing command_print().\nEven in the case of events triggered by the command\n\t\u003ctarget\u003e invoke-event \u003cevent-name\u003e\nthe eventual error in the event handler is not propagated to the\ncommand, so the command_print() is still not appropriate.\n\nReplace command_print() with LOG_USER() in target_handle_event().\nAdd further info in the log to identify which event has generated\nthe error and its associated target.\nBefore return, clean-up the error message and the stacktrace from\nthe error already displayed, to avoid propagate them.\n\nChange-Id: I5966aa25e7c81348f4ad4d6e7ce5d4dee44ea4c8\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}