)]}'
{"id":"openocd~master~I7fa0628fabacd9ceb62ce921192f88edca659c15","project":"openocd","branch":"master","topic":"Tcl_return_values","hashtags":[],"change_id":"I7fa0628fabacd9ceb62ce921192f88edca659c15","subject":"target/arm720t: change prototype of arm720t_verify_pointer()","status":"MERGED","created":"2019-04-07 04:25:12.000000000","updated":"2019-05-14 18:34:37.000000000","submitted":"2019-05-14 18:34:37.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"5059-1557858877233-5dedb4e1","meta_rev_id":"0bff7fc03aa6d02f704b7bfcac4ccbc85dfaa4fe","_number":5059,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":1,"date":"2019-05-14 18:34:37.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"value":0,"date":"2019-05-14 18:34:37.000000000","permitted_voting_range":{"min":0,"max":2},"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"value":2,"date":"2019-05-14 18:34:37.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-04-07 04:25:12.000000000","updated_by":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"reviewer":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"state":"REVIEWER"},{"updated":"2019-04-07 11:16:29.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-05-14 18:34:37.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"e5c6731e314b434c8bd6d03d3306b7ec5364dac7","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2019-04-07 04:25:12.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3b1774509a8696301715426ef3bcecebc2df6086","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2019-04-07 11:16:29.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/11493/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/10827/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"ad9c2dd3c6105f60a83fb55821a5434da644aa3d","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2019-04-26 15:26:21.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"fb0835d85e422802cad3698ac910ee7e58ab486f","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2019-05-14 18:34:37.000000000","message":"Change has been successfully cherry-picked as 2f3ab89a78d217f20233fab0f514b241908c9ce8 by Tomas Vanek","accounts_in_message":[],"_revision_number":2}],"current_revision":"2f3ab89a78d217f20233fab0f514b241908c9ce8","revisions":{"2f3ab89a78d217f20233fab0f514b241908c9ce8":{"kind":"REWORK","_number":2,"created":"2019-05-14 18:34:37.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/59/5059/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/59/5059/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/59/5059/2 \u0026\u0026 git checkout -b change-5059 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/59/5059/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/59/5059/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/59/5059/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/59/5059/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/59/5059/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6a453e5cf0adc4d19378e953122ca69efcf32b6d","subject":"target/arm966e: change prototype of arm966e_verify_pointer()"}],"author":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2019-04-01 02:44:43.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2019-05-14 18:34:37.000000000","tz":60},"subject":"target/arm720t: change prototype of arm720t_verify_pointer()","message":"target/arm720t: change prototype of arm720t_verify_pointer()\n\nTo prepare for handling TCL return values consistently, all calls\nto command_print/command_print_sameline should be ready to switch\nto CMD as first parameter.\n\nChange prototype of arm720t_verify_pointer() to pass CMD instead\nof CMD_CTX.\n\nThis change was part of http://openocd.zylin.com/1815 from Paul\nFertser and has been extracted and rebased to simplify the review.\n\nChange-Id: I7fa0628fabacd9ceb62ce921192f88edca659c15\nSigned-off-by: Paul Fertser \u003cfercerpav@gmail.com\u003e\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: http://openocd.zylin.com/5059\nTested-by: jenkins\n"}},"c2c5100bf5a82cae282b3697a5c7b310563182df":{"kind":"REWORK","_number":1,"created":"2019-04-07 04:25:12.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/59/5059/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/59/5059/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/59/5059/1 \u0026\u0026 git checkout -b change-5059 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/59/5059/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/59/5059/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/59/5059/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/59/5059/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/59/5059/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5aa4444178c006e18c0e011de4c101f08d1b77cd","subject":"target/arm966e: change prototype of arm966e_verify_pointer()"}],"author":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2019-04-01 02:44:43.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2019-04-07 04:24:15.000000000","tz":120},"subject":"target/arm720t: change prototype of arm720t_verify_pointer()","message":"target/arm720t: change prototype of arm720t_verify_pointer()\n\nTo prepare for handling TCL return values consistently, all calls\nto command_print/command_print_sameline should be ready to switch\nto CMD as first parameter.\n\nChange prototype of arm720t_verify_pointer() to pass CMD instead\nof CMD_CTX.\n\nThis change was part of http://openocd.zylin.com/1815 from Paul\nFertser and has been extracted and rebased to simplify the review.\n\nChange-Id: I7fa0628fabacd9ceb62ce921192f88edca659c15\nSigned-off-by: Paul Fertser \u003cfercerpav@gmail.com\u003e\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}