)]}'
{"id":"openocd~master~I528760aad0ba55ebc57fc1fabfdfdf07c92cac94","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2026-02-15 18:15:30.000000000","reason":"removed on reply"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2026-02-15 18:15:33.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I528760aad0ba55ebc57fc1fabfdfdf07c92cac94","subject":"flash: read only alias","status":"MERGED","created":"2019-04-11 09:10:54.000000000","updated":"2026-02-15 18:15:33.000000000","submitted":"2026-02-15 18:15:33.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"5107","meta_rev_id":"a74b07e188d3b6e46552d11f87aeb8c96cbad840","_number":5107,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2026-02-15 18:15:33.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2026-02-15 18:15:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2026-02-15 18:15:33.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-04-11 09:27:28.000000000","updated_by":{"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},"reviewer":{"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},"state":"REVIEWER"},{"updated":"2019-04-11 09:50:30.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-02-15 18:15:30.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"76152c968c0a58d5354db2309be5223b0c0e6f47","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2019-04-11 09:10:54.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2aa045de1264e71fc11108981960344a9fa5cf5f","author":{"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},"real_author":{"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},"date":"2019-04-11 09:27:28.000000000","message":"Patch Set 1:\n\nWouldn\u0027t it be easier (and smaller) to just have an optional argument(s) for \"virtual\" driver which would disable writes and erases?","accounts_in_message":[],"_revision_number":1},{"id":"7307c1b7a8cdec252181ab3b4d49dd0fd2e0e725","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2019-04-11 09:44:58.000000000","message":"Patch Set 1:\n\nDon\u0027t think so. The only copied code is FLASH_BANK_COMMAND_HANDLER(ro_alias_bank_command)\n\nIf you used the same struct flash driver, you would need to solve  flash protect, which is a bit tricky when num_sectors is 0.\n\nAnd \u0027ro_alias\u0027 seems me much more understandable than\n\u0027virtual  0x00200000 0 0 0 $_TARGETNAME $_FLASHNAME read_only\u0027","accounts_in_message":[],"_revision_number":1},{"id":"1c53ffc4e1c88e195fccb8eb07424a1346752177","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2019-04-11 09:50:30.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/11560/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/10885/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"34af92a8398304e6e5447a74886fb348fdacd44b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-01-31 16:04:17.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"6a5ffa0b19ebc3733bcc710e1041ddf8b94b19c5","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-01-31 16:39:55.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/21709/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/22597/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"25f0ba208819e0c367cc9f7d92a27b9ae6a45b53","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2026-01-31 19:34:18.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"c0d5c953084984e4c963348f6dde44cd93c78e0e","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-02-15 18:15:30.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"a74b07e188d3b6e46552d11f87aeb8c96cbad840","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-02-15 18:15:33.000000000","message":"Change has been successfully cherry-picked as 2b986178cfee4244953defde1868997b6172c8e6","accounts_in_message":[],"_revision_number":3}],"current_revision":"2b986178cfee4244953defde1868997b6172c8e6","revisions":{"2b986178cfee4244953defde1868997b6172c8e6":{"kind":"REWORK","_number":3,"created":"2026-02-15 18:15:33.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/07/5107/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/07/5107/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/07/5107/3 \u0026\u0026 git checkout -b change-5107 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/07/5107/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/07/5107/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/07/5107/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/07/5107/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/07/5107/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8ee7cb12cf8838e91329dccb3647a611cf53186a","subject":"flash: ROM support"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2019-04-11 06:39:10.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-02-15 18:15:33.000000000","tz":0},"subject":"flash: read only alias","message":"flash: read only alias\n\nSimilar as virtual flash but has write/erase suppressed.\n\n\u0027virtual\u0027 flash driver name check in flash_free_all_banks()\nwas replaced by a customized free_driver_priv()\n\nChange-Id: I528760aad0ba55ebc57fc1fabfdfdf07c92cac94\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/5107\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\n"}},"2150f530f4e1545e377d38cde485c79b2f3c455f":{"kind":"REWORK","_number":2,"created":"2026-01-31 16:04:17.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/07/5107/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/07/5107/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/07/5107/2 \u0026\u0026 git checkout -b change-5107 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/07/5107/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/07/5107/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/07/5107/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/07/5107/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/07/5107/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5f2e8fa453acbad558bd69f0cc60795d99d8982c","subject":"flash: ROM support"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2019-04-11 06:39:10.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-01-30 17:33:23.000000000","tz":60},"subject":"flash: read only alias","message":"flash: read only alias\n\nSimilar as virtual flash but has write/erase suppressed.\n\n\u0027virtual\u0027 flash driver name check in flash_free_all_banks()\nwas replaced by a customized free_driver_priv()\n\nChange-Id: I528760aad0ba55ebc57fc1fabfdfdf07c92cac94\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"62b9c3537d3cd48426b86827358b92a69110853a":{"kind":"REWORK","_number":1,"created":"2019-04-11 09:10:54.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/07/5107/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/07/5107/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/07/5107/1 \u0026\u0026 git checkout -b change-5107 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/07/5107/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/07/5107/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/07/5107/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/07/5107/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/07/5107/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"dd34cefc09ed2bcd8f540f5fbcbece508d5ee344","subject":"flash: ROM support"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2019-04-11 06:39:10.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2019-04-11 09:06:45.000000000","tz":120},"subject":"flash: read only alias","message":"flash: read only alias\n\nSimilar as virtual flash but has write/erase suppressed.\n\n\u0027virtual\u0027 flash driver name check in flash_free_all_banks()\nwas replaced by a customized free_driver_priv()\n\nChange-Id: I528760aad0ba55ebc57fc1fabfdfdf07c92cac94\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}