)]}'
{"id":"openocd~master~I6c3bdf27465dc563464fbc8fafbaec696e287624","project":"openocd","branch":"master","topic":"checkpatch","hashtags":[],"change_id":"I6c3bdf27465dc563464fbc8fafbaec696e287624","subject":"checkpatch: add OpenOCD specific config flags","status":"MERGED","created":"2019-04-16 22:44:45.000000000","updated":"2022-09-18 08:17:08.000000000","submitted":"2022-09-18 08:17:08.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"5117-checkpatch","meta_rev_id":"1615d7140ebf79f3246f1aac2ad0dc336cdc2fe1","_number":5117,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-09-18 08:17:08.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-09-18 08:17:08.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-04-18 18:05:19.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-04-24 05:18:23.000000000","updated_by":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"reviewer":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"state":"REVIEWER"},{"updated":"2021-05-02 06:49:06.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"bb94bfe07cb79eefeca33a7381d60ba636bee516","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2019-04-16 22:44:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"14cca3d90c0a12f8567cd574fee29cdf9fe05234","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2019-04-16 23:05:29.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttp://build.openocd.org/job/openocd-gerrit/11574/ : FAILURE\n\nhttp://build.openocd.org/job/openocd-gerrit-build/10899/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"21b3153cdd5b1d23f57623724d0c07a085a43d2e","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2019-04-17 08:58:41.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"8889b22b5471f13ba5c1430987304f7c38a2e662","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2019-04-17 09:40:26.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/11581/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/10906/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"0adc3b11500aba7d0179adaa629753dfb588e065","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2020-04-26 14:32:51.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"080d39d261972a1c3c22551f8fa63d8a0d71004a","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2020-04-26 16:24:18.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/12911/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/12206/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"79356a1bd3f4b1080499390f513f0ce6d3767f4f","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-04-15 12:42:45.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"78ca47eba8ce573d8414240ebf3170cafaf82f88","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-04-15 14:31:47.000000000","message":"Patch Set 4: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14347/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/13601/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"f7d29658051f2b7803c8f147a72f9b964191c865","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-04-15 20:10:23.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"1ccf2a138ed260694a4f2e04111b5eb3c15423d0","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-04-18 16:21:17.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"89645cde7052a8594bb6bd7dfdbc78ccba2b64b4","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-04-18 18:05:19.000000000","message":"Patch Set 5: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14366/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/13619/ : SUCCESS","accounts_in_message":[],"_revision_number":5},{"id":"296d1faea17b0464c86a5eda017ca1041b042d0a","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-04-19 14:16:42.000000000","message":"Patch Set 5: Code-Review+1","accounts_in_message":[],"_revision_number":5},{"id":"51a518def8e4916bf876b70c051394529ef24a01","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-04-24 05:18:23.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"19b5484171fb7b6e3fe8308cb3ead503e72c5fba","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-05-02 05:22:40.000000000","message":"Patch Set 5:\n\nI vote for\n  --ignore COMPARISON_TO_NULL\n\nCurrently we have\n  $ grep -r \u0027[\u003d!]\u003d NULL\u0027 src|wc -l\n  *999*\n\nso I don\u0027t see any point in forcing contributors to follow another useless and non documented rule.\n\nBTW Do you plan to sync C-style guide with the new checkpatch?","accounts_in_message":[],"_revision_number":5},{"id":"2e8aef527ed2a085e0f66ba77bd8e1415b2c6b86","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-05-02 06:06:52.000000000","message":"Patch Set 5:\n\ni would say, the point is - reuse code (checkpatch, flash drivers, etc) from projects like u-boot and linux kernel. And make life for developers working on this projects easier. Otherwise it is just more of project specific rules. From point of view of developers primly working on projects like u-boot or kernel, the OpenOCD specific style is \"forcing contributors to follow another useless rules\"","accounts_in_message":[],"_revision_number":5},{"id":"f51a8ae82b889d3e77abfb7148d605fb0b6dc3c2","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-05-02 06:15:13.000000000","message":"Patch Set 5:\n\nhttps://docs.zephyrproject.org/latest/contribute/index.html#id1\nhttps://www.denx.de/wiki/U-Boot/CodingStyle","accounts_in_message":[],"_revision_number":5},{"id":"6b9ae0fc187733d620df8e41653bb49dcd0e637f","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-05-02 06:49:06.000000000","message":"Patch Set 5:\n\n\u003e https://docs.zephyrproject.org/latest/contribute/index.html#id1\n \u003e https://www.denx.de/wiki/U-Boot/CodingStyle\n\nIt\u0027s really funny that neither of the coding styles above nor\nhttps://www.kernel.org/doc/html/latest/process/coding-style.html\nsays anything relevant about comparison to NULL.\nAnd good to know there are substantial exclusions (compulsory braces @ zephyr,\nI like them, it\u0027s my style as well).\n\nThe code reusability is a good thing. But we should prefer reusability\nof the old code in OpenOCD project itself! I mean if someone makes a small\nchange on the line where one of 999 NULL comparisons resides, chackpatch will force\nhim to fix the comparison too. This certainly is not what I would describe as\n\"make life for developers working on this projects easier.\"\n\nAnd if we relax the rule by --ignore COMPARISON_TO_NULL it doesn\u0027t mean\nwe require something OpenOCD specific, does it?","accounts_in_message":[],"_revision_number":5},{"id":"e57719269245829c3be574281c9586cee30cd544","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-05-02 07:00:44.000000000","message":"Patch Set 5:\n\nYes, but I assume, you would agree, that keeping the difference smaller and working on reducing this difference is the point of any checkpatch related work.\nIf we are arguing on keeping old style because we already use it, we should not introduce SPDX tags as well. We have never use it before, and some one should add this tag to the old code too. But we are doing it, because it will safe some one time...\nThere is always the old code what can be done better.","accounts_in_message":[],"_revision_number":5},{"id":"088141e123edbd322c7be34270a5e2e1470fefc2","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-05-02 10:37:58.000000000","message":"Patch Set 5:\n\nI\u0027m completing the clean-up of a patch-set of already 3231 line changed for CamelCase, macro lowercase, variables and functions uppercase.\nCoding style asks it (and personally I find it nice), but old checkpatch didn\u0027t care, while new one tests it.\nThe CamelCase situation is bad because having a function name CamelCase somewhere triggers the error when you use it in another file, forcing to change the symbol everywhere!\nI\u0027m keeping out of the patch series the rtos folder, for the moment, till zephyr support get merged. Maybe I will also wait to merge 6170 until the zephyr merge.\n\nThe comparison to NULL has instead a local \"impact\", does not propagates to other files. Yes, if you change something unrelated to NULL in the same line of the NULL comparison checkpatch will complain about the NULL comparison. But this will happen for all the tests that were not covered by the old checkpatch. I don\u0027t consider it critical and it does not require rushing for a project-wide rework.\nAnd by the way NULL comparison is easy to fix with a script generated patch.\n\nAbout the coding-style: it risks to be a never-ending discussion because it\u0027s just style, touching personal feeling or habits. C language itself left wide freedom.\nI cried fool at my first impact to 4-char TAB in OpenOCD, but later I get used at it. Actually I don\u0027t care anymore, but I like to see a more homogeneous style across the files. And checkpatch can help!\nToday\u0027s coding-style does not forbids NULL comparison, so we could ignore it as Tomas suggest. But at the same time I suggest adding it in the coding-style only to increase the \"uniformity\" in OpenOCD code.\n\nSPDX is a completely different animal in the zoo! It helps checking licenses with scripts. And this is far more relevant than personal taste and coding style. The fact that checkpatch will help testing SPDX is welcome, but partially out of this topic.","accounts_in_message":[],"_revision_number":5},{"id":"831be9f5193a8e2fdef4654fbb972ebbdc4a3888","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-06-12 14:41:58.000000000","message":"Uploaded patch set 6: Patch Set 5 was rebased.","accounts_in_message":[],"_revision_number":6},{"id":"89d1d72dd2d77671cfadbaf7e69797df9d929535","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-06-12 15:58:15.000000000","message":"Patch Set 6: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/16272/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15482/ : SUCCESS","accounts_in_message":[],"_revision_number":6},{"id":"7c8a6b7ba50e7b96aaf3c7d91d1783aa17bd0250","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-01 20:28:50.000000000","message":"Uploaded patch set 7: Code-Review+1.","accounts_in_message":[],"_revision_number":7},{"id":"0309dcbee9567ed6aa7375b936eb868e237128a5","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-09-01 21:51:46.000000000","message":"Patch Set 7: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15824/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16615/ : SUCCESS","accounts_in_message":[],"_revision_number":7},{"id":"d34cee3a362bf0f3dd775866137ed79af15734d4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-13 23:11:50.000000000","message":"Uploaded patch set 8: Patch Set 7 was rebased.","accounts_in_message":[],"_revision_number":8},{"id":"8b92bb8ffe9be0f06b7d8c0d8601bb690da43a00","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-09-14 02:48:48.000000000","message":"Patch Set 8: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15910/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16701/ : SUCCESS","accounts_in_message":[],"_revision_number":8},{"id":"7bdec23095407d642785ec7d95bc41e9bd0d0057","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-14 14:47:56.000000000","message":"Patch Set 8: Code-Review+2","accounts_in_message":[],"_revision_number":8},{"id":"1615d7140ebf79f3246f1aac2ad0dc336cdc2fe1","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-18 08:17:08.000000000","message":"Change has been successfully cherry-picked as 85a918b44d4f297e0dd30fc5bf6e798c991ddc6c","accounts_in_message":[],"_revision_number":9}],"current_revision":"85a918b44d4f297e0dd30fc5bf6e798c991ddc6c","revisions":{"c13e1a753b8a14612752bd60e32e26e3db9202b6":{"kind":"TRIVIAL_REBASE","_number":8,"created":"2022-09-13 23:11:50.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/17/5117/8","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/17/5117/8","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/8 \u0026\u0026 git checkout -b change-5117 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/17/5117/8","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/8 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4cd287f3903d7e4ff3bd696694de2cb4dbc145d9","subject":"checkpatch: import new script version from kernel v6.0-rc3"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2019-04-17 07:50:27.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-13 23:06:15.000000000","tz":120},"subject":"checkpatch: add OpenOCD specific config flags","message":"checkpatch: add OpenOCD specific config flags\n\nThis initial setup covers the old commits:\ncommit 09571d62bc1e (\"checkpatch: disable extern and switch indent checks\")\ncommit 2f6f7c442d24 (\"checkpatch: remove typedef check\")\ncommit 9ad57e96b3c1 (\"checkpatch: remove volatile check\")\ncommit 3da783f62854 (\"checkpatch: increase line length to 120\")\ncommit 2af5b97ba31f (\"checkpatch: remove __packed and __aligned checks\")\ncommit 164450a01576 (\"Change checkpatch.pl tab expanding to 4 characters.\")\n\nIt also skips the check for SPDX_LICENSE_TAG, not implemented in\nOpenOCD yet.\nExtend to the check in \u0027strict\u0027 mode and skip all the check that\ncannot apply on OpenOCD project.\n\nChange-Id: I6c3bdf27465dc563464fbc8fafbaec696e287624\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"85a918b44d4f297e0dd30fc5bf6e798c991ddc6c":{"kind":"REWORK","_number":9,"created":"2022-09-18 08:17:08.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/17/5117/9","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/17/5117/9","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/9 \u0026\u0026 git checkout -b change-5117 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/17/5117/9","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/9 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8d395421ab359716843144dbe069607133a29b16","subject":"checkpatch: import new script version from kernel v6.0-rc3"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2019-04-17 07:50:27.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-18 08:17:08.000000000","tz":0},"subject":"checkpatch: add OpenOCD specific config flags","message":"checkpatch: add OpenOCD specific config flags\n\nThis initial setup covers the old commits:\ncommit 09571d62bc1e (\"checkpatch: disable extern and switch indent checks\")\ncommit 2f6f7c442d24 (\"checkpatch: remove typedef check\")\ncommit 9ad57e96b3c1 (\"checkpatch: remove volatile check\")\ncommit 3da783f62854 (\"checkpatch: increase line length to 120\")\ncommit 2af5b97ba31f (\"checkpatch: remove __packed and __aligned checks\")\ncommit 164450a01576 (\"Change checkpatch.pl tab expanding to 4 characters.\")\n\nIt also skips the check for SPDX_LICENSE_TAG, not implemented in\nOpenOCD yet.\nExtend to the check in \u0027strict\u0027 mode and skip all the check that\ncannot apply on OpenOCD project.\n\nChange-Id: I6c3bdf27465dc563464fbc8fafbaec696e287624\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/5117\nTested-by: jenkins\n"}},"25d7544b00569da3f8a8c5457d8d697bdd0033a3":{"kind":"REWORK","_number":1,"created":"2019-04-16 22:44:45.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/17/5117/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/17/5117/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/1 \u0026\u0026 git checkout -b change-5117 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/17/5117/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7352f8ae6dc362e5935b61b2488879c690e3983a","subject":"[RFC] checkpatch: import new script version from kernel v5.1-rc5"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2019-04-10 12:50:45.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2019-04-16 22:36:49.000000000","tz":120},"subject":"[RFC] checkpatch: add initial .checkpatch.conf","message":"[RFC] checkpatch: add initial .checkpatch.conf\n\nThis initial setup covers the old commits:\n09571d62bc1e (\"checkpatch: disable extern and switch indent checks\")\n2f6f7c442d24 (\"checkpatch: remove typedef check\")\n9ad57e96b3c1 (\"checkpatch: remove volatile check\")\n3da783f62854 (\"checkpatch: increase line length to 120\")\n2af5b97ba31f (\"checkpatch: remove __packed and __aligned checks\")\n\nIt also skip the check for SPDX_LICENSE_TAG, not implemented in\nOpenOCD yet.\n\nChange-Id: I6c3bdf27465dc563464fbc8fafbaec696e287624\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"d68589c56bcde871fa593bb544bb0a43efce695a":{"kind":"REWORK","_number":2,"created":"2019-04-17 08:58:41.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/17/5117/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/17/5117/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/2 \u0026\u0026 git checkout -b change-5117 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/17/5117/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"50f0188c487ffe050f01e9a84b0332e53b0bc021","subject":"[RFC] checkpatch: import new script version from kernel v5.1-rc5"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2019-04-17 07:50:27.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2019-04-17 07:54:06.000000000","tz":120},"subject":"[RFC] checkpatch: add OpenOCD specific lines in .checkpatch.conf","message":"[RFC] checkpatch: add OpenOCD specific lines in .checkpatch.conf\n\nThis initial setup covers the old commits:\ncommit 09571d62bc1e (\"checkpatch: disable extern and switch indent checks\")\ncommit 2f6f7c442d24 (\"checkpatch: remove typedef check\")\ncommit 9ad57e96b3c1 (\"checkpatch: remove volatile check\")\ncommit 3da783f62854 (\"checkpatch: increase line length to 120\")\ncommit 2af5b97ba31f (\"checkpatch: remove __packed and __aligned checks\")\n\nIt also skip the check for SPDX_LICENSE_TAG, not implemented in\nOpenOCD yet.\n\nChange-Id: I6c3bdf27465dc563464fbc8fafbaec696e287624\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"2c3b2a470201b7fdd4156a4ceff538bdcce3538e":{"kind":"REWORK","_number":3,"created":"2020-04-26 14:32:51.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/17/5117/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/17/5117/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/3 \u0026\u0026 git checkout -b change-5117 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/17/5117/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c2b0af9b339f634d0efb6c5c6e6a65416c962351","subject":"[RFC] checkpatch: import new script version from kernel v5.7-rc1"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2019-04-17 07:50:27.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2020-04-26 14:20:53.000000000","tz":120},"subject":"[RFC] checkpatch: add OpenOCD specific lines in .checkpatch.conf","message":"[RFC] checkpatch: add OpenOCD specific lines in .checkpatch.conf\n\nThis initial setup covers the old commits:\ncommit 09571d62bc1e (\"checkpatch: disable extern and switch indent checks\")\ncommit 2f6f7c442d24 (\"checkpatch: remove typedef check\")\ncommit 9ad57e96b3c1 (\"checkpatch: remove volatile check\")\ncommit 3da783f62854 (\"checkpatch: increase line length to 120\")\ncommit 2af5b97ba31f (\"checkpatch: remove __packed and __aligned checks\")\n\nIt also skip the check for SPDX_LICENSE_TAG, not implemented in\nOpenOCD yet.\n\nChange-Id: I6c3bdf27465dc563464fbc8fafbaec696e287624\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"40d79965e2e1385845285806f4bb1b6d5441697d":{"kind":"REWORK","_number":4,"created":"2021-04-15 12:42:45.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/17/5117/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/17/5117/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/4 \u0026\u0026 git checkout -b change-5117 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/17/5117/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c569ad1633521a8eb69ffd1cb1131755740bd003","subject":"checkpatch: import new script version from kernel v5.12"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2019-04-17 07:50:27.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-04-15 12:41:38.000000000","tz":120},"subject":"checkpatch: add OpenOCD specific config flags","message":"checkpatch: add OpenOCD specific config flags\n\nThis initial setup covers the old commits:\ncommit 09571d62bc1e (\"checkpatch: disable extern and switch indent checks\")\ncommit 2f6f7c442d24 (\"checkpatch: remove typedef check\")\ncommit 9ad57e96b3c1 (\"checkpatch: remove volatile check\")\ncommit 3da783f62854 (\"checkpatch: increase line length to 120\")\ncommit 2af5b97ba31f (\"checkpatch: remove __packed and __aligned checks\")\ncommit 164450a01576 (\"Change checkpatch.pl tab expanding to 4 characters.\")\n\nIt also skip the check for SPDX_LICENSE_TAG, not implemented in\nOpenOCD yet.\n\nChange-Id: I6c3bdf27465dc563464fbc8fafbaec696e287624\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"d2bba44456219c7d5a3a62d99e3d54befc10d51d":{"kind":"REWORK","_number":5,"created":"2021-04-18 16:21:17.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/17/5117/5","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/17/5117/5","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/5 \u0026\u0026 git checkout -b change-5117 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/17/5117/5","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3a2f67c1b64b0ca5598d2f20d97d061c4875b782","subject":"checkpatch: import new script version from kernel v5.12"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2019-04-17 07:50:27.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-04-18 16:19:55.000000000","tz":120},"subject":"checkpatch: add OpenOCD specific config flags","message":"checkpatch: add OpenOCD specific config flags\n\nThis initial setup covers the old commits:\ncommit 09571d62bc1e (\"checkpatch: disable extern and switch indent checks\")\ncommit 2f6f7c442d24 (\"checkpatch: remove typedef check\")\ncommit 9ad57e96b3c1 (\"checkpatch: remove volatile check\")\ncommit 3da783f62854 (\"checkpatch: increase line length to 120\")\ncommit 2af5b97ba31f (\"checkpatch: remove __packed and __aligned checks\")\ncommit 164450a01576 (\"Change checkpatch.pl tab expanding to 4 characters.\")\n\nIt also skips the check for SPDX_LICENSE_TAG, not implemented in\nOpenOCD yet.\nExtend to the check in \u0027strict\u0027 mode and skip all the check that\ncannot apply on OpenOCD project.\n\nChange-Id: I6c3bdf27465dc563464fbc8fafbaec696e287624\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"3d4ad2b85ff162b1e1b2b0573fc09da83ff0202e":{"kind":"TRIVIAL_REBASE","_number":6,"created":"2022-06-12 14:41:58.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/17/5117/6","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/17/5117/6","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/6 \u0026\u0026 git checkout -b change-5117 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/17/5117/6","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3b2c656e5e0278c2d922f30b0e46b175075e3825","subject":"checkpatch: import new script version from kernel v5.19-rc1"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2019-04-17 07:50:27.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-06-11 21:01:00.000000000","tz":120},"subject":"checkpatch: add OpenOCD specific config flags","message":"checkpatch: add OpenOCD specific config flags\n\nThis initial setup covers the old commits:\ncommit 09571d62bc1e (\"checkpatch: disable extern and switch indent checks\")\ncommit 2f6f7c442d24 (\"checkpatch: remove typedef check\")\ncommit 9ad57e96b3c1 (\"checkpatch: remove volatile check\")\ncommit 3da783f62854 (\"checkpatch: increase line length to 120\")\ncommit 2af5b97ba31f (\"checkpatch: remove __packed and __aligned checks\")\ncommit 164450a01576 (\"Change checkpatch.pl tab expanding to 4 characters.\")\n\nIt also skips the check for SPDX_LICENSE_TAG, not implemented in\nOpenOCD yet.\nExtend to the check in \u0027strict\u0027 mode and skip all the check that\ncannot apply on OpenOCD project.\n\nChange-Id: I6c3bdf27465dc563464fbc8fafbaec696e287624\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"470ffba162453f3eb3a82b3db5605c1bf992339f":{"kind":"REWORK","_number":7,"created":"2022-09-01 20:28:50.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/17/5117/7","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/17/5117/7","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/7 \u0026\u0026 git checkout -b change-5117 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/17/5117/7","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/17/5117/7 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"36b809f4e8cb78816e05afff44a3229f6e3ab6b9","subject":"checkpatch: import new script version from kernel v6.0-rc3"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2019-04-17 07:50:27.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-01 20:22:28.000000000","tz":120},"subject":"checkpatch: add OpenOCD specific config flags","message":"checkpatch: add OpenOCD specific config flags\n\nThis initial setup covers the old commits:\ncommit 09571d62bc1e (\"checkpatch: disable extern and switch indent checks\")\ncommit 2f6f7c442d24 (\"checkpatch: remove typedef check\")\ncommit 9ad57e96b3c1 (\"checkpatch: remove volatile check\")\ncommit 3da783f62854 (\"checkpatch: increase line length to 120\")\ncommit 2af5b97ba31f (\"checkpatch: remove __packed and __aligned checks\")\ncommit 164450a01576 (\"Change checkpatch.pl tab expanding to 4 characters.\")\n\nIt also skips the check for SPDX_LICENSE_TAG, not implemented in\nOpenOCD yet.\nExtend to the check in \u0027strict\u0027 mode and skip all the check that\ncannot apply on OpenOCD project.\n\nChange-Id: I6c3bdf27465dc563464fbc8fafbaec696e287624\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}