)]}'
{"id":"openocd~master~Ieebc790096f40961283c644642e56fde975e957f","project":"openocd","branch":"master","hashtags":[],"change_id":"Ieebc790096f40961283c644642e56fde975e957f","subject":"coding style: add newline at end of text files","status":"MERGED","created":"2019-05-14 20:43:30.000000000","updated":"2020-02-24 10:30:53.000000000","submitted":"2020-02-24 10:30:53.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"5167-1582540253719-5acc1cd2","meta_rev_id":"4c3fb74bbbe8f2f79302612ebb3b2dbadf9c5473","_number":5167,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":1,"date":"2020-02-24 10:30:53.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"value":2,"date":"2020-02-24 10:30:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-02-17 00:33:57.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"ef7047b56361c29d2f0c92f4744a832c92783b96","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2019-05-14 20:43:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"69748007909c4d992e99eaf8d13c6d1b8ef1623e","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2019-05-14 20:46:30.000000000","message":"Patch Set 1:\n\nThis series is an initial outcome of testing the new Linux checkpatch script on the OpenOCD code.\nAnd yes, the whole series is extremely boring for review.","accounts_in_message":[],"_revision_number":1},{"id":"b160761cfea560dba5e1569cb60486fd959224ec","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2019-05-14 21:02:23.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttp://build.openocd.org/job/openocd-gerrit-build/11020/ : FAILURE\n\nhttp://build.openocd.org/job/openocd-gerrit/11704/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"bc5b586dae68a4284c8620182452fe8b1bcfc971","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2019-05-15 04:36:28.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"d6b9af989e8efda7b6f88b78e28b3fac23beab8a","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2019-05-15 04:56:21.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/11713/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/11028/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"018351c755e39c4bb4aac664b2cc158ae7a89b5b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2019-05-15 06:04:57.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"8fbed90c1781cd97141edfc8aaf64807819123b5","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2019-05-15 07:40:27.000000000","message":"Patch Set 3:\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/11719/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/11034/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"e243490036a2e81840fbbcd951f0c9934a4d8855","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2019-05-15 10:19:32.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"b862c0adeb77be62459528078a69ff1e6b241527","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2020-02-16 22:53:08.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"351769c347975e3f8f81cf79dbea35ed10d9ef8a","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2020-02-17 00:33:57.000000000","message":"Patch Set 4: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/12551/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/11848/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"6dce945fc88aa698f1ea8606ec0842a520c00886","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2020-02-17 09:09:25.000000000","message":"Patch Set 4: Code-Review+2\n\nNo conflicts with other patches in gerrit. If there is no concerns, I will merge it in one week","accounts_in_message":[],"_revision_number":4},{"id":"4c3fb74bbbe8f2f79302612ebb3b2dbadf9c5473","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2020-02-24 10:30:53.000000000","message":"Change has been successfully cherry-picked as 9d5767b6b005e426f77460c42bafce157de74a25 by Antonio Borneo","accounts_in_message":[],"_revision_number":5}],"current_revision":"9d5767b6b005e426f77460c42bafce157de74a25","revisions":{"9d5767b6b005e426f77460c42bafce157de74a25":{"kind":"REWORK","_number":5,"created":"2020-02-24 10:30:53.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/67/5167/5","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/67/5167/5","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/67/5167/5 \u0026\u0026 git checkout -b change-5167 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/67/5167/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/67/5167/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/67/5167/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/67/5167/5","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/67/5167/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e7306d361b5d503cf27dfb3dc69298ddad495f88","subject":"coding style: fix space around pointer\u0027s asterisk"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2019-05-12 10:26:46.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2020-02-24 10:30:53.000000000","tz":0},"subject":"coding style: add newline at end of text files","message":"coding style: add newline at end of text files\n\nSome text file is missing newline at EOF.\nAdd it.\n\nChange-Id: Ieebc790096f40961283c644642e56fde975e957f\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: http://openocd.zylin.com/5167\nTested-by: jenkins\n"}},"1366b245e840cca96aa5e36d4e9f14a68d2a24e3":{"kind":"REWORK","_number":4,"created":"2020-02-16 22:53:08.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/67/5167/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/67/5167/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/67/5167/4 \u0026\u0026 git checkout -b change-5167 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/67/5167/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/67/5167/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/67/5167/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/67/5167/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/67/5167/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"17d0af0f2001769435017645a1b41bfb214f6f19","subject":"coding style: fix space around pointer\u0027s asterisk"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2019-05-12 10:26:46.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2020-02-16 22:51:37.000000000","tz":60},"subject":"coding style: add newline at end of text files","message":"coding style: add newline at end of text files\n\nSome text file is missing newline at EOF.\nAdd it.\n\nChange-Id: Ieebc790096f40961283c644642e56fde975e957f\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"717b81c0ef6c6299f48c1400f461de4903c2433b":{"kind":"NO_CHANGE","_number":3,"created":"2019-05-15 06:04:57.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/67/5167/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/67/5167/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/67/5167/3 \u0026\u0026 git checkout -b change-5167 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/67/5167/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/67/5167/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/67/5167/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/67/5167/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/67/5167/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ea450298296ec6db233e24dff6732257c1cfb12d","subject":"drivers/bcm2835gpio: fix build for ARM host"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2019-05-12 10:26:46.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2019-05-15 06:03:40.000000000","tz":120},"subject":"coding style: add newline at end of text files","message":"coding style: add newline at end of text files\n\nSome text file is missing newline at EOF.\nAdd it.\n\nChange-Id: Ieebc790096f40961283c644642e56fde975e957f\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"16afb195e2ad395b77a2ccae5fafe2f958513827":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2019-05-15 04:36:28.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"ref":"refs/changes/67/5167/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/67/5167/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/67/5167/2 \u0026\u0026 git checkout -b change-5167 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/67/5167/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/67/5167/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/67/5167/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/67/5167/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/67/5167/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ea450298296ec6db233e24dff6732257c1cfb12d","subject":"drivers/bcm2835gpio: fix build for ARM host"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2019-05-12 10:26:46.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2019-05-15 04:36:28.000000000","tz":60},"subject":"coding style: add newline at end of text files","message":"coding style: add newline at end of text files\n\nSome text file is missing newline at EOF.\nAdd it.\n\nChange-Id: Ieebc790096f40961283c644642e56fde975e957f\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"eab83e57432a8c3642e9dfa7d37ab26e5c36faf5":{"kind":"REWORK","_number":1,"created":"2019-05-14 20:43:30.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/67/5167/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/67/5167/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/67/5167/1 \u0026\u0026 git checkout -b change-5167 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/67/5167/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/67/5167/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/67/5167/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/67/5167/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/67/5167/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b3d4c97b9f441b1dfe36f26d64bb80974ee06ee3","subject":"jtag_vpi: fixed state transitions in \"stableclocks\""}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2019-05-12 10:26:46.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2019-05-14 20:39:25.000000000","tz":120},"subject":"coding style: add newline at end of text files","message":"coding style: add newline at end of text files\n\nSome text file is missing newline at EOF.\nAdd it.\n\nChange-Id: Ieebc790096f40961283c644642e56fde975e957f\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}