)]}'
{"id":"openocd~master~I59393ce5c954dc97962c1cf08de3e6bd932830e9","project":"openocd","branch":"master","topic":"reset","hashtags":[],"change_id":"I59393ce5c954dc97962c1cf08de3e6bd932830e9","subject":"jtag/adapter: consolidate reset_config","status":"NEW","created":"2019-06-05 17:28:59.000000000","updated":"2021-05-14 17:40:24.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":12,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"6e6ba43e0cd23eb62b583ff716b9b76d14283ffa","_number":5210,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"date":"2020-03-16 22:12:10.000000000","_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},{"date":"2021-05-14 17:40:24.000000000","_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"date":"2020-10-20 05:36:53.000000000","_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":1,"date":"2019-07-24 15:00:19.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},{"value":0,"date":"2020-03-16 21:42:23.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-06 12:58:40.000000000","updated_by":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"reviewer":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"state":"REVIEWER"},{"updated":"2019-07-24 15:00:19.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-03-16 21:42:23.000000000","updated_by":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"reviewer":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"state":"REVIEWER"},{"updated":"2020-03-16 22:12:10.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2021-05-14 17:40:24.000000000","updated_by":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"reviewer":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"state":"REVIEWER"}],"messages":[{"id":"bb2305503945bcf22f9aeec364428936cb78637f","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2019-06-05 17:28:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"18c0773497499afd3bd22d509c6a6eb86c13dd7e","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2019-06-05 17:48:46.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/11815/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/11129/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"379e46a0f74bb627fbf993ae365f9ee8becfc82f","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2019-06-05 18:04:07.000000000","message":"Patch Set 1:\n\nAntonio, please take a look to my version of reset_config.\nI haven\u0027t updated the doc and I also plan to substitute existing \u0027combined\u0027 references in tcl files.","accounts_in_message":[],"_revision_number":1},{"id":"80e60c8ea70392f158ba02f6880237883f9309f5","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2019-06-05 20:21:06.000000000","message":"Patch Set 1:\n\n(4 comments)\n\nI was preparing something similar, but doesn\u0027t matter; let\u0027s go ahead here.\n\nI do not have strong opinion w.r.t. the words \"combined\" and \"tied\", and cannot find better alternatives.\n\nJust \"trst_srst_tied\" seams too long. May I propose simply \"tied\"?\nWe would simply output \"trst_and_srst tied\" that sounds better than  \"trst_and_srst trst_srst_tied\".","accounts_in_message":[],"_revision_number":1},{"id":"2277766f9c96a017e3f42c0bf45c436ca7c9a78b","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2019-06-05 21:22:07.000000000","message":"Patch Set 1:\n\n(2 comments)\n\n\u003e I do not have strong opinion w.r.t. the words \"combined\" and\n \u003e \"tied\", and cannot find better alternatives.\n \u003e \n \u003e Just \"trst_srst_tied\" seams too long. May I propose simply \"tied\"?\n \u003e We would simply output \"trst_and_srst tied\" that sounds better than\n \u003e  \"trst_and_srst trst_srst_tied\".\n\nThe reason I substitute \u0027combined\u0027 is that it is not intuitive what is combined with what. Most probably it means \u0027trst_pulls_srst\u0027 combined with \u0027srst_pulls_trst\u0027. Great.\n\n\"trst_and_srst tied\" looks good but keep in mind that we need also\n\"srst_only tied\" Huh? What is tied with what? \"srst_only trst_srst_tied\" is longer but self-explanatory.","accounts_in_message":[],"_revision_number":1},{"id":"c41807b4c052b6206358113482b8d4853f3f21e3","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2019-06-05 22:05:30.000000000","message":"Patch Set 1:\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"423bf5a1e425ca29a88d943933f22e49d0d4c4a4","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2019-06-06 07:03:30.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"4773c257427ca99133e5577f10dbb01b4dd09718","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2019-06-06 07:06:20.000000000","message":"Patch Set 2:\n\nChanged usage according to your comment and explained motivation for the changes in the commit msg.","accounts_in_message":[],"_revision_number":2},{"id":"1c6f0a5dbbda79193b2b87d6f78b3db40ad686b1","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2019-06-06 07:23:18.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/11828/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/11141/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"5b2f3446fc5b0f97abd55d7421d649d317670e48","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2019-06-06 08:50:19.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"20741b22048a4852ee4d9212d68450379b1f3b94","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2019-06-06 12:43:37.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"a6e4490d6dc0050506233a150542b8f63b7b5445","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2019-06-06 12:45:50.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"289e39fa06fcae1fa7d8c7936d438d5c769f7df1","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2019-06-06 12:51:02.000000000","message":"Patch Set 4:\n\nno other comments from my side.\nShould be completed with change in doc and config files.","accounts_in_message":[],"_revision_number":4},{"id":"cc0d4a2806e37f5bfee3c76f2f67601ebeeb8f22","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2019-06-06 13:30:32.000000000","message":"Patch Set 4: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/11837/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/11150/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"7d03b907f445a5268370355f420230613bbb54b8","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2019-06-14 13:56:45.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"c20519f0f55a406fdeb25979ca69154354ffc6d9","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2019-06-14 15:55:26.000000000","message":"Patch Set 5: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/11905/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/11216/ : SUCCESS","accounts_in_message":[],"_revision_number":5},{"id":"d0d16e4ecbcae9adc31b002b17ec3cc1202bc0f8","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2019-07-24 14:39:06.000000000","message":"Uploaded patch set 6: Patch Set 5 was rebased.","accounts_in_message":[],"_revision_number":6},{"id":"47ae275a547a56c2d809e21564308713691801e1","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2019-07-24 14:46:19.000000000","message":"Patch Set 6:\n\nSorry, too busy to return earlier on this.\nAdded in the topic \"reset\"","accounts_in_message":[],"_revision_number":6},{"id":"16ceafedf548b121086e9d268308bab55872d4d2","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2019-07-24 15:00:19.000000000","message":"Patch Set 6: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/11990/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/11299/ : SUCCESS","accounts_in_message":[],"_revision_number":6},{"id":"53e381d2a73de468c05503f18482fda5d89938d9","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2020-03-16 21:41:51.000000000","message":"Patch Set 6:\n\nAntonio, any chance to get review on this one?","accounts_in_message":[],"_revision_number":6},{"id":"bc117cbec38e0eca15880db9d83899f45eb9e36a","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2020-03-16 22:12:10.000000000","message":"Patch Set 6:\n\n(1 comment)\n\nFor me it the code change is ok, but I would like to extend its scope in the documentation.\nThen, in following patches, this would impact how the reset_config options will be used.","accounts_in_message":[],"_revision_number":6},{"id":"216d39588a5d8ecd5c33e427fb75b283d7f4090b","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2020-10-20 05:36:53.000000000","message":"Patch Set 6:\n\n\u003e (1 comment)\n \u003e \n \u003e ... but I would like to extend its\n \u003e scope in the documentation.\n\nSo if you want to do so then submit a patch...\nThe code changes done in this patch are documented.\nThe topic does not read \u0027extend the reset documentation\u0027.","accounts_in_message":[],"_revision_number":6},{"id":"4ecf727b50a310ae800fca1272581860554790ac","author":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"real_author":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"date":"2021-05-14 17:40:24.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6}],"current_revision":"572f03b3f1a315f79d7ee1b917a507b120a5fdd0","revisions":{"5d47d22c47a9dde09893def587cb4fa97cfd5043":{"kind":"REWORK","_number":4,"created":"2019-06-06 12:45:50.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/10/5210/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/10/5210/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/10/5210/4 \u0026\u0026 git checkout -b change-5210 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/10/5210/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/10/5210/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/10/5210/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/10/5210/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/10/5210/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8b9560349fb78887d8e353e20b303966d9ac2d1b","subject":"Convert DEBUG_JTAG_IO to LOG_DEBUG_IO"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2019-06-05 17:14:41.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2019-06-06 12:45:45.000000000","tz":120},"subject":"jtag/adapter: consolidate reset_config","message":"jtag/adapter: consolidate reset_config\n\nChange \u0027combined\u0027 option to more descriptive \u0027trst_srst_tied\u0027\n\nDo not output information not relevant to the current config\nand make the output easier to test in Tcl script.\n\nIf reset_config none, no signal combination (separate...) is relevant.\n\nIf configured to drive single reset line only\n(reset_config srst_only or trst_only), do not output single direction\npulls (trst_pulls_srst and srst_pulls_trst) and use \u0027trst_srst_tied\u0027\ninstead.\n\nBefore this patch, reset_config had 5 (!) possible configurations for\na fully degraded mode where both test and system reset are triggered\ntogether:\n reset_config srst_only srst_pulls_trst\n reset_config srst_only combined\n reset_config trst_only trst_pulls_srst\n reset_config trst_only combined\n reset_config trst_and_srst combined\n\nThe only difference is the adapter drives SRST, TRST or both.\nThe first two cases are equivalent because TRST is not driven.\nSimilarly 3th and 4th ones are equivalent because SRST is not driven.\nThis made Tcl tests for the fully degraded reset mode very complicated.\nThe new reset_config permits all 5 configs at the input but reduces\nambiguity at the output:\n srst_only trst_srst_tied\n trst_only trst_srst_tied\n trst_and_srst trst_srst_tied\n\nand the Tcl script can easily look for trst_srst_tied.\n\nIn the case of a semi-degraded mode where one reset signal pulls the other\nbut not vice versa, Tcl script can simply look for srst_pulls_trst or\ntrst_pulls_srst at reset_config output, because they are now shown\nin the semi-degraded mode only.\n\nChange-Id: I59393ce5c954dc97962c1cf08de3e6bd932830e9\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"4963a19e53d1f0d582209ad3185a21d7c400a7b8":{"kind":"REWORK","_number":5,"created":"2019-06-14 13:56:45.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/10/5210/5","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/10/5210/5","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/10/5210/5 \u0026\u0026 git checkout -b change-5210 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/10/5210/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/10/5210/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/10/5210/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/10/5210/5","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/10/5210/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4dbcb1e79d94a113af9c3da9c6f172782515f35e","subject":"target/cortex_a: remove dependency from jtag queue"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2019-06-05 17:14:41.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2019-06-14 13:55:48.000000000","tz":120},"subject":"jtag/adapter: consolidate reset_config","message":"jtag/adapter: consolidate reset_config\n\nChange \u0027combined\u0027 option to more descriptive \u0027trst_srst_tied\u0027\n\nDo not output information not relevant to the current config\nand make the output easier to test in Tcl script.\n\nIf reset_config none, no signal combination (separate...) is relevant.\n\nIf configured to drive single reset line only\n(reset_config srst_only or trst_only), do not output single direction\npulls (trst_pulls_srst and srst_pulls_trst) and use \u0027trst_srst_tied\u0027\ninstead.\n\nBefore this patch, reset_config had 5 (!) possible configurations for\na fully degraded mode where both test and system reset are triggered\ntogether:\n reset_config srst_only srst_pulls_trst\n reset_config srst_only combined\n reset_config trst_only trst_pulls_srst\n reset_config trst_only combined\n reset_config trst_and_srst combined\n\nThe only difference is the adapter drives SRST, TRST or both.\nThe first two cases are equivalent because TRST is not driven.\nSimilarly 3th and 4th ones are equivalent because SRST is not driven.\nThis made Tcl tests for the fully degraded reset mode very complicated.\nThe new reset_config permits all 5 configs at the input but reduces\nambiguity at the output:\n srst_only trst_srst_tied\n trst_only trst_srst_tied\n trst_and_srst trst_srst_tied\n\nand the Tcl script can easily look for trst_srst_tied.\n\nIn the case of a semi-degraded mode where one reset signal pulls the other\nbut not vice versa, Tcl script can simply look for srst_pulls_trst or\ntrst_pulls_srst at reset_config output, because they are now shown\nin the semi-degraded mode only.\n\nChange-Id: I59393ce5c954dc97962c1cf08de3e6bd932830e9\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"572f03b3f1a315f79d7ee1b917a507b120a5fdd0":{"kind":"TRIVIAL_REBASE","_number":6,"created":"2019-07-24 14:39:06.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/10/5210/6","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/10/5210/6","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/10/5210/6 \u0026\u0026 git checkout -b change-5210 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/10/5210/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/10/5210/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/10/5210/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/10/5210/6","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/10/5210/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"263deb3802a515ba8155b6c59146f0f539de4e43","subject":"configure.ac: Fix ST-Link adapter description"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2019-06-05 17:14:41.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2019-07-24 14:19:46.000000000","tz":120},"subject":"jtag/adapter: consolidate reset_config","message":"jtag/adapter: consolidate reset_config\n\nChange \u0027combined\u0027 option to more descriptive \u0027trst_srst_tied\u0027\n\nDo not output information not relevant to the current config\nand make the output easier to test in Tcl script.\n\nIf reset_config none, no signal combination (separate...) is relevant.\n\nIf configured to drive single reset line only\n(reset_config srst_only or trst_only), do not output single direction\npulls (trst_pulls_srst and srst_pulls_trst) and use \u0027trst_srst_tied\u0027\ninstead.\n\nBefore this patch, reset_config had 5 (!) possible configurations for\na fully degraded mode where both test and system reset are triggered\ntogether:\n reset_config srst_only srst_pulls_trst\n reset_config srst_only combined\n reset_config trst_only trst_pulls_srst\n reset_config trst_only combined\n reset_config trst_and_srst combined\n\nThe only difference is the adapter drives SRST, TRST or both.\nThe first two cases are equivalent because TRST is not driven.\nSimilarly 3th and 4th ones are equivalent because SRST is not driven.\nThis made Tcl tests for the fully degraded reset mode very complicated.\nThe new reset_config permits all 5 configs at the input but reduces\nambiguity at the output:\n srst_only trst_srst_tied\n trst_only trst_srst_tied\n trst_and_srst trst_srst_tied\n\nand the Tcl script can easily look for trst_srst_tied.\n\nIn the case of a semi-degraded mode where one reset signal pulls the other\nbut not vice versa, Tcl script can simply look for srst_pulls_trst or\ntrst_pulls_srst at reset_config output, because they are now shown\nin the semi-degraded mode only.\n\nChange-Id: I59393ce5c954dc97962c1cf08de3e6bd932830e9\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"661556415fe15b69377468434c03248afa324931":{"kind":"REWORK","_number":1,"created":"2019-06-05 17:28:59.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/10/5210/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/10/5210/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/10/5210/1 \u0026\u0026 git checkout -b change-5210 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/10/5210/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/10/5210/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/10/5210/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/10/5210/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/10/5210/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8b9560349fb78887d8e353e20b303966d9ac2d1b","subject":"Convert DEBUG_JTAG_IO to LOG_DEBUG_IO"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2019-06-05 17:14:41.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2019-06-05 17:14:41.000000000","tz":120},"subject":"jtag/adapter: consolidate reset_config","message":"jtag/adapter: consolidate reset_config\n\nChange \u0027combined\u0027 option to \u0027trst_srst_tied\u0027\n\nDo not output information not relevant to the current config.\n\nIf reset_config none, any signal combination (separate...) is not relevant.\n\nIf configured single line only (reset_config srst_only or trst_only),\ndo not output single direction pulls (trst_pulls_srst and srst_pulls_trst)\nand use \u0027trst_srst_tied\u0027 instead.\n\nChange-Id: I59393ce5c954dc97962c1cf08de3e6bd932830e9\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"599122d8bdfedbbc4e9bd10db67eb22be23cf9f3":{"kind":"REWORK","_number":2,"created":"2019-06-06 07:03:30.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/10/5210/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/10/5210/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/10/5210/2 \u0026\u0026 git checkout -b change-5210 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/10/5210/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/10/5210/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/10/5210/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/10/5210/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/10/5210/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8b9560349fb78887d8e353e20b303966d9ac2d1b","subject":"Convert DEBUG_JTAG_IO to LOG_DEBUG_IO"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2019-06-05 17:14:41.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2019-06-06 06:30:51.000000000","tz":120},"subject":"jtag/adapter: consolidate reset_config","message":"jtag/adapter: consolidate reset_config\n\nChange \u0027combined\u0027 option to more descriptive \u0027trst_srst_tied\u0027\n\nDo not output information not relevant to the current config\nand make the output easier to test in Tcl script.\n\nIf reset_config none, no signal combination (separate...) is relevant.\n\nIf configured to drive single reset line only\n(reset_config srst_only or trst_only), do not output single direction\npulls (trst_pulls_srst and srst_pulls_trst) and use \u0027trst_srst_tied\u0027\ninstead.\n\nBefore this patch, reset_config had 5 (!) possible configurations for\na fully degraded mode where both test and system reset are triggered\ntogether:\n reset_config srst_only srst_pulls_trst\n reset_config srst_only combined\n reset_config trst_only trst_pulls_srst\n reset_config trst_only combined\n reset_config trst_and_srst combined\n\nThe only difference is the adapter drives SRST, TRST or both.\nThe first two cases are equivalent because TRST is not driven.\nSimilarly 3th and 4th ones are equivalent because SRST is not driven.\nThis made Tcl tests for the fully degraded reset mode very complicated.\nThe new reset_config permits all 5 configs at the input but reduces\nambiguity at the output:\n srst_only trst_srst_tied\n trst_only trst_srst_tied\n trst_and_srst trst_srst_tied\n\nand the Tcl script can easily look for trst_srst_tied.\n\nIn the case of a semi-degraded mode where one reset signal pulls the other\nbut not vice versa, Tcl script can simply look for srst_pulls_trst or\ntrst_pulls_srst at reset_config output, because they are now shown\nin the semi-degraded mode only.\n\nChange-Id: I59393ce5c954dc97962c1cf08de3e6bd932830e9\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"ffdf52a75a2d936d6f80e9fec13cc2c29262343f":{"kind":"REWORK","_number":3,"created":"2019-06-06 12:43:37.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/10/5210/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/10/5210/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/10/5210/3 \u0026\u0026 git checkout -b change-5210 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/10/5210/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/10/5210/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/10/5210/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/10/5210/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/10/5210/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8b9560349fb78887d8e353e20b303966d9ac2d1b","subject":"Convert DEBUG_JTAG_IO to LOG_DEBUG_IO"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2019-06-05 17:14:41.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2019-06-06 12:43:28.000000000","tz":120},"subject":"jtag/adapter: consolidate reset_config","message":"jtag/adapter: consolidate reset_config\n\nChange \u0027combined\u0027 option to more descriptive \u0027trst_srst_tied\u0027\n\nDo not output information not relevant to the current config\nand make the output easier to test in Tcl script.\n\nIf reset_config none, no signal combination (separate...) is relevant.\n\nIf configured to drive single reset line only\n(reset_config srst_only or trst_only), do not output single direction\npulls (trst_pulls_srst and srst_pulls_trst) and use \u0027trst_srst_tied\u0027\ninstead.\n\nBefore this patch, reset_config had 5 (!) possible configurations for\na fully degraded mode where both test and system reset are triggered\ntogether:\n reset_config srst_only srst_pulls_trst\n reset_config srst_only combined\n reset_config trst_only trst_pulls_srst\n reset_config trst_only combined\n reset_config trst_and_srst combined\n\nThe only difference is the adapter drives SRST, TRST or both.\nThe first two cases are equivalent because TRST is not driven.\nSimilarly 3th and 4th ones are equivalent because SRST is not driven.\nThis made Tcl tests for the fully degraded reset mode very complicated.\nThe new reset_config permits all 5 configs at the input but reduces\nambiguity at the output:\n srst_only trst_srst_tied\n trst_only trst_srst_tied\n trst_and_srst trst_srst_tied\n\nand the Tcl script can easily look for trst_srst_tied.\n\nIn the case of a semi-degraded mode where one reset signal pulls the other\nbut not vice versa, Tcl script can simply look for srst_pulls_trst or\ntrst_pulls_srst at reset_config output, because they are now shown\nin the semi-degraded mode only.\n\nChange-Id: I59393ce5c954dc97962c1cf08de3e6bd932830e9\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"NEED"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}}]}