)]}'
{"id":"openocd~master~Ic4975026c1ae4f2853795575ac7701d541248736","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001651":{"account":{"_account_id":1001651,"name":"Florian Fainelli","email":"f.fainelli@gmail.com","username":"ffainelli"},"last_update":"2023-10-14 11:55:42.000000000","reason":"Change was submitted"},"1002166":{"account":{"_account_id":1002166,"name":"Michael Chalfant","email":"michael.chalfant@gmail.com","username":"mlchalfant"},"last_update":"2023-10-14 11:55:42.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ic4975026c1ae4f2853795575ac7701d541248736","subject":"arm_opcode: Add support for ARM MCRR/MRRC","status":"MERGED","created":"2019-06-11 19:47:21.000000000","updated":"2023-10-14 11:55:42.000000000","submitted":"2023-10-14 11:55:42.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":20,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"5228","meta_rev_id":"37ddee7904002a30550af3fc6bf7cf17a1aa38ed","_number":5228,"owner":{"_account_id":1001651,"name":"Florian Fainelli","email":"f.fainelli@gmail.com","username":"ffainelli"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001651,"name":"Florian Fainelli","email":"f.fainelli@gmail.com","username":"ffainelli"},{"value":0,"_account_id":1000256,"name":"Kamal Dasu","email":"kamal.dasu@gmail.com"},{"value":0,"_account_id":1001654,"name":"Mete Balci","email":"metebalci@gmail.com","username":"mete"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000213,"name":"Kamal Dasu","email":"kdasu.kdev@gmail.com","username":"kdasu.kdev"},{"value":0,"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},{"value":0,"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-10-14 11:55:42.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"value":0,"_account_id":1001651,"name":"Florian Fainelli","email":"f.fainelli@gmail.com","username":"ffainelli"},{"value":0,"_account_id":1000256,"name":"Kamal Dasu","email":"kamal.dasu@gmail.com"},{"value":0,"_account_id":1001654,"name":"Mete Balci","email":"metebalci@gmail.com","username":"mete"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-10-14 11:55:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000213,"name":"Kamal Dasu","email":"kdasu.kdev@gmail.com","username":"kdasu.kdev"},{"value":0,"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},{"value":0,"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1002166,"name":"Michael Chalfant","email":"michael.chalfant@gmail.com","username":"mlchalfant"}],"reviewers":{"REVIEWER":[{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000213,"name":"Kamal Dasu","email":"kdasu.kdev@gmail.com","username":"kdasu.kdev"},{"_account_id":1000256,"name":"Kamal Dasu","email":"kamal.dasu@gmail.com"},{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},{"_account_id":1001651,"name":"Florian Fainelli","email":"f.fainelli@gmail.com","username":"ffainelli"},{"_account_id":1001654,"name":"Mete Balci","email":"metebalci@gmail.com","username":"mete"},{"_account_id":1002166,"name":"Michael Chalfant","email":"michael.chalfant@gmail.com","username":"mlchalfant"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-11 19:48:12.000000000","updated_by":{"_account_id":1000256,"name":"Kamal Dasu","email":"kamal.dasu@gmail.com"},"reviewer":{"_account_id":1000256,"name":"Kamal Dasu","email":"kamal.dasu@gmail.com"},"state":"REVIEWER"},{"updated":"2019-06-11 19:48:16.000000000","updated_by":{"_account_id":1000213,"name":"Kamal Dasu","email":"kdasu.kdev@gmail.com","username":"kdasu.kdev"},"reviewer":{"_account_id":1000213,"name":"Kamal Dasu","email":"kdasu.kdev@gmail.com","username":"kdasu.kdev"},"state":"REVIEWER"},{"updated":"2019-06-11 19:48:27.000000000","updated_by":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"reviewer":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"state":"REVIEWER"},{"updated":"2019-06-11 19:48:31.000000000","updated_by":{"_account_id":1001654,"name":"Mete Balci","email":"metebalci@gmail.com","username":"mete"},"reviewer":{"_account_id":1001654,"name":"Mete Balci","email":"metebalci@gmail.com","username":"mete"},"state":"REVIEWER"},{"updated":"2019-11-02 22:28:03.000000000","updated_by":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"reviewer":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"state":"REVIEWER"},{"updated":"2020-07-26 18:42:58.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2021-07-23 03:57:05.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-07-19 23:43:45.000000000","updated_by":{"_account_id":1002166,"name":"Michael Chalfant","email":"michael.chalfant@gmail.com","username":"mlchalfant"},"reviewer":{"_account_id":1002166,"name":"Michael Chalfant","email":"michael.chalfant@gmail.com","username":"mlchalfant"},"state":"REVIEWER"}],"messages":[{"id":"4eaaea65059bb32b23612b38e33326ff94dd071f","author":{"_account_id":1001651,"name":"Florian Fainelli","email":"f.fainelli@gmail.com","username":"ffainelli"},"real_author":{"_account_id":1001651,"name":"Florian Fainelli","email":"f.fainelli@gmail.com","username":"ffainelli"},"date":"2019-06-11 19:47:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ad71131376d545ebd4ffb0f3812b90b005402481","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2019-06-11 20:07:53.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttp://build.openocd.org/job/openocd-gerrit/11870/ : FAILURE\n\nhttp://build.openocd.org/job/openocd-gerrit-build/11182/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"25f3d81e8376b554765bb8518a8469d8a5fe397a","author":{"_account_id":1001651,"name":"Florian Fainelli","email":"f.fainelli@gmail.com","username":"ffainelli"},"real_author":{"_account_id":1001651,"name":"Florian Fainelli","email":"f.fainelli@gmail.com","username":"ffainelli"},"date":"2019-06-17 21:47:05.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"eb9daf9114bdc7a15f8479b4d39cc72d669a53c3","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2019-06-17 22:29:00.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/11915/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/11226/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"fb2be17848dac7d30bf6a801cab8ac886f40cea7","author":{"_account_id":1001651,"name":"Florian Fainelli","email":"f.fainelli@gmail.com","username":"ffainelli"},"real_author":{"_account_id":1001651,"name":"Florian Fainelli","email":"f.fainelli@gmail.com","username":"ffainelli"},"date":"2019-09-20 22:18:20.000000000","message":"Patch Set 2:\n\nShould I rebase this patchset?","accounts_in_message":[],"_revision_number":2},{"id":"881b9df760306d1343102b9690f7fc1168ae4034","author":{"_account_id":1001651,"name":"Florian Fainelli","email":"f.fainelli@gmail.com","username":"ffainelli"},"real_author":{"_account_id":1001651,"name":"Florian Fainelli","email":"f.fainelli@gmail.com","username":"ffainelli"},"date":"2019-11-01 17:20:46.000000000","message":"Patch Set 2:\n\nDoes anyone have any objections to this?","accounts_in_message":[],"_revision_number":2},{"id":"077204c07e0c4572729d58ffe4ab7e7a1ab9bced","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2019-11-02 22:28:03.000000000","message":"Patch Set 2: Code-Review+1\n\nNot an ARMv7A expert but I don\u0027t smell anything weird here.","accounts_in_message":[],"_revision_number":2},{"id":"b612e24d72cfd05cb2efde409c015c1368d3397f","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2019-11-02 23:11:25.000000000","message":"Patch Set 2:\n\n(3 comments)\n\nAlmost ok with this, just few minor comments below.\nI hesitated because I could not find anymore some old patch for recovering R1 after being used as scratch value, but then I found it already merged in http://openocd.zylin.com/4506/ so ok.","accounts_in_message":[],"_revision_number":2},{"id":"b90eb3cad94d52823701ee6cb11e95661c442747","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2019-11-03 09:04:57.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"f94d4ba1487728fa6ffb9838eca8cdfaff5af5c2","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2020-07-26 18:42:58.000000000","message":"Patch Set 2: Code-Review-1\n\nHi Florian, could you please reply about\nhttp://openocd.zylin.com/#/c/5228/2/src/target/armv4_5.c@1173\nand\nhttp://openocd.zylin.com/#/c/5228/2/src/target/cortex_a.c@656\n? Thanks","accounts_in_message":[],"_revision_number":2},{"id":"9ec7b2e39a48318cd599a138b5fca47a54739ace","author":{"_account_id":1001651,"name":"Florian Fainelli","email":"f.fainelli@gmail.com","username":"ffainelli"},"real_author":{"_account_id":1001651,"name":"Florian Fainelli","email":"f.fainelli@gmail.com","username":"ffainelli"},"date":"2020-07-30 20:45:57.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"780a8ee36de0b6fc9215d6f78016672425feb653","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2020-07-30 21:25:35.000000000","message":"Patch Set 2:\n\n(6 comments)\n\nFew other minor comments","accounts_in_message":[],"_revision_number":2},{"id":"32f4c0a4f935a5a2a56e5a2b3072aab704fa2140","author":{"_account_id":1001651,"name":"Florian Fainelli","email":"f.fainelli@gmail.com","username":"ffainelli"},"real_author":{"_account_id":1001651,"name":"Florian Fainelli","email":"f.fainelli@gmail.com","username":"ffainelli"},"date":"2021-07-22 03:17:37.000000000","message":"Patch Set 2:\n\n(5 comments)","accounts_in_message":[],"_revision_number":2},{"id":"069c97b84a8e60e4bd02bccea0e310de7e757bb0","author":{"_account_id":1001651,"name":"Florian Fainelli","email":"f.fainelli@gmail.com","username":"ffainelli"},"real_author":{"_account_id":1001651,"name":"Florian Fainelli","email":"f.fainelli@gmail.com","username":"ffainelli"},"date":"2021-07-23 03:27:16.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"c8f98e26832a655e7accfd78caf4ac9b678a3bce","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-07-23 03:57:05.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14885/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/14131/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"4552dc006c26bc863eea27a415f4773107960633","author":{"_account_id":1001651,"name":"Florian Fainelli","email":"f.fainelli@gmail.com","username":"ffainelli"},"real_author":{"_account_id":1001651,"name":"Florian Fainelli","email":"f.fainelli@gmail.com","username":"ffainelli"},"date":"2021-10-20 21:59:44.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"44b02524acc256716c8def46aeb920f062dcf139","author":{"_account_id":1001651,"name":"Florian Fainelli","email":"f.fainelli@gmail.com","username":"ffainelli"},"real_author":{"_account_id":1001651,"name":"Florian Fainelli","email":"f.fainelli@gmail.com","username":"ffainelli"},"date":"2022-04-26 22:01:13.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"a6f7f1752626f3f3ae8b3bebb84561aed467274b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001651,"name":"Florian Fainelli","email":"f.fainelli@gmail.com","username":"ffainelli"},"real_author":{"_account_id":1001651,"name":"Florian Fainelli","email":"f.fainelli@gmail.com","username":"ffainelli"},"date":"2022-04-26 22:05:39.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"825982265bcb1a58d4db51c30c9b629edbea1cc5","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-04-26 22:46:56.000000000","message":"Patch Set 4: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/16068/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15278/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"0c9e9b6ff22fd4a9fc61c98637620670d774e3b8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002166,"name":"Michael Chalfant","email":"michael.chalfant@gmail.com","username":"mlchalfant"},"real_author":{"_account_id":1002166,"name":"Michael Chalfant","email":"michael.chalfant@gmail.com","username":"mlchalfant"},"date":"2023-07-19 23:43:45.000000000","message":"Uploaded patch set 5.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":5},{"id":"fdaebcd3798953739927023974923200000e4a04","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-07-19 23:44:46.000000000","message":"Patch Set 5: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/17999/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17198/ : FAILURE","accounts_in_message":[],"_revision_number":5},{"id":"f837c7dc64e043162456495870af122fd10ffbb8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002166,"name":"Michael Chalfant","email":"michael.chalfant@gmail.com","username":"mlchalfant"},"real_author":{"_account_id":1002166,"name":"Michael Chalfant","email":"michael.chalfant@gmail.com","username":"mlchalfant"},"date":"2023-07-20 00:13:29.000000000","message":"Patch Set 6: Commit message was updated.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":6},{"id":"be2ffa14822327f76c6cce23847a5e80d73e9b3e","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-07-20 00:14:17.000000000","message":"Patch Set 6: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/18000/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17199/ : FAILURE","accounts_in_message":[],"_revision_number":6},{"id":"ef3b4f439c9aa7c6bdf2679c010e0b02bb9fa921","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002166,"name":"Michael Chalfant","email":"michael.chalfant@gmail.com","username":"mlchalfant"},"real_author":{"_account_id":1002166,"name":"Michael Chalfant","email":"michael.chalfant@gmail.com","username":"mlchalfant"},"date":"2023-07-21 17:45:47.000000000","message":"Uploaded patch set 7.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":7},{"id":"f72a7d6828b74f2e8cacd84028805efda7518250","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-07-21 17:56:51.000000000","message":"Patch Set 7: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/18006/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17205/ : SUCCESS","accounts_in_message":[],"_revision_number":7},{"id":"c8a728706089f592ab36015871a6ce1ea4a9e921","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-10-03 11:58:22.000000000","message":"Patch Set 7: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":7},{"id":"f26b22413e579d15e0ef4791e3b0b1e8b9a88162","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-10-14 11:55:27.000000000","message":"Patch Set 7: Code-Review+2","accounts_in_message":[],"_revision_number":7},{"id":"37ddee7904002a30550af3fc6bf7cf17a1aa38ed","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-10-14 11:55:42.000000000","message":"Change has been successfully cherry-picked as d27a3a00b8582cf2750cbc86c6194f5796ccca06","accounts_in_message":[],"_revision_number":8}],"current_revision":"d27a3a00b8582cf2750cbc86c6194f5796ccca06","revisions":{"d27a3a00b8582cf2750cbc86c6194f5796ccca06":{"kind":"REWORK","_number":8,"created":"2023-10-14 11:55:42.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/28/5228/8","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/28/5228/8","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/28/5228/8 \u0026\u0026 git checkout -b change-5228 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/28/5228/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/28/5228/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/28/5228/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/28/5228/8","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/28/5228/8 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1bc4182cebcbdf93d68d9759f4b4579ea4df7887","subject":"target/nrf52: Create and configure TPIU"}],"author":{"name":"Florian Fainelli","email":"f.fainelli@gmail.com","date":"2019-03-18 23:00:07.000000000","tz":-420},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-10-14 11:55:42.000000000","tz":0},"subject":"arm_opcode: Add support for ARM MCRR/MRRC","message":"arm_opcode: Add support for ARM MCRR/MRRC\n\nAdd support for the ARM MCRR/MRRC instructions which require the use of\ntwo registers to transfer a 64-bit co-processor registers. We are going\nto use this in a subsequent patch in order to properly dump 64-bit page\ntable descriptors that exist on ARMv7A with VMSA extensions.\n\nWe make use of r0 and r1 to transfer 64-bit quantities to/from DCC.\n\nChange-Id: Ic4975026c1ae4f2853795575ac7701d541248736\nSigned-off-by: Florian Fainelli \u003cf.fainelli@gmail.com\u003e\nSigned-off-by: Michael Chalfant \u003cmichael.chalfant@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/5228\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"2628e98f3e462c685a75150b0d237e41311ce926":{"kind":"REWORK","_number":1,"created":"2019-06-11 19:47:21.000000000","uploader":{"_account_id":1001651,"name":"Florian Fainelli","email":"f.fainelli@gmail.com","username":"ffainelli"},"ref":"refs/changes/28/5228/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/28/5228/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/28/5228/1 \u0026\u0026 git checkout -b change-5228 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/28/5228/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/28/5228/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/28/5228/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/28/5228/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/28/5228/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"15882d184da09cbdfa9c9fede19de43ccdad4e33","subject":"target/cortex_a: Extract code to read/write from/to register to/from DCC"}],"author":{"name":"Florian Fainelli","email":"f.fainelli@gmail.com","date":"2019-03-18 23:00:07.000000000","tz":-420},"committer":{"name":"Florian Fainelli","email":"f.fainelli@gmail.com","date":"2019-06-11 19:47:10.000000000","tz":-420},"subject":"arm_opcode: Add support for ARM MCRR/MRRC","message":"arm_opcode: Add support for ARM MCRR/MRRC\n\nAdd support for the ARM MCRR/MRRC instructions which require the use of\ntwo registers to transfer a 64-bit co-processor registers. We are going\nto use this in a subsequent patch in order to properly dump 64-bit page\ntable descriptors that exist on ARMv7A with VMSA extensions.\n\nWe make use of r0 and r1 to transfer 64-bit quantities to/from DCC.\n\nChange-Id: Ic4975026c1ae4f2853795575ac7701d541248736\nSigned-off-by: Florian Fainelli \u003cf.fainelli@gmail.com\u003e\n"}},"78701ef37a2ddcfd689b4806578a8cda190a923c":{"kind":"REWORK","_number":3,"created":"2021-07-23 03:27:16.000000000","uploader":{"_account_id":1001651,"name":"Florian Fainelli","email":"f.fainelli@gmail.com","username":"ffainelli"},"ref":"refs/changes/28/5228/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/28/5228/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/28/5228/3 \u0026\u0026 git checkout -b change-5228 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/28/5228/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/28/5228/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/28/5228/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/28/5228/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/28/5228/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"20b29b7767097f999fe2eb4f7fb6c2917e9f66a6","subject":"openocd: manually fix Yoda conditions"}],"author":{"name":"Florian Fainelli","email":"f.fainelli@gmail.com","date":"2019-03-18 23:00:07.000000000","tz":-420},"committer":{"name":"Florian Fainelli","email":"f.fainelli@gmail.com","date":"2021-07-23 03:23:17.000000000","tz":-420},"subject":"arm_opcode: Add support for ARM MCRR/MRRC","message":"arm_opcode: Add support for ARM MCRR/MRRC\n\nAdd support for the ARM MCRR/MRRC instructions which require the use of\ntwo registers to transfer a 64-bit co-processor registers. We are going\nto use this in a subsequent patch in order to properly dump 64-bit page\ntable descriptors that exist on ARMv7A with VMSA extensions.\n\nWe make use of r0 and r1 to transfer 64-bit quantities to/from DCC.\n\nChange-Id: Ic4975026c1ae4f2853795575ac7701d541248736\nSigned-off-by: Florian Fainelli \u003cf.fainelli@gmail.com\u003e\n"}},"ac1bcc2c8ec8a4ca6d75b2cbe853155a1425067d":{"kind":"REWORK","_number":2,"created":"2019-06-17 21:47:05.000000000","uploader":{"_account_id":1001651,"name":"Florian Fainelli","email":"f.fainelli@gmail.com","username":"ffainelli"},"ref":"refs/changes/28/5228/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/28/5228/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/28/5228/2 \u0026\u0026 git checkout -b change-5228 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/28/5228/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/28/5228/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/28/5228/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/28/5228/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/28/5228/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ea668738c2d3941bd8b82ec7bea7c21637406081","subject":"target/cortex_a: Extract code to read/write from/to register to/from DCC"}],"author":{"name":"Florian Fainelli","email":"f.fainelli@gmail.com","date":"2019-03-18 23:00:07.000000000","tz":-420},"committer":{"name":"Florian Fainelli","email":"f.fainelli@gmail.com","date":"2019-06-17 21:46:35.000000000","tz":-420},"subject":"arm_opcode: Add support for ARM MCRR/MRRC","message":"arm_opcode: Add support for ARM MCRR/MRRC\n\nAdd support for the ARM MCRR/MRRC instructions which require the use of\ntwo registers to transfer a 64-bit co-processor registers. We are going\nto use this in a subsequent patch in order to properly dump 64-bit page\ntable descriptors that exist on ARMv7A with VMSA extensions.\n\nWe make use of r0 and r1 to transfer 64-bit quantities to/from DCC.\n\nChange-Id: Ic4975026c1ae4f2853795575ac7701d541248736\nSigned-off-by: Florian Fainelli \u003cf.fainelli@gmail.com\u003e\n"}},"e7db22627dd395b6fd8d089d6385b32f3f583cbf":{"kind":"REWORK","_number":5,"created":"2023-07-19 23:43:45.000000000","uploader":{"_account_id":1002166,"name":"Michael Chalfant","email":"michael.chalfant@gmail.com","username":"mlchalfant"},"ref":"refs/changes/28/5228/5","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/28/5228/5","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/28/5228/5 \u0026\u0026 git checkout -b change-5228 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/28/5228/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/28/5228/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/28/5228/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/28/5228/5","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/28/5228/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2c57d11c78108c6547f31ca07f1ff672fa855f10","subject":"tcl/board: add esp32s3-builtin.cfg file"}],"author":{"name":"Florian Fainelli","email":"f.fainelli@gmail.com","date":"2019-03-18 23:00:07.000000000","tz":-420},"committer":{"name":"Michael Chalfant","email":"michael.chalfant@gmail.com","date":"2023-07-19 23:43:17.000000000","tz":-420},"subject":"arm_opcode: Add support for ARM MCRR/MRRC","message":"arm_opcode: Add support for ARM MCRR/MRRC\n\nAdd support for the ARM MCRR/MRRC instructions which require the use of\ntwo registers to transfer a 64-bit co-processor registers. We are going\nto use this in a subsequent patch in order to properly dump 64-bit page\ntable descriptors that exist on ARMv7A with VMSA extensions.\n\nWe make use of r0 and r1 to transfer 64-bit quantities to/from DCC.\n\nChange-Id: Ic4975026c1ae4f2853795575ac7701d541248736\nSigned-off-by: Florian Fainelli \u003cf.fainelli@gmail.com\u003e\nSigned-off-by: Michael Chalfant \u003cmichael.chalfant@gmail.com\u003e\n"}},"c5feda37bc1e263a5f378ae7dbf694ea6179b1ba":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2022-04-26 22:05:39.000000000","uploader":{"_account_id":1001651,"name":"Florian Fainelli","email":"f.fainelli@gmail.com","username":"ffainelli"},"ref":"refs/changes/28/5228/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/28/5228/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/28/5228/4 \u0026\u0026 git checkout -b change-5228 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/28/5228/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/28/5228/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/28/5228/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/28/5228/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/28/5228/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9de084e0067a86b8040f8ea2c3f46dff0b9e6a70","subject":"flash/nor/stm32f1x: add can_load_options flag for GD32F1x0, F3x0 and E23x"}],"author":{"name":"Florian Fainelli","email":"f.fainelli@gmail.com","date":"2019-03-18 23:00:07.000000000","tz":-420},"committer":{"name":"Florian Fainelli","email":"f.fainelli@gmail.com","date":"2022-04-26 22:04:07.000000000","tz":-420},"subject":"arm_opcode: Add support for ARM MCRR/MRRC","message":"arm_opcode: Add support for ARM MCRR/MRRC\n\nAdd support for the ARM MCRR/MRRC instructions which require the use of\ntwo registers to transfer a 64-bit co-processor registers. We are going\nto use this in a subsequent patch in order to properly dump 64-bit page\ntable descriptors that exist on ARMv7A with VMSA extensions.\n\nWe make use of r0 and r1 to transfer 64-bit quantities to/from DCC.\n\nChange-Id: Ic4975026c1ae4f2853795575ac7701d541248736\nSigned-off-by: Florian Fainelli \u003cf.fainelli@gmail.com\u003e\n"}},"1aeed41a5179fef619212fd43df146f067ed92de":{"kind":"REWORK","_number":7,"created":"2023-07-21 17:45:47.000000000","uploader":{"_account_id":1002166,"name":"Michael Chalfant","email":"michael.chalfant@gmail.com","username":"mlchalfant"},"ref":"refs/changes/28/5228/7","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/28/5228/7","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/28/5228/7 \u0026\u0026 git checkout -b change-5228 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/28/5228/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/28/5228/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/28/5228/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/28/5228/7","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/28/5228/7 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2c57d11c78108c6547f31ca07f1ff672fa855f10","subject":"tcl/board: add esp32s3-builtin.cfg file"}],"author":{"name":"Florian Fainelli","email":"f.fainelli@gmail.com","date":"2019-03-18 23:00:07.000000000","tz":-420},"committer":{"name":"Michael Chalfant","email":"michael.chalfant@gmail.com","date":"2023-07-21 17:44:54.000000000","tz":-420},"subject":"arm_opcode: Add support for ARM MCRR/MRRC","message":"arm_opcode: Add support for ARM MCRR/MRRC\n\nAdd support for the ARM MCRR/MRRC instructions which require the use of\ntwo registers to transfer a 64-bit co-processor registers. We are going\nto use this in a subsequent patch in order to properly dump 64-bit page\ntable descriptors that exist on ARMv7A with VMSA extensions.\n\nWe make use of r0 and r1 to transfer 64-bit quantities to/from DCC.\n\nChange-Id: Ic4975026c1ae4f2853795575ac7701d541248736\nSigned-off-by: Florian Fainelli \u003cf.fainelli@gmail.com\u003e\nSigned-off-by: Michael Chalfant \u003cmichael.chalfant@gmail.com\u003e\n"}},"0e1e340fe463b9727a67c5526cc2c383fddff845":{"kind":"NO_CODE_CHANGE","_number":6,"created":"2023-07-20 00:13:29.000000000","uploader":{"_account_id":1002166,"name":"Michael Chalfant","email":"michael.chalfant@gmail.com","username":"mlchalfant"},"ref":"refs/changes/28/5228/6","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/28/5228/6","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/28/5228/6 \u0026\u0026 git checkout -b change-5228 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/28/5228/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/28/5228/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/28/5228/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/28/5228/6","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/28/5228/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2c57d11c78108c6547f31ca07f1ff672fa855f10","subject":"tcl/board: add esp32s3-builtin.cfg file"}],"author":{"name":"Florian Fainelli","email":"f.fainelli@gmail.com","date":"2019-03-18 23:00:07.000000000","tz":-420},"committer":{"name":"Michael Chalfant","email":"michael.chalfant@gmail.com","date":"2023-07-20 00:13:29.000000000","tz":0},"subject":"arm_opcode: Add support for ARM MCRR/MRRC","message":"arm_opcode: Add support for ARM MCRR/MRRC\n\nAdd support for the ARM MCRR/MRRC instructions which require the use of\ntwo registers to transfer a 64-bit co-processor registers. We are going\nto use this in a subsequent patch in order to properly dump 64-bit page\ntable descriptors that exist on ARMv7A with VMSA extensions.\n\nWe make use of r0 and r1 to transfer 64-bit quantities to/from DCC.\n\nRebase of patchset 4.\nConvert jim_mcrrmrrcc to use COMMAND_HANDLER following the model established in handle_armv4_5_mcrmrc.\nUse instr_(read/write)_data_r0_r1 to ensure use of r0 and r1.\n\nChange-Id: Ic4975026c1ae4f2853795575ac7701d541248736\nSigned-off-by: Florian Fainelli \u003cf.fainelli@gmail.com\u003e\nSigned-off-by: Michael Chalfant \u003cmichael.chalfant@gmail.com\u003e\n"},"description":"Edit commit message"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}