)]}'
{"id":"openocd~master~I2b4122f7939cec91a72284006748f99a23548324","project":"openocd","branch":"master","hashtags":[],"change_id":"I2b4122f7939cec91a72284006748f99a23548324","subject":"bitbang: Fix FTBFS with GCC 10","status":"MERGED","created":"2020-04-17 12:18:50.000000000","updated":"2020-04-24 16:44:13.000000000","submitted":"2020-04-24 16:44:13.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"5592-1587746653644-604eaebb","meta_rev_id":"79a07362a7ab5eebbf50551203fd0d842029fb00","_number":5592,"owner":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001415,"name":"Jonathan McDowell","email":"noodles-openocd@earth.li","username":"u1f35c"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":1,"date":"2020-04-24 16:44:13.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"value":1,"date":"2020-04-24 16:44:13.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001415,"name":"Jonathan McDowell","email":"noodles-openocd@earth.li","username":"u1f35c"},{"value":2,"date":"2020-04-24 16:44:13.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001415,"name":"Jonathan McDowell","email":"noodles-openocd@earth.li","username":"u1f35c"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-04-17 12:54:12.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-04-17 14:35:01.000000000","updated_by":{"_account_id":1001415,"name":"Jonathan McDowell","email":"noodles-openocd@earth.li","username":"u1f35c"},"reviewer":{"_account_id":1001415,"name":"Jonathan McDowell","email":"noodles-openocd@earth.li","username":"u1f35c"},"state":"REVIEWER"},{"updated":"2020-04-24 16:44:13.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"44a26725e452efa1f7b46f5cf996cd85be96abd6","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2020-04-17 12:18:50.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d95c75445fdeeb1a9caae8f25fff34cb63d6655f","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2020-04-17 12:54:12.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/12865/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/12160/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"2caf6748de3e68f0e737c6ddb2a5c01c35f8e12c","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2020-04-17 13:29:28.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"b87be7f67ae9f541e8efda3a90cdccbec2396eeb","author":{"_account_id":1001415,"name":"Jonathan McDowell","email":"noodles-openocd@earth.li","username":"u1f35c"},"real_author":{"_account_id":1001415,"name":"Jonathan McDowell","email":"noodles-openocd@earth.li","username":"u1f35c"},"date":"2020-04-17 14:35:01.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"79a07362a7ab5eebbf50551203fd0d842029fb00","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2020-04-24 16:44:13.000000000","message":"Change has been successfully cherry-picked as c60252ac2b636c4d99b766a574b9df0966151696 by Antonio Borneo","accounts_in_message":[],"_revision_number":2}],"current_revision":"c60252ac2b636c4d99b766a574b9df0966151696","revisions":{"c60252ac2b636c4d99b766a574b9df0966151696":{"kind":"REWORK","_number":2,"created":"2020-04-24 16:44:13.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/92/5592/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/92/5592/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/92/5592/2 \u0026\u0026 git checkout -b change-5592 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/92/5592/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/92/5592/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/92/5592/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/92/5592/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/92/5592/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bed0215573269cd9f85d23eaa15a27ce13a53e87","subject":"flash/nor/stm32l4x: cast wrpxxr_mask to uint16_to to print"}],"author":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2020-04-17 11:49:28.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2020-04-24 16:44:13.000000000","tz":60},"subject":"bitbang: Fix FTBFS with GCC 10","message":"bitbang: Fix FTBFS with GCC 10\n\nGCC 10 defaults to -fno-common which breaks the sharing of bitbang_swd\nstruct between bitbang drivers due to a missing extern.\n\nChange-Id: I2b4122f7939cec91a72284006748f99a23548324\nSigned-off-by: Andreas Fritiofson \u003candreas.fritiofson@gmail.com\u003e\nReviewed-on: http://openocd.zylin.com/5592\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-by: Jonathan McDowell \u003cnoodles-openocd@earth.li\u003e\n"}},"612d35e3e87a2a4028ffd625093a391895bef880":{"kind":"REWORK","_number":1,"created":"2020-04-17 12:18:50.000000000","uploader":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"ref":"refs/changes/92/5592/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/92/5592/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/92/5592/1 \u0026\u0026 git checkout -b change-5592 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/92/5592/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/92/5592/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/92/5592/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/92/5592/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/92/5592/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a1c51caafbac67df36dbecb27dd4b195730354b9","subject":"Revert \"rtos/FreeRTOS: Fix FreeRTOS thread list reading\""}],"author":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2020-04-17 11:49:28.000000000","tz":120},"committer":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2020-04-17 12:18:43.000000000","tz":120},"subject":"bitbang: Fix FTBFS with GCC 10","message":"bitbang: Fix FTBFS with GCC 10\n\nGCC 10 defaults to -fno-common which breaks the sharing of bitbang_swd\nstruct between bitbang drivers due to a missing extern.\n\nChange-Id: I2b4122f7939cec91a72284006748f99a23548324\nSigned-off-by: Andreas Fritiofson \u003candreas.fritiofson@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}