)]}'
{"id":"openocd~master~I0aa52a08d43a00cbd396efdeadd504fc31c98510","project":"openocd","branch":"master","hashtags":[],"change_id":"I0aa52a08d43a00cbd396efdeadd504fc31c98510","subject":"target/icepick.cfg: Add support for Test TAPs in ICEPick C","status":"MERGED","created":"2020-06-03 20:00:21.000000000","updated":"2020-06-14 13:25:07.000000000","submitted":"2020-06-14 13:25:07.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"5715-1592141107485-0524beb1","meta_rev_id":"81dccc19a961767e0431cefd6cb3987bb2dab687","_number":5715,"owner":{"_account_id":1001391,"name":"Edward Fewell","email":"edwardfewell@hotmail.com","username":"EdwardFewell"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"date":"2020-06-14 13:25:07.000000000","_account_id":1001391,"name":"Edward Fewell","email":"edwardfewell@hotmail.com","username":"EdwardFewell"},{"value":1,"date":"2020-06-14 13:25:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"value":2,"date":"2020-06-14 13:25:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1001391,"name":"Edward Fewell","email":"edwardfewell@hotmail.com","username":"EdwardFewell"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001391,"name":"Edward Fewell","email":"edwardfewell@hotmail.com","username":"EdwardFewell"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-06-03 20:34:58.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-06-14 13:25:07.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"8e4e1e8f82e16edfecaa1ae88e6f52194cbf2f22","author":{"_account_id":1001391,"name":"Edward Fewell","email":"edwardfewell@hotmail.com","username":"EdwardFewell"},"real_author":{"_account_id":1001391,"name":"Edward Fewell","email":"edwardfewell@hotmail.com","username":"EdwardFewell"},"date":"2020-06-03 20:00:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f835976b88f22816e4268cf19ce7b1e63ad3c473","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2020-06-03 20:34:58.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/13131/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/12412/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"3f386392f7739ef0cbd763f5f93dba5375352818","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2020-06-03 22:38:18.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"1c3261fbf543774cf5a40f371e5037b09faec0f6","author":{"_account_id":1001391,"name":"Edward Fewell","email":"edwardfewell@hotmail.com","username":"EdwardFewell"},"real_author":{"_account_id":1001391,"name":"Edward Fewell","email":"edwardfewell@hotmail.com","username":"EdwardFewell"},"date":"2020-06-04 00:16:20.000000000","message":"Patch Set 1:\n\nAn artifact of adding, then removing some logging. I didn\u0027t notice it until after the patch had been submitted.","accounts_in_message":[],"_revision_number":1},{"id":"21084c27cf9bfc41579a294a1bcd90245f337a2f","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2020-06-14 13:25:03.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"81dccc19a961767e0431cefd6cb3987bb2dab687","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2020-06-14 13:25:07.000000000","message":"Change has been successfully cherry-picked as 11116ef6ad875055a43cf9af1f228991349f2ba1 by Antonio Borneo","accounts_in_message":[],"_revision_number":2}],"current_revision":"11116ef6ad875055a43cf9af1f228991349f2ba1","revisions":{"f2156e2db69cc68c606b412b399083b767b15533":{"kind":"REWORK","_number":1,"created":"2020-06-03 20:00:21.000000000","uploader":{"_account_id":1001391,"name":"Edward Fewell","email":"edwardfewell@hotmail.com","username":"EdwardFewell"},"ref":"refs/changes/15/5715/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/15/5715/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/15/5715/1 \u0026\u0026 git checkout -b change-5715 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/15/5715/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/15/5715/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/15/5715/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/15/5715/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/15/5715/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d8ac0086f957fabf63d596a3b8d396b110bc696d","subject":"helper/command: remove unused functions and make static local ones"}],"author":{"name":"Edward Fewell","email":"efewell@ti.com","date":"2020-06-03 19:55:07.000000000","tz":-300},"committer":{"name":"Edward Fewell","email":"efewell@ti.com","date":"2020-06-03 19:55:07.000000000","tz":-300},"subject":"target/icepick.cfg: Add support for Test TAPs in ICEPick C","message":"target/icepick.cfg: Add support for Test TAPs in ICEPick C\n\nIn addition to the debug TAPs, the ICEPick C also supports\na bank of Test TAPs (limited functionality intended for\nnon-debuggable targets). Added support for Test TAPs to\nthe icepick_c_tapenable routine. Port numbers of 0 to 15\nwill continue to be handled as a debug TAP number. Test\nTAPs will be port numbers of 16 to 31.\n\nThis functionality will be needed for doing a flash\nmass erase on CC26xx/CC13xx targets. It is possible\nfor user application to block even adding the Cortex M\nTAP to the scan chain, so the only way to unbrick the\ntarget and erase the flash is using a component on a\ntest TAP of the device\u0027s ICEPick router.\n\nChange-Id: I0aa52a08d43a00cbd396efdeadd504fc31c98510\nSigned-off-by: Edward Fewell \u003cefewell@ti.com\u003e\n"}},"11116ef6ad875055a43cf9af1f228991349f2ba1":{"kind":"REWORK","_number":2,"created":"2020-06-14 13:25:07.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/15/5715/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/15/5715/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/15/5715/2 \u0026\u0026 git checkout -b change-5715 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/15/5715/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/15/5715/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/15/5715/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/15/5715/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/15/5715/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b7d41ef96aaf371e71cb58f5fa7104f4a201ea27","subject":"flash/nor/stm32l4x: Fix check for number of arguments"}],"author":{"name":"Edward Fewell","email":"efewell@ti.com","date":"2020-06-03 19:55:07.000000000","tz":-300},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2020-06-14 13:25:07.000000000","tz":60},"subject":"target/icepick.cfg: Add support for Test TAPs in ICEPick C","message":"target/icepick.cfg: Add support for Test TAPs in ICEPick C\n\nIn addition to the debug TAPs, the ICEPick C also supports\na bank of Test TAPs (limited functionality intended for\nnon-debuggable targets). Added support for Test TAPs to\nthe icepick_c_tapenable routine. Port numbers of 0 to 15\nwill continue to be handled as a debug TAP number. Test\nTAPs will be port numbers of 16 to 31.\n\nThis functionality will be needed for doing a flash\nmass erase on CC26xx/CC13xx targets. It is possible\nfor user application to block even adding the Cortex M\nTAP to the scan chain, so the only way to unbrick the\ntarget and erase the flash is using a component on a\ntest TAP of the device\u0027s ICEPick router.\n\nChange-Id: I0aa52a08d43a00cbd396efdeadd504fc31c98510\nSigned-off-by: Edward Fewell \u003cefewell@ti.com\u003e\nReviewed-on: http://openocd.zylin.com/5715\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}