)]}'
{"id":"openocd~master~I52599b2b09c2dc50c95d64059213c832d380ea31","project":"openocd","branch":"master","hashtags":[],"change_id":"I52599b2b09c2dc50c95d64059213c832d380ea31","subject":"cortex_m: add detection of Cortex M35P and M55","status":"MERGED","created":"2020-08-11 14:23:32.000000000","updated":"2020-09-20 13:35:48.000000000","submitted":"2020-09-20 13:35:48.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"5799-1600608948936-d636e020","meta_rev_id":"999b629ef7e8b596a475e78ba1f4e9ed558a12fb","_number":5799,"owner":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":1,"date":"2020-09-20 13:35:48.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"value":2,"date":"2020-09-20 13:35:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":1,"date":"2020-09-20 13:35:48.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-08-11 14:55:04.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-09-20 13:35:48.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"790855954557acb4c14f52d29352d8d82a23b428","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2020-08-11 14:23:32.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9b181e46e59d058800a6e129659c757aaa6d861a","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2020-08-11 14:55:04.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/13302/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/12577/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"06e4ecf68b6e90c3c7f0ea15fe4608bdc36021f5","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2020-08-12 10:41:33.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)\n\nDo you have a reference doc for the M35P CPUID?","accounts_in_message":[],"_revision_number":1},{"id":"c5b71fc62dd22fae06b1468b61d7a867bfe47607","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2020-08-12 11:07:27.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1: Code-Review+1\n \u003e \n \u003e (1 comment)\n \u003e \n \u003e Do you have a reference doc for the M35P CPUID?\n\nonly internal documents, but you can rely on pyocd source code, the value is present there \nhttps://github.com/mbedmicro/pyOCD/blob/master/pyocd/coresight/core_ids.py\n\nbtw, the values in openocd should be shifted by 4 bits (in another change)","accounts_in_message":[],"_revision_number":1},{"id":"ccb4b1db7641f24f79a8b03fa3e4c2137f5934df","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2020-09-06 00:45:48.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"a17c43b60e9c9dd95889fc945afbbcbdefd24805","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2020-09-06 06:19:51.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"5971e9bed6414563e80e08d6d61bbf01018360f8","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2020-09-06 06:26:04.000000000","message":"Patch Set 1:\n\nI think the series 5797, 5798 and 5799 can be merged.\nAll the conflicting patches are with -1 and no need to include the new asm instructions.\nDo you agree?","accounts_in_message":[],"_revision_number":1},{"id":"50e1120f19f3c416d8c4dffe33cb35f64b106e42","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2020-09-06 20:10:45.000000000","message":"Patch Set 1:\n\nthanks Antonio, i strongly agree, let\u0027s wait for capstone 😀","accounts_in_message":[],"_revision_number":1},{"id":"999b629ef7e8b596a475e78ba1f4e9ed558a12fb","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2020-09-20 13:35:48.000000000","message":"Change has been successfully cherry-picked as 762ddcb74948852b0dfb25fcbca0965b09249a2f by Antonio Borneo","accounts_in_message":[],"_revision_number":2}],"current_revision":"762ddcb74948852b0dfb25fcbca0965b09249a2f","revisions":{"09687b8c5327c1efd40925b095c3c9baffe38dbb":{"kind":"REWORK","_number":1,"created":"2020-08-11 14:23:32.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/99/5799/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/99/5799/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/99/5799/1 \u0026\u0026 git checkout -b change-5799 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/99/5799/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/99/5799/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/99/5799/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/99/5799/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/99/5799/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"02f7ef58fe2934cd7317886dab01e0bf6a423206","subject":"cortex_m: read and display core security state"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2020-08-11 14:23:19.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2020-08-11 14:23:19.000000000","tz":60},"subject":"cortex_m: add detection of Cortex M35P and M55","message":"cortex_m: add detection of Cortex M35P and M55\n\nChange-Id: I52599b2b09c2dc50c95d64059213c832d380ea31\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}},"762ddcb74948852b0dfb25fcbca0965b09249a2f":{"kind":"REWORK","_number":2,"created":"2020-09-20 13:35:48.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/99/5799/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/99/5799/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/99/5799/2 \u0026\u0026 git checkout -b change-5799 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/99/5799/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/99/5799/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/99/5799/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/99/5799/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/99/5799/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f2c83fade3ea7e51e5c9283aa3ff94632a41cc55","subject":"cortex_m: read and display core security state"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2020-08-11 14:23:19.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2020-09-20 13:35:48.000000000","tz":60},"subject":"cortex_m: add detection of Cortex M35P and M55","message":"cortex_m: add detection of Cortex M35P and M55\n\nChange-Id: I52599b2b09c2dc50c95d64059213c832d380ea31\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\nReviewed-on: http://openocd.zylin.com/5799\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}