)]}'
{"jimtcl":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"88e2addd97f69280ca723f44a66d50458a4696f6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Subproject commit 0aa0fb4e3a38d38a49de9eb585d93d63a370dcf6"}],"source_content_type":"x-git/gitlink","patch_set":17,"id":"aedf27f1_0927fd0e","line":1,"updated":"2021-05-19 10:31:44.000000000","message":"bad rebase! You reverted to old jimtcl","commit_id":"741d603ee1200d8b696ec91fe2ebf9d3adfb3092"}],"src/jtag/drivers/cmsis_dap.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9268c636aaa8b16f2f43436ae94bc435cf246797","unresolved":false,"context_lines":[{"line_number":198,"context_line":"#define DAP_SWO_STATUS_STREAM_ERROR_MASK     BIT(6)"},{"line_number":199,"context_line":"#define DAP_SWO_STATUS_BUFFER_OVERRUN_MASK   BIT(7)"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"#define DAP_SWO_MIN_BAUDRATE 300"},{"line_number":202,"context_line":"#define DAP_SWO_MAX_BAUDRATE 921600"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"/* CMSIS-DAP Vendor Commands"},{"line_number":205,"context_line":" * None as yet... */"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"ceda9b01_2af753f4","line":202,"range":{"start_line":201,"start_character":0,"end_line":202,"end_character":35},"updated":"2020-12-06 16:27:06.000000000","message":"Where did you got these info? ARM does not specify any limit in\nhttps://arm-software.github.io/CMSIS_5/DAP/html/group__DAP__SWO__Baudrate.html","commit_id":"fda26593ed0939977774257010e9721188b7c39f"},{"author":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"change_message_id":"d8f35d8b3057e45a45fe8910eeafc92d3080d38d","unresolved":false,"context_lines":[{"line_number":198,"context_line":"#define DAP_SWO_STATUS_STREAM_ERROR_MASK     BIT(6)"},{"line_number":199,"context_line":"#define DAP_SWO_STATUS_BUFFER_OVERRUN_MASK   BIT(7)"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"#define DAP_SWO_MIN_BAUDRATE 300"},{"line_number":202,"context_line":"#define DAP_SWO_MAX_BAUDRATE 921600"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"/* CMSIS-DAP Vendor Commands"},{"line_number":205,"context_line":" * None as yet... */"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"ceda9b01_6ad9db2b","line":202,"range":{"start_line":201,"start_character":0,"end_line":202,"end_character":35},"in_reply_to":"ceda9b01_2af753f4","updated":"2020-12-07 17:46:11.000000000","message":"Done","commit_id":"fda26593ed0939977774257010e9721188b7c39f"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9268c636aaa8b16f2f43436ae94bc435cf246797","unresolved":false,"context_lines":[{"line_number":212,"context_line":"};"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"/* max clock speed */"},{"line_number":215,"context_line":"#define DAP_MAX_CLOCK_KHZ         50000"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"struct pending_transfer_result {"},{"line_number":218,"context_line":"\tuint8_t cmd;"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"ceda9b01_8af2ff01","line":215,"range":{"start_line":215,"start_character":0,"end_line":215,"end_character":39},"updated":"2020-12-06 16:27:06.000000000","message":"Should not be part of this patch! At lease, please mention it in the commit message.","commit_id":"fda26593ed0939977774257010e9721188b7c39f"},{"author":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"change_message_id":"d8f35d8b3057e45a45fe8910eeafc92d3080d38d","unresolved":false,"context_lines":[{"line_number":212,"context_line":"};"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"/* max clock speed */"},{"line_number":215,"context_line":"#define DAP_MAX_CLOCK_KHZ         50000"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"struct pending_transfer_result {"},{"line_number":218,"context_line":"\tuint8_t cmd;"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"ceda9b01_8ade7f13","line":215,"range":{"start_line":215,"start_character":0,"end_line":215,"end_character":39},"in_reply_to":"ceda9b01_8af2ff01","updated":"2020-12-07 17:46:11.000000000","message":"Done","commit_id":"fda26593ed0939977774257010e9721188b7c39f"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9268c636aaa8b16f2f43436ae94bc435cf246797","unresolved":false,"context_lines":[{"line_number":363,"context_line":"\treturn ERROR_OK;"},{"line_number":364,"context_line":"}"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"static int cmsis_dap_cmd_DAP_SWJ_Pins(uint8_t pins, uint8_t mask, uint32_t delay, uint8_t *input)"},{"line_number":367,"context_line":"{"},{"line_number":368,"context_line":"\tuint8_t *buffer \u003d cmsis_dap_handle-\u003epacket_buffer;"},{"line_number":369,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":10,"id":"ceda9b01_eac70b99","line":366,"range":{"start_line":366,"start_character":11,"end_line":366,"end_character":37},"updated":"2020-12-06 16:27:06.000000000","message":"This is still CamelCase.\nSince you have run this cleanup in the same patch, please add it in the commit message too!","commit_id":"fda26593ed0939977774257010e9721188b7c39f"},{"author":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"change_message_id":"d8f35d8b3057e45a45fe8910eeafc92d3080d38d","unresolved":false,"context_lines":[{"line_number":363,"context_line":"\treturn ERROR_OK;"},{"line_number":364,"context_line":"}"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"static int cmsis_dap_cmd_DAP_SWJ_Pins(uint8_t pins, uint8_t mask, uint32_t delay, uint8_t *input)"},{"line_number":367,"context_line":"{"},{"line_number":368,"context_line":"\tuint8_t *buffer \u003d cmsis_dap_handle-\u003epacket_buffer;"},{"line_number":369,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":10,"id":"ceda9b01_4ae897af","line":366,"range":{"start_line":366,"start_character":11,"end_line":366,"end_character":37},"in_reply_to":"ceda9b01_eac70b99","updated":"2020-12-07 17:46:11.000000000","message":"Done","commit_id":"fda26593ed0939977774257010e9721188b7c39f"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9268c636aaa8b16f2f43436ae94bc435cf246797","unresolved":false,"context_lines":[{"line_number":1821,"context_line":"\t\t\t\tunsigned int traceclkin_hz,"},{"line_number":1822,"context_line":"\t\t\t\tuint16_t *swo_prescaler)"},{"line_number":1823,"context_line":"{"},{"line_number":1824,"context_line":"\tif (!trace_enabled) {"},{"line_number":1825,"context_line":"\t\tcmsis_dap_handle-\u003etrace_enabled \u003d false;"},{"line_number":1826,"context_line":"\t\tLOG_INFO(\"SWO tracing disabled.\");"},{"line_number":1827,"context_line":"\t\treturn ERROR_OK;"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"ceda9b01_eae06b27","line":1824,"range":{"start_line":1824,"start_character":0,"end_line":1824,"end_character":22},"updated":"2020-12-06 16:27:06.000000000","message":"I think you need to call\n cmsis_dap_cmd_dap_swo_control(..., DAP_SWO_CONTROL_STOP);\nin this case, to really disable the data gathering.","commit_id":"fda26593ed0939977774257010e9721188b7c39f"},{"author":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"change_message_id":"d8f35d8b3057e45a45fe8910eeafc92d3080d38d","unresolved":false,"context_lines":[{"line_number":1821,"context_line":"\t\t\t\tunsigned int traceclkin_hz,"},{"line_number":1822,"context_line":"\t\t\t\tuint16_t *swo_prescaler)"},{"line_number":1823,"context_line":"{"},{"line_number":1824,"context_line":"\tif (!trace_enabled) {"},{"line_number":1825,"context_line":"\t\tcmsis_dap_handle-\u003etrace_enabled \u003d false;"},{"line_number":1826,"context_line":"\t\tLOG_INFO(\"SWO tracing disabled.\");"},{"line_number":1827,"context_line":"\t\treturn ERROR_OK;"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"ceda9b01_0aca8f4a","line":1824,"range":{"start_line":1824,"start_character":0,"end_line":1824,"end_character":22},"in_reply_to":"ceda9b01_eae06b27","updated":"2020-12-07 17:46:11.000000000","message":"Done","commit_id":"fda26593ed0939977774257010e9721188b7c39f"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9268c636aaa8b16f2f43436ae94bc435cf246797","unresolved":false,"context_lines":[{"line_number":1829,"context_line":""},{"line_number":1830,"context_line":"\tcmsis_dap_handle-\u003etrace_enabled \u003d false;"},{"line_number":1831,"context_line":""},{"line_number":1832,"context_line":"\tif (!(cmsis_dap_handle-\u003ecaps \u0026 INFO_CAPS_SWO_UART)) {"},{"line_number":1833,"context_line":"\t\tLOG_ERROR(\"Trace capturing is not supported by the device.\");"},{"line_number":1834,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":1835,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"ceda9b01_0ade0f71","line":1832,"range":{"start_line":1832,"start_character":0,"end_line":1832,"end_character":54},"updated":"2020-12-06 16:27:06.000000000","message":"Could be possible to have an adapter that only supports INFO_CAPS_SWO_MANCHESTER?","commit_id":"fda26593ed0939977774257010e9721188b7c39f"},{"author":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"change_message_id":"d8f35d8b3057e45a45fe8910eeafc92d3080d38d","unresolved":false,"context_lines":[{"line_number":1829,"context_line":""},{"line_number":1830,"context_line":"\tcmsis_dap_handle-\u003etrace_enabled \u003d false;"},{"line_number":1831,"context_line":""},{"line_number":1832,"context_line":"\tif (!(cmsis_dap_handle-\u003ecaps \u0026 INFO_CAPS_SWO_UART)) {"},{"line_number":1833,"context_line":"\t\tLOG_ERROR(\"Trace capturing is not supported by the device.\");"},{"line_number":1834,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":1835,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"ceda9b01_aad6e3f4","line":1832,"range":{"start_line":1832,"start_character":0,"end_line":1832,"end_character":54},"in_reply_to":"ceda9b01_0ade0f71","updated":"2020-12-07 17:46:11.000000000","message":"Done","commit_id":"fda26593ed0939977774257010e9721188b7c39f"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9268c636aaa8b16f2f43436ae94bc435cf246797","unresolved":false,"context_lines":[{"line_number":1835,"context_line":"\t}"},{"line_number":1836,"context_line":""},{"line_number":1837,"context_line":"\tuint8_t swo_mode;"},{"line_number":1838,"context_line":"\tswitch (pin_protocol) {"},{"line_number":1839,"context_line":"\t\tcase TPIU_PIN_PROTOCOL_ASYNC_UART:"},{"line_number":1840,"context_line":"\t\t\tswo_mode \u003d DAP_SWO_MODE_UART;"},{"line_number":1841,"context_line":"\t\t\tbreak;"},{"line_number":1842,"context_line":"\t\tcase TPIU_PIN_PROTOCOL_ASYNC_MANCHESTER:"},{"line_number":1843,"context_line":"\t\t\tswo_mode \u003d DAP_SWO_MODE_MANCHESTER;"},{"line_number":1844,"context_line":"\t\t\tbreak;"},{"line_number":1845,"context_line":"\t\tdefault:"},{"line_number":1846,"context_line":"\t\t\tLOG_ERROR(\"Selected pin protocol is not supported.\");"},{"line_number":1847,"context_line":"\t\t\treturn ERROR_FAIL;"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"ceda9b01_aaea6303","line":1844,"range":{"start_line":1838,"start_character":0,"end_line":1844,"end_character":9},"updated":"2020-12-06 16:27:06.000000000","message":"This should also include the check on the CAPS.","commit_id":"fda26593ed0939977774257010e9721188b7c39f"},{"author":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"change_message_id":"d8f35d8b3057e45a45fe8910eeafc92d3080d38d","unresolved":false,"context_lines":[{"line_number":1835,"context_line":"\t}"},{"line_number":1836,"context_line":""},{"line_number":1837,"context_line":"\tuint8_t swo_mode;"},{"line_number":1838,"context_line":"\tswitch (pin_protocol) {"},{"line_number":1839,"context_line":"\t\tcase TPIU_PIN_PROTOCOL_ASYNC_UART:"},{"line_number":1840,"context_line":"\t\t\tswo_mode \u003d DAP_SWO_MODE_UART;"},{"line_number":1841,"context_line":"\t\t\tbreak;"},{"line_number":1842,"context_line":"\t\tcase TPIU_PIN_PROTOCOL_ASYNC_MANCHESTER:"},{"line_number":1843,"context_line":"\t\t\tswo_mode \u003d DAP_SWO_MODE_MANCHESTER;"},{"line_number":1844,"context_line":"\t\t\tbreak;"},{"line_number":1845,"context_line":"\t\tdefault:"},{"line_number":1846,"context_line":"\t\t\tLOG_ERROR(\"Selected pin protocol is not supported.\");"},{"line_number":1847,"context_line":"\t\t\treturn ERROR_FAIL;"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"ceda9b01_cad32704","line":1844,"range":{"start_line":1838,"start_character":0,"end_line":1844,"end_character":9},"in_reply_to":"ceda9b01_aaea6303","updated":"2020-12-07 17:46:11.000000000","message":"Done","commit_id":"fda26593ed0939977774257010e9721188b7c39f"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9268c636aaa8b16f2f43436ae94bc435cf246797","unresolved":false,"context_lines":[{"line_number":1914,"context_line":"\t\treturn ERROR_OK;"},{"line_number":1915,"context_line":"\t}"},{"line_number":1916,"context_line":""},{"line_number":1917,"context_line":"\tif (!(cmsis_dap_handle-\u003ecaps \u0026 INFO_CAPS_SWO_UART)) {"},{"line_number":1918,"context_line":"\t\tLOG_ERROR(\"SWO-UART capturing is not supported by the device.\");"},{"line_number":1919,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":1920,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"ceda9b01_6ad47b4c","line":1917,"range":{"start_line":1917,"start_character":0,"end_line":1917,"end_character":54},"updated":"2020-12-06 16:27:06.000000000","message":"What about MANCHESTER?\nI think that when cmsis_dap_handle-\u003etrace_enabled \u003d\u003d true, the checks on CAPS are already passed.","commit_id":"fda26593ed0939977774257010e9721188b7c39f"},{"author":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"change_message_id":"7928316b75252e67c0330b71e36faf45cae26eaf","unresolved":false,"context_lines":[{"line_number":1914,"context_line":"\t\treturn ERROR_OK;"},{"line_number":1915,"context_line":"\t}"},{"line_number":1916,"context_line":""},{"line_number":1917,"context_line":"\tif (!(cmsis_dap_handle-\u003ecaps \u0026 INFO_CAPS_SWO_UART)) {"},{"line_number":1918,"context_line":"\t\tLOG_ERROR(\"SWO-UART capturing is not supported by the device.\");"},{"line_number":1919,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":1920,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"ceda9b01_0a55af52","line":1917,"range":{"start_line":1917,"start_character":0,"end_line":1917,"end_character":54},"in_reply_to":"ceda9b01_6ad47b4c","updated":"2020-12-07 17:50:56.000000000","message":"Done","commit_id":"fda26593ed0939977774257010e9721188b7c39f"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9268c636aaa8b16f2f43436ae94bc435cf246797","unresolved":false,"context_lines":[{"line_number":1924,"context_line":"\t\treturn retval;"},{"line_number":1925,"context_line":"\tif ((trace_status \u0026 DAP_SWO_STATUS_CAPTURE_MASK) !\u003d DAP_SWO_STATUS_CAPTURE_ACTIVE)"},{"line_number":1926,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":1927,"context_line":""},{"line_number":1928,"context_line":"\t*size \u003d trace_count \u003c *size ? trace_count : *size - 1;"},{"line_number":1929,"context_line":"\tsize_t off \u003d 0;"},{"line_number":1930,"context_line":"\tdo {"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"ceda9b01_8ad99f85","line":1927,"updated":"2020-12-06 16:27:06.000000000","message":"check also DAP_SWO_STATUS_STREAM_ERROR_MASK and DAP_SWO_STATUS_BUFFER_OVERRUN_MASK.\nPrint a warning about the error but go ahead grabbing data.\nThe message about overrun could include a suggestion to reduce the SWO speed.","commit_id":"fda26593ed0939977774257010e9721188b7c39f"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f7ae39871034db0f93660abe8d2c7204a128c16d","unresolved":false,"context_lines":[{"line_number":563,"context_line":"#endif"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"/**"},{"line_number":566,"context_line":" * Sets the SWO transport mode."},{"line_number":567,"context_line":" * @param[in] transport     The transport mode. Can be None, SWO_Data or"},{"line_number":568,"context_line":" *                          WinUSB (requires CMSIS-DAP v2)."},{"line_number":569,"context_line":" */"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"ceda9b01_8dbd3666","line":566,"range":{"start_line":566,"start_character":0,"end_line":566,"end_character":31},"updated":"2021-01-31 15:35:42.000000000","message":"Doxygen complains for parameter \u0027dap\u0027 not listed here","commit_id":"9e4dad64b12251619c9787c4a92dc2e53bc54581"},{"author":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"change_message_id":"4d35f307c560af823d671b19b2992d109347eb69","unresolved":false,"context_lines":[{"line_number":563,"context_line":"#endif"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"/**"},{"line_number":566,"context_line":" * Sets the SWO transport mode."},{"line_number":567,"context_line":" * @param[in] transport     The transport mode. Can be None, SWO_Data or"},{"line_number":568,"context_line":" *                          WinUSB (requires CMSIS-DAP v2)."},{"line_number":569,"context_line":" */"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"ceda9b01_100cf93c","line":566,"range":{"start_line":566,"start_character":0,"end_line":566,"end_character":31},"in_reply_to":"ceda9b01_8dbd3666","updated":"2021-02-02 06:21:59.000000000","message":"Done","commit_id":"9e4dad64b12251619c9787c4a92dc2e53bc54581"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f7ae39871034db0f93660abe8d2c7204a128c16d","unresolved":false,"context_lines":[{"line_number":587,"context_line":"}"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"/**"},{"line_number":590,"context_line":" * Sets the SWO trace capture mode."},{"line_number":591,"context_line":" * @param[in] mode          Trace capture mode. Can be UART or MANCHESTER."},{"line_number":592,"context_line":" */"},{"line_number":593,"context_line":"static int cmsis_dap_cmd_dap_swo_mode(struct cmsis_dap *dap, uint8_t mode)"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"ceda9b01_2db20a93","line":590,"range":{"start_line":590,"start_character":0,"end_line":590,"end_character":35},"updated":"2021-01-31 15:35:42.000000000","message":"same here, \u0027dap\u0027 missing","commit_id":"9e4dad64b12251619c9787c4a92dc2e53bc54581"},{"author":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"change_message_id":"4d35f307c560af823d671b19b2992d109347eb69","unresolved":false,"context_lines":[{"line_number":587,"context_line":"}"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"/**"},{"line_number":590,"context_line":" * Sets the SWO trace capture mode."},{"line_number":591,"context_line":" * @param[in] mode          Trace capture mode. Can be UART or MANCHESTER."},{"line_number":592,"context_line":" */"},{"line_number":593,"context_line":"static int cmsis_dap_cmd_dap_swo_mode(struct cmsis_dap *dap, uint8_t mode)"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"ceda9b01_b0188d7b","line":590,"range":{"start_line":590,"start_character":0,"end_line":590,"end_character":35},"in_reply_to":"ceda9b01_2db20a93","updated":"2021-02-02 06:21:59.000000000","message":"Done","commit_id":"9e4dad64b12251619c9787c4a92dc2e53bc54581"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f7ae39871034db0f93660abe8d2c7204a128c16d","unresolved":false,"context_lines":[{"line_number":610,"context_line":"/**"},{"line_number":611,"context_line":" * Sets the baudrate for capturing SWO trace data."},{"line_number":612,"context_line":" * Can be called iteratively to determine supported baudrates."},{"line_number":613,"context_line":" * @param[in]  dev_baudrate Requested baudrate."},{"line_number":614,"context_line":" * @param[out] dev_baudrate Actual baudrate or 0 (baudrate not configured)."},{"line_number":615,"context_line":" *                          When requested baudrate is not achievable the"},{"line_number":616,"context_line":" *                          closest configured baudrate can be returned or"},{"line_number":617,"context_line":" *                          0 which indicates that baudrate was not configured."}],"source_content_type":"text/x-csrc","patch_set":15,"id":"ceda9b01_4db74e82","line":614,"range":{"start_line":613,"start_character":0,"end_line":614,"end_character":75},"updated":"2021-01-31 15:35:42.000000000","message":"here missing \u0027dap\u0027 and \u0027in_baudrate\u0027, while \u0027dev_boudrate\u0027 is replicated","commit_id":"9e4dad64b12251619c9787c4a92dc2e53bc54581"},{"author":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"change_message_id":"4d35f307c560af823d671b19b2992d109347eb69","unresolved":false,"context_lines":[{"line_number":610,"context_line":"/**"},{"line_number":611,"context_line":" * Sets the baudrate for capturing SWO trace data."},{"line_number":612,"context_line":" * Can be called iteratively to determine supported baudrates."},{"line_number":613,"context_line":" * @param[in]  dev_baudrate Requested baudrate."},{"line_number":614,"context_line":" * @param[out] dev_baudrate Actual baudrate or 0 (baudrate not configured)."},{"line_number":615,"context_line":" *                          When requested baudrate is not achievable the"},{"line_number":616,"context_line":" *                          closest configured baudrate can be returned or"},{"line_number":617,"context_line":" *                          0 which indicates that baudrate was not configured."}],"source_content_type":"text/x-csrc","patch_set":15,"id":"ceda9b01_d0151142","line":614,"range":{"start_line":613,"start_character":0,"end_line":614,"end_character":75},"in_reply_to":"ceda9b01_4db74e82","updated":"2021-02-02 06:21:59.000000000","message":"Done","commit_id":"9e4dad64b12251619c9787c4a92dc2e53bc54581"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f7ae39871034db0f93660abe8d2c7204a128c16d","unresolved":false,"context_lines":[{"line_number":646,"context_line":"}"},{"line_number":647,"context_line":""},{"line_number":648,"context_line":"/**"},{"line_number":649,"context_line":" * Controls the SWO trace data capture."},{"line_number":650,"context_line":" * @param[in] control       Start or stop a trace. Starting capture automatically"},{"line_number":651,"context_line":" *                          flushes any existing trace data in buffers which has"},{"line_number":652,"context_line":" *                          not yet been read."}],"source_content_type":"text/x-csrc","patch_set":15,"id":"ceda9b01_edaba219","line":649,"range":{"start_line":649,"start_character":0,"end_line":649,"end_character":39},"updated":"2021-01-31 15:35:42.000000000","message":"\u0027dap\u0027 missing","commit_id":"9e4dad64b12251619c9787c4a92dc2e53bc54581"},{"author":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"change_message_id":"4d35f307c560af823d671b19b2992d109347eb69","unresolved":false,"context_lines":[{"line_number":646,"context_line":"}"},{"line_number":647,"context_line":""},{"line_number":648,"context_line":"/**"},{"line_number":649,"context_line":" * Controls the SWO trace data capture."},{"line_number":650,"context_line":" * @param[in] control       Start or stop a trace. Starting capture automatically"},{"line_number":651,"context_line":" *                          flushes any existing trace data in buffers which has"},{"line_number":652,"context_line":" *                          not yet been read."}],"source_content_type":"text/x-csrc","patch_set":15,"id":"ceda9b01_702225a4","line":649,"range":{"start_line":649,"start_character":0,"end_line":649,"end_character":39},"in_reply_to":"ceda9b01_edaba219","updated":"2021-02-02 06:21:59.000000000","message":"Done","commit_id":"9e4dad64b12251619c9787c4a92dc2e53bc54581"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f7ae39871034db0f93660abe8d2c7204a128c16d","unresolved":false,"context_lines":[{"line_number":671,"context_line":"}"},{"line_number":672,"context_line":""},{"line_number":673,"context_line":"/**"},{"line_number":674,"context_line":" * Reads the SWO trace status."},{"line_number":675,"context_line":" * @param[out] trace_status The trace\u0027s status."},{"line_number":676,"context_line":" *                          Bit0: Trace Capture (1 - active, 0 - inactive)."},{"line_number":677,"context_line":" *                          Bit6: Trace Stream Error."}],"source_content_type":"text/x-csrc","patch_set":15,"id":"ceda9b01_0da94621","line":674,"range":{"start_line":674,"start_character":0,"end_line":674,"end_character":30},"updated":"2021-01-31 15:35:42.000000000","message":"\u0027dap\u0027 missing","commit_id":"9e4dad64b12251619c9787c4a92dc2e53bc54581"},{"author":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"change_message_id":"4d35f307c560af823d671b19b2992d109347eb69","unresolved":false,"context_lines":[{"line_number":671,"context_line":"}"},{"line_number":672,"context_line":""},{"line_number":673,"context_line":"/**"},{"line_number":674,"context_line":" * Reads the SWO trace status."},{"line_number":675,"context_line":" * @param[out] trace_status The trace\u0027s status."},{"line_number":676,"context_line":" *                          Bit0: Trace Capture (1 - active, 0 - inactive)."},{"line_number":677,"context_line":" *                          Bit6: Trace Stream Error."}],"source_content_type":"text/x-csrc","patch_set":15,"id":"ceda9b01_902789b1","line":674,"range":{"start_line":674,"start_character":0,"end_line":674,"end_character":30},"in_reply_to":"ceda9b01_0da94621","updated":"2021-02-02 06:21:59.000000000","message":"Done","commit_id":"9e4dad64b12251619c9787c4a92dc2e53bc54581"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f7ae39871034db0f93660abe8d2c7204a128c16d","unresolved":false,"context_lines":[{"line_number":703,"context_line":"}"},{"line_number":704,"context_line":""},{"line_number":705,"context_line":"/**"},{"line_number":706,"context_line":" * Reads the captured SWO trace data from Trace Buffer."},{"line_number":707,"context_line":" * @param[in]  max_trace_count Maximum number of Trace Data bytes to read."},{"line_number":708,"context_line":" * @param[out] trace_status The trace\u0027s status."},{"line_number":709,"context_line":" * @param[out] trace_count  Number of Trace Data bytes read."}],"source_content_type":"text/x-csrc","patch_set":15,"id":"ceda9b01_ada59a45","line":706,"range":{"start_line":706,"start_character":0,"end_line":706,"end_character":55},"updated":"2021-01-31 15:35:42.000000000","message":"\u0027dap\u0027 missing","commit_id":"9e4dad64b12251619c9787c4a92dc2e53bc54581"},{"author":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"change_message_id":"4d35f307c560af823d671b19b2992d109347eb69","unresolved":false,"context_lines":[{"line_number":703,"context_line":"}"},{"line_number":704,"context_line":""},{"line_number":705,"context_line":"/**"},{"line_number":706,"context_line":" * Reads the captured SWO trace data from Trace Buffer."},{"line_number":707,"context_line":" * @param[in]  max_trace_count Maximum number of Trace Data bytes to read."},{"line_number":708,"context_line":" * @param[out] trace_status The trace\u0027s status."},{"line_number":709,"context_line":" * @param[out] trace_count  Number of Trace Data bytes read."}],"source_content_type":"text/x-csrc","patch_set":15,"id":"ceda9b01_301c9d6a","line":706,"range":{"start_line":706,"start_character":0,"end_line":706,"end_character":55},"in_reply_to":"ceda9b01_ada59a45","updated":"2021-02-02 06:21:59.000000000","message":"Done","commit_id":"9e4dad64b12251619c9787c4a92dc2e53bc54581"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f7ae39871034db0f93660abe8d2c7204a128c16d","unresolved":false,"context_lines":[{"line_number":1822,"context_line":"\t\treturn ERROR_OK;"},{"line_number":1823,"context_line":"\t}"},{"line_number":1824,"context_line":""},{"line_number":1825,"context_line":"\tcmsis_dap_handle-\u003etrace_enabled \u003d false;"},{"line_number":1826,"context_line":""},{"line_number":1827,"context_line":"\tif (!(cmsis_dap_handle-\u003ecaps \u0026 INFO_CAPS_SWO_UART) \u0026\u0026"},{"line_number":1828,"context_line":"\t    !(cmsis_dap_handle-\u003ecaps \u0026 INFO_CAPS_SWO_MANCHESTER)) {"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"ceda9b01_4da0ae3e","line":1825,"range":{"start_line":1825,"start_character":0,"end_line":1825,"end_character":41},"updated":"2021-01-31 15:35:42.000000000","message":"move this line \u0027after\u0027 DAP_SWO_CONTROL_STOP, at line 1853","commit_id":"9e4dad64b12251619c9787c4a92dc2e53bc54581"},{"author":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"change_message_id":"4d35f307c560af823d671b19b2992d109347eb69","unresolved":false,"context_lines":[{"line_number":1822,"context_line":"\t\treturn ERROR_OK;"},{"line_number":1823,"context_line":"\t}"},{"line_number":1824,"context_line":""},{"line_number":1825,"context_line":"\tcmsis_dap_handle-\u003etrace_enabled \u003d false;"},{"line_number":1826,"context_line":""},{"line_number":1827,"context_line":"\tif (!(cmsis_dap_handle-\u003ecaps \u0026 INFO_CAPS_SWO_UART) \u0026\u0026"},{"line_number":1828,"context_line":"\t    !(cmsis_dap_handle-\u003ecaps \u0026 INFO_CAPS_SWO_MANCHESTER)) {"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"ceda9b01_500a8125","line":1825,"range":{"start_line":1825,"start_character":0,"end_line":1825,"end_character":41},"in_reply_to":"ceda9b01_4da0ae3e","updated":"2021-02-02 06:21:59.000000000","message":"Done","commit_id":"9e4dad64b12251619c9787c4a92dc2e53bc54581"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f7ae39871034db0f93660abe8d2c7204a128c16d","unresolved":false,"context_lines":[{"line_number":1867,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":1868,"context_line":"\t\treturn retval;"},{"line_number":1869,"context_line":""},{"line_number":1870,"context_line":"\tif (!calculate_swo_prescaler(traceclkin_hz, *swo_freq,"},{"line_number":1871,"context_line":"\t\t\tswo_prescaler)) {"},{"line_number":1872,"context_line":"\t\tLOG_ERROR(\"SWO frequency is not suitable. Please choose a \""},{"line_number":1873,"context_line":"\t\t\t\"different frequency or use auto-detection.\");"},{"line_number":1874,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":1875,"context_line":"\t}"},{"line_number":1876,"context_line":""},{"line_number":1877,"context_line":"\tLOG_INFO(\"SWO frequency: %u Hz.\", *swo_freq);"},{"line_number":1878,"context_line":"\tLOG_INFO(\"SWO prescaler: %u.\", *swo_prescaler);"},{"line_number":1879,"context_line":""},{"line_number":1880,"context_line":"\tretval \u003d cmsis_dap_cmd_dap_swo_control(cmsis_dap_handle, DAP_SWO_CONTROL_START);"},{"line_number":1881,"context_line":"\tif (retval !\u003d ERROR_OK)"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"ceda9b01_ed8402b8","line":1878,"range":{"start_line":1870,"start_character":0,"end_line":1878,"end_character":48},"updated":"2021-01-31 15:35:42.000000000","message":"this is only input values check. Move them before the first command, at line 1849","commit_id":"9e4dad64b12251619c9787c4a92dc2e53bc54581"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0c3cfe3d4c2cffb3be87f71855c3404c05562b17","unresolved":false,"context_lines":[{"line_number":1867,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":1868,"context_line":"\t\treturn retval;"},{"line_number":1869,"context_line":""},{"line_number":1870,"context_line":"\tif (!calculate_swo_prescaler(traceclkin_hz, *swo_freq,"},{"line_number":1871,"context_line":"\t\t\tswo_prescaler)) {"},{"line_number":1872,"context_line":"\t\tLOG_ERROR(\"SWO frequency is not suitable. Please choose a \""},{"line_number":1873,"context_line":"\t\t\t\"different frequency or use auto-detection.\");"},{"line_number":1874,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":1875,"context_line":"\t}"},{"line_number":1876,"context_line":""},{"line_number":1877,"context_line":"\tLOG_INFO(\"SWO frequency: %u Hz.\", *swo_freq);"},{"line_number":1878,"context_line":"\tLOG_INFO(\"SWO prescaler: %u.\", *swo_prescaler);"},{"line_number":1879,"context_line":""},{"line_number":1880,"context_line":"\tretval \u003d cmsis_dap_cmd_dap_swo_control(cmsis_dap_handle, DAP_SWO_CONTROL_START);"},{"line_number":1881,"context_line":"\tif (retval !\u003d ERROR_OK)"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"ceda9b01_90dc694d","line":1878,"range":{"start_line":1870,"start_character":0,"end_line":1878,"end_character":48},"in_reply_to":"ceda9b01_50212199","updated":"2021-02-04 23:42:35.000000000","message":"Yes, you are right!\nThis seems a limitation of CMSIS-DAP.\nPersonally I would like to first check all input parameters, including if freq is suitable, then operate on the device.\nBut CMSIS-DAP has a single API to both set the freq and get info if the freq is allowed. This means we MUST stop SWO to test a new freq.\nIf we test the new freq with SWO still enabled, this \u0027should\u0027 change the current freq and kill current SWO operation.\nAgree to left it as is. Thanks.","commit_id":"9e4dad64b12251619c9787c4a92dc2e53bc54581"},{"author":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"change_message_id":"4d35f307c560af823d671b19b2992d109347eb69","unresolved":false,"context_lines":[{"line_number":1867,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":1868,"context_line":"\t\treturn retval;"},{"line_number":1869,"context_line":""},{"line_number":1870,"context_line":"\tif (!calculate_swo_prescaler(traceclkin_hz, *swo_freq,"},{"line_number":1871,"context_line":"\t\t\tswo_prescaler)) {"},{"line_number":1872,"context_line":"\t\tLOG_ERROR(\"SWO frequency is not suitable. Please choose a \""},{"line_number":1873,"context_line":"\t\t\t\"different frequency or use auto-detection.\");"},{"line_number":1874,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":1875,"context_line":"\t}"},{"line_number":1876,"context_line":""},{"line_number":1877,"context_line":"\tLOG_INFO(\"SWO frequency: %u Hz.\", *swo_freq);"},{"line_number":1878,"context_line":"\tLOG_INFO(\"SWO prescaler: %u.\", *swo_prescaler);"},{"line_number":1879,"context_line":""},{"line_number":1880,"context_line":"\tretval \u003d cmsis_dap_cmd_dap_swo_control(cmsis_dap_handle, DAP_SWO_CONTROL_START);"},{"line_number":1881,"context_line":"\tif (retval !\u003d ERROR_OK)"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"ceda9b01_50212199","line":1878,"range":{"start_line":1870,"start_character":0,"end_line":1878,"end_character":48},"in_reply_to":"ceda9b01_ed8402b8","updated":"2021-02-02 06:21:59.000000000","message":"calculate_swo_prescaler() is using the *swo_freq reported by cmsis_dap_cmd_dap_swo_baudrate(), on line 1866.","commit_id":"9e4dad64b12251619c9787c4a92dc2e53bc54581"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f7ae39871034db0f93660abe8d2c7204a128c16d","unresolved":false,"context_lines":[{"line_number":1905,"context_line":"\tif ((trace_status \u0026 DAP_SWO_STATUS_CAPTURE_MASK) !\u003d DAP_SWO_STATUS_CAPTURE_ACTIVE)"},{"line_number":1906,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":1907,"context_line":""},{"line_number":1908,"context_line":"\t*size \u003d trace_count \u003c *size ? trace_count : *size - 1;"},{"line_number":1909,"context_line":"\tsize_t read_so_far \u003d 0;"},{"line_number":1910,"context_line":"\tdo {"},{"line_number":1911,"context_line":"\t\tsize_t rb \u003d 0;"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"ceda9b01_0d82a6a9","line":1908,"range":{"start_line":1908,"start_character":0,"end_line":1908,"end_character":55},"updated":"2021-01-31 15:35:42.000000000","message":"why \u0027- 1\u0027 ?","commit_id":"9e4dad64b12251619c9787c4a92dc2e53bc54581"},{"author":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"change_message_id":"4d35f307c560af823d671b19b2992d109347eb69","unresolved":false,"context_lines":[{"line_number":1905,"context_line":"\tif ((trace_status \u0026 DAP_SWO_STATUS_CAPTURE_MASK) !\u003d DAP_SWO_STATUS_CAPTURE_ACTIVE)"},{"line_number":1906,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":1907,"context_line":""},{"line_number":1908,"context_line":"\t*size \u003d trace_count \u003c *size ? trace_count : *size - 1;"},{"line_number":1909,"context_line":"\tsize_t read_so_far \u003d 0;"},{"line_number":1910,"context_line":"\tdo {"},{"line_number":1911,"context_line":"\t\tsize_t rb \u003d 0;"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"ceda9b01_f035b5d8","line":1908,"range":{"start_line":1908,"start_character":0,"end_line":1908,"end_character":55},"in_reply_to":"ceda9b01_0d82a6a9","updated":"2021-02-02 06:21:59.000000000","message":"Copy-pasta from stlink_usb_trace_read().\nI\u0027ve searched for any comment on what \"size\" means but nothing came up.\nSame applies to the \"-1\" on line 1912.","commit_id":"9e4dad64b12251619c9787c4a92dc2e53bc54581"},{"author":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"change_message_id":"b9245387f2ab1e3464e46c32d09a0129c49eed9b","unresolved":false,"context_lines":[{"line_number":1905,"context_line":"\tif ((trace_status \u0026 DAP_SWO_STATUS_CAPTURE_MASK) !\u003d DAP_SWO_STATUS_CAPTURE_ACTIVE)"},{"line_number":1906,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":1907,"context_line":""},{"line_number":1908,"context_line":"\t*size \u003d trace_count \u003c *size ? trace_count : *size - 1;"},{"line_number":1909,"context_line":"\tsize_t read_so_far \u003d 0;"},{"line_number":1910,"context_line":"\tdo {"},{"line_number":1911,"context_line":"\t\tsize_t rb \u003d 0;"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"ceda9b01_30b81de2","line":1908,"range":{"start_line":1908,"start_character":0,"end_line":1908,"end_character":55},"in_reply_to":"ceda9b01_30e1fdfb","updated":"2021-02-05 08:43:26.000000000","message":"Nope, haven\u0027t tested w/o the -1. I\u0027ll give it a try and\nsee if it breaks anything.\n\nI\u0027ve seen the same pattern of doing \"-1\" which is related to the USB-HID\u0027s MaxPacketSize.\nI tried taking it out, but I think my change is too convoluted (also badly explained)\nhttp://openocd.zylin.com/#/c/5920/","commit_id":"9e4dad64b12251619c9787c4a92dc2e53bc54581"},{"author":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"change_message_id":"df26c343061de2e8515bd25f1893f78d45698ab1","unresolved":false,"context_lines":[{"line_number":1905,"context_line":"\tif ((trace_status \u0026 DAP_SWO_STATUS_CAPTURE_MASK) !\u003d DAP_SWO_STATUS_CAPTURE_ACTIVE)"},{"line_number":1906,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":1907,"context_line":""},{"line_number":1908,"context_line":"\t*size \u003d trace_count \u003c *size ? trace_count : *size - 1;"},{"line_number":1909,"context_line":"\tsize_t read_so_far \u003d 0;"},{"line_number":1910,"context_line":"\tdo {"},{"line_number":1911,"context_line":"\t\tsize_t rb \u003d 0;"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"aedf27f1_89052d7f","line":1908,"range":{"start_line":1908,"start_character":0,"end_line":1908,"end_character":55},"in_reply_to":"ceda9b01_30e1fdfb","updated":"2021-05-18 15:36:20.000000000","message":"tested w/o the -1 and it looks fine; I\u0027m able to get\nvalid ITM packets coming from the application.","commit_id":"9e4dad64b12251619c9787c4a92dc2e53bc54581"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0c3cfe3d4c2cffb3be87f71855c3404c05562b17","unresolved":false,"context_lines":[{"line_number":1905,"context_line":"\tif ((trace_status \u0026 DAP_SWO_STATUS_CAPTURE_MASK) !\u003d DAP_SWO_STATUS_CAPTURE_ACTIVE)"},{"line_number":1906,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":1907,"context_line":""},{"line_number":1908,"context_line":"\t*size \u003d trace_count \u003c *size ? trace_count : *size - 1;"},{"line_number":1909,"context_line":"\tsize_t read_so_far \u003d 0;"},{"line_number":1910,"context_line":"\tdo {"},{"line_number":1911,"context_line":"\t\tsize_t rb \u003d 0;"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"ceda9b01_30e1fdfb","line":1908,"range":{"start_line":1908,"start_character":0,"end_line":1908,"end_character":55},"in_reply_to":"ceda9b01_f035b5d8","updated":"2021-02-04 23:42:35.000000000","message":"Interesting, never noticed it in stlink driver. That code is there since the initial commit in 2013 http://openocd.zylin.com/#/c/1524/6/src/jtag/drivers/stlink_usb.c@845\nFor me it\u0027s incorrect. I will run some test on st-link, but I have never found any data lost...\n\nBack to cmsis-dap, the documentation doesn\u0027t require the -1 here, nor below.\nHave you tried without?\nI\u0027m thinking how could I trick the SWO to generate exactly the amount of data I want, so to test this case ...\nMaybe increase the trace polling time from 1ms to 10s, so there is time to fill the buffer with known ITM data, then print here some detail.","commit_id":"9e4dad64b12251619c9787c4a92dc2e53bc54581"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f7ae39871034db0f93660abe8d2c7204a128c16d","unresolved":false,"context_lines":[{"line_number":1944,"context_line":""},{"line_number":1945,"context_line":"\tbuffer[0] \u003d 0;\t/* report number */"},{"line_number":1946,"context_line":""},{"line_number":1947,"context_line":"\tfor (unsigned i \u003d 0; i \u003c CMD_ARGC; i++)"},{"line_number":1948,"context_line":"\t\tbuffer[i + 1] \u003d strtoul(CMD_ARGV[i], NULL, 16);"},{"line_number":1949,"context_line":""},{"line_number":1950,"context_line":"\tint retval \u003d cmsis_dap_xfer(cmsis_dap_handle, CMD_ARGC + 1);"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"ceda9b01_cd8b3ec3","line":1947,"range":{"start_line":1947,"start_character":6,"end_line":1947,"end_character":16},"updated":"2021-01-31 15:35:42.000000000","message":"please use \u0027unsigned int\u0027","commit_id":"9e4dad64b12251619c9787c4a92dc2e53bc54581"},{"author":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"change_message_id":"4d35f307c560af823d671b19b2992d109347eb69","unresolved":false,"context_lines":[{"line_number":1944,"context_line":""},{"line_number":1945,"context_line":"\tbuffer[0] \u003d 0;\t/* report number */"},{"line_number":1946,"context_line":""},{"line_number":1947,"context_line":"\tfor (unsigned i \u003d 0; i \u003c CMD_ARGC; i++)"},{"line_number":1948,"context_line":"\t\tbuffer[i + 1] \u003d strtoul(CMD_ARGV[i], NULL, 16);"},{"line_number":1949,"context_line":""},{"line_number":1950,"context_line":"\tint retval \u003d cmsis_dap_xfer(cmsis_dap_handle, CMD_ARGC + 1);"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"ceda9b01_103399f4","line":1947,"range":{"start_line":1947,"start_character":6,"end_line":1947,"end_character":16},"in_reply_to":"ceda9b01_cd8b3ec3","updated":"2021-02-02 06:21:59.000000000","message":"Done","commit_id":"9e4dad64b12251619c9787c4a92dc2e53bc54581"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f7ae39871034db0f93660abe8d2c7204a128c16d","unresolved":false,"context_lines":[{"line_number":2107,"context_line":"\t.speed \u003d cmsis_dap_speed,"},{"line_number":2108,"context_line":"\t.khz \u003d cmsis_dap_khz,"},{"line_number":2109,"context_line":"\t.speed_div \u003d cmsis_dap_speed_div,"},{"line_number":2110,"context_line":"\t.config_trace \u003d \u0026cmsis_dap_config_trace,"},{"line_number":2111,"context_line":"\t.poll_trace \u003d \u0026cmsis_dap_poll_trace,"},{"line_number":2112,"context_line":""},{"line_number":2113,"context_line":"\t.jtag_ops \u003d \u0026cmsis_dap_interface,"},{"line_number":2114,"context_line":"\t.swd_ops \u003d \u0026cmsis_dap_swd_driver,"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"ceda9b01_6db81275","line":2111,"range":{"start_line":2110,"start_character":0,"end_line":2111,"end_character":37},"updated":"2021-01-31 15:35:42.000000000","message":"the operator \u0027\u0026\u0027 is optional, so uniform these lines with the rest of the struct and remove \u0027\u0026\u0027","commit_id":"9e4dad64b12251619c9787c4a92dc2e53bc54581"},{"author":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"change_message_id":"4d35f307c560af823d671b19b2992d109347eb69","unresolved":false,"context_lines":[{"line_number":2107,"context_line":"\t.speed \u003d cmsis_dap_speed,"},{"line_number":2108,"context_line":"\t.khz \u003d cmsis_dap_khz,"},{"line_number":2109,"context_line":"\t.speed_div \u003d cmsis_dap_speed_div,"},{"line_number":2110,"context_line":"\t.config_trace \u003d \u0026cmsis_dap_config_trace,"},{"line_number":2111,"context_line":"\t.poll_trace \u003d \u0026cmsis_dap_poll_trace,"},{"line_number":2112,"context_line":""},{"line_number":2113,"context_line":"\t.jtag_ops \u003d \u0026cmsis_dap_interface,"},{"line_number":2114,"context_line":"\t.swd_ops \u003d \u0026cmsis_dap_swd_driver,"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"ceda9b01_b02f2d85","line":2111,"range":{"start_line":2110,"start_character":0,"end_line":2111,"end_character":37},"in_reply_to":"ceda9b01_6db81275","updated":"2021-02-02 06:21:59.000000000","message":"Done","commit_id":"9e4dad64b12251619c9787c4a92dc2e53bc54581"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"88e2addd97f69280ca723f44a66d50458a4696f6","unresolved":false,"context_lines":[{"line_number":608,"context_line":" *                          WinUSB (requires CMSIS-DAP v2)."},{"line_number":609,"context_line":" */"},{"line_number":610,"context_line":"static int cmsis_dap_cmd_dap_swo_transport("},{"line_number":611,"context_line":"\t\t\t\t\tuint8_t transport)"},{"line_number":612,"context_line":"{"},{"line_number":613,"context_line":"\tuint8_t *command \u003d cmsis_dap_handle-\u003ecommand;"},{"line_number":614,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":17,"id":"aedf27f1_891bedd3","line":611,"updated":"2021-05-19 10:31:44.000000000","message":"no need for newline, the function prototype fits in a single line","commit_id":"741d603ee1200d8b696ec91fe2ebf9d3adfb3092"},{"author":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"change_message_id":"44de0fa32ebc7a430ad879c09e5fe5c881fa8864","unresolved":false,"context_lines":[{"line_number":608,"context_line":" *                          WinUSB (requires CMSIS-DAP v2)."},{"line_number":609,"context_line":" */"},{"line_number":610,"context_line":"static int cmsis_dap_cmd_dap_swo_transport("},{"line_number":611,"context_line":"\t\t\t\t\tuint8_t transport)"},{"line_number":612,"context_line":"{"},{"line_number":613,"context_line":"\tuint8_t *command \u003d cmsis_dap_handle-\u003ecommand;"},{"line_number":614,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":17,"id":"aedf27f1_89820dcc","line":611,"in_reply_to":"aedf27f1_891bedd3","updated":"2021-05-19 10:36:09.000000000","message":"fixed","commit_id":"741d603ee1200d8b696ec91fe2ebf9d3adfb3092"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"88e2addd97f69280ca723f44a66d50458a4696f6","unresolved":false,"context_lines":[{"line_number":629,"context_line":" * @param[in] mode          Trace capture mode. Can be UART or MANCHESTER."},{"line_number":630,"context_line":" */"},{"line_number":631,"context_line":"static int cmsis_dap_cmd_dap_swo_mode("},{"line_number":632,"context_line":"\t\t\t\t\tuint8_t mode)"},{"line_number":633,"context_line":"{"},{"line_number":634,"context_line":"\tuint8_t *command \u003d cmsis_dap_handle-\u003ecommand;"},{"line_number":635,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":17,"id":"aedf27f1_2910c1ac","line":632,"updated":"2021-05-19 10:31:44.000000000","message":"same here","commit_id":"741d603ee1200d8b696ec91fe2ebf9d3adfb3092"},{"author":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"change_message_id":"44de0fa32ebc7a430ad879c09e5fe5c881fa8864","unresolved":false,"context_lines":[{"line_number":629,"context_line":" * @param[in] mode          Trace capture mode. Can be UART or MANCHESTER."},{"line_number":630,"context_line":" */"},{"line_number":631,"context_line":"static int cmsis_dap_cmd_dap_swo_mode("},{"line_number":632,"context_line":"\t\t\t\t\tuint8_t mode)"},{"line_number":633,"context_line":"{"},{"line_number":634,"context_line":"\tuint8_t *command \u003d cmsis_dap_handle-\u003ecommand;"},{"line_number":635,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":17,"id":"aedf27f1_298761de","line":632,"in_reply_to":"aedf27f1_2910c1ac","updated":"2021-05-19 10:36:09.000000000","message":"fixed","commit_id":"741d603ee1200d8b696ec91fe2ebf9d3adfb3092"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"88e2addd97f69280ca723f44a66d50458a4696f6","unresolved":false,"context_lines":[{"line_number":685,"context_line":" *                          not yet been read."},{"line_number":686,"context_line":" */"},{"line_number":687,"context_line":"static int cmsis_dap_cmd_dap_swo_control("},{"line_number":688,"context_line":"\t\t\t\t\tuint8_t control)"},{"line_number":689,"context_line":"{"},{"line_number":690,"context_line":"\tuint8_t *command \u003d cmsis_dap_handle-\u003ecommand;"},{"line_number":691,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":17,"id":"aedf27f1_4915059c","line":688,"updated":"2021-05-19 10:31:44.000000000","message":"same here","commit_id":"741d603ee1200d8b696ec91fe2ebf9d3adfb3092"},{"author":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"change_message_id":"44de0fa32ebc7a430ad879c09e5fe5c881fa8864","unresolved":false,"context_lines":[{"line_number":685,"context_line":" *                          not yet been read."},{"line_number":686,"context_line":" */"},{"line_number":687,"context_line":"static int cmsis_dap_cmd_dap_swo_control("},{"line_number":688,"context_line":"\t\t\t\t\tuint8_t control)"},{"line_number":689,"context_line":"{"},{"line_number":690,"context_line":"\tuint8_t *command \u003d cmsis_dap_handle-\u003ecommand;"},{"line_number":691,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":17,"id":"aedf27f1_498c2500","line":688,"in_reply_to":"aedf27f1_4915059c","updated":"2021-05-19 10:36:09.000000000","message":"fixed","commit_id":"741d603ee1200d8b696ec91fe2ebf9d3adfb3092"}],"src/jtag/drivers/cmsis_dap_usb.c":[{"author":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"f4dd78bc2f9795d4fb87cbdaf93a096f0c342f9c","unresolved":false,"context_lines":[{"line_number":206,"context_line":"\tuint8_t *packet_buffer;"},{"line_number":207,"context_line":"\tuint8_t caps;"},{"line_number":208,"context_line":"\tuint8_t mode;"},{"line_number":209,"context_line":"\tuint8_t enabled;"},{"line_number":210,"context_line":"\tuint32_t swo_buf_sz;"},{"line_number":211,"context_line":"};"},{"line_number":212,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"eed59fcf_54492269","line":209,"updated":"2020-08-19 17:22:28.000000000","message":"What is \"enabled\"? And why is the data type not bool?","commit_id":"b8742aeed4699f46edd18fd8d610b05e19f75fe4"},{"author":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"change_message_id":"45fdd490f072be7bb9fe9f79229a26edff1194f6","unresolved":false,"context_lines":[{"line_number":206,"context_line":"\tuint8_t *packet_buffer;"},{"line_number":207,"context_line":"\tuint8_t caps;"},{"line_number":208,"context_line":"\tuint8_t mode;"},{"line_number":209,"context_line":"\tuint8_t enabled;"},{"line_number":210,"context_line":"\tuint32_t swo_buf_sz;"},{"line_number":211,"context_line":"};"},{"line_number":212,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"eed59fcf_34581e35","line":209,"in_reply_to":"eed59fcf_54492269","updated":"2020-08-19 17:35:14.000000000","message":"* renamed enabled to trace_enabled\n* changed type from uint8_t to bool","commit_id":"b8742aeed4699f46edd18fd8d610b05e19f75fe4"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"adc28c4bc1652007f2b068edd1287d41ad79ff1a","unresolved":false,"context_lines":[{"line_number":90,"context_line":"#define INFO_ID_PKT_SZ            0xff      /* short */"},{"line_number":91,"context_line":"#define INFO_ID_SWO_BUF_SZ        0xfd      /* word */"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"#define INFO_CAPS_SWD             0x01"},{"line_number":94,"context_line":"#define INFO_CAPS_JTAG            0x02"},{"line_number":95,"context_line":"#define INFO_CAPS_SWO_UART        0x04"},{"line_number":96,"context_line":"#define INFO_CAPS_SWO_MANCHESTER  0x08"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"/* CMD_LED */"},{"line_number":99,"context_line":"#define LED_ID_CONNECT            0x00"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"eed59fcf_f4961697","line":96,"range":{"start_line":93,"start_character":0,"end_line":96,"end_character":38},"updated":"2020-08-19 22:18:16.000000000","message":"can all these CAPS be converted to use BIT()?","commit_id":"9e339b1c4a08ce4ab75a9266102e90b0025c7841"},{"author":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"change_message_id":"75d05b2df9bf72d268986254661fe216067b7a4e","unresolved":false,"context_lines":[{"line_number":90,"context_line":"#define INFO_ID_PKT_SZ            0xff      /* short */"},{"line_number":91,"context_line":"#define INFO_ID_SWO_BUF_SZ        0xfd      /* word */"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"#define INFO_CAPS_SWD             0x01"},{"line_number":94,"context_line":"#define INFO_CAPS_JTAG            0x02"},{"line_number":95,"context_line":"#define INFO_CAPS_SWO_UART        0x04"},{"line_number":96,"context_line":"#define INFO_CAPS_SWO_MANCHESTER  0x08"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"/* CMD_LED */"},{"line_number":99,"context_line":"#define LED_ID_CONNECT            0x00"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"ceda9b01_5f64d745","line":96,"range":{"start_line":93,"start_character":0,"end_line":96,"end_character":38},"in_reply_to":"eed59fcf_f4961697","updated":"2020-12-01 11:26:41.000000000","message":"Done","commit_id":"9e339b1c4a08ce4ab75a9266102e90b0025c7841"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"adc28c4bc1652007f2b068edd1287d41ad79ff1a","unresolved":false,"context_lines":[{"line_number":181,"context_line":"#define DAP_SWO_CONTROL_START     1"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"/* SWO trace status */"},{"line_number":184,"context_line":"#define DAP_SWO_STATUS_CAPTURE_ACTIVE   (1U\u003c\u003c0)"},{"line_number":185,"context_line":"#define DAP_SWO_STATUS_CAPTURE_PAUSED   (1U\u003c\u003c1)"},{"line_number":186,"context_line":"#define DAP_SWO_STATUS_STREAM_ERROR     (1U\u003c\u003c6)"},{"line_number":187,"context_line":"#define DAP_SWO_STATUS_BUFFER_OVERRUN   (1U\u003c\u003c7)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"/* CMSIS-DAP Vendor Commands"},{"line_number":190,"context_line":" * None as yet... */"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"eed59fcf_d4b2f247","line":187,"range":{"start_line":184,"start_character":0,"end_line":187,"end_character":47},"updated":"2020-08-19 22:18:16.000000000","message":"Please use BIT() instead of shifts","commit_id":"9e339b1c4a08ce4ab75a9266102e90b0025c7841"},{"author":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"change_message_id":"55b131dd6e13c41f8fded8e692a74003ccb23afe","unresolved":false,"context_lines":[{"line_number":181,"context_line":"#define DAP_SWO_CONTROL_START     1"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"/* SWO trace status */"},{"line_number":184,"context_line":"#define DAP_SWO_STATUS_CAPTURE_ACTIVE   (1U\u003c\u003c0)"},{"line_number":185,"context_line":"#define DAP_SWO_STATUS_CAPTURE_PAUSED   (1U\u003c\u003c1)"},{"line_number":186,"context_line":"#define DAP_SWO_STATUS_STREAM_ERROR     (1U\u003c\u003c6)"},{"line_number":187,"context_line":"#define DAP_SWO_STATUS_BUFFER_OVERRUN   (1U\u003c\u003c7)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"/* CMSIS-DAP Vendor Commands"},{"line_number":190,"context_line":" * None as yet... */"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"eed59fcf_94c1ca85","line":187,"range":{"start_line":184,"start_character":0,"end_line":187,"end_character":47},"in_reply_to":"eed59fcf_d4b2f247","updated":"2020-08-20 09:45:41.000000000","message":"Done","commit_id":"9e339b1c4a08ce4ab75a9266102e90b0025c7841"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"adc28c4bc1652007f2b068edd1287d41ad79ff1a","unresolved":false,"context_lines":[{"line_number":197,"context_line":"};"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"/* max clock speed (kHz) */"},{"line_number":200,"context_line":"#define DAP_MAX_CLOCK_kHz             50000"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"struct cmsis_dap {"},{"line_number":203,"context_line":"\thid_device *dev_handle;"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"eed59fcf_f4aff6dc","line":200,"range":{"start_line":200,"start_character":8,"end_line":200,"end_character":25},"updated":"2020-08-19 22:18:16.000000000","message":"Agree that for the International System of Units \u0027k\u0027 is lowercase and freq is in \u0027Hz\u0027, but this is a macro and the coding style requires all uppercase.\nAvoid CamelCase in OpenOCD","commit_id":"9e339b1c4a08ce4ab75a9266102e90b0025c7841"},{"author":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"f71bb1c671d0bde9b6223102936751d839004818","unresolved":false,"context_lines":[{"line_number":197,"context_line":"};"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"/* max clock speed (kHz) */"},{"line_number":200,"context_line":"#define DAP_MAX_CLOCK_kHz             50000"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"struct cmsis_dap {"},{"line_number":203,"context_line":"\thid_device *dev_handle;"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"eed59fcf_74f22605","line":200,"updated":"2020-08-19 22:12:43.000000000","message":"The comment already mentions the unit. Either way, only use upper-case letters for #defines","commit_id":"9e339b1c4a08ce4ab75a9266102e90b0025c7841"},{"author":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"change_message_id":"55b131dd6e13c41f8fded8e692a74003ccb23afe","unresolved":false,"context_lines":[{"line_number":197,"context_line":"};"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"/* max clock speed (kHz) */"},{"line_number":200,"context_line":"#define DAP_MAX_CLOCK_kHz             50000"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"struct cmsis_dap {"},{"line_number":203,"context_line":"\thid_device *dev_handle;"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"eed59fcf_b4be4ef9","line":200,"range":{"start_line":200,"start_character":8,"end_line":200,"end_character":25},"in_reply_to":"eed59fcf_f4aff6dc","updated":"2020-08-20 09:45:41.000000000","message":"Done","commit_id":"9e339b1c4a08ce4ab75a9266102e90b0025c7841"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"adc28c4bc1652007f2b068edd1287d41ad79ff1a","unresolved":false,"context_lines":[{"line_number":663,"context_line":"}"},{"line_number":664,"context_line":"#endif"},{"line_number":665,"context_line":""},{"line_number":666,"context_line":"static int cmsis_dap_cmd_DAP_SWO_Transport("},{"line_number":667,"context_line":"\t\t\t\t\tstruct cmsis_dap *dap,"},{"line_number":668,"context_line":"\t\t\t\t\tuint8_t transport)"},{"line_number":669,"context_line":"{"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"eed59fcf_94bc6a1c","line":666,"range":{"start_line":666,"start_character":11,"end_line":666,"end_character":42},"updated":"2020-08-19 22:18:16.000000000","message":"This CamelCase is also in violation of the coding style, but all the file follows this function naming...\nLeft it as is, the whole file needs a rework!","commit_id":"9e339b1c4a08ce4ab75a9266102e90b0025c7841"},{"author":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"change_message_id":"75d05b2df9bf72d268986254661fe216067b7a4e","unresolved":false,"context_lines":[{"line_number":663,"context_line":"}"},{"line_number":664,"context_line":"#endif"},{"line_number":665,"context_line":""},{"line_number":666,"context_line":"static int cmsis_dap_cmd_DAP_SWO_Transport("},{"line_number":667,"context_line":"\t\t\t\t\tstruct cmsis_dap *dap,"},{"line_number":668,"context_line":"\t\t\t\t\tuint8_t transport)"},{"line_number":669,"context_line":"{"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"ceda9b01_7f699b1c","line":666,"range":{"start_line":666,"start_character":11,"end_line":666,"end_character":42},"in_reply_to":"eed59fcf_94bc6a1c","updated":"2020-12-01 11:26:41.000000000","message":"Done","commit_id":"9e339b1c4a08ce4ab75a9266102e90b0025c7841"},{"author":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"f71bb1c671d0bde9b6223102936751d839004818","unresolved":false,"context_lines":[{"line_number":691,"context_line":"\tbuffer[0] \u003d 0;\t/* report number */"},{"line_number":692,"context_line":"\tbuffer[1] \u003d CMD_DAP_SWO_MODE;"},{"line_number":693,"context_line":"\tbuffer[2] \u003d mode;"},{"line_number":694,"context_line":"\tretval \u003d cmsis_dap_usb_xfer(dap, 3);"},{"line_number":695,"context_line":""},{"line_number":696,"context_line":"\tif (retval !\u003d ERROR_OK || buffer[1] !\u003d DAP_OK) {"},{"line_number":697,"context_line":"\t\tLOG_ERROR(\"CMSIS-DAP: command CMD_SWO_Mode(%d) failed.\", mode);"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"eed59fcf_94930aa6","line":694,"updated":"2020-08-19 22:12:43.000000000","message":"Declare variables at the point of first use","commit_id":"9e339b1c4a08ce4ab75a9266102e90b0025c7841"},{"author":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"change_message_id":"55b131dd6e13c41f8fded8e692a74003ccb23afe","unresolved":false,"context_lines":[{"line_number":691,"context_line":"\tbuffer[0] \u003d 0;\t/* report number */"},{"line_number":692,"context_line":"\tbuffer[1] \u003d CMD_DAP_SWO_MODE;"},{"line_number":693,"context_line":"\tbuffer[2] \u003d mode;"},{"line_number":694,"context_line":"\tretval \u003d cmsis_dap_usb_xfer(dap, 3);"},{"line_number":695,"context_line":""},{"line_number":696,"context_line":"\tif (retval !\u003d ERROR_OK || buffer[1] !\u003d DAP_OK) {"},{"line_number":697,"context_line":"\t\tLOG_ERROR(\"CMSIS-DAP: command CMD_SWO_Mode(%d) failed.\", mode);"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"eed59fcf_f4c4d696","line":694,"in_reply_to":"eed59fcf_94930aa6","updated":"2020-08-20 09:45:41.000000000","message":"\u003e Declare variables at the point of first use\n\nThis is not consistent across the file.\nOk if I submit a following patch to consolidate this?","commit_id":"9e339b1c4a08ce4ab75a9266102e90b0025c7841"},{"author":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"change_message_id":"75d05b2df9bf72d268986254661fe216067b7a4e","unresolved":false,"context_lines":[{"line_number":691,"context_line":"\tbuffer[0] \u003d 0;\t/* report number */"},{"line_number":692,"context_line":"\tbuffer[1] \u003d CMD_DAP_SWO_MODE;"},{"line_number":693,"context_line":"\tbuffer[2] \u003d mode;"},{"line_number":694,"context_line":"\tretval \u003d cmsis_dap_usb_xfer(dap, 3);"},{"line_number":695,"context_line":""},{"line_number":696,"context_line":"\tif (retval !\u003d ERROR_OK || buffer[1] !\u003d DAP_OK) {"},{"line_number":697,"context_line":"\t\tLOG_ERROR(\"CMSIS-DAP: command CMD_SWO_Mode(%d) failed.\", mode);"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"ceda9b01_1f5e4f7c","line":694,"in_reply_to":"eed59fcf_f4c4d696","updated":"2020-12-01 11:26:41.000000000","message":"Done","commit_id":"9e339b1c4a08ce4ab75a9266102e90b0025c7841"},{"author":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"f71bb1c671d0bde9b6223102936751d839004818","unresolved":false,"context_lines":[{"line_number":701,"context_line":"\treturn ERROR_OK;"},{"line_number":702,"context_line":"}"},{"line_number":703,"context_line":""},{"line_number":704,"context_line":"static int cmsis_dap_cmd_DAP_SWO_Baudrate("},{"line_number":705,"context_line":"\t\t\t\t\tstruct cmsis_dap *dap,"},{"line_number":706,"context_line":"\t\t\t\t\tuint32_t in_baudrate,"},{"line_number":707,"context_line":"\t\t\t\t\tuint32_t *dev_baudrate)"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"eed59fcf_b4908e99","line":704,"updated":"2020-08-19 22:12:43.000000000","message":"Do not use upper-case letters in function names","commit_id":"9e339b1c4a08ce4ab75a9266102e90b0025c7841"},{"author":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"change_message_id":"75d05b2df9bf72d268986254661fe216067b7a4e","unresolved":false,"context_lines":[{"line_number":701,"context_line":"\treturn ERROR_OK;"},{"line_number":702,"context_line":"}"},{"line_number":703,"context_line":""},{"line_number":704,"context_line":"static int cmsis_dap_cmd_DAP_SWO_Baudrate("},{"line_number":705,"context_line":"\t\t\t\t\tstruct cmsis_dap *dap,"},{"line_number":706,"context_line":"\t\t\t\t\tuint32_t in_baudrate,"},{"line_number":707,"context_line":"\t\t\t\t\tuint32_t *dev_baudrate)"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"ceda9b01_3f63133d","line":704,"in_reply_to":"eed59fcf_94846aa5","updated":"2020-12-01 11:26:41.000000000","message":"Done","commit_id":"9e339b1c4a08ce4ab75a9266102e90b0025c7841"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b26d9b65b8d8be679f5caa59ade2ba8138140db4","unresolved":false,"context_lines":[{"line_number":701,"context_line":"\treturn ERROR_OK;"},{"line_number":702,"context_line":"}"},{"line_number":703,"context_line":""},{"line_number":704,"context_line":"static int cmsis_dap_cmd_DAP_SWO_Baudrate("},{"line_number":705,"context_line":"\t\t\t\t\tstruct cmsis_dap *dap,"},{"line_number":706,"context_line":"\t\t\t\t\tuint32_t in_baudrate,"},{"line_number":707,"context_line":"\t\t\t\t\tuint32_t *dev_baudrate)"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"eed59fcf_d4e0b227","line":704,"in_reply_to":"eed59fcf_b4908e99","updated":"2020-08-19 22:20:17.000000000","message":"Mark, the whole file need a rework for function names.\nLet\u0027s have this patch consistent with the rest of the file, then a single patch will fix all the function names in one shot.","commit_id":"9e339b1c4a08ce4ab75a9266102e90b0025c7841"},{"author":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"a7c92c21743f7d8f76e592f726bd6a3a532d48e8","unresolved":false,"context_lines":[{"line_number":701,"context_line":"\treturn ERROR_OK;"},{"line_number":702,"context_line":"}"},{"line_number":703,"context_line":""},{"line_number":704,"context_line":"static int cmsis_dap_cmd_DAP_SWO_Baudrate("},{"line_number":705,"context_line":"\t\t\t\t\tstruct cmsis_dap *dap,"},{"line_number":706,"context_line":"\t\t\t\t\tuint32_t in_baudrate,"},{"line_number":707,"context_line":"\t\t\t\t\tuint32_t *dev_baudrate)"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"eed59fcf_94846aa5","line":704,"in_reply_to":"eed59fcf_d4e0b227","updated":"2020-08-25 18:42:15.000000000","message":"Sure, that\u0027s fine by me","commit_id":"9e339b1c4a08ce4ab75a9266102e90b0025c7841"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"adc28c4bc1652007f2b068edd1287d41ad79ff1a","unresolved":false,"context_lines":[{"line_number":803,"context_line":"\t*trace_count \u003d le_to_h_u16(\u0026buffer[2]);"},{"line_number":804,"context_line":""},{"line_number":805,"context_line":"\tif (*trace_count \u003e 0)"},{"line_number":806,"context_line":"\t\tmemcpy(data, \u0026(buffer[4]), *trace_count);"},{"line_number":807,"context_line":""},{"line_number":808,"context_line":"\treturn ERROR_OK;"},{"line_number":809,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"eed59fcf_b4b96e2b","line":806,"range":{"start_line":806,"start_character":16,"end_line":806,"end_character":27},"updated":"2020-08-19 22:18:16.000000000","message":"These parenthesis are not required","commit_id":"9e339b1c4a08ce4ab75a9266102e90b0025c7841"},{"author":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"change_message_id":"75d05b2df9bf72d268986254661fe216067b7a4e","unresolved":false,"context_lines":[{"line_number":803,"context_line":"\t*trace_count \u003d le_to_h_u16(\u0026buffer[2]);"},{"line_number":804,"context_line":""},{"line_number":805,"context_line":"\tif (*trace_count \u003e 0)"},{"line_number":806,"context_line":"\t\tmemcpy(data, \u0026(buffer[4]), *trace_count);"},{"line_number":807,"context_line":""},{"line_number":808,"context_line":"\treturn ERROR_OK;"},{"line_number":809,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"ceda9b01_df57675b","line":806,"range":{"start_line":806,"start_character":16,"end_line":806,"end_character":27},"in_reply_to":"eed59fcf_b4b96e2b","updated":"2020-12-01 11:26:41.000000000","message":"Done","commit_id":"9e339b1c4a08ce4ab75a9266102e90b0025c7841"},{"author":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"f71bb1c671d0bde9b6223102936751d839004818","unresolved":false,"context_lines":[{"line_number":1867,"context_line":"\tunsigned int presc;"},{"line_number":1868,"context_line":"\tdouble deviation;"},{"line_number":1869,"context_line":""},{"line_number":1870,"context_line":"\tpresc \u003d traceclkin_freq/swo_freq;"},{"line_number":1871,"context_line":"\tif (presc \u003e TPIU_ACPR_MAX_SWOSCALER)"},{"line_number":1872,"context_line":"\t\treturn false;"},{"line_number":1873,"context_line":"\tdeviation \u003d fabs(1.0 - ((double)presc*swo_freq / traceclkin_freq));"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"eed59fcf_54eda221","line":1870,"updated":"2020-08-19 22:12:43.000000000","message":"Use spaces around operators","commit_id":"9e339b1c4a08ce4ab75a9266102e90b0025c7841"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"adc28c4bc1652007f2b068edd1287d41ad79ff1a","unresolved":false,"context_lines":[{"line_number":1867,"context_line":"\tunsigned int presc;"},{"line_number":1868,"context_line":"\tdouble deviation;"},{"line_number":1869,"context_line":""},{"line_number":1870,"context_line":"\tpresc \u003d traceclkin_freq/swo_freq;"},{"line_number":1871,"context_line":"\tif (presc \u003e TPIU_ACPR_MAX_SWOSCALER)"},{"line_number":1872,"context_line":"\t\treturn false;"},{"line_number":1873,"context_line":"\tdeviation \u003d fabs(1.0 - ((double)presc*swo_freq / traceclkin_freq));"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"eed59fcf_5486026c","line":1870,"range":{"start_line":1870,"start_character":9,"end_line":1870,"end_character":34},"updated":"2020-08-19 22:18:16.000000000","message":"add space around \u0027/\u0027","commit_id":"9e339b1c4a08ce4ab75a9266102e90b0025c7841"},{"author":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"change_message_id":"75d05b2df9bf72d268986254661fe216067b7a4e","unresolved":false,"context_lines":[{"line_number":1867,"context_line":"\tunsigned int presc;"},{"line_number":1868,"context_line":"\tdouble deviation;"},{"line_number":1869,"context_line":""},{"line_number":1870,"context_line":"\tpresc \u003d traceclkin_freq/swo_freq;"},{"line_number":1871,"context_line":"\tif (presc \u003e TPIU_ACPR_MAX_SWOSCALER)"},{"line_number":1872,"context_line":"\t\treturn false;"},{"line_number":1873,"context_line":"\tdeviation \u003d fabs(1.0 - ((double)presc*swo_freq / traceclkin_freq));"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"ceda9b01_ff54ab58","line":1870,"range":{"start_line":1870,"start_character":9,"end_line":1870,"end_character":34},"in_reply_to":"eed59fcf_5486026c","updated":"2020-12-01 11:26:41.000000000","message":"Done","commit_id":"9e339b1c4a08ce4ab75a9266102e90b0025c7841"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"adc28c4bc1652007f2b068edd1287d41ad79ff1a","unresolved":false,"context_lines":[{"line_number":1870,"context_line":"\tpresc \u003d traceclkin_freq/swo_freq;"},{"line_number":1871,"context_line":"\tif (presc \u003e TPIU_ACPR_MAX_SWOSCALER)"},{"line_number":1872,"context_line":"\t\treturn false;"},{"line_number":1873,"context_line":"\tdeviation \u003d fabs(1.0 - ((double)presc*swo_freq / traceclkin_freq));"},{"line_number":1874,"context_line":"\tif (deviation \u003e SWO_MAX_FREQ_DEV)"},{"line_number":1875,"context_line":"\t\treturn false;"},{"line_number":1876,"context_line":"\t*swo_prescaler \u003d presc;"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"eed59fcf_748b0673","line":1873,"range":{"start_line":1873,"start_character":33,"end_line":1873,"end_character":47},"updated":"2020-08-19 22:18:16.000000000","message":"add space around \u0027*\u0027\nI\u0027m not really happy to use a double precision here, just for checking the deviation error.\nWould this work?\nunsigned int max_deviation \u003d traceclkin_freq * 3 / 100;\nif (presc * swo_freq \u003e traceclkin_freg + max_deviation ||\n    presc * swo_freq \u003c traceclkin_freg - max_deviation)\n        return false;","commit_id":"9e339b1c4a08ce4ab75a9266102e90b0025c7841"},{"author":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"change_message_id":"8657eb7ae2c159521141b784cbf9e15fa5d9e46d","unresolved":false,"context_lines":[{"line_number":1870,"context_line":"\tpresc \u003d traceclkin_freq/swo_freq;"},{"line_number":1871,"context_line":"\tif (presc \u003e TPIU_ACPR_MAX_SWOSCALER)"},{"line_number":1872,"context_line":"\t\treturn false;"},{"line_number":1873,"context_line":"\tdeviation \u003d fabs(1.0 - ((double)presc*swo_freq / traceclkin_freq));"},{"line_number":1874,"context_line":"\tif (deviation \u003e SWO_MAX_FREQ_DEV)"},{"line_number":1875,"context_line":"\t\treturn false;"},{"line_number":1876,"context_line":"\t*swo_prescaler \u003d presc;"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"eed59fcf_34d33e63","line":1873,"range":{"start_line":1873,"start_character":33,"end_line":1873,"end_character":47},"in_reply_to":"eed59fcf_748b0673","updated":"2020-08-19 23:45:14.000000000","message":"\u003e I\u0027m not really happy to use a double precision here, just for\n \u003e checking the deviation error.\nOn point observation!\nI\u0027m not either. This is just copy-pasta from src/jtag/drivers/jlink.c:1269 ( see also http://openocd.zylin.com/#/c/5807/ ).\n\n\n \u003e Would this work?\n \u003e unsigned int max_deviation \u003d traceclkin_freq * 3 / 100;\nShould work; maybe just adding ( ) to make sure we multiply first.","commit_id":"9e339b1c4a08ce4ab75a9266102e90b0025c7841"},{"author":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"change_message_id":"55b131dd6e13c41f8fded8e692a74003ccb23afe","unresolved":false,"context_lines":[{"line_number":1870,"context_line":"\tpresc \u003d traceclkin_freq/swo_freq;"},{"line_number":1871,"context_line":"\tif (presc \u003e TPIU_ACPR_MAX_SWOSCALER)"},{"line_number":1872,"context_line":"\t\treturn false;"},{"line_number":1873,"context_line":"\tdeviation \u003d fabs(1.0 - ((double)presc*swo_freq / traceclkin_freq));"},{"line_number":1874,"context_line":"\tif (deviation \u003e SWO_MAX_FREQ_DEV)"},{"line_number":1875,"context_line":"\t\treturn false;"},{"line_number":1876,"context_line":"\t*swo_prescaler \u003d presc;"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"eed59fcf_543362c0","line":1873,"range":{"start_line":1873,"start_character":33,"end_line":1873,"end_character":47},"in_reply_to":"eed59fcf_748b0673","updated":"2020-08-20 09:45:41.000000000","message":"Done","commit_id":"9e339b1c4a08ce4ab75a9266102e90b0025c7841"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"adc28c4bc1652007f2b068edd1287d41ad79ff1a","unresolved":false,"context_lines":[{"line_number":1878,"context_line":"\treturn true;"},{"line_number":1879,"context_line":"}"},{"line_number":1880,"context_line":""},{"line_number":1881,"context_line":"#define MIN_BAUDRATE 300"},{"line_number":1882,"context_line":"#define MAX_BAUDRATE 921600"},{"line_number":1883,"context_line":"static int cmsis_dap_config_trace("},{"line_number":1884,"context_line":"\t\t\t\tbool trace_enabled,"},{"line_number":1885,"context_line":"\t\t\t\tenum tpiu_pin_protocol pin_protocol,"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"eed59fcf_d49992c9","line":1882,"range":{"start_line":1881,"start_character":0,"end_line":1882,"end_character":27},"updated":"2020-08-19 22:18:16.000000000","message":"move macros at the beginning of the file, together with the other macros.\nAre these limits cmsis-dap specific? Then can be renamed to highlight this?","commit_id":"9e339b1c4a08ce4ab75a9266102e90b0025c7841"},{"author":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"change_message_id":"55b131dd6e13c41f8fded8e692a74003ccb23afe","unresolved":false,"context_lines":[{"line_number":1878,"context_line":"\treturn true;"},{"line_number":1879,"context_line":"}"},{"line_number":1880,"context_line":""},{"line_number":1881,"context_line":"#define MIN_BAUDRATE 300"},{"line_number":1882,"context_line":"#define MAX_BAUDRATE 921600"},{"line_number":1883,"context_line":"static int cmsis_dap_config_trace("},{"line_number":1884,"context_line":"\t\t\t\tbool trace_enabled,"},{"line_number":1885,"context_line":"\t\t\t\tenum tpiu_pin_protocol pin_protocol,"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"eed59fcf_7438e69b","line":1882,"range":{"start_line":1881,"start_character":0,"end_line":1882,"end_character":27},"in_reply_to":"eed59fcf_d49992c9","updated":"2020-08-20 09:45:41.000000000","message":"Done","commit_id":"9e339b1c4a08ce4ab75a9266102e90b0025c7841"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"adc28c4bc1652007f2b068edd1287d41ad79ff1a","unresolved":false,"context_lines":[{"line_number":1981,"context_line":"\tretval \u003d cmsis_dap_cmd_DAP_SWO_Status(cmsis_dap_handle, \u0026trace_status, \u0026trace_count);"},{"line_number":1982,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":1983,"context_line":"\t\treturn retval;"},{"line_number":1984,"context_line":"\tif ((trace_status\u0026DAP_SWO_STATUS_CAPTURE_ACTIVE) !\u003d DAP_SWO_STATUS_CAPTURE_ACTIVE)"},{"line_number":1985,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":1986,"context_line":""},{"line_number":1987,"context_line":"\t*size \u003d trace_count \u003c *size ? trace_count : *size - 1;"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"eed59fcf_14807a4a","line":1984,"range":{"start_line":1984,"start_character":6,"end_line":1984,"end_character":48},"updated":"2020-08-19 22:18:16.000000000","message":"add space around \u0027\u0026\u0027","commit_id":"9e339b1c4a08ce4ab75a9266102e90b0025c7841"},{"author":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"change_message_id":"55b131dd6e13c41f8fded8e692a74003ccb23afe","unresolved":false,"context_lines":[{"line_number":1981,"context_line":"\tretval \u003d cmsis_dap_cmd_DAP_SWO_Status(cmsis_dap_handle, \u0026trace_status, \u0026trace_count);"},{"line_number":1982,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":1983,"context_line":"\t\treturn retval;"},{"line_number":1984,"context_line":"\tif ((trace_status\u0026DAP_SWO_STATUS_CAPTURE_ACTIVE) !\u003d DAP_SWO_STATUS_CAPTURE_ACTIVE)"},{"line_number":1985,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":1986,"context_line":""},{"line_number":1987,"context_line":"\t*size \u003d trace_count \u003c *size ? trace_count : *size - 1;"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"eed59fcf_143dda8a","line":1984,"range":{"start_line":1984,"start_character":6,"end_line":1984,"end_character":48},"in_reply_to":"eed59fcf_14807a4a","updated":"2020-08-20 09:45:41.000000000","message":"Done","commit_id":"9e339b1c4a08ce4ab75a9266102e90b0025c7841"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"adc28c4bc1652007f2b068edd1287d41ad79ff1a","unresolved":false,"context_lines":[{"line_number":1996,"context_line":"\t\t\t\t\t\t\u0026buf[off]);"},{"line_number":1997,"context_line":"\t\tif (retval !\u003d ERROR_OK)"},{"line_number":1998,"context_line":"\t\t\treturn retval;"},{"line_number":1999,"context_line":"\t\tif ((trace_status\u0026DAP_SWO_STATUS_CAPTURE_ACTIVE) !\u003d DAP_SWO_STATUS_CAPTURE_ACTIVE)"},{"line_number":2000,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":2001,"context_line":""},{"line_number":2002,"context_line":"\t\toff +\u003d rb;"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"eed59fcf_34857e5b","line":1999,"range":{"start_line":1999,"start_character":7,"end_line":1999,"end_character":49},"updated":"2020-08-19 22:18:16.000000000","message":"add space around \u0027\u0026\u0027","commit_id":"9e339b1c4a08ce4ab75a9266102e90b0025c7841"},{"author":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"change_message_id":"55b131dd6e13c41f8fded8e692a74003ccb23afe","unresolved":false,"context_lines":[{"line_number":1996,"context_line":"\t\t\t\t\t\t\u0026buf[off]);"},{"line_number":1997,"context_line":"\t\tif (retval !\u003d ERROR_OK)"},{"line_number":1998,"context_line":"\t\t\treturn retval;"},{"line_number":1999,"context_line":"\t\tif ((trace_status\u0026DAP_SWO_STATUS_CAPTURE_ACTIVE) !\u003d DAP_SWO_STATUS_CAPTURE_ACTIVE)"},{"line_number":2000,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":2001,"context_line":""},{"line_number":2002,"context_line":"\t\toff +\u003d rb;"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"eed59fcf_34425e14","line":1999,"range":{"start_line":1999,"start_character":7,"end_line":1999,"end_character":49},"in_reply_to":"eed59fcf_34857e5b","updated":"2020-08-20 09:45:41.000000000","message":"Done","commit_id":"9e339b1c4a08ce4ab75a9266102e90b0025c7841"}],"src/jtag/drivers/libjaylink":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"88e2addd97f69280ca723f44a66d50458a4696f6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Subproject commit f73ad5e667ae8b26a52b847c603fdadaabf302a6"}],"source_content_type":"x-git/gitlink","patch_set":17,"id":"aedf27f1_a92351ff","line":1,"updated":"2021-05-19 10:31:44.000000000","message":"bad rebase! You reverted to old libjaylink","commit_id":"741d603ee1200d8b696ec91fe2ebf9d3adfb3092"}],"src/target/cortex_m.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"adc28c4bc1652007f2b068edd1287d41ad79ff1a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"#define ITM_TPR\t\t0xE0000E40"},{"line_number":37,"context_line":"#define ITM_TCR\t\t0xE0000E80"},{"line_number":38,"context_line":"#define ITM_LAR\t\t0xE0000FB0"},{"line_number":39,"context_line":"#define ITM_LSR\t\t0xE0000FB4"},{"line_number":40,"context_line":"#define ITM_LAR_KEY\t0xC5ACCE55"},{"line_number":41,"context_line":"#define ITM_TCR_ITMENA_BIT\t0"},{"line_number":42,"context_line":"#define ITM_TCR_BUSY_BIT\t23"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"#define SWO_LAR\t\t0xe0048FB0"},{"line_number":45,"context_line":"#define SWO_LSR\t\t0xe0048FB4"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"#define CPUID\t\t0xE000ED00"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":6,"id":"eed59fcf_34aedee5","line":46,"range":{"start_line":39,"start_character":0,"end_line":46,"end_character":0},"updated":"2020-08-19 22:18:16.000000000","message":"Why this patch for cmsis-dap swo includes these changes in cortex_m.h?\nNone of them is requested in the patch.\nCan you remove them and, if you need for other purpose, provide them in a separate patch?","commit_id":"9e339b1c4a08ce4ab75a9266102e90b0025c7841"},{"author":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"change_message_id":"55b131dd6e13c41f8fded8e692a74003ccb23afe","unresolved":false,"context_lines":[{"line_number":36,"context_line":"#define ITM_TPR\t\t0xE0000E40"},{"line_number":37,"context_line":"#define ITM_TCR\t\t0xE0000E80"},{"line_number":38,"context_line":"#define ITM_LAR\t\t0xE0000FB0"},{"line_number":39,"context_line":"#define ITM_LSR\t\t0xE0000FB4"},{"line_number":40,"context_line":"#define ITM_LAR_KEY\t0xC5ACCE55"},{"line_number":41,"context_line":"#define ITM_TCR_ITMENA_BIT\t0"},{"line_number":42,"context_line":"#define ITM_TCR_BUSY_BIT\t23"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"#define SWO_LAR\t\t0xe0048FB0"},{"line_number":45,"context_line":"#define SWO_LSR\t\t0xe0048FB4"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"#define CPUID\t\t0xE000ED00"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":6,"id":"eed59fcf_d4467226","line":46,"range":{"start_line":39,"start_character":0,"end_line":46,"end_character":0},"in_reply_to":"eed59fcf_34aedee5","updated":"2020-08-20 09:45:41.000000000","message":"Right. Will do","commit_id":"9e339b1c4a08ce4ab75a9266102e90b0025c7841"}]}