)]}'
{"id":"openocd~master~Ic1484665cd53afcccb5c20b152993a3f0407f8a2","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001765":{"account":{"_account_id":1001765,"name":"Kevin Yang","email":"kangyang@google.com","username":"kangyang_google"},"last_update":"2025-06-07 10:13:41.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ic1484665cd53afcccb5c20b152993a3f0407f8a2","subject":"target/armv8: Handle modeswitch for aarch32 secure EL3","status":"MERGED","created":"2020-10-12 20:41:29.000000000","updated":"2025-06-07 10:13:41.000000000","submitted":"2025-06-07 10:13:41.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"5854","meta_rev_id":"2b656bb2c3d47248755566f48b31f59b6b982cf5","_number":5854,"owner":{"_account_id":1001765,"name":"Kevin Yang","email":"kangyang@google.com","username":"kangyang_google"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1002342,"name":"Plamena Marinova","email":"pmarinova@hilscher.com","username":"pmarinova-hilscher"},{"tag":"autogenerated:gerrit:merged","value":0,"date":"2025-06-07 10:13:41.000000000","_account_id":1001765,"name":"Kevin Yang","email":"kangyang@google.com","username":"kangyang_google"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},{"value":0,"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-06-07 10:13:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-06-07 10:13:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002342,"name":"Plamena Marinova","email":"pmarinova@hilscher.com","username":"pmarinova-hilscher"},{"value":0,"_account_id":1001765,"name":"Kevin Yang","email":"kangyang@google.com","username":"kangyang_google"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-06-07 10:13:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-06-07 10:13:41.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},{"tag":"autogenerated:gerrit:merged","value":0,"date":"2025-06-07 10:13:41.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},{"_account_id":1001765,"name":"Kevin Yang","email":"kangyang@google.com","username":"kangyang_google"},{"_account_id":1002342,"name":"Plamena Marinova","email":"pmarinova@hilscher.com","username":"pmarinova-hilscher"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-10-12 21:50:43.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-10-15 18:48:14.000000000","updated_by":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"reviewer":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"state":"REVIEWER"},{"updated":"2021-03-10 20:40:43.000000000","updated_by":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"reviewer":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"state":"REVIEWER"},{"updated":"2024-12-03 08:04:04.000000000","updated_by":{"_account_id":1002342,"name":"Plamena Marinova","email":"pmarinova@hilscher.com","username":"pmarinova-hilscher"},"reviewer":{"_account_id":1002342,"name":"Plamena Marinova","email":"pmarinova@hilscher.com","username":"pmarinova-hilscher"},"state":"REVIEWER"},{"updated":"2025-06-04 09:46:20.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"ab742df82d49214c48793c0fdcf9f5468f58253c","author":{"_account_id":1001765,"name":"Kevin Yang","email":"kangyang@google.com","username":"kangyang_google"},"real_author":{"_account_id":1001765,"name":"Kevin Yang","email":"kangyang@google.com","username":"kangyang_google"},"date":"2020-10-12 20:41:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f4e98e7e725972d161b94416cddc61feafecb4b8","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2020-10-12 21:50:43.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/13425/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/12700/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"07f1df9ea4aecd95cc2bfc3dbc6f7b647269f00b","author":{"_account_id":1001765,"name":"Kevin Yang","email":"kangyang@google.com","username":"kangyang_google"},"real_author":{"_account_id":1001765,"name":"Kevin Yang","email":"kangyang@google.com","username":"kangyang_google"},"date":"2020-10-20 15:54:29.000000000","message":"Patch Set 1:\n\nAny thoughts on this one?","accounts_in_message":[],"_revision_number":1},{"id":"10b230dbdc864f4fe1bca4e2d4ed4a27e7b52dcd","author":{"_account_id":1001765,"name":"Kevin Yang","email":"kangyang@google.com","username":"kangyang_google"},"real_author":{"_account_id":1001765,"name":"Kevin Yang","email":"kangyang@google.com","username":"kangyang_google"},"date":"2020-11-02 21:16:56.000000000","message":"Patch Set 1:\n\nThis is the other change that fixes aarch32 usage. This one also prevents aarch32 from being used if there is secure EL3.","accounts_in_message":[],"_revision_number":1},{"id":"bece95873688e882a8febcdf27f063e59bb149a1","author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"real_author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"date":"2021-03-10 20:40:43.000000000","message":"Patch Set 1: Code-Review+1\n\nCan\u0027t test this at the moment, but it looks reasonable.","accounts_in_message":[],"_revision_number":1},{"id":"ed5b4caad42e870a43d5bca7c8b22748699df142","author":{"_account_id":1002342,"name":"Plamena Marinova","email":"pmarinova@hilscher.com","username":"pmarinova-hilscher"},"real_author":{"_account_id":1002342,"name":"Plamena Marinova","email":"pmarinova@hilscher.com","username":"pmarinova-hilscher"},"date":"2024-12-03 08:04:04.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"4db9ab0116f5a32c15c1d98fa5903d7c6e0b3750","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-06-04 09:46:20.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"2b656bb2c3d47248755566f48b31f59b6b982cf5","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-06-07 10:13:41.000000000","message":"Change has been successfully cherry-picked as d9b614a56db9ff08b349dc29f4b257c16a442013","accounts_in_message":[],"_revision_number":2}],"current_revision":"d9b614a56db9ff08b349dc29f4b257c16a442013","revisions":{"d9b614a56db9ff08b349dc29f4b257c16a442013":{"kind":"REWORK","_number":2,"created":"2025-06-07 10:13:41.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/54/5854/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/54/5854/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/54/5854/2 \u0026\u0026 git checkout -b change-5854 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/54/5854/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/54/5854/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/54/5854/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/54/5854/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/54/5854/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e23a6bbc635aa426668c040abda8c2d38628e8d4","subject":"tcl: fix broken Raspberry Pi website links"}],"author":{"name":"Kevin Yang","email":"kangyang@google.com","date":"2020-10-12 20:22:47.000000000","tz":-420},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-06-07 10:13:41.000000000","tz":0},"subject":"target/armv8: Handle modeswitch for aarch32 secure EL3","message":"target/armv8: Handle modeswitch for aarch32 secure EL3\n\nFor aarch32 secure EL3\n- Change target_el to 3 for SVC/ABT/IRQ/FIQ/UND/SYS for aarch32 secure\nEL3\n- Do not update SPSR for SYS, behavior is UNPREDICTABLE (ARMv8-A F5.1.121)\n- Do not execute DRPS for SYS, behavior is UNPREDICTABLE (ARMv8-A\nF5.1.51)\n\nChange-Id: Ic1484665cd53afcccb5c20b152993a3f0407f8a2\nSigned-off-by: Kevin Yang \u003ckangyang@google.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/5854\nTested-by: jenkins\nReviewed-by: Matthias Welwarsky \u003cmatthias@welwarsky.de\u003e\nReviewed-by: Plamena Marinova \u003cpmarinova@hilscher.com\u003e\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"2f01aa65204e7171d631b43715bbc48a9e018231":{"kind":"REWORK","_number":1,"created":"2020-10-12 20:41:29.000000000","uploader":{"_account_id":1001765,"name":"Kevin Yang","email":"kangyang@google.com","username":"kangyang_google"},"ref":"refs/changes/54/5854/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/54/5854/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/54/5854/1 \u0026\u0026 git checkout -b change-5854 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/54/5854/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/54/5854/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/54/5854/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/54/5854/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/54/5854/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"63b529ac3ac9dce92a4dd1ba9b57b1a96a030904","subject":"target/armv8: Handle halted aarch32"}],"author":{"name":"Kevin Yang","email":"kangyang@google.com","date":"2020-10-12 20:22:47.000000000","tz":-420},"committer":{"name":"Kevin Yang","email":"kangyang@google.com","date":"2020-10-12 20:22:47.000000000","tz":-420},"subject":"target/armv8: Handle modeswitch for aarch32 secure EL3","message":"target/armv8: Handle modeswitch for aarch32 secure EL3\n\nFor aarch32 secure EL3\n- Change target_el to 3 for SVC/ABT/IRQ/FIQ/UND/SYS for aarch32 secure\nEL3\n- Do not update SPSR for SYS, behavior is UNPREDICTABLE (ARMv8-A F5.1.121)\n- Do not execute DRPS for SYS, behavior is UNPREDICTABLE (ARMv8-A\nF5.1.51)\n\nChange-Id: Ic1484665cd53afcccb5c20b152993a3f0407f8a2\nSigned-off-by: Kevin Yang \u003ckangyang@google.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}