)]}'
{"id":"openocd~master~Ida679e5f4fec02d94ffb0bd3f265ed7ed2221cdc","project":"openocd","branch":"master","hashtags":[],"change_id":"Ida679e5f4fec02d94ffb0bd3f265ed7ed2221cdc","subject":"target/cortex_m,hla_target: rework Cortex-M register handling part 4","status":"MERGED","created":"2020-10-14 20:17:28.000000000","updated":"2021-09-27 08:19:02.000000000","submitted":"2020-11-15 21:06:45.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"5864-1605474405102-1a13cf1d","meta_rev_id":"f2c8c85c91cec82f8d17d9bead0645451c93909d","_number":5864,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":1,"date":"2020-11-15 21:06:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"value":2,"date":"2020-11-15 21:06:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":2,"date":"2020-11-15 21:06:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-10-25 07:59:03.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-11-15 21:06:45.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"136490f50850526afd16ce9f5bb2b97e1b183e7f","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2020-10-14 20:17:28.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"131222eb4c9ffb8c5d6163827b927057d5c3abbd","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2020-10-14 21:40:55.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttp://build.openocd.org/job/openocd-gerrit/13440/ : FAILURE\n\nhttp://build.openocd.org/job/openocd-gerrit-build/12715/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"162b282645a638c9c1356aeec8feac0927de962a","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2020-10-15 06:12:13.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"fce839513e2628be79d5c2aef6d5cd0b6ba5a733","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2020-10-15 08:10:37.000000000","message":"Patch Set 2: Verified-1\n\nBuild Failed \n\nhttp://build.openocd.org/job/openocd-gerrit-build/12720/ : FAILURE\n\nhttp://build.openocd.org/job/openocd-gerrit/13445/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"a001ef082310f2b4a1d90674c5206b1388655b46","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2020-10-15 08:28:28.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"942ed6b7d74e36ff958734e488f79097915c3939","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2020-10-15 08:37:14.000000000","message":"Patch Set 3:\n\nBuild Failed \n\nhttp://build.openocd.org/job/openocd-gerrit-build/12721/ : FAILURE\n\nhttp://build.openocd.org/job/openocd-gerrit/13446/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"b2d0d6584cc090073dad4b8b8a49f0ac5bd67d7d","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2020-10-15 10:19:01.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"bea5d76eb20dca782efd5dce20b226e9d639bab3","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2020-10-15 12:41:36.000000000","message":"Patch Set 4: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/13452/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/12727/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"fde8b27723a28b673e4922f09f5e230db5b6bc62","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2020-10-21 14:03:43.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"2aa82e1890415cd32272e4f528eff10c939956aa","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2020-10-22 10:46:00.000000000","message":"Patch Set 4:\n\nAntonio, can you confirm that ST-Link does not support reading/writing FP registers? Do not functions stlink_usb_read_reg/stlink_usb_write_reg() expect something else than DCRSR.REGSEL values?","accounts_in_message":[],"_revision_number":4},{"id":"ae9de984add321b6d8b5afd0aa58c7dbcacbc9f3","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2020-10-22 11:09:30.000000000","message":"Patch Set 4:\n\n\u003e Antonio, can you confirm that ST-Link does not support\n \u003e reading/writing FP registers? Do not functions stlink_usb_read_reg/stlink_usb_write_reg()\n \u003e expect something else than DCRSR.REGSEL values?\n\nI never checked before this part of the specs.\nActually there is a dedicated API (from v2j15) to read all FPU registers in one shot, including FPSCR!\nPlus, the usual API for read/write registers (0x33 and 0x34) support FPU regs. To functions -\u003eread_reg() and -\u003ewrite_reg(), pass num:\n\"from 0 to 0x14 for core registers, 0x21 for FPSCR on target with FPU, from 0x40 to 0x5F on target with FPU\".\n\nProblem is that today we have 3 HLA adapters, not only ST-Link; nulink_usb.c and ti_icdi_usb.c.\nWe need to check with their respective developers.","accounts_in_message":[],"_revision_number":4},{"id":"6511b4f584d5a0f327efdb0b3184424696d0e409","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2020-10-22 11:53:38.000000000","message":"Patch Set 4:\n\n\u003e Plus, the usual API for read/write registers (0x33 and 0x34)\n \u003e support FPU regs. To functions -\u003eread_reg() and -\u003ewrite_reg(), pass\n \u003e num:\n \u003e \"from 0 to 0x14 for core registers, 0x21 for FPSCR on target with\n \u003e FPU, from 0x40 to 0x5F on target with FPU\".\n \u003e \n \u003e Problem is that today we have 3 HLA adapters, not only ST-Link;\n \u003e nulink_usb.c and ti_icdi_usb.c.\n \u003e We need to check with their respective developers.\n\nThanks!\nI asked especially for ST-Link because I originally used -\u003eread_reg() for FP\nand it did not work on ST-Link (probably v2j28)?!\nSo let\u0027s merge this one as is (should work with any hla) and we can optionally switch to the adapter r/w reg API if all hla support it.","accounts_in_message":[],"_revision_number":4},{"id":"c97ada06dbb00736ba962c58130398845a6a878f","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2020-10-22 12:03:33.000000000","message":"Patch Set 4:\n\n\u003e So let\u0027s merge this one as is (should work with any hla) and we can\n \u003e optionally switch to the adapter r/w reg API if all hla support it.\n\nAgree!","accounts_in_message":[],"_revision_number":4},{"id":"b130568666ab67ac57cb3f6557b860935f8d58f2","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2020-10-25 07:26:29.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"14a8c0abce1cb533fae9f07d1cbea7db95e5944b","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2020-10-25 07:47:05.000000000","message":"Patch Set 5:\n\nAntonio, thanks for you effort getting info on ti-icdi and nulink api.\n\nIn this patcheset I changed the hla part to use register read/write api for all registers including FP.\n\nI tested it on ST-Link V2J29S0 on STM32L4R5 nucleo and also with the same ST-Link fw version connected to Kinetis K22 (to be sure that FP support in ST-Link is not enabled based on STM32 specific chip identification)","accounts_in_message":[],"_revision_number":5},{"id":"d3d983fe17b65e56ebfba877f0f866332ae55060","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2020-10-25 07:59:03.000000000","message":"Patch Set 5: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/13494/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/12769/ : SUCCESS","accounts_in_message":[],"_revision_number":5},{"id":"6c8f9c363403debcbf3d631de86d153bc20ae48b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2020-10-25 14:13:44.000000000","message":"Patch Set 5: Code-Review+1\n\nTested OK on boards:\n- NK-M483KG (nulink + Cortex-M4F based nuvoton M483KG);\n- EK-TM4C1294XL (ti-icdi + Cortex-M4F based TI TM4C1294NCPD).","accounts_in_message":[],"_revision_number":5},{"id":"6d4a75aee80f2ad9b0a71531499900f75dea45c3","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2020-10-25 14:43:50.000000000","message":"Patch Set 5:\n\nFailed on ST-Link V1!\nInfo : STLINK V1J13S3 (API v2) VID:PID 0483:3744\nI will ask ST-Link developers if they still keep some knowledge on this obsoleted device. And also if some old version of stlink v2 has this issue too.\nAnyway, I prefer to set this V1 handling as a special case inside stlink driver and keep this patch as is. Please wait few days before merging it to let me check.","accounts_in_message":[],"_revision_number":5},{"id":"652bc8ade7c39880f049baafdcee0d8b998e748f","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2020-11-08 09:49:35.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"e403db524b0dfc282cf09f4fe414b53a565f8324","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2020-11-15 21:06:43.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"a89f127010abc6e6fed68bd1ec95b3168326f15e","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2020-11-15 21:06:45.000000000","message":"Change has been successfully cherry-picked as 62394a6b1c25ac92630a4828ec1b5d70acfe6e0f by Antonio Borneo","accounts_in_message":[],"_revision_number":6},{"id":"f2c8c85c91cec82f8d17d9bead0645451c93909d","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-09-27 08:19:02.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6}],"current_revision":"62394a6b1c25ac92630a4828ec1b5d70acfe6e0f","revisions":{"f298cbc3555b7b405ee97fc09e69e03ce82ec78b":{"kind":"REWORK","_number":5,"created":"2020-10-25 07:26:29.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/64/5864/5","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/64/5864/5","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/64/5864/5 \u0026\u0026 git checkout -b change-5864 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/64/5864/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/64/5864/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/64/5864/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/64/5864/5","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/64/5864/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1f05a2bf227295857f8014908b56975c2f16df45","subject":"target/armv7m: rework Cortex-M register handling part 3"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2020-10-14 19:03:02.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2020-10-25 07:23:48.000000000","tz":60},"subject":"target/cortex_m,hla_target: rework Cortex-M register handling part 4","message":"target/cortex_m,hla_target: rework Cortex-M register handling part 4\n\nConsolidate low level register read/write.\n\nFloating point registers were handled by target_read/write_u32\nunlike other registers handled by cortexm_dap_read/write_coreregister_u32\nThere is no reason to do so in cortex_m.\nRemove cortexm_dap_read/write_coreregister_u32\nand use cortex_m_load/store_core_reg_u32 directly.\n\nSimilarly HLA adapters register read/write interface supports all registers\nso use it for any floating point and other registers.\n\nChange-Id: Ida679e5f4fec02d94ffb0bd3f265ed7ed2221cdc\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"d30e056ba3231fa533e11f3d0f2513387168f6e1":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2020-10-15 10:19:01.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/64/5864/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/64/5864/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/64/5864/4 \u0026\u0026 git checkout -b change-5864 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/64/5864/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/64/5864/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/64/5864/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/64/5864/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/64/5864/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1f05a2bf227295857f8014908b56975c2f16df45","subject":"target/armv7m: rework Cortex-M register handling part 3"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2020-10-14 19:03:02.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2020-10-15 10:18:34.000000000","tz":120},"subject":"target/cortex_m,hla_target: rework Cortex-M register handling part 4","message":"target/cortex_m,hla_target: rework Cortex-M register handling part 4\n\nConsolidate low level register read/write.\n\nFloating point registers were handled by target_read/write_u32\nunlike other registers handled by cortexm_dap_read/write_coreregister_u32\nThere is no reason to do so in cortex_m.\nRemove cortexm_dap_read/write_coreregister_u32\nand use cortex_m_load/store_core_reg_u32 directly.\n\nHLA adapter register read/write interface supports base registers\nonly so keep using target_read/write_u32 for any floating point\nand other registers.\n\nChange-Id: Ida679e5f4fec02d94ffb0bd3f265ed7ed2221cdc\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"62394a6b1c25ac92630a4828ec1b5d70acfe6e0f":{"kind":"REWORK","_number":6,"created":"2020-11-15 21:06:45.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/64/5864/6","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/64/5864/6","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/64/5864/6 \u0026\u0026 git checkout -b change-5864 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/64/5864/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/64/5864/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/64/5864/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/64/5864/6","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/64/5864/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d3a37b0e76ece5625db74b4f343ebcc90059657f","subject":"target/armv7m: rework Cortex-M register handling part 3"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2020-10-14 19:03:02.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2020-11-15 21:06:45.000000000","tz":0},"subject":"target/cortex_m,hla_target: rework Cortex-M register handling part 4","message":"target/cortex_m,hla_target: rework Cortex-M register handling part 4\n\nConsolidate low level register read/write.\n\nFloating point registers were handled by target_read/write_u32\nunlike other registers handled by cortexm_dap_read/write_coreregister_u32\nThere is no reason to do so in cortex_m.\nRemove cortexm_dap_read/write_coreregister_u32\nand use cortex_m_load/store_core_reg_u32 directly.\n\nSimilarly HLA adapters register read/write interface supports all registers\nso use it for any floating point and other registers.\n\nChange-Id: Ida679e5f4fec02d94ffb0bd3f265ed7ed2221cdc\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: http://openocd.zylin.com/5864\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"28cd327ccc45fc6a1dbac3f3f558c0e7e149a28b":{"kind":"REWORK","_number":1,"created":"2020-10-14 20:17:28.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/64/5864/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/64/5864/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/64/5864/1 \u0026\u0026 git checkout -b change-5864 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/64/5864/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/64/5864/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/64/5864/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/64/5864/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/64/5864/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4be02b1fb2ed24af55d54a0d4d248a6d236671d9","subject":"target/armv7m: rework Cortex-M register handling part 3"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2020-10-14 19:03:02.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2020-10-14 20:16:46.000000000","tz":120},"subject":"target/cortex_m,hla_target: rework Cortex-M register handling part 4","message":"target/cortex_m,hla_target: rework Cortex-M register handling part 4\n\nConsolidate low level register read/write.\n\nFloating point registers were handled by target_read/write_u32\nunlike other registers handled by cortexm_dap_read/write_coreregister_u32\nThere is no reason to do so in cortex_m.\nRemove cortexm_dap_read/write_coreregister_u32\nand use cortex_m_load/store_core_reg_u32 directly.\n\nHLA adapter register read/write interface supports base registers\nonly so keep using target_read/write_u32 for any floating point\nand other registers.\n\nChange-Id: Ida679e5f4fec02d94ffb0bd3f265ed7ed2221cdc\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"17fb7f98f97ce517e476e5235d57a093a18df410":{"kind":"REWORK","_number":3,"created":"2020-10-15 08:28:28.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/64/5864/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/64/5864/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/64/5864/3 \u0026\u0026 git checkout -b change-5864 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/64/5864/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/64/5864/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/64/5864/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/64/5864/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/64/5864/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"14b659856fd4cd7466f675fb32bc09931ca33070","subject":"target/armv7m: rework Cortex-M register handling part 3"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2020-10-14 19:03:02.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2020-10-15 08:24:16.000000000","tz":120},"subject":"target/cortex_m,hla_target: rework Cortex-M register handling part 4","message":"target/cortex_m,hla_target: rework Cortex-M register handling part 4\n\nConsolidate low level register read/write.\n\nFloating point registers were handled by target_read/write_u32\nunlike other registers handled by cortexm_dap_read/write_coreregister_u32\nThere is no reason to do so in cortex_m.\nRemove cortexm_dap_read/write_coreregister_u32\nand use cortex_m_load/store_core_reg_u32 directly.\n\nHLA adapter register read/write interface supports base registers\nonly so keep using target_read/write_u32 for any floating point\nand other registers.\n\nChange-Id: Ida679e5f4fec02d94ffb0bd3f265ed7ed2221cdc\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"d4de79c4e56066c1d5989316de11d79ffe5a4945":{"kind":"REWORK","_number":2,"created":"2020-10-15 06:12:13.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/64/5864/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/64/5864/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/64/5864/2 \u0026\u0026 git checkout -b change-5864 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/64/5864/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/64/5864/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/64/5864/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/64/5864/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/64/5864/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"30cef06ee49db240b8db91eeb90a1ce6f9518591","subject":"target/armv7m: rework Cortex-M register handling part 3"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2020-10-14 19:03:02.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2020-10-15 05:59:07.000000000","tz":120},"subject":"target/cortex_m,hla_target: rework Cortex-M register handling part 4","message":"target/cortex_m,hla_target: rework Cortex-M register handling part 4\n\nConsolidate low level register read/write.\n\nFloating point registers were handled by target_read/write_u32\nunlike other registers handled by cortexm_dap_read/write_coreregister_u32\nThere is no reason to do so in cortex_m.\nRemove cortexm_dap_read/write_coreregister_u32\nand use cortex_m_load/store_core_reg_u32 directly.\n\nHLA adapter register read/write interface supports base registers\nonly so keep using target_read/write_u32 for any floating point\nand other registers.\n\nChange-Id: Ida679e5f4fec02d94ffb0bd3f265ed7ed2221cdc\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}