)]}'
{"id":"openocd~master~Ia9f63f56b508688e74278b022eaec47e503916e7","project":"openocd","branch":"master","hashtags":[],"change_id":"Ia9f63f56b508688e74278b022eaec47e503916e7","subject":"stm32h7x: Fix reset with non-HLA interfaces on macOS","status":"MERGED","created":"2020-10-20 16:56:47.000000000","updated":"2020-11-07 20:52:46.000000000","submitted":"2020-11-07 20:52:46.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"5872-1604782366701-60fc6f66","meta_rev_id":"0f1d56f8749c3b5163b5a0a5b0819288c2611602","_number":5872,"owner":{"_account_id":1001826,"name":"Alberto García Hierro","email":"alberto@garciahierro.com","username":"fiam"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001826,"name":"Alberto García Hierro","email":"alberto@garciahierro.com","username":"fiam"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":1,"date":"2020-11-07 20:52:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000716,"name":"Christopher Head","email":"chead@zaber.com","username":"Hawk777"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"value":0,"_account_id":1001826,"name":"Alberto García Hierro","email":"alberto@garciahierro.com","username":"fiam"},{"value":2,"date":"2020-11-07 20:52:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":1,"date":"2020-11-07 20:52:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"value":1,"date":"2020-11-07 20:52:46.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000716,"name":"Christopher Head","email":"chead@zaber.com","username":"Hawk777"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000716,"name":"Christopher Head","email":"chead@zaber.com","username":"Hawk777"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"_account_id":1001826,"name":"Alberto García Hierro","email":"alberto@garciahierro.com","username":"fiam"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-10-26 23:07:56.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-11-03 01:20:40.000000000","updated_by":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"reviewer":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"state":"REVIEWER"},{"updated":"2020-11-05 19:49:00.000000000","updated_by":{"_account_id":1000716,"name":"Christopher Head","email":"chead@zaber.com","username":"Hawk777"},"reviewer":{"_account_id":1000716,"name":"Christopher Head","email":"chead@zaber.com","username":"Hawk777"},"state":"REVIEWER"},{"updated":"2020-11-07 20:52:46.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"7452314b17d232c2a3721b00f80c76a532a972bb","author":{"_account_id":1001826,"name":"Alberto García Hierro","email":"alberto@garciahierro.com","username":"fiam"},"real_author":{"_account_id":1001826,"name":"Alberto García Hierro","email":"alberto@garciahierro.com","username":"fiam"},"date":"2020-10-20 16:56:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7dc90ae9f6eff188a7d4b092d5527f363b248a51","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2020-10-20 17:32:45.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/13468/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/12743/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"e043d2f56f8172624ef46fddb1e5801a1b8c3202","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2020-10-20 22:04:39.000000000","message":"Patch Set 1:\n\nLooks like you have found a bug in jimtcl!\nCan you provide a TCL regexp that fails on macOS? What result you get?\n\nCan you also try the latest head-of-tree of jimtcl?\nAfter run \"./bootstrap\"\ncd jimtcl\ngit remote update\ngit checkout origin/master\ncd ..\nThen the usual ./configure and make.","accounts_in_message":[],"_revision_number":1},{"id":"1eb5bfb666ef396c5880fb40f924f8ada17037d5","author":{"_account_id":1001826,"name":"Alberto García Hierro","email":"alberto@garciahierro.com","username":"fiam"},"real_author":{"_account_id":1001826,"name":"Alberto García Hierro","email":"alberto@garciahierro.com","username":"fiam"},"date":"2020-10-24 19:27:06.000000000","message":"Patch Set 1:\n\n\u003e Looks like you have found a bug in jimtcl!\n \u003e Can you provide a TCL regexp that fails on macOS? What result you\n \u003e get?\n \u003e \n \u003e Can you also try the latest head-of-tree of jimtcl?\n \u003e After run \"./bootstrap\"\n \u003e cd jimtcl\n \u003e git remote update\n \u003e git checkout origin/master\n \u003e cd ..\n \u003e Then the usual ./configure and make.\n\nIt\u0027s indeed a bug in jimtcl, good catch! Updating the submodule to use  master from https://github.com/msteveb/jimtcl does fix the problem too (I added some puts in stm32h7x.cfg to check that the regsub does return the correct value). I think, however, that it would be a good thing to refactor the code for retrieving the CHIPNAME into a function. Would you prefer the approach in this patch or do you think updating jimtcl and continuing to use the regex is better?\n\nLet me add that I couldn\u0027t reproduce it with an isolated simple test case like:\n\n\u003e cat t.tcl\nset _CHIPNAME [regsub \".(cpu|ap)\\\\d*$\" \"stm32h7x.cpu0\" \"\"]\nputs $_CHIPNAME\n\nThis prints \"\"stm32h7x\" correctly in both jimtcl from master and in 0.79, so I guess the bug needs something more elaborate in order to trigger.","accounts_in_message":[],"_revision_number":1},{"id":"b4705ba89ed1011d77e9f479d6f73ecb22f4edb2","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2020-10-24 21:16:48.000000000","message":"Patch Set 1:\n\nthanks Alberto !\n\nin change http://openocd.zylin.com/5403 we switched to jimtcl 0.79\nso this should be ok.\nunless jimtcl is not built with openocd\nwhat do you think Antonio and Alberto ?","accounts_in_message":[],"_revision_number":1},{"id":"a235ffcf7372e8af331bec2cbe924c852287dd22","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2020-10-24 21:50:08.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nI would like to sort out the issue and fix it in jimtcl.\nIf it appears today in this file, it could break other scripts too.\nThen, if we need a workaround in OpenOCD until jimtcl get fixed, that\u0027s another story.\n\nAlberto, I cannot replicate anything incorrect.\nCan you please report the wrong output you get with the expression in the script?\nOn my Linux PC I get exactly the same output from jimtcl 0.77, 0.79 and master branch.\nMaybe it\u0027s an odd combination of jimtcl and GCC. What GCC version are you using? (post first line of \u0027gcc --version\u0027). Is your MAC based on intel x86 or some old big-endian PowerPC?","accounts_in_message":[],"_revision_number":1},{"id":"5ee30516679f7bbe86d802893bfffce081f36c47","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2020-10-25 01:11:13.000000000","message":"Patch Set 1:\n\n(2 comments)\n\n\u003e Updating the submodule to use  master from https://github.com/msteveb/jimtcl does fix the problem too\n\nif I understood well, it\u0027s already fixed in jimtcl master.\nIMO, i don\u0027t like changing jimtcl before the 0.11. so I prefer having the cfg fix\n\nFTR, I have detected some issues in external memories change by Andreas (in macos) with cfg files but these got fixed by the jimtcl 0.79.","accounts_in_message":[],"_revision_number":1},{"id":"f6ce0cfc4b324d79b0ebcb2e95250a89c050d970","author":{"_account_id":1001826,"name":"Alberto García Hierro","email":"alberto@garciahierro.com","username":"fiam"},"real_author":{"_account_id":1001826,"name":"Alberto García Hierro","email":"alberto@garciahierro.com","username":"fiam"},"date":"2020-10-25 10:29:44.000000000","message":"Patch Set 1:\n\nJust to clarify, I do get this error using 4fc61a2f9d60e49b8134ab7e0929cfb2b3a4f771, which is already using jimtcl 0.79\n\nError executing event examine-end on target stm32h7x.cpu0:\n/usr/local/Cellar/open-ocd/HEAD-4fc61a2/share/openocd/scripts/target/stm32h7x.cfg:199: Error: invalid command name \"stm32h7x.cpu0.ap2\"\nin procedure \u0027stm32h7x_dbgmcu_mmw\u0027 called at file \"/usr/local/Cellar/open-ocd/HEAD-4fc61a2/share/openocd/scripts/target/stm32h7x.cfg\", line 149\nin procedure \u0027stm32h7x_mmw\u0027 called at file \"/usr/local/Cellar/open-ocd/HEAD-4fc61a2/share/openocd/scripts/target/stm32h7x.cfg\", line 224\nin procedure \u0027stm32h7x_mrw\u0027 called at file \"/usr/local/Cellar/open-ocd/HEAD-4fc61a2/share/openocd/scripts/target/stm32h7x.cfg\", line 205\nat file \"/usr/local/Cellar/open-ocd/HEAD-4fc61a2/share/openocd/scripts/target/stm32h7x.cfg\", line 199\n\nThis is caused because the regsub returns \"stm32h7.cpu0\" instead of \"stm32h7x\", causing the script to try to use \"stm32h7x.cpu0.ap2\" instead of \"stm32h7x.ap2\".\n\nI did verify the return value from [target current] and it does return \"stm32h7x.cpu0\" as it should (it could be returning e.g. stm32h7x.cpu0.cpu0, and then a correct execution of regsub would yield stm32h7x.cpu0, but that\u0027s not the case). Also, fiddling with the regular expression, I got OpenOCD to abort() with several valid regular expressions (I\u0027d assume from a bug in jimtcl 0.79)\n\nI tried to reproduce the problem with this minimal test case and jimsh, but I can\u0027t reproduce the problem in jimtcl 0.79 nor 0.77 nor master. I prints \"stm32h7x\" in all cases.\n\nproc current {} {\n    return \"stm32h7x.cpu0\"\n}\nset _CHIPNAME [regsub \".(cpu|ap)\\\\d*$\" [current] \"\"] \nputs $_CHIPNAME","accounts_in_message":[],"_revision_number":1},{"id":"7e49a1590fefafd6190f674ee3164957742dac11","author":{"_account_id":1001826,"name":"Alberto García Hierro","email":"alberto@garciahierro.com","username":"fiam"},"real_author":{"_account_id":1001826,"name":"Alberto García Hierro","email":"alberto@garciahierro.com","username":"fiam"},"date":"2020-10-25 10:31:25.000000000","message":"Patch Set 1:\n\nSorry, I forgot to mention I\u0027m using an Intel based Apple computer, running macOS 10.15 (Catalina)","accounts_in_message":[],"_revision_number":1},{"id":"ea6cb8fadcb851f571c6b206a8eeb03277d8847e","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2020-10-26 15:46:00.000000000","message":"Patch Set 1: Code-Review+1\n\nLGTM\nIMO maybe could be enhanced by changing the name of \u0027stm32h7x_chipname\u0027 to \u0027stm32h7x_get_chipname\u0027 or \u0027stm32h7x_extract_chipname\u0027\nbut it could be a personal taste ...\nAntonio, do you think ?","accounts_in_message":[],"_revision_number":1},{"id":"796a735b8b6a5c2ed892bf666c7c46a95f1f39ca","author":{"_account_id":1001826,"name":"Alberto García Hierro","email":"alberto@garciahierro.com","username":"fiam"},"real_author":{"_account_id":1001826,"name":"Alberto García Hierro","email":"alberto@garciahierro.com","username":"fiam"},"date":"2020-10-26 16:11:30.000000000","message":"Patch Set 1:\n\nThanks for the review!\n\n\u003e maybe could be enhanced by changing the name of \u0027stm32h7x_chipname\u0027 to \u0027stm32h7x_get_chipname\u0027 or \u0027stm32h7x_extract_chipname\u0027\n\nI agree, I\u0027ll change it today. Which one do you prefer, \u0027get\u0027 or \u0027extract\u0027?","accounts_in_message":[],"_revision_number":1},{"id":"4c39e8f38066208c4f37540810dbc1f5e45b3963","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2020-10-26 17:25:35.000000000","message":"Patch Set 1:\n\n\u003e LGTM\n \u003e  ...\n \u003e Antonio, do you think ?\nYes, let\u0027s add the workaround and make the code more readable.\nBut I\u0027m still scared about a bug in jimtcl that we cannot replicate nor fix!","accounts_in_message":[],"_revision_number":1},{"id":"caa53e65a5bf53332321262942b7718f6f497e5e","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2020-10-26 18:12:26.000000000","message":"Patch Set 1:\n\nAntonio, I have a team mac running catalina as far as i can remember.\nI can try to replicate by Wednesday.\nfurthermore I remember I have senn several fixes in jimtcl regarding UTF-8.\nI will try using jimtcl head as well.","accounts_in_message":[],"_revision_number":1},{"id":"48a5bb3c01b4984f75e550e0f1a1ef5f2a37b93e","author":{"_account_id":1001826,"name":"Alberto García Hierro","email":"alberto@garciahierro.com","username":"fiam"},"real_author":{"_account_id":1001826,"name":"Alberto García Hierro","email":"alberto@garciahierro.com","username":"fiam"},"date":"2020-10-26 22:34:29.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"b693de5d917b6e05213b2cb76f9654454bd20f21","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2020-10-26 23:07:56.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/13515/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/12789/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"e9bc9698891266339764d473b60a98a9f2c65a37","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2020-11-03 01:20:40.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"af27b9f2065f60251dffa5f3647c1768526cec6b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2020-11-04 23:00:52.000000000","message":"Patch Set 2: Code-Review+1\n\nWould be good if someone can check if the issue is in jimtcl or in openocd.\nrunning\n./jimtcl/jimsh -e \u0027set src xx.cpu0;regsub \".(cpu|ap)\\\\d*$\" $src \"\"\u0027\nif result is \"xx\", then jimtcl is ok, so bug in openocd\nif result is \"xx.cpu0\", then jimtcl has bug","accounts_in_message":[],"_revision_number":2},{"id":"d8ede34197664c2902cca16afacb248fd37d25fe","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2020-11-05 07:11:24.000000000","message":"Patch Set 2:\n\nAntonio,  i have tested (2 days ago) on MacOS High Sierra \nand I confirm the issue is in jimtcl","accounts_in_message":[],"_revision_number":2},{"id":"871d2b759d27b4f5a4f224cd383fe830d12c7e84","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2020-11-05 09:04:31.000000000","message":"Patch Set 2:\n\nThe repository for jimtcl we use is https://repo.or.cz/jimtcl.git/\nThis is not updated since July 31, 2020\nThe official repository is https://github.com/msteveb/jimtcl\nwhere there are several updates, the new release 0.80 and one interesting fix\nhttps://github.com/msteveb/jimtcl/issues/163\nbut this fix is also the last commit taken by https://repo.or.cz/jimtcl.git/\n\nCan you please check the master branch on github?\nIf you don\u0027t know how to add and use it, here is the sequence\n./bootstrap\ncd jimtcl\ngit remote add github https://github.com/msteveb/jimtcl.git\ngit checkout github/master\ncd ..\n./configure\nmake\n\nYou probably also need http://openocd.zylin.com/5922/ to complete the build. At least on Arch Linux I need it to link the new jimtcl in openocd.","accounts_in_message":[],"_revision_number":2},{"id":"2f42e9f484470251362caa7d9bbfcb03e8786066","author":{"_account_id":1000716,"name":"Christopher Head","email":"chead@zaber.com","username":"Hawk777"},"real_author":{"_account_id":1000716,"name":"Christopher Head","email":"chead@zaber.com","username":"Hawk777"},"date":"2020-11-05 19:49:00.000000000","message":"Patch Set 2: Code-Review+1\n\nI have no thoughts on whether we *should* do this or not, but I have no objections, tested and works fine for me, code looks good. I don’t mind regexps but I also don’t mind explicit string manipulation.","accounts_in_message":[],"_revision_number":2},{"id":"25cfa1751ed09815b964df48f873ac215ecb3cd0","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2020-11-07 20:52:43.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"0f1d56f8749c3b5163b5a0a5b0819288c2611602","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2020-11-07 20:52:46.000000000","message":"Change has been successfully cherry-picked as 535f5309ba1277479d44f471655bf722e32fbb6b by Antonio Borneo","accounts_in_message":[],"_revision_number":3}],"current_revision":"535f5309ba1277479d44f471655bf722e32fbb6b","revisions":{"535f5309ba1277479d44f471655bf722e32fbb6b":{"kind":"REWORK","_number":3,"created":"2020-11-07 20:52:46.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/72/5872/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/72/5872/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/72/5872/3 \u0026\u0026 git checkout -b change-5872 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/72/5872/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/72/5872/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/72/5872/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/72/5872/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/72/5872/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"92ea7e41b9261d4d7a88d96cc3ef0a727d1059f0","subject":"target: Examine subsequent targets after failure"}],"author":{"name":"Alberto García Hierro","email":"alberto@garciahierro.com","date":"2020-10-20 15:13:17.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2020-11-07 20:52:46.000000000","tz":0},"subject":"stm32h7x: Fix reset with non-HLA interfaces on macOS","message":"stm32h7x: Fix reset with non-HLA interfaces on macOS\n\nregsub doesn\u0027t work correctly on macOS Catalina, which results in\nan incorrect CHIPNAME derived from the current target. Since regsub\nis only used by this target, replace it with a simple string search\nfor \u0027.\u0027 followed by a substring. This is funcionally equivalent to\nwhat the regular expression was doing, but instead relies in simpler\nstring operations that should have little to no differences\nbetween systems.\n\nAlso, refactor CHIPNAME detection into proc stm32h7x_chipname, so\nit\u0027s always retrieved in the same way without duplicating the code.\n\nChange-Id: Ia9f63f56b508688e74278b022eaec47e503916e7\nSigned-off-by: Alberto Garcia Hierro \u003calberto@garciahierro.com\u003e\nReviewed-on: http://openocd.zylin.com/5872\nTested-by: jenkins\nReviewed-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\nReviewed-by: Christopher Head \u003cchead@zaber.com\u003e\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"8a01797d65c29b48019b15b54e95e9a3723838b8":{"kind":"REWORK","_number":2,"created":"2020-10-26 22:34:29.000000000","uploader":{"_account_id":1001826,"name":"Alberto García Hierro","email":"alberto@garciahierro.com","username":"fiam"},"ref":"refs/changes/72/5872/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/72/5872/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/72/5872/2 \u0026\u0026 git checkout -b change-5872 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/72/5872/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/72/5872/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/72/5872/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/72/5872/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/72/5872/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9e2a0effb2b7b933db00543f1e6879541707a2f3","subject":"server/telnet: Handle Ctrl+K"}],"author":{"name":"Alberto García Hierro","email":"alberto@garciahierro.com","date":"2020-10-20 15:13:17.000000000","tz":60},"committer":{"name":"Alberto García Hierro","email":"alberto@garciahierro.com","date":"2020-10-26 22:34:23.000000000","tz":0},"subject":"stm32h7x: Fix reset with non-HLA interfaces on macOS","message":"stm32h7x: Fix reset with non-HLA interfaces on macOS\n\nregsub doesn\u0027t work correctly on macOS Catalina, which results in\nan incorrect CHIPNAME derived from the current target. Since regsub\nis only used by this target, replace it with a simple string search\nfor \u0027.\u0027 followed by a substring. This is funcionally equivalent to\nwhat the regular expression was doing, but instead relies in simpler\nstring operations that should have little to no differences\nbetween systems.\n\nAlso, refactor CHIPNAME detection into proc stm32h7x_chipname, so\nit\u0027s always retrieved in the same way without duplicating the code.\n\nChange-Id: Ia9f63f56b508688e74278b022eaec47e503916e7\nSigned-off-by: Alberto Garcia Hierro \u003calberto@garciahierro.com\u003e\n"}},"7a108b04e546e72c8ce183c5dd5833d89993a7d1":{"kind":"REWORK","_number":1,"created":"2020-10-20 16:56:47.000000000","uploader":{"_account_id":1001826,"name":"Alberto García Hierro","email":"alberto@garciahierro.com","username":"fiam"},"ref":"refs/changes/72/5872/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/72/5872/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/72/5872/1 \u0026\u0026 git checkout -b change-5872 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/72/5872/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/72/5872/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/72/5872/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/72/5872/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/72/5872/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4fc61a2f9d60e49b8134ab7e0929cfb2b3a4f771","subject":"riscv: fix compile error"}],"author":{"name":"Alberto García Hierro","email":"alberto@garciahierro.com","date":"2020-10-20 15:13:17.000000000","tz":60},"committer":{"name":"Alberto García Hierro","email":"alberto@garciahierro.com","date":"2020-10-20 16:56:26.000000000","tz":60},"subject":"stm32h7x: Fix reset with non-HLA interfaces on macOS","message":"stm32h7x: Fix reset with non-HLA interfaces on macOS\n\nregsub doesn\u0027t work correctly on macOS Catalina, which results in\nan incorrect CHIPNAME derived from the current target. Since regsub\nis only used by this target, replace it with a simple string search\nfor \u0027.\u0027 followed by a substring. This is funcionally equivalent to\nwhat the regular expression was doing, but instead relies in simpler\nstring operations that should have little to no differences\nbetween systems.\n\nAlso, refactor CHIPNAME detection into proc stm32h7x_chipname, so\nit\u0027s always retrieved in the same way without duplicating the code.\n\nChange-Id: Ia9f63f56b508688e74278b022eaec47e503916e7\nSigned-off-by: Alberto Garcia Hierro \u003calberto@garciahierro.com\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}