)]}'
{"src/flash/nor/stm32l4x.c":[{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"822a5529dffd7723106d6ab393204fafff98bfdb","unresolved":false,"context_lines":[{"line_number":1035,"context_line":"\t4. Wait for the BSY bit to be cleared"},{"line_number":1036,"context_line":"\t */"},{"line_number":1037,"context_line":""},{"line_number":1038,"context_line":"\tconst uint32_t flash_cr_bker \u003d (stm32l4_info-\u003epart_info-\u003eflags \u0026 F_HAS_G0_BKER) ?"},{"line_number":1039,"context_line":"\t\t\tFLASH_CR_BKER_G0 : FLASH_CR_BKER;"},{"line_number":1040,"context_line":""},{"line_number":1041,"context_line":"\tfor (unsigned int i \u003d first; i \u003c\u003d last; i++) {"},{"line_number":1042,"context_line":"\t\tuint32_t erase_flags;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"ceda9b01_cddd7ee3","line":1039,"range":{"start_line":1038,"start_character":1,"end_line":1039,"end_character":36},"updated":"2021-01-30 21:23:16.000000000","message":"do you prefer using the flags or just test on the device id ?","commit_id":"5551417b01fb84276e1a84630edaca85ec4abd22"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"35952f35248ef7df9e7b26637330557cf7401594","unresolved":false,"context_lines":[{"line_number":402,"context_line":"\t  .otp_size              \u003d 1024,"},{"line_number":403,"context_line":"\t},"},{"line_number":404,"context_line":"\t{"},{"line_number":405,"context_line":"\t  .id                    \u003d 0x467,"},{"line_number":406,"context_line":"\t  .revs                  \u003d stm32_467_revs,"},{"line_number":407,"context_line":"\t  .num_revs              \u003d ARRAY_SIZE(stm32_467_revs),"},{"line_number":408,"context_line":"\t  .device_str            \u003d \"STM32G0Bx/G0Cx\","}],"source_content_type":"text/x-csrc","patch_set":10,"id":"2ecb373e_ab8b49c3","line":405,"updated":"2021-08-14 05:46:26.000000000","message":"For this patch, it is ok, but it would be better to clean up all IDs. Same magic number are used on different places.","commit_id":"f1e5b97bc9baf3d1351adaadb914d729c6bd8776"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"af7bef006222f8f6df1c7663d3cb09dc25f5fcc9","unresolved":false,"context_lines":[{"line_number":402,"context_line":"\t  .otp_size              \u003d 1024,"},{"line_number":403,"context_line":"\t},"},{"line_number":404,"context_line":"\t{"},{"line_number":405,"context_line":"\t  .id                    \u003d 0x467,"},{"line_number":406,"context_line":"\t  .revs                  \u003d stm32_467_revs,"},{"line_number":407,"context_line":"\t  .num_revs              \u003d ARRAY_SIZE(stm32_467_revs),"},{"line_number":408,"context_line":"\t  .device_str            \u003d \"STM32G0Bx/G0Cx\","}],"source_content_type":"text/x-csrc","patch_set":10,"id":"2ecb373e_2e85275b","line":405,"in_reply_to":"2ecb373e_ab8b49c3","updated":"2021-08-14 13:32:30.000000000","message":"ok will do, this idea should applied om several drivers I guess","commit_id":"f1e5b97bc9baf3d1351adaadb914d729c6bd8776"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"35952f35248ef7df9e7b26637330557cf7401594","unresolved":false,"context_lines":[{"line_number":1489,"context_line":"\t * as the flash loader does not use the SR_BSY2"},{"line_number":1490,"context_line":"\t */"},{"line_number":1491,"context_line":"\tbool use_flashloader \u003d stm32l4_info-\u003euse_flashloader;"},{"line_number":1492,"context_line":"\tif ((stm32l4_info-\u003epart_info-\u003eid \u003d\u003d 0x467) \u0026\u0026 stm32l4_info-\u003edual_bank_mode) {"},{"line_number":1493,"context_line":"\t\tLOG_INFO(\"Couldn\u0027t use the flash loader in dual-bank mode\");"},{"line_number":1494,"context_line":"\t\tuse_flashloader \u003d false;"},{"line_number":1495,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"2ecb373e_6bbd6163","line":1492,"updated":"2021-08-14 05:46:26.000000000","message":"magic numbers. I would prefer to have a device specific quirk or flag to signal to signal this kind of issues. Imagine you will have here more id in the future.","commit_id":"f1e5b97bc9baf3d1351adaadb914d729c6bd8776"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"af7bef006222f8f6df1c7663d3cb09dc25f5fcc9","unresolved":false,"context_lines":[{"line_number":1489,"context_line":"\t * as the flash loader does not use the SR_BSY2"},{"line_number":1490,"context_line":"\t */"},{"line_number":1491,"context_line":"\tbool use_flashloader \u003d stm32l4_info-\u003euse_flashloader;"},{"line_number":1492,"context_line":"\tif ((stm32l4_info-\u003epart_info-\u003eid \u003d\u003d 0x467) \u0026\u0026 stm32l4_info-\u003edual_bank_mode) {"},{"line_number":1493,"context_line":"\t\tLOG_INFO(\"Couldn\u0027t use the flash loader in dual-bank mode\");"},{"line_number":1494,"context_line":"\t\tuse_flashloader \u003d false;"},{"line_number":1495,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"2ecb373e_ce9903ca","line":1492,"in_reply_to":"2ecb373e_6bbd6163","updated":"2021-08-14 13:32:30.000000000","message":"I can do, but I have been lazy on this because this lines of code to perform the quirk is remove in the upcoming patches, please see: http://openocd.zylin.com/#/c/6109/8/src/flash/nor/stm32l4x.c@1554","commit_id":"f1e5b97bc9baf3d1351adaadb914d729c6bd8776"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"35952f35248ef7df9e7b26637330557cf7401594","unresolved":false,"context_lines":[{"line_number":1737,"context_line":"\t\tstm32l4_info-\u003ecr_bker_mask \u003d FLASH_BKER_G0;"},{"line_number":1738,"context_line":""},{"line_number":1739,"context_line":"\t\t/* check DUAL_BANK bit */"},{"line_number":1740,"context_line":"\t\tif (stm32l4_info-\u003eoptr \u0026 BIT(21)) {"},{"line_number":1741,"context_line":"\t\t\tstm32l4_info-\u003esr_bsy_mask \u003d FLASH_BSY | FLASH_BSY2;"},{"line_number":1742,"context_line":"\t\t\tstm32l4_info-\u003edual_bank_mode \u003d true;"},{"line_number":1743,"context_line":"\t\t\tstm32l4_info-\u003ebank1_sectors \u003d num_pages / 2;"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"2ecb373e_0bb29d92","line":1740,"updated":"2021-08-14 05:46:26.000000000","message":"It is different kind of magic number :)","commit_id":"f1e5b97bc9baf3d1351adaadb914d729c6bd8776"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"af7bef006222f8f6df1c7663d3cb09dc25f5fcc9","unresolved":false,"context_lines":[{"line_number":1737,"context_line":"\t\tstm32l4_info-\u003ecr_bker_mask \u003d FLASH_BKER_G0;"},{"line_number":1738,"context_line":""},{"line_number":1739,"context_line":"\t\t/* check DUAL_BANK bit */"},{"line_number":1740,"context_line":"\t\tif (stm32l4_info-\u003eoptr \u0026 BIT(21)) {"},{"line_number":1741,"context_line":"\t\t\tstm32l4_info-\u003esr_bsy_mask \u003d FLASH_BSY | FLASH_BSY2;"},{"line_number":1742,"context_line":"\t\t\tstm32l4_info-\u003edual_bank_mode \u003d true;"},{"line_number":1743,"context_line":"\t\t\tstm32l4_info-\u003ebank1_sectors \u003d num_pages / 2;"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"2ecb373e_ae903799","line":1740,"in_reply_to":"2ecb373e_0bb29d92","updated":"2021-08-14 13:32:30.000000000","message":"I guess I will ask you to let it go, for this patch.\nit\u0027s kind of the same style used accross the full driver.\nmeanwhile I will prepare a change to fix all this suff","commit_id":"f1e5b97bc9baf3d1351adaadb914d729c6bd8776"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"8e0408402ee56d7009d1c54dc463f5c0365bb1c6","unresolved":false,"context_lines":[{"line_number":1737,"context_line":"\t\tstm32l4_info-\u003ecr_bker_mask \u003d FLASH_BKER_G0;"},{"line_number":1738,"context_line":""},{"line_number":1739,"context_line":"\t\t/* check DUAL_BANK bit */"},{"line_number":1740,"context_line":"\t\tif (stm32l4_info-\u003eoptr \u0026 BIT(21)) {"},{"line_number":1741,"context_line":"\t\t\tstm32l4_info-\u003esr_bsy_mask \u003d FLASH_BSY | FLASH_BSY2;"},{"line_number":1742,"context_line":"\t\t\tstm32l4_info-\u003edual_bank_mode \u003d true;"},{"line_number":1743,"context_line":"\t\t\tstm32l4_info-\u003ebank1_sectors \u003d num_pages / 2;"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"2ecb373e_4e33d3c0","line":1740,"in_reply_to":"2ecb373e_ae903799","updated":"2021-08-14 13:41:16.000000000","message":"please check #6437, it\u0027s still WIP\nI will add this DBANK bits","commit_id":"f1e5b97bc9baf3d1351adaadb914d729c6bd8776"}],"src/flash/nor/stm32l4x.h":[{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"35952f35248ef7df9e7b26637330557cf7401594","unresolved":false,"context_lines":[{"line_number":24,"context_line":"#define FLASH_PER\t\t\t\t(1 \u003c\u003c 1)"},{"line_number":25,"context_line":"#define FLASH_MER1\t\t\t\t(1 \u003c\u003c 2)"},{"line_number":26,"context_line":"#define FLASH_PAGE_SHIFT\t\t3"},{"line_number":27,"context_line":"#define FLASH_BKER\t\t\t\t(1 \u003c\u003c 11)"},{"line_number":28,"context_line":"#define FLASH_BKER_G0\t\t\t(1 \u003c\u003c 13)"},{"line_number":29,"context_line":"#define FLASH_MER2\t\t\t\t(1 \u003c\u003c 15)"},{"line_number":30,"context_line":"#define FLASH_STRT\t\t\t\t(1 \u003c\u003c 16)"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"2ecb373e_4bb8a574","line":27,"updated":"2021-08-14 05:46:26.000000000","message":"For this patch, it is ok, but it would be nice to use BIT(x) helper. Especially because it is already defined in different drivers.","commit_id":"f1e5b97bc9baf3d1351adaadb914d729c6bd8776"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"af7bef006222f8f6df1c7663d3cb09dc25f5fcc9","unresolved":false,"context_lines":[{"line_number":24,"context_line":"#define FLASH_PER\t\t\t\t(1 \u003c\u003c 1)"},{"line_number":25,"context_line":"#define FLASH_MER1\t\t\t\t(1 \u003c\u003c 2)"},{"line_number":26,"context_line":"#define FLASH_PAGE_SHIFT\t\t3"},{"line_number":27,"context_line":"#define FLASH_BKER\t\t\t\t(1 \u003c\u003c 11)"},{"line_number":28,"context_line":"#define FLASH_BKER_G0\t\t\t(1 \u003c\u003c 13)"},{"line_number":29,"context_line":"#define FLASH_MER2\t\t\t\t(1 \u003c\u003c 15)"},{"line_number":30,"context_line":"#define FLASH_STRT\t\t\t\t(1 \u003c\u003c 16)"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"2ecb373e_ee963f97","line":27,"in_reply_to":"","updated":"2021-08-14 13:32:30.000000000","message":"\u003e For this patch, it is ok, but it would be nice to use BIT(x) helper. Especially because it is already defined in different drivers.\n\nthere an ongoing patch in that sense #6429. I was thinking to ask him to rebase on top of my series and apply the change to all the new BITS","commit_id":"f1e5b97bc9baf3d1351adaadb914d729c6bd8776"}]}