)]}'
{"id":"openocd~master~Ifeb012952473d624327e8c010ac5c886d9473aa0","project":"openocd","branch":"master","hashtags":[],"change_id":"Ifeb012952473d624327e8c010ac5c886d9473aa0","subject":"tcl/target: add BCM2835 configuration file","status":"MERGED","created":"2021-02-19 14:23:49.000000000","updated":"2021-03-10 21:36:45.000000000","submitted":"2021-03-10 21:36:45.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6067-1615412205496-6ad64891","meta_rev_id":"5236c9ae79daac1ce988ff8e7295bb7369f22d0c","_number":6067,"owner":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":1,"date":"2021-03-10 21:36:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"value":2,"date":"2021-03-10 21:36:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":1,"date":"2021-03-10 21:36:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-02-26 20:49:08.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-03-10 21:36:45.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"cc606985b6512313bc9687e6fd7f5da724c2e8f1","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-02-19 14:23:49.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d294b0af991b9eac7deac8d29dddb26dea3ba099","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-02-19 14:26:44.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"9d22258783d32ec6a344f5761785df6087ef1720","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-02-19 14:26:45.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttp://build.openocd.org/job/openocd-gerrit/14014/ : ABORTED\n\nhttp://build.openocd.org/job/openocd-gerrit-build/13278/ : ABORTED","accounts_in_message":[],"_revision_number":1},{"id":"d0800170ef616dd44c5be53fb1146d5d1588bcdd","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-02-19 14:56:55.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14015/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/13279/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"13130d788a4f2c6460d52012f20f32e6c8d68dd2","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-02-20 23:42:37.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"c935ada2c1794d1ad4684ac0508875e726b5f1b3","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-02-21 00:11:56.000000000","message":"Patch Set 3:\n\nfor reference @see https://github.com/librerpi/rpi-open-firmware/tree/master/jtag","accounts_in_message":[],"_revision_number":3},{"id":"a8811a1bc1a0a3bf50424330e112c5603f7647ec","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-02-21 01:42:09.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14016/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/13283/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"d0bc13ad1646dea3f0b4e024aa815e45e940bc06","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-02-26 16:41:09.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"8c5da49f5b4eecfb98d73490e469e9c61d8962cb","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-02-26 20:14:33.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"68e1800c76e9114391be529ff15c1e305d0ee485","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-02-26 20:19:28.000000000","message":"Patch Set 4:\n\n(1 comment)\n\nThanks Antonio !","accounts_in_message":[],"_revision_number":4},{"id":"c17b0f47fda1d6d06d91c7c4a3ebfb0f76c17421","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-02-26 20:49:08.000000000","message":"Patch Set 4: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14026/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/13290/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"18f7a7e563b3fab7ba72bbd7cbe4b37ee4a2e638","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-02-26 21:55:09.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"797272996c6934d6523474c3caabe69d763934e7","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-02-27 17:10:57.000000000","message":"Patch Set 4: Code-Review+1\n\nthanks!","accounts_in_message":[],"_revision_number":4},{"id":"9f253173e0a426e6fda6e0699727d8894adf1bc5","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-03-07 14:37:57.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"5236c9ae79daac1ce988ff8e7295bb7369f22d0c","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-03-10 21:36:45.000000000","message":"Change has been successfully cherry-picked as a909df7088c32ef455ad3f78041ea17ffde41795 by Antonio Borneo","accounts_in_message":[],"_revision_number":5}],"current_revision":"a909df7088c32ef455ad3f78041ea17ffde41795","revisions":{"ef61b44751f2c0cc8dae26d8f2aef5676605614a":{"kind":"REWORK","_number":4,"created":"2021-02-26 20:14:33.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/67/6067/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/67/6067/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/67/6067/4 \u0026\u0026 git checkout -b change-6067 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/67/6067/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/67/6067/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/67/6067/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/67/6067/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/67/6067/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ba0f382137749b78b27ac58238735cc20a6fa847","subject":"autotools: generate list of NEWS-xx file during configure"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-02-19 14:23:34.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-02-26 20:03:06.000000000","tz":60},"subject":"tcl/target: add BCM2835 configuration file","message":"tcl/target: add BCM2835 configuration file\n\nThis is the Broadcom chip used in the Raspberry Pi Model A, B, B+,\nthe Compute Module, and the Raspberry Pi Zero.\n\nPartial information is available in raspberry pi website:\nhttps://www.raspberrypi.org/documentation/hardware/raspberrypi/bcm2835\n\nChange-Id: Ifeb012952473d624327e8c010ac5c886d9473aa0\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}},"a909df7088c32ef455ad3f78041ea17ffde41795":{"kind":"REWORK","_number":5,"created":"2021-03-10 21:36:45.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/67/6067/5","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/67/6067/5","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/67/6067/5 \u0026\u0026 git checkout -b change-6067 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/67/6067/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/67/6067/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/67/6067/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/67/6067/5","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/67/6067/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"210b7d2d1644c5c3dd1e59ffa684af56e3be498f","subject":"flash/nor/stmqspi: Replace macros with static inline functions"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-02-19 14:23:34.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-03-10 21:36:45.000000000","tz":0},"subject":"tcl/target: add BCM2835 configuration file","message":"tcl/target: add BCM2835 configuration file\n\nThis is the Broadcom chip used in the Raspberry Pi Model A, B, B+,\nthe Compute Module, and the Raspberry Pi Zero.\n\nPartial information is available in raspberry pi website:\nhttps://www.raspberrypi.org/documentation/hardware/raspberrypi/bcm2835\n\nChange-Id: Ifeb012952473d624327e8c010ac5c886d9473aa0\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\nReviewed-on: http://openocd.zylin.com/6067\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"18dcdfc1b1c37b974f360656923f9fa0a2fed503":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2021-02-19 14:26:44.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/67/6067/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/67/6067/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/67/6067/2 \u0026\u0026 git checkout -b change-6067 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/67/6067/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/67/6067/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/67/6067/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/67/6067/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/67/6067/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a7c436d1f6f8dd72aa937077bbc788ba2cf43f70","subject":"tcl/target: add BCM2711 configuration file"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-02-19 14:23:34.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-02-19 14:26:20.000000000","tz":60},"subject":"tcl/target: add BCM2835 configuration file","message":"tcl/target: add BCM2835 configuration file\n\nThis is the Broadcom chip used in the Raspberry Pi Model A, B, B+,\nthe Compute Module, and the Raspberry Pi Zero.\n\nPartial information are available in raspberry pi website:\nhttps://www.raspberrypi.org/documentation/hardware/raspberrypi/bcm2835\n\nChange-Id: Ifeb012952473d624327e8c010ac5c886d9473aa0\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}},"e289b8bb248c820e127e180fc0b59453ea8339e7":{"kind":"REWORK","_number":3,"created":"2021-02-20 23:42:37.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/67/6067/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/67/6067/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/67/6067/3 \u0026\u0026 git checkout -b change-6067 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/67/6067/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/67/6067/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/67/6067/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/67/6067/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/67/6067/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ba0f382137749b78b27ac58238735cc20a6fa847","subject":"autotools: generate list of NEWS-xx file during configure"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-02-19 14:23:34.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-02-20 23:29:07.000000000","tz":60},"subject":"tcl/target: add BCM2835 configuration file","message":"tcl/target: add BCM2835 configuration file\n\nThis is the Broadcom chip used in the Raspberry Pi Model A, B, B+,\nthe Compute Module, and the Raspberry Pi Zero.\n\nPartial information are available in raspberry pi website:\nhttps://www.raspberrypi.org/documentation/hardware/raspberrypi/bcm2835\n\nChange-Id: Ifeb012952473d624327e8c010ac5c886d9473aa0\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}},"881d442ddbdeaa8e6b23f1ebd7f55f1bc8999f99":{"kind":"REWORK","_number":1,"created":"2021-02-19 14:23:49.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/67/6067/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/67/6067/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/67/6067/1 \u0026\u0026 git checkout -b change-6067 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/67/6067/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/67/6067/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/67/6067/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/67/6067/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/67/6067/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a7c436d1f6f8dd72aa937077bbc788ba2cf43f70","subject":"tcl/target: add BCM2711 configuration file"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@st.com","date":"2021-02-19 14:23:34.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@st.com","date":"2021-02-19 14:23:34.000000000","tz":60},"subject":"tcl/target: add BCM2835 configuration file","message":"tcl/target: add BCM2835 configuration file\n\nThis is the Broadcom chip used in the Raspberry Pi Model A, B, B+,\nthe Compute Module, and the Raspberry Pi Zero.\n\nPartial information are available in raspberry pi website:\nhttps://www.raspberrypi.org/documentation/hardware/raspberrypi/bcm2835\n\nChange-Id: Ifeb012952473d624327e8c010ac5c886d9473aa0\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@st.com\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}