)]}'
{"id":"openocd~master~I1bc105b3addc3f34161c2356c482ff3011e3f2cc","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001872":{"account":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"last_update":"2022-02-14 15:12:10.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-01-30 15:44:38.000000000","reason":"Antonio Borneo replied on the change"},"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2022-01-30 11:12:00.000000000","reason":"Marc Schink replied on the change"},"1000410":{"account":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"last_update":"2021-11-24 08:25:18.000000000","reason":"removed on reply"},"1001661":{"account":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"last_update":"2022-02-14 15:12:10.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I1bc105b3addc3f34161c2356c482ff3011e3f2cc","subject":"Cadence virtual debug interface (vdebug) integration","status":"MERGED","created":"2021-03-12 15:56:08.000000000","updated":"2022-02-14 15:12:10.000000000","submitted":"2022-02-14 15:12:10.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":426,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6097","meta_rev_id":"f40d3c8af3b909097c509b8efd80b346d4d1976a","_number":6097,"owner":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"value":0,"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"value":0,"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-02-14 15:12:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"all":[{"value":0,"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-02-14 15:12:10.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-02-14 15:12:10.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-02-14 15:12:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"value":0,"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"}],"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-03-14 11:52:40.000000000","updated_by":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"reviewer":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"state":"REVIEWER"},{"updated":"2021-04-12 18:29:56.000000000","updated_by":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"reviewer":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"state":"REVIEWER"},{"updated":"2021-04-12 23:08:37.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2021-06-26 10:39:28.000000000","updated_by":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"reviewer":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"REVIEWER"},{"updated":"2021-08-11 19:43:07.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-08-12 06:30:46.000000000","updated_by":{"_account_id":1001871,"name":"Jacek M Wuwer","email":"jacekmw8@gmail.com"},"reviewer":{"_account_id":1001871,"name":"Jacek M Wuwer","email":"jacekmw8@gmail.com"},"state":"REVIEWER"},{"updated":"2021-11-08 16:24:13.000000000","updated_by":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"reviewer":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"state":"CC"},{"updated":"2021-12-09 19:29:45.000000000","updated_by":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"reviewer":{"_account_id":1001871,"name":"Jacek M Wuwer","email":"jacekmw8@gmail.com"},"state":"REMOVED"}],"messages":[{"id":"dbac6363cd2795c759397c42d65dc558f78e098d","author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"real_author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"date":"2021-03-12 15:56:08.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5b3f1b9afb5d4111bd6e480bd151edd0f114ce7f","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-03-12 15:57:03.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttp://build.openocd.org/job/openocd-gerrit/14107/ : FAILURE\n\nhttp://build.openocd.org/job/openocd-gerrit-build/13369/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"47b9f05793f91f81ab689c6975b086594d5f0376","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-03-13 05:38:09.000000000","message":"Patch Set 1:\n\nThis patch will need a lot of time. Are you ready to work on it? Otherwise i\u0027ll do not bother to review it","accounts_in_message":[],"_revision_number":1},{"id":"879d35cb8a01c11e3eaae91422558bcb4a7b123e","author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"real_author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"date":"2021-03-13 10:31:22.000000000","message":"Patch Set 1:\n\n\u003e This patch will need a lot of time. Are you ready to work on it?\n \u003e Otherwise i\u0027ll do not bother to review it\n\nYes, I am ready to work on it. is there anything that pops up other than formatting that I need to pay attention ?\nAlso, do I need to abandon this push, ammend my commit after fixing the format and push again ? Thanks","accounts_in_message":[],"_revision_number":1},{"id":"eae70b02cccc2952ac8ea44009ef15d5d98c09f0","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2021-03-13 10:59:36.000000000","message":"Patch Set 1: Code-Review-1\n\nHi Jacek,\n\nthanks for you contribution! As Oleksij already said, the patch is full of issues:\n\n - Use tabs instead of spaces (see Jenkins)\n - Spaces between if and parentheses\n - Trailing whitespaces\n - Check the OpenOCD style guide: http://openocd.org/doc-release/doxygen/stylec.html\n   - Don\u0027t use typedef enum / struct\n   - Use proper data types\n   - Declare variable at the point of first use","accounts_in_message":[],"_revision_number":1},{"id":"c34345a352f07a0aaddce9b71a20c0c5cfeccc4a","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-03-13 11:10:20.000000000","message":"Patch Set 1:\n\nexcept of style issues:\n- please add more comments and some documentation to the driver. Not many peaple know about this interface, so it will be hurd to review now, not even harder for some one after 10 years :)\n- add a some kind of desdcription and protocol documentation to the top of the driver files. \n- split long functions to make it readable\n- avoid unexplained numbers, use defines\n- for example pollmin \u003d 1000; pollmax \u003d 5000.. you need to add comments, why do you use this numbers. If it is just rundom number with good feeling, describe it as: \"seems to be sane poll values, works for me...\"","accounts_in_message":[],"_revision_number":1},{"id":"d707ce5bcab1ad625101b7841c3d2fc7104501df","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-03-13 11:11:49.000000000","message":"Patch Set 1:\n\nconfig files should be not work space specific, no speed limits, no drivers included, no commented out code\nAdd a lot of comments to explain why you do this and not something else...","accounts_in_message":[],"_revision_number":1},{"id":"950c7896a1ddb9421ca0aaacd60cad4d3a5088c0","author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"real_author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"date":"2021-03-13 11:20:18.000000000","message":"Patch Set 1:\n\n\u003e Hi Jacek,\n \u003e \n \u003e thanks for you contribution! As Oleksij already said, the patch is\n \u003e full of issues:\n \u003e \n \u003e - Use tabs instead of spaces (see Jenkins)\n \u003e - Spaces between if and parentheses\n \u003e - Trailing whitespaces\n \u003e - Check the OpenOCD style guide: http://openocd.org/doc-release/doxygen/stylec.html\n \u003e - Don\u0027t use typedef enum / struct\n \u003e - Use proper data types\n \u003e - Declare variable at the point of first use\n\nThanks Marc,\nis there a script that I can run locally to check the format before commit/push ?\nhow I deal with errors like: \nERROR: do not use C99 // comments\nwhere the style guide says:\n// comments – in new code, prefer these for single-line comments\nwhich imo makes much more sense...","accounts_in_message":[],"_revision_number":1},{"id":"3a4baab3b4fcce199751d9c828f8973a47f6ae50","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-03-13 11:33:07.000000000","message":"Patch Set 1:\n\nthe validation script is located in tools/checkpatch.sh\nwhich is a copy of the linux kernel validation script. So, most of the kernel coding guide lines apply on OpenOCD:\nhttps://www.kernel.org/doc/html/v5.11/process/coding-style.html","accounts_in_message":[],"_revision_number":1},{"id":"ed08b934e4b744b8908c129b1566935bbe60d426","author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"real_author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"date":"2021-03-13 11:45:18.000000000","message":"Patch Set 1:\n\n\u003e config files should be not work space specific, no speed limits, no\n \u003e drivers included, no commented out code\n \u003e Add a lot of comments to explain why you do this and not something\n \u003e else...\nThanks. not sure what you mean work space specific...\nI have the driver config under interfaces, and target specific config under target, will remove the driver reference from there and source it.   \nWill add more comments.","accounts_in_message":[],"_revision_number":1},{"id":"863a7e1e36b646d82433f39a90f2675f739d3e0a","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-03-13 11:52:02.000000000","message":"Patch Set 1:\n\n(3 comments)\n\nthe target script describes target chip/SoC. The board script describes board and includes target script.\nOn your workspace you usually have some random jtag adapter, connected with some random cable to some specific board.\nAll of this config parts which are related to your workspace should not go to target or board config","accounts_in_message":[],"_revision_number":1},{"id":"460b30671c482468a0edc16843b85115485d4238","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2021-03-13 11:55:38.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"b47836ed445bf80b196d1ac6eb42cac5f252b538","author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"real_author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"date":"2021-03-13 12:00:14.000000000","message":"Patch Set 1:\n\nOK, will do.","accounts_in_message":[],"_revision_number":1},{"id":"2e89a4332304a59ca4e63ab370c65efe32919420","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-03-13 12:18:10.000000000","message":"Patch Set 1: Code-Review-1\n\n(11 comments)","accounts_in_message":[],"_revision_number":1},{"id":"2a089162da85d76571c6583ede707a65a8d502ba","author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"real_author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"date":"2021-03-13 12:59:47.000000000","message":"Patch Set 1:\n\nThanks for the review. will check the specific comments. \nAs a background information.\nThe vdebug interface has been implemented for many commercial debuggers already, so the the driver code has not been newly written for openocd, it is essentially an adaptation of a subset if the vdebug client interface to implement the openocd-specifc hooks.\nI did not want to carry over the original headers in there, just packed all is needed into one driver source, thus there is few raw numbers in there.\nThat\u0027s why there is a separate logging in there, need to have a consistent data in a log, regardless of what debugger it comes from.\nAlso the style comes from the existing code base. Will look into your comments individually and reformat it with tabs, etc, run checkpatch.sh\nWhat to do with this patch set now ?\nthanks - Jacek","accounts_in_message":[],"_revision_number":1},{"id":"eec59c9b76b0382d589b680dfc68de3151c9b535","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-03-13 14:11:17.000000000","message":"Patch Set 1:\n\n\u003e Thanks for the review. will check the specific comments.\n \u003e As a background information.\n \u003e The vdebug interface has been implemented for many commercial\n \u003e debuggers already,\n\nJust a hint: there are many confusions about commercial and opensource.\nOpensource is not opposite of commercial, first of all it is type of project management and development.\nOpenOCD is used by many commercial project and used for following reasons:\n- avoiding vendor lock\n- getting long term support\n- being able to fix bugs even by being small company\n- offload or share maintenance price with other companies and users\n\nTo mainline something, for example this driver, means:\n- to get quality verification for free\n- transfer maintaining responsibility to project participants\n- be able to get updates, security fixes, new futures without maintaining own patch set\n\n \u003e so the the driver code has not been newly\n \u003e written for openocd, it is essentially an adaptation of a subset if\n \u003e the vdebug client interface to implement the openocd-specifc hooks.\n\nIt is typical situation for almost every driver in any project. OpenOCD is not an exception here :)\n\n \u003e I did not want to carry over the original headers in there, just\n \u003e packed all is needed into one driver source, thus there is few raw\n \u003e numbers in there.\n\nIt would be better to fix it. Raw numbers are make maintaining job harder. It make no sense to\noffload to some one by making it harder :)\n\n \u003e That\u0027s why there is a separate logging in there, need to have a\n \u003e consistent data in a log, regardless of what debugger it comes\n \u003e from.\n\nimagine, this driver is just one of many drivers and each of them implements own logging interface... should i continue?\n\n \u003e Also the style comes from the existing code base. Will look into\n \u003e your comments individually and reformat it with tabs, etc, run\n \u003e checkpatch.sh\n\nok\n\n \u003e What to do with this patch set now ?\n \u003e thanks - Jacek\n\njust push new patch with current Change-Id. jenkins will replace current patch provide patch change history. In this case, we will be able to see, what comments we made and if this comments was addressed.","accounts_in_message":[],"_revision_number":1},{"id":"2153ee9e878799441ceeb5e2e04c590a3d49dd83","author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"real_author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"date":"2021-03-14 10:09:11.000000000","message":"Patch Set 1:\n\nThank you for the response and the elaboration Oleksij.\n\nOnce the vdebug driver is integrated in the openocd I will do our share to maintain it, it won\u0027t be just dropped and left there ;-) \n\nAnd to support it, where the support goes well beyond what is included in openocd. And that is the reason for the diagnostic log in the code, it can only be enabled by setting an env, usually per instructions from a  support team and the log will them to diagnose the issue, without looking at the source. \nI have attempted to cleanly split the logging into vdebug protocol specific transport level, controlled by env variable and openocd, visible and controlled by the config starting from vdebug_poll function and below. \n\nThis function marks the split between what has been carried over from general vdebug codebase (above) and implemented for openocd. I\u0027d like to keep the vdebug part in vdebug.c as consistent with codebase as possible. \nDefining constants and better commenting/documenting is beneficial to any code, I will make an diligent effort to improve it, including pushing it back to origin ;-)","accounts_in_message":[],"_revision_number":1},{"id":"811bf07b248de07c02d7012737927684dca586d0","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-03-14 11:52:40.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n \u003e And to support it, where the support goes well beyond what is included in openocd. And that is the reason for the diagnostic log in the code, it can only be enabled by setting an env, usually per instructions from a  support team and the log will them to diagnose the issue, without looking at the source. \n \u003e I have attempted to cleanly split the logging into vdebug protocol specific transport level, controlled by env variable and openocd, visible and controlled by the config starting from vdebug_poll function and below. \n \u003e \n \u003e This function marks the split between what has been carried over from general vdebug codebase (above) and implemented for openocd. I\u0027d like to keep the vdebug part in vdebug.c as consistent with codebase as possible. \n \u003e \nwhen using the openocd LOG_DEBUG you will have the file name and function name in the log.\nto exchange with support team you can grep the lines having the driver  file name ...","accounts_in_message":[],"_revision_number":1},{"id":"c32345feb391995a5f22d199ca589b8579ad8ba7","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-03-14 12:00:27.000000000","message":"Patch Set 1:\n\n\u003e Thank you for the response and the elaboration Oleksij.\n \u003e \n \u003e Once the vdebug driver is integrated in the openocd I will do our\n \u003e share to maintain it, it won\u0027t be just dropped and left there ;-)\n\nHeh.. :) OK, it is good to know, it is not just next vendor code drop. I can list you bad and good reason why people stop to contribute.\nbad reasons: covid-19, bus accident, no more job, etc\ngood reasons: family, baby, other better job\n\nSo, the review process is to make sure, that after this code is commited, we still able to handle it.\n\n \u003e And to support it, where the support goes well beyond what is\n \u003e included in openocd. And that is the reason for the diagnostic log\n \u003e in the code, it can only be enabled by setting an env, usually per\n \u003e instructions from a  support team and the log will them to diagnose\n \u003e the issue, without looking at the source.\n \u003e I have attempted to cleanly split the logging into vdebug protocol\n \u003e specific transport level, controlled by env variable and openocd,\n \u003e visible and controlled by the config starting from vdebug_poll\n \u003e function and below.\n \nThere are two perspectives\n- Candence perspective: we are busy making our project and OpenOCD is just one of many projects to support. OpenOCD should do what we tell :)\n- OpenOCD perspective: we are busy making our project and vdebug is just one of many drivers to support.... \n\nI assume the point is clear? :D\n\nFrom OpenOCD long term view, it makes no sense to support separate tracing interfaces for each driver. Otherwise this driver will not be accepted.\n\nCurrently you have following options:\n- use currently existing OpenOCD loging interface and make some parser to extract/format log you need for cadence support\n- extend OpenOCD logging or tracing interface so it will fit you needs and can be reused by all drivers.\n- keep downstream patch stack for this kind of tracing.\n\n \u003e This function marks the split between what has been carried over\n \u003e from general vdebug codebase (above) and implemented for openocd.\n \u003e I\u0027d like to keep the vdebug part in vdebug.c as consistent with\n \u003e codebase as possible.\n \u003e Defining constants and better commenting/documenting is beneficial\n \u003e to any code, I will make an diligent effort to improve it,\n \u003e including pushing it back to origin ;-)\n\nIt is standard challenge of every project. Some vendor created some code and over generations kept it under lock.\nThen this code was not able to compete with other projects, so it is decided to take advantage of other OSS\nso OSS should accept rules and project management of the vendor to integrate this code.\n\nI see it every working day :)\nI can understand you motivation, but... you need to accept rules of this project to upstream this code","accounts_in_message":[],"_revision_number":1},{"id":"5ea9928a23634fc06a3bcaea49b788685d406b6f","author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"real_author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"date":"2021-03-17 12:23:22.000000000","message":"Patch Set 1:\n\nI admit I have not realized how painful the \"ERROR: do not use assignment in if condition\" could be... I guess I am not the first to go through this experience ;-)\n\n \u003e Currently you have following options:\n \u003e - use currently existing OpenOCD loging interface and make some\n \u003e parser to extract/format log you need for cadence support\n \u003e - extend OpenOCD logging or tracing interface so it will fit you\n \u003e needs and can be reused by all drivers.\n \u003e - keep downstream patch stack for this kind of tracing.\nNot sure, I think I\u0027ll drop the lowest level logging and use the existing logs.\n \u003e It is standard challenge of every project. Some vendor created some\n \u003e code and over generations kept it under lock.\n \u003e Then this code was not able to compete with other projects, so it\n \u003e is decided to take advantage of other OSS\n \u003e so OSS should accept rules and project management of the vendor to\n \u003e integrate this code.\nI do not think that the case often, definitively not in this case. The motivation is the extend the capability of the product to support openocd. You do not do this with an obsolete code.\nThe fact however that the code has been \u0027ported\u0027 to comply with the OS licensing, all the rules and styles makes it quite a branch, that diverged a lot from the upstream from the very start, so there is an effort to keep it up to date and it may become outdated.., I guess that is the way it is.\n\u003e \n \u003e I see it every working day :)\n \u003e I can understand you motivation, but... you need to accept rules of\n \u003e this project to upstream this code\nYes, understand.","accounts_in_message":[],"_revision_number":1},{"id":"5e34b0b77fb26073952756fa517b7c95b654e013","author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"real_author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"date":"2021-03-19 16:16:54.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"812866be6e7b9135d4bf34772439cc3db36b8b80","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-03-19 17:00:19.000000000","message":"Patch Set 2: Verified-1\n\nBuild Failed \n\nhttp://build.openocd.org/job/openocd-gerrit/14214/ : FAILURE\n\nhttp://build.openocd.org/job/openocd-gerrit-build/13476/ : FAILURE","accounts_in_message":[],"_revision_number":2},{"id":"a8211dcc3951973db07d15ae85dae1845506b3f5","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-03-21 22:03:24.000000000","message":"Patch Set 2:\n\nCadence BFM is already supported by OpenOCD v0.11.0!\nhttp://openocd.zylin.com/5573/ merged 2020-10-03\nCan you please confirm it\u0027s the same?","accounts_in_message":[],"_revision_number":2},{"id":"9778145f6395dc639aa2ec276b92f657438813e4","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2021-03-22 07:35:18.000000000","message":"Patch Set 2:\n\n\u003e Cadence BFM is already supported by OpenOCD v0.11.0!\n\nLooks like this patch has a different wire protocol, no?","accounts_in_message":[],"_revision_number":2},{"id":"696be340d2ac84149d0df42ccdb07e5dae9144c9","author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"real_author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"date":"2021-03-22 08:48:48.000000000","message":"Patch Set 2:\n\n\u003e Cadence BFM is already supported by OpenOCD v0.11.0!\n \u003e http://openocd.zylin.com/5573/ merged 2020-10-03\n \u003e Can you please confirm it\u0027s the same?\nNo. It is not the same. \nThis patch includes the official Cadence virtual debug interface, which is much more comprehensive, supports many interfaces (\u0027transports\u0027) and debuggers. \nCadence also provides something called jtag_dpi, it is freely available for its customers and contains a JTAG transactor consisting of BFM and C/C++ interface. I think the patch you mention, implements a patch to connect to that transactor, based on the protocol similar to long available jtag_vpi debug driver. I have contacted Ampere about that, unfortunately the person who uploaded the jtag_dpi has left the company and I did not get any info what Ampere plans to do further with the jtag_dpi.\nI think it would be nice to make the BFM and transactor available to all on github for instance, but then on openocd it would be supported by this driver, not by the current jtag_dpi.","accounts_in_message":[],"_revision_number":2},{"id":"c0f1e468505e9845ab6e6936a72243281c5012ee","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-03-22 17:54:46.000000000","message":"Patch Set 2:\n\nThere seems to be a new person at Ampera, http://openocd.zylin.com/#/c/6119/ try to contact Daniel Goehring \u003cdgoehrin@os.amperecomputing.com\u003e","accounts_in_message":[],"_revision_number":2},{"id":"358f6b7ef6dcf46f052542d156f8d87edd68eb64","author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"real_author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"date":"2021-04-06 18:36:54.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"6828527e43313517e61c85fce5814ddd7686b298","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-04-06 18:37:44.000000000","message":"Patch Set 3: Verified-1\n\nBuild Failed \n\nhttp://build.openocd.org/job/openocd-gerrit/14296/ : FAILURE\n\nhttp://build.openocd.org/job/openocd-gerrit-build/13551/ : FAILURE","accounts_in_message":[],"_revision_number":3},{"id":"470ab234024afd8406163fdc6676327a8f201bcc","author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"real_author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"date":"2021-04-06 18:42:06.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"16b62025882dfe43e3992e7491eaf4730a6f888b","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-04-06 19:11:40.000000000","message":"Patch Set 4: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14297/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/13552/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"55d93241a070daffcb3cc7296ef6e138b5d0080c","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-04-12 18:29:56.000000000","message":"Patch Set 4: Code-Review-2\n\nHi Jacek, thank you for your work.\nPlease drop all target config from this patch. Usually we have multiple types of configs:\n1. adapter config (jtag adapter)\n2. target config (SoC specific configuration\u003d\n3. board config (includes target + some board specific configurations like RAM init and so on)\n3. workplace config including adapter, board and your special, work place specific configuration\nConfig attached in to your patch are mix of workplace + target + adapter. Which is not suitable for mainline.","accounts_in_message":[],"_revision_number":4},{"id":"be7cd3ba2010fdbe86ce01733332fa77c26c7eb0","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-04-12 18:58:11.000000000","message":"Patch Set 4:\n\n(13 comments)","accounts_in_message":[],"_revision_number":4},{"id":"5db1b09d795246bb2b1a58571cc10ca15b8a6e7a","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-04-12 23:08:37.000000000","message":"Patch Set 4: Code-Review-2\n\n(13 comments)","accounts_in_message":[],"_revision_number":4},{"id":"ef1d1a49099319a76ebf36ecef0d89f6fb0d8c87","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-04-13 04:59:23.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"2704447e68f4228a4d240bb1dfcdfefb50ac9c58","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-04-13 09:17:24.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"b344ace7fb99ceba83da6671b3accabf5aa320d8","author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"real_author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"date":"2021-04-14 09:08:12.000000000","message":"Patch Set 4:\n\nThank you Antonio, Oleksij for the comments. I will address them one by one.","accounts_in_message":[],"_revision_number":4},{"id":"29268d64de4e930a2e545f0935d46ac6e073457d","author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"real_author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"date":"2021-04-14 09:40:14.000000000","message":"Patch Set 4:\n\n(3 comments)","accounts_in_message":[],"_revision_number":4},{"id":"0ef122294d0ff6c023f38cf98ed9d0e1987a22a3","author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"real_author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"date":"2021-04-14 10:18:54.000000000","message":"Patch Set 4:\n\n(6 comments)","accounts_in_message":[],"_revision_number":4},{"id":"ed2cc39c7d4584faff7631470bb2267007726729","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-04-14 13:31:03.000000000","message":"Patch Set 4:\n\n(4 comments)","accounts_in_message":[],"_revision_number":4},{"id":"d43eb218f4115a8314167324e144d5eee4b61129","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-04-14 14:34:23.000000000","message":"Patch Set 4:\n\n(3 comments)","accounts_in_message":[],"_revision_number":4},{"id":"98f3e5bfe6b98d87771d8bac9eb80bf03cd58cae","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-04-14 15:47:51.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"9add23c1187d124eeb3b4501ef60b61b8a395207","author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"real_author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"date":"2021-04-14 18:26:35.000000000","message":"Patch Set 4:\n\n(4 comments)","accounts_in_message":[],"_revision_number":4},{"id":"27bf58e2585acb7f856b8f50093815f94a77d9ef","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-04-15 07:51:32.000000000","message":"Patch Set 4:\n\n(4 comments)","accounts_in_message":[],"_revision_number":4},{"id":"71703f37192f1192b2c424f160ec49df9bbee440","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-04-15 15:18:28.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"1117930718229718ee8f4a61dfa787a0cceecf42","author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"real_author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"date":"2021-04-15 18:18:48.000000000","message":"Patch Set 4:\n\n(4 comments)","accounts_in_message":[],"_revision_number":4},{"id":"c2109082fdd4b0eb125c77ebf779f58983c8d472","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-04-15 19:10:55.000000000","message":"Patch Set 4:\n\n(3 comments)","accounts_in_message":[],"_revision_number":4},{"id":"c5b2fc58d7ed4481de2d054605e313aea8ee0851","author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"real_author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"date":"2021-04-17 16:01:53.000000000","message":"Patch Set 4:\n\n(3 comments)","accounts_in_message":[],"_revision_number":4},{"id":"4cd45e48d15c4467c3f46bbbf75e7d94064be4a1","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-04-18 11:17:01.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"1ff41317c906b773bacdde0989155b3326636c82","author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"real_author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"date":"2021-05-17 10:11:39.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"e288e5adcdb0f71e64b0b1ace7f4515a967bc07c","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-05-17 10:42:49.000000000","message":"Patch Set 5: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14568/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/13820/ : SUCCESS","accounts_in_message":[],"_revision_number":5},{"id":"4d4533d0857bfc8b23621453e918f2a64a452aa1","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-05-17 17:27:18.000000000","message":"Patch Set 5:\n\n(6 comments)\n\nsome extra comment","accounts_in_message":[],"_revision_number":5},{"id":"eec3184123ddf9d5bf346545a884ac65c0dd71b6","author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"real_author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"date":"2021-05-18 13:47:30.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"23e84ab07fbf652f36b4b1a0c380178917f8a234","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-05-18 14:20:00.000000000","message":"Patch Set 6: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14580/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/13832/ : SUCCESS","accounts_in_message":[],"_revision_number":6},{"id":"6753b0fa65fc623a66936f22882597a9605ffa7f","author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"real_author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"date":"2021-06-24 17:10:45.000000000","message":"Patch Set 6:\n\nHi Oleksij \u0026 Antonio,\nWhat happens next with this patch ? It has been a while since I uploaded the patch addressing your latest comments/requests.","accounts_in_message":[],"_revision_number":6},{"id":"fd014fa7e78c159f13a06cad54e1b32a585737c1","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-06-25 11:03:01.000000000","message":"Patch Set 6:\n\n(5 comments)\n\nAlmost non of my comments was addressed","accounts_in_message":[],"_revision_number":6},{"id":"4041027ed41cbe9106bb53e0f08005e539df9c61","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2021-06-26 10:39:28.000000000","message":"Patch Set 6: Code-Review-1\n\n(20 comments)","accounts_in_message":[],"_revision_number":6},{"id":"9f39d8454be0e814bf448e07520997dbbeac29df","author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"real_author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"date":"2021-07-01 11:37:05.000000000","message":"Patch Set 6:\n\nThank you for your comments. I will respond to some of your comments.","accounts_in_message":[],"_revision_number":6},{"id":"8add227a0bf7a658ef47e2a7bbe9e2443457f20f","author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"real_author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"date":"2021-07-01 15:04:40.000000000","message":"Patch Set 6:\n\n(8 comments)","accounts_in_message":[],"_revision_number":6},{"id":"3097cb2c42cd5fcc39ddc2d75ea02f3f8b64cafb","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2021-07-01 19:00:32.000000000","message":"Patch Set 6:\n\n(4 comments)","accounts_in_message":[],"_revision_number":6},{"id":"09c44fea34a7ac1dea6113c3b3e3de16ca152352","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-07-02 05:34:46.000000000","message":"Patch Set 4:\n\n(6 comments)","accounts_in_message":[],"_revision_number":4},{"id":"86f1034d15dd18632d342721ae86560106c79788","author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"real_author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"date":"2021-07-02 11:25:34.000000000","message":"Patch Set 4:\n\n(12 comments)","accounts_in_message":[],"_revision_number":4},{"id":"032c43ad3b37f08e21b22f69a18c15f9517c08a9","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-07-02 12:24:17.000000000","message":"Patch Set 4:\n\n(2 comments)","accounts_in_message":[],"_revision_number":4},{"id":"53d6f3268d4fd044d11306cb558c2816b4978b9e","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-07-02 12:56:18.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"0bb6aa252322e9a9ed88d93034fc1f6e87a6d135","author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"real_author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"date":"2021-07-04 14:08:45.000000000","message":"Patch Set 6:\n\nAfter recent git pull I could not compile anymore, due to build structure being changed upstream. autoreconf --install did help, but shouldn\u0027t git take care of it ?\nThank you again for the review and your comments. At this point when I am slowly becoming a laughing stock (\u0027what did you rewrite this time?\u0027) I have started asking questions. The driver code has been put together from a project that has been actively used and developed for 8 years, with some code pieces 20 years old. I have rewritten it to conform to project standard, went over iterations, playing with white spaces, bloating the code, making the checker fail. I even crippled the driver somewhat by removing some relevant code temporarily from this patch to move forward. Yet at this stage I get requests, calling for n-th rewrite. I am sorry but I cannot afford rewriting this piece of code without end in sight and I find some of the requests going well beyond common sense.\nAs an example: In March Oleksij asked for more comments and documentation to the protocol driver, I have added comments to the code. 4 months later he wants to have separate structures allocated for every request type... I can understand request for more documentation (even though we will be supporting and debugging this code, not you dear reviewers, for the reasons I explained), but not for this.\nI am willing to help overall OpenOCD code overhaul and rewrite again to apply the latest standard, but pls understand it\u0027s time consuming, possibly much more than you think. \nAs an example vdebug prefix change implies not only code changes, but also the config files, here and the internal example that we maintain as a part of the build and - not to forget - the documentation. Customers who use vdebug with OpenOCD, requested it and we keep updating it as we move forward in this process. Also this documentation exists on other forms too, on the support site and internal wiki page...\nI hope you can what I explained as a reasonable approach, I\u0027d like to see moving to the closure, not going in circles.","accounts_in_message":[],"_revision_number":6},{"id":"b045503b71c8dd2c7cf77640c75a766c6abafc5f","author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"real_author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"date":"2021-07-04 14:39:26.000000000","message":"Patch Set 6:\n\n(2 comments)","accounts_in_message":[],"_revision_number":6},{"id":"6ccdd10828dab0dc6aa8424db7ebcaacee6549aa","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-07-04 18:51:27.000000000","message":"Patch Set 6:\n\n(1 comment)\n\n\u003e After recent git pull I could not compile anymore, due to build\n \u003e structure being changed upstream. autoreconf --install did help,\n \u003e but shouldn\u0027t git take care of it ?\n \u003e Thank you again for the review and your comments. At this point\n \u003e when I am slowly becoming a laughing stock (\u0027what did you rewrite\n \u003e this time?\u0027) I have started asking questions. The driver code has\n \u003e been put together from a project that has been actively used and\n \u003e developed for 8 years, with some code pieces 20 years old. I have\n \u003e rewritten it to conform to project standard, went over iterations,\n \u003e playing with white spaces, bloating the code, making the checker\n \u003e fail. I even crippled the driver somewhat by removing some relevant\n \u003e code temporarily from this patch to move forward. Yet at this stage\n \u003e I get requests, calling for n-th rewrite. I am sorry but I cannot\n \u003e afford rewriting this piece of code without end in sight and I find\n \u003e some of the requests going well beyond common sense.\n \u003e As an example: In March Oleksij asked for more comments and\n \u003e documentation to the protocol driver, I have added comments to the\n \u003e code. 4 months later he wants to have separate structures allocated\n \u003e for every request type... I can understand request for more\n \u003e documentation (even though we will be supporting and debugging this\n \u003e code, not you dear reviewers, for the reasons I explained), but not\n \u003e for this.\n \u003e I am willing to help overall OpenOCD code overhaul and rewrite\n \u003e again to apply the latest standard, but pls understand it\u0027s time\n \u003e consuming, possibly much more than you think.\n \u003e As an example vdebug prefix change implies not only code changes,\n \u003e but also the config files, here and the internal example that we\n \u003e maintain as a part of the build and - not to forget - the\n \u003e documentation. Customers who use vdebug with OpenOCD, requested it\n \u003e and we keep updating it as we move forward in this process. Also\n \u003e this documentation exists on other forms too, on the support site\n \u003e and internal wiki page...\n \u003e I hope you can what I explained as a reasonable approach, I\u0027d like\n \u003e to see moving to the closure, not going in circles.\n\nWell, where should I start?\nOpenOCD is a community project maintained by IT professionals somewhere after work. With other words, most of us do it for free. Reviewing is a time consuming process (of our free time) which need understanding of code.\n\nWhat is needed to review the code? Usually it is a simple process - just read the code. Depending on the coding stile, some one like me need more or less time.\n\nCode review is only one step within lifetime of any project. Maintaining of the code is starting right after code is accepted. More code, means more maintaining work.\n\nEven if you say, that you will take over maintenance of this drive, in reality, maintainers of this project take responsibility for this code. If there are security holes, we are blamed - not you.\nIf we would not force you to write the code in the project specific way, some one like you will come and say: hay! other old drivers are made this way, why I should do it differently?!\n\nNo one claims that this code is not working, but you wont to integrate it in to this project, so please respect coding rules of this project and do not waste the (free) time of reviewers.\n\nMarc pointed to move defines of variable to be able to recognize if usage type is in sync with defined type. If you variable is never negative, then please use unsigned type. If it is only 0 or 1, then please use bool.\n\nWhat i\u0027m requesting is same sort of requirement: be able to understand  and see how the functions works, without going to \"schnitzeljagd\", by calculating offsets and comparing behavior of different compilers. This cost my personal time.","accounts_in_message":[],"_revision_number":6},{"id":"de8df468803b03caea3181c494e341d61f5a77fb","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-07-04 19:14:23.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"7d7f3e55997579abecd07c50258a87ebad8344f5","author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"real_author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"date":"2021-07-08 18:52:31.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"0148fdb29f6cb8d0cc91fad124fae1a9ab45e9d4","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-07-08 19:24:01.000000000","message":"Patch Set 7: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14832/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/14078/ : SUCCESS","accounts_in_message":[],"_revision_number":7},{"id":"d8814d6197f563d82adfa114c25c2a699c767cf0","author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"real_author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"date":"2021-07-20 09:13:41.000000000","message":"Uploaded patch set 8.","accounts_in_message":[],"_revision_number":8},{"id":"928f9bb30559e810b3537acac821b0fcab7c82fc","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-07-20 09:50:14.000000000","message":"Patch Set 8: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14861/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/14107/ : SUCCESS","accounts_in_message":[],"_revision_number":8},{"id":"c3282ff2ecae860caa5a463a7ad499f4bca78754","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-08-07 18:16:56.000000000","message":"Uploaded patch set 9.","accounts_in_message":[],"_revision_number":9},{"id":"4fa13c4e0701337588a3acb174633da81f300f0d","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-08-07 18:20:12.000000000","message":"Patch Set 9: Verified-1\n\nBuild Failed \n\nhttp://build.openocd.org/job/openocd-gerrit/14965/ : FAILURE\n\nhttp://build.openocd.org/job/openocd-gerrit-build/14200/ : FAILURE","accounts_in_message":[],"_revision_number":9},{"id":"de1802b4bd9fc929d51070c973be15622d899fd6","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-08-07 18:23:46.000000000","message":"Patch Set 9:\n\nI enabled this driver by default to let the build bot be able to test it","accounts_in_message":[],"_revision_number":9},{"id":"db7bf06b25d4d6895839d087622f44d7ed305968","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-08-11 16:52:00.000000000","message":"Patch Set 9:\n\n\u003e I enabled this driver by default to let the build bot be able to\n \u003e test it\n\nHello Jacek,\n\nbuild bot detected some compile issues. Please fix them.","accounts_in_message":[],"_revision_number":9},{"id":"92e7ad610f73aa95af0827de9af6f512bc8ad5b8","author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"real_author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"date":"2021-08-11 19:10:22.000000000","message":"Uploaded patch set 10.","accounts_in_message":[],"_revision_number":10},{"id":"abb97b7fdd7f0aef59adeac54ac71367f4a1c037","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-08-11 19:43:07.000000000","message":"Patch Set 10: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14989/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/14224/ : SUCCESS","accounts_in_message":[],"_revision_number":10},{"id":"a752d7f10f0f39ec0e21b04c8490a5e95122654e","author":{"_account_id":1001871,"name":"Jacek M Wuwer","email":"jacekmw8@gmail.com"},"real_author":{"_account_id":1001871,"name":"Jacek M Wuwer","email":"jacekmw8@gmail.com"},"date":"2021-08-12 06:30:46.000000000","message":"Patch Set 10:\n\nhi Oleksij, done. Interesting that my local build does not generate these warnings, must be the gcc version.","accounts_in_message":[],"_revision_number":10},{"id":"deb5bfcd0fbbbb104fc24673767d8e0d7b5b3c08","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-09-11 12:13:41.000000000","message":"Patch Set 10: Code-Review+1","accounts_in_message":[],"_revision_number":10},{"id":"6edc06785c272e3e94c557982dea50b4f08a2982","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-11 22:07:17.000000000","message":"Patch Set 10: Code-Review-1\n\n(50 comments)","accounts_in_message":[],"_revision_number":10},{"id":"0f37fcf9bc5ec67c44b2b523cae32f3df77ab103","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-12 20:48:27.000000000","message":"Patch Set 10:\n\n(2 comments)","accounts_in_message":[],"_revision_number":10},{"id":"1373c4c98e58fcf886dfb2dc21b4f530da94de18","author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"real_author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"date":"2021-09-16 09:48:59.000000000","message":"Patch Set 10:\n\n(52 comments)","accounts_in_message":[],"_revision_number":10},{"id":"5acff41ffa8e02a7426733a25877f62cc9a38187","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"real_author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"date":"2021-09-16 12:35:36.000000000","message":"Uploaded patch set 11.","accounts_in_message":[],"_revision_number":11},{"id":"083a72c08b56ad9102d50e79e914be5467223b25","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-09-16 12:58:21.000000000","message":"Patch Set 11: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15241/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14465/ : SUCCESS","accounts_in_message":[],"_revision_number":11},{"id":"eb866144abd97e99e9b14d2df15c126ef9407310","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-18 13:02:26.000000000","message":"Patch Set 11: Code-Review-1\n\n(60 comments)","accounts_in_message":[],"_revision_number":11},{"id":"d73fa3cb7ad2e4c641a9fd3a90ab7924808c67c4","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-18 13:08:50.000000000","message":"Patch Set 11:\n\n(1 comment)","accounts_in_message":[],"_revision_number":11},{"id":"762bb5cdbb2dfe373ac0c94495a649742f96ad99","author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"real_author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"date":"2021-10-07 15:25:41.000000000","message":"Patch Set 11:\n\n(60 comments)","accounts_in_message":[],"_revision_number":11},{"id":"3ed73695a6d215bc42c7ffff3b2724a24a717749","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"real_author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"date":"2021-10-08 09:30:35.000000000","message":"Uploaded patch set 12.","accounts_in_message":[],"_revision_number":12},{"id":"508212a097a434c6145558a2fa4367aef810f24e","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-10-08 09:43:59.000000000","message":"Patch Set 12: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15403/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14621/ : SUCCESS","accounts_in_message":[],"_revision_number":12},{"id":"522f4a49a8b491bd0ad7f8eddd349eec8269dc09","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-10-12 09:30:57.000000000","message":"Patch Set 12:\n\n(6 comments)","accounts_in_message":[],"_revision_number":12},{"id":"8a16719b5d4a09b1086659de330df1f8032ec76e","author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"real_author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"date":"2021-10-12 18:00:08.000000000","message":"Patch Set 12:\n\n(4 comments)","accounts_in_message":[],"_revision_number":12},{"id":"28b3b9909d68ab95fcdaa97db4b1dd860620bee8","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-10-16 08:58:02.000000000","message":"Patch Set 12:\n\n(1 comment)","accounts_in_message":[],"_revision_number":12},{"id":"628c8f5ba2a6dbd51e7322e302cd5867e20e1020","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"real_author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"date":"2021-10-21 18:44:14.000000000","message":"Uploaded patch set 13.","accounts_in_message":[],"_revision_number":13},{"id":"2b9c613eca6a456721bbd31b3bf090a4c97b2fbc","author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"real_author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"date":"2021-10-21 18:53:25.000000000","message":"Patch Set 13:\n\n(1 comment)","accounts_in_message":[],"_revision_number":13},{"id":"1e44b565ae90124943a4baab2d1461a2a06a1450","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-10-21 18:57:51.000000000","message":"Patch Set 13: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15434/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14652/ : SUCCESS","accounts_in_message":[],"_revision_number":13},{"id":"e2109b90821f0fff8af80a0f63c1424ff1808518","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-01 17:59:49.000000000","message":"Patch Set 13: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":13},{"id":"973f318d74ea45e4cce277d4aa25f515636f2198","author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"real_author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"date":"2021-11-04 08:50:15.000000000","message":"Patch Set 13:\n\n(11 comments)","accounts_in_message":[],"_revision_number":13},{"id":"f8e7ecd84a7c289c545e62c6d70a33a09a69d5dc","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2021-11-06 10:14:29.000000000","message":"Patch Set 13: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":13},{"id":"5548365bd4af4032f28daea7d616f040e1f6435d","author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"real_author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"date":"2021-11-08 16:24:13.000000000","message":"Patch Set 13:\n\n(3 comments)","accounts_in_message":[],"_revision_number":13},{"id":"03d6a9a6d05f7b013dacd231b51ec87a2ffad5a5","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-11-19 09:09:38.000000000","message":"Patch Set 13:\n\n(3 comments)","accounts_in_message":[],"_revision_number":13},{"id":"5062ae95d4decd940387657930f46cf23744c5b8","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-11-19 09:13:23.000000000","message":"Patch Set 13:\n\n(1 comment)","accounts_in_message":[],"_revision_number":13},{"id":"ca78e84a29386b4b7e806ee8b78971e4204eb2e7","author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"real_author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"date":"2021-11-19 14:21:37.000000000","message":"Patch Set 13:\n\n(1 comment)","accounts_in_message":[],"_revision_number":13},{"id":"8a0054c39890a9f10156fdbaec56bf8f0bd60683","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-11-24 08:25:18.000000000","message":"Patch Set 13: Code-Review+2","accounts_in_message":[],"_revision_number":13},{"id":"714e0aec355378b80c7b0b8b0c6cdae1771ad0dd","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2021-11-24 17:50:20.000000000","message":"Patch Set 13:\n\n(8 comments)","accounts_in_message":[],"_revision_number":13},{"id":"d17e4ee3760bf3e14f9b1bd4fedf12a1f8cdaeef","author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"real_author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"date":"2021-12-09 18:51:29.000000000","message":"Patch Set 13:\n\n(10 comments)","accounts_in_message":[],"_revision_number":13},{"id":"72c5b0d4fd45fdde15ce3f759c1151eff8a24e6d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"real_author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"date":"2021-12-09 18:58:58.000000000","message":"Uploaded patch set 14.","accounts_in_message":[],"_revision_number":14},{"id":"db30ea6409f18f9aba15e92fe6ebe0d73d6977a0","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-12-09 19:27:18.000000000","message":"Patch Set 14: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15690/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14907/ : SUCCESS","accounts_in_message":[],"_revision_number":14},{"id":"b203d302f205e1dedd100f0e1a2a3cb303e38dde","tag":"autogenerated:gerrit:deleteReviewer","author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"real_author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"date":"2021-12-09 19:29:45.000000000","message":"Removed reviewer Jacek M Wuwer.","accounts_in_message":[],"_revision_number":14},{"id":"fff6140a517187aa353f70ee2a0bd8329b5971b9","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2022-01-28 10:34:27.000000000","message":"Patch Set 14: Code-Review+2","accounts_in_message":[],"_revision_number":14},{"id":"280f9a5d770ca29932c2057b7904f1c9b40d44cd","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2022-01-30 11:12:00.000000000","message":"Patch Set 14: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":14},{"id":"0adbcee0632dc6798eca1474dbbc40750a411964","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-01-30 15:44:38.000000000","message":"Patch Set 14: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":14},{"id":"f40d3c8af3b909097c509b8efd80b346d4d1976a","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-02-14 15:12:10.000000000","message":"Change has been successfully cherry-picked as f998a2aaf19c14b46fd7f7dd50607a0904f40bd3","accounts_in_message":[],"_revision_number":15}],"current_revision":"f998a2aaf19c14b46fd7f7dd50607a0904f40bd3","revisions":{"d5feacc5b6ef6075fe3a36e8a8661a8092c1bf49":{"kind":"REWORK","_number":10,"created":"2021-08-11 19:10:22.000000000","uploader":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"ref":"refs/changes/97/6097/10","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/97/6097/10","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/10 \u0026\u0026 git checkout -b change-6097 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/10 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/10 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/10 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/97/6097/10","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/10 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3d9534b8a85d314f82440ce0e37632571c42245a","subject":"github/workflow: upgrade libraries in windows build to latest versions"}],"author":{"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","date":"2021-04-06 18:08:11.000000000","tz":120},"committer":{"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","date":"2021-08-11 19:08:20.000000000","tz":120},"subject":"Cadence virtual debug interface (vdebug) integration","message":"Cadence virtual debug interface (vdebug) integration\n\nChange-Id: I1bc105b3addc3f34161c2356c482ff3011e3f2cc\nSigned-off-by: Jacek Wuwer \u003cjacekmw8@gmail.com\u003e\n"}},"4fd6e4209a318bafb926e5f1b42dcc1ee2e068a5":{"kind":"REWORK","_number":11,"created":"2021-09-16 12:35:36.000000000","uploader":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"ref":"refs/changes/97/6097/11","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/97/6097/11","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/11 \u0026\u0026 git checkout -b change-6097 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/11 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/11 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/11 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/97/6097/11","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/11 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b61a280860f9ceb9bc38125c48d2f0f4d35f1c11","subject":"flash/stm32l4x: fix flash programming in 64-bit hosts"}],"author":{"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","date":"2021-04-06 18:08:11.000000000","tz":120},"committer":{"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","date":"2021-09-16 10:42:13.000000000","tz":120},"subject":"Cadence virtual debug interface (vdebug) integration","message":"Cadence virtual debug interface (vdebug) integration\n\nChange-Id: I1bc105b3addc3f34161c2356c482ff3011e3f2cc\nSigned-off-by: Jacek Wuwer \u003cjacekmw8@gmail.com\u003e\n"}},"b259752b438faf1e416c4ec8c759b8cafcc8dd34":{"kind":"REWORK","_number":8,"created":"2021-07-20 09:13:41.000000000","uploader":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"ref":"refs/changes/97/6097/8","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/97/6097/8","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/8 \u0026\u0026 git checkout -b change-6097 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/97/6097/8","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/8 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"65c9653cc768f77a5e8cf2af73e0f40d614bdec2","subject":"target: add support for 64bit data in mem2array and array2mem"}],"author":{"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","date":"2021-04-06 18:08:11.000000000","tz":120},"committer":{"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","date":"2021-07-20 09:15:19.000000000","tz":120},"subject":"Cadence virtual debug interface (vdebug) integration","message":"Cadence virtual debug interface (vdebug) integration\n\nChange-Id: I1bc105b3addc3f34161c2356c482ff3011e3f2cc\nSigned-off-by: Jacek Wuwer \u003cjacekmw8@gmail.com\u003e\n"}},"59a6a85fb8de422310dea788b6146870a1bb031f":{"kind":"REWORK","_number":9,"created":"2021-08-07 18:16:56.000000000","uploader":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"ref":"refs/changes/97/6097/9","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/97/6097/9","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/9 \u0026\u0026 git checkout -b change-6097 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/97/6097/9","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/9 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"65c9653cc768f77a5e8cf2af73e0f40d614bdec2","subject":"target: add support for 64bit data in mem2array and array2mem"}],"author":{"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","date":"2021-04-06 18:08:11.000000000","tz":120},"committer":{"name":"Oleksij Rempel","email":"linux@rempel-privat.de","date":"2021-08-07 18:16:29.000000000","tz":120},"subject":"Cadence virtual debug interface (vdebug) integration","message":"Cadence virtual debug interface (vdebug) integration\n\nChange-Id: I1bc105b3addc3f34161c2356c482ff3011e3f2cc\nSigned-off-by: Jacek Wuwer \u003cjacekmw8@gmail.com\u003e\n"}},"a00c26aab682bb430be2f73d6c713d83fc5cfd97":{"kind":"REWORK","_number":14,"created":"2021-12-09 18:58:58.000000000","uploader":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"ref":"refs/changes/97/6097/14","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/97/6097/14","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/14 \u0026\u0026 git checkout -b change-6097 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/14 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/14 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/14 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/97/6097/14","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/14 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b1de11616099fe97f3534fa0f268c10dfd6ecf2b","subject":"gdb_server: added and improved several debug prints"}],"author":{"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","date":"2021-04-06 18:08:11.000000000","tz":120},"committer":{"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","date":"2021-12-09 18:58:22.000000000","tz":60},"subject":"Cadence virtual debug interface (vdebug) integration","message":"Cadence virtual debug interface (vdebug) integration\n\nChange-Id: I1bc105b3addc3f34161c2356c482ff3011e3f2cc\nSigned-off-by: Jacek Wuwer \u003cjacekmw8@gmail.com\u003e\n"}},"f998a2aaf19c14b46fd7f7dd50607a0904f40bd3":{"kind":"REWORK","_number":15,"created":"2022-02-14 15:12:10.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/97/6097/15","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/97/6097/15","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/15 \u0026\u0026 git checkout -b change-6097 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/15 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/15 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/15 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/97/6097/15","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/15 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2a2636f138dc40be3fff06cb7bf1f126d906e0a1","subject":"doxygen: fix some function prototype description"}],"author":{"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","date":"2021-04-06 18:08:11.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-02-14 15:12:10.000000000","tz":0},"subject":"Cadence virtual debug interface (vdebug) integration","message":"Cadence virtual debug interface (vdebug) integration\n\nChange-Id: I1bc105b3addc3f34161c2356c482ff3011e3f2cc\nSigned-off-by: Jacek Wuwer \u003cjacekmw8@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6097\nTested-by: jenkins\nReviewed-by: Oleksij Rempel \u003clinux@rempel-privat.de\u003e\nReviewed-by: zapb \u003cdev@zapb.de\u003e\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"3f85385b604c745788c68c8f3ed760c6d7685c71":{"kind":"REWORK","_number":12,"created":"2021-10-08 09:30:35.000000000","uploader":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"ref":"refs/changes/97/6097/12","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/97/6097/12","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/12 \u0026\u0026 git checkout -b change-6097 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/12 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/12 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/12 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/97/6097/12","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/12 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b61a280860f9ceb9bc38125c48d2f0f4d35f1c11","subject":"flash/stm32l4x: fix flash programming in 64-bit hosts"}],"author":{"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","date":"2021-04-06 18:08:11.000000000","tz":120},"committer":{"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","date":"2021-10-08 09:27:31.000000000","tz":120},"subject":"Cadence virtual debug interface (vdebug) integration","message":"Cadence virtual debug interface (vdebug) integration\n\nChange-Id: I1bc105b3addc3f34161c2356c482ff3011e3f2cc\nSigned-off-by: Jacek Wuwer \u003cjacekmw8@gmail.com\u003e\n"}},"8bff5a722b17bfb679d756b469e24bfba62da95b":{"kind":"REWORK","_number":13,"created":"2021-10-21 18:44:14.000000000","uploader":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"ref":"refs/changes/97/6097/13","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/97/6097/13","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/13 \u0026\u0026 git checkout -b change-6097 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/13 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/13 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/13 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/97/6097/13","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/13 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b61a280860f9ceb9bc38125c48d2f0f4d35f1c11","subject":"flash/stm32l4x: fix flash programming in 64-bit hosts"}],"author":{"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","date":"2021-04-06 18:08:11.000000000","tz":120},"committer":{"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","date":"2021-10-21 18:44:21.000000000","tz":120},"subject":"Cadence virtual debug interface (vdebug) integration","message":"Cadence virtual debug interface (vdebug) integration\n\nChange-Id: I1bc105b3addc3f34161c2356c482ff3011e3f2cc\nSigned-off-by: Jacek Wuwer \u003cjacekmw8@gmail.com\u003e\n"}},"e1d762d6172348dcd1019c568b0d789d5a247893":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2021-03-19 16:16:54.000000000","uploader":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"ref":"refs/changes/97/6097/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/97/6097/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/2 \u0026\u0026 git checkout -b change-6097 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/97/6097/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8d6f7c92239a54ce77d7a268f51b49445470fe00","subject":"flash/stm32l4x: zero init stm32l4_flash_bank struct on flash bank initialization"}],"author":{"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","date":"2021-03-12 15:57:20.000000000","tz":60},"committer":{"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","date":"2021-03-19 16:17:09.000000000","tz":60},"subject":"Cadence virtual debug interface (vdebug) integration","message":"Cadence virtual debug interface (vdebug) integration\n\nChange-Id: I1bc105b3addc3f34161c2356c482ff3011e3f2cc\nSigned-off-by: Jacek Wuwer \u003cjacekmw8@gmail.com\u003e\n"}},"dbbd0694116444f022dc950373413598af72a577":{"kind":"REWORK","_number":3,"created":"2021-04-06 18:36:54.000000000","uploader":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"ref":"refs/changes/97/6097/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/97/6097/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/3 \u0026\u0026 git checkout -b change-6097 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/97/6097/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"68e50415a115f3b80b7d1a1b580287745b281a5c","subject":"openocd: drop dependency from libusb0"}],"author":{"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","date":"2021-04-06 18:08:11.000000000","tz":120},"committer":{"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","date":"2021-04-06 18:30:56.000000000","tz":120},"subject":"Cadence virtual debug interface (vdebug) integration","message":"Cadence virtual debug interface (vdebug) integration\n\nChange-Id: I1bc105b3addc3f34161c2356c482ff3011e3f2cc\nSigned-off-by: Jacek Wuwer \u003cjacekmw8@gmail.com\u003e\n"}},"5727e30ac46c281e7e3925798abcc8dcba6bd2ff":{"kind":"REWORK","_number":1,"created":"2021-03-12 15:56:08.000000000","uploader":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"ref":"refs/changes/97/6097/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/97/6097/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/1 \u0026\u0026 git checkout -b change-6097 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/97/6097/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4c00f96fc2e32397da5b46ca3428a992333548da","subject":"configure.ac: switch to autoconf 2.69"}],"author":{"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","date":"2021-03-12 15:57:20.000000000","tz":60},"committer":{"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","date":"2021-03-12 15:57:20.000000000","tz":60},"subject":"Cadence virtual debug interface (vdebug) integration","message":"Cadence virtual debug interface (vdebug) integration\n\nChange-Id: I1bc105b3addc3f34161c2356c482ff3011e3f2cc\nSigned-off-by: Jacek Wuwer \u003cjacekmw8@gmail.com\u003e\n"}},"0c525276762ff2486217df549d7246014a183421":{"kind":"REWORK","_number":6,"created":"2021-05-18 13:47:30.000000000","uploader":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"ref":"refs/changes/97/6097/6","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/97/6097/6","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/6 \u0026\u0026 git checkout -b change-6097 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/97/6097/6","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bbbfddc3efd4a93b0c9489c2537efbaa117bcfb0","subject":"jimtcl: restrict memory leak workaround on Linux only"}],"author":{"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","date":"2021-04-06 18:08:11.000000000","tz":120},"committer":{"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","date":"2021-05-18 13:50:22.000000000","tz":120},"subject":"Cadence virtual debug interface (vdebug) integration","message":"Cadence virtual debug interface (vdebug) integration\n\nChange-Id: I1bc105b3addc3f34161c2356c482ff3011e3f2cc\nSigned-off-by: Jacek Wuwer \u003cjacekmw8@gmail.com\u003e\n"}},"4b6ec15901e274a992a925a7a63c427758a57cc4":{"kind":"REWORK","_number":7,"created":"2021-07-08 18:52:31.000000000","uploader":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"ref":"refs/changes/97/6097/7","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/97/6097/7","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/7 \u0026\u0026 git checkout -b change-6097 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/97/6097/7","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/7 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"28c91b8f80937e6ec6521496f363038d9a5f9a04","subject":"tcl: Update Flyswatter product links"}],"author":{"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","date":"2021-04-06 18:08:11.000000000","tz":120},"committer":{"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","date":"2021-07-08 18:41:42.000000000","tz":120},"subject":"Cadence virtual debug interface (vdebug) integration","message":"Cadence virtual debug interface (vdebug) integration\n\nChange-Id: I1bc105b3addc3f34161c2356c482ff3011e3f2cc\nSigned-off-by: Jacek Wuwer \u003cjacekmw8@gmail.com\u003e\n"}},"b30b1cee69f1aabe67633b025798d637043c7c87":{"kind":"REWORK","_number":4,"created":"2021-04-06 18:42:06.000000000","uploader":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"ref":"refs/changes/97/6097/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/97/6097/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/4 \u0026\u0026 git checkout -b change-6097 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/97/6097/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"68e50415a115f3b80b7d1a1b580287745b281a5c","subject":"openocd: drop dependency from libusb0"}],"author":{"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","date":"2021-04-06 18:08:11.000000000","tz":120},"committer":{"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","date":"2021-04-06 18:44:25.000000000","tz":120},"subject":"Cadence virtual debug interface (vdebug) integration","message":"Cadence virtual debug interface (vdebug) integration\n\nChange-Id: I1bc105b3addc3f34161c2356c482ff3011e3f2cc\nSigned-off-by: Jacek Wuwer \u003cjacekmw8@gmail.com\u003e\n"}},"f3b5c9be0b8949651a1ff080f3c82467b09351c0":{"kind":"REWORK","_number":5,"created":"2021-05-17 10:11:39.000000000","uploader":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"ref":"refs/changes/97/6097/5","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/97/6097/5","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/5 \u0026\u0026 git checkout -b change-6097 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/97/6097/5","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/97/6097/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bbbfddc3efd4a93b0c9489c2537efbaa117bcfb0","subject":"jimtcl: restrict memory leak workaround on Linux only"}],"author":{"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","date":"2021-04-06 18:08:11.000000000","tz":120},"committer":{"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","date":"2021-05-17 10:07:37.000000000","tz":120},"subject":"Cadence virtual debug interface (vdebug) integration","message":"Cadence virtual debug interface (vdebug) integration\n\nChange-Id: I1bc105b3addc3f34161c2356c482ff3011e3f2cc\nSigned-off-by: Jacek Wuwer \u003cjacekmw8@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}