)]}'
{"id":"openocd~master~If9fd09b002e6c531a76963054847580b65180371","project":"openocd","branch":"master","attention_set":{"1002145":{"account":{"_account_id":1002145,"name":"Ben Campbell","username":"benjacam"},"last_update":"2023-06-08 13:14:34.000000000","reason":"\u003cGERRIT_ACCOUNT_1000697\u003e replied on the change","reason_account":{"_account_id":1000697,"name":"Fredrik Hederstierna","email":"fredrik.hederstierna@gmail.com"}},"1001959":{"account":{"_account_id":1001959,"name":"Michael T","username":"knieriem"},"last_update":"2022-03-10 08:20:30.000000000","reason":"Henrik Persson replied on the change"},"1000859":{"account":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"last_update":"2023-05-22 11:33:02.000000000","reason":"\u003cGERRIT_ACCOUNT_1002145\u003e replied on the change","reason_account":{"_account_id":1002145,"name":"Ben Campbell","username":"benjacam"}}},"removed_from_attention_set":{"1001127":{"account":{"_account_id":1001127,"name":"Steven Stallion","email":"sstallion@gmail.com","username":"sstallion"},"last_update":"2021-11-03 18:12:55.000000000","reason":"Steven Stallion replied on the change"},"1000697":{"account":{"_account_id":1000697,"name":"Fredrik Hederstierna","email":"fredrik.hederstierna@gmail.com"},"last_update":"2023-06-08 13:14:34.000000000","reason":"\u003cGERRIT_ACCOUNT_1000697\u003e replied on the change","reason_account":{"_account_id":1000697,"name":"Fredrik Hederstierna","email":"fredrik.hederstierna@gmail.com"}}},"hashtags":[],"change_id":"If9fd09b002e6c531a76963054847580b65180371","subject":"WIP: support EFM32 series 2 devices","status":"NEW","created":"2021-04-20 23:08:27.000000000","updated":"2026-01-25 15:40:40.000000000","submit_type":"CHERRY_PICK","mergeable":false,"submittable":false,"total_comment_count":10,"unresolved_comment_count":3,"has_review_started":true,"meta_rev_id":"f2c85c2a3e063f22f5da06e98bc1948b8cf6f915","_number":6173,"owner":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"actions":{},"labels":{"Verified":{"rejected":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"_account_id":1001127,"name":"Steven Stallion","email":"sstallion@gmail.com","username":"sstallion"},{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},{"value":-1,"date":"2021-04-20 23:09:16.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0,"blocking":true},"Code-Review":{"disliked":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"all":[{"value":0,"date":"2021-11-03 18:12:55.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1001127,"name":"Steven Stallion","email":"sstallion@gmail.com","username":"sstallion"},{"value":-1,"date":"2021-04-20 23:10:08.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","value":-1,"default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1000697,"name":"Fredrik Hederstierna","email":"fredrik.hederstierna@gmail.com"},{"_account_id":1001959,"name":"Michael T","username":"knieriem"},{"_account_id":1001962,"name":"Henrik Persson","email":"henrik.persson@mikrodust.com","username":"mikrodust-henrikp"},{"_account_id":1002145,"name":"Ben Campbell","username":"benjacam"}],"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},{"_account_id":1001127,"name":"Steven Stallion","email":"sstallion@gmail.com","username":"sstallion"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-04-20 23:09:16.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-04-21 19:25:12.000000000","updated_by":{"_account_id":1001127,"name":"Steven Stallion","email":"sstallion@gmail.com","username":"sstallion"},"reviewer":{"_account_id":1001127,"name":"Steven Stallion","email":"sstallion@gmail.com","username":"sstallion"},"state":"REVIEWER"},{"updated":"2021-10-29 08:18:09.000000000","updated_by":{"_account_id":1000697,"name":"Fredrik Hederstierna","email":"fredrik.hederstierna@gmail.com"},"reviewer":{"_account_id":1000697,"name":"Fredrik Hederstierna","email":"fredrik.hederstierna@gmail.com"},"state":"CC"},{"updated":"2022-02-08 23:11:30.000000000","updated_by":{"_account_id":1001959,"name":"Michael T","username":"knieriem"},"reviewer":{"_account_id":1001959,"name":"Michael T","username":"knieriem"},"state":"CC"},{"updated":"2022-03-10 08:20:30.000000000","updated_by":{"_account_id":1001962,"name":"Henrik Persson","email":"henrik.persson@mikrodust.com","username":"mikrodust-henrikp"},"reviewer":{"_account_id":1001962,"name":"Henrik Persson","email":"henrik.persson@mikrodust.com","username":"mikrodust-henrikp"},"state":"CC"},{"updated":"2023-05-22 11:33:02.000000000","updated_by":{"_account_id":1002145,"name":"Ben Campbell","username":"benjacam"},"reviewer":{"_account_id":1002145,"name":"Ben Campbell","username":"benjacam"},"state":"CC"},{"updated":"2026-01-25 15:40:40.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"CC"}],"messages":[{"id":"43942e26e2154a799915cb67d1522290f734f9d9","author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"real_author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"date":"2021-04-20 23:08:27.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"058ab26adf32d83ef369a9f9570c93367dfaba83","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-04-20 23:09:16.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttp://build.openocd.org/job/openocd-gerrit/14394/ : FAILURE\n\nhttp://build.openocd.org/job/openocd-gerrit-build/13648/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"0d015c9621026acee7991c25023ff3f160753e9e","author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"real_author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"date":"2021-04-20 23:10:08.000000000","message":"Patch Set 1: Code-Review-1\n\nNOTE! this is only a draft in case someone wants to pick it up at any stage before me.  Hopefully it proves useful or at least starts.  I\u0027ve not (yet?) retested this with older parts, I only have a series 0 and series 2 board.  This at least got me to debugging, which wasn\u0027t supported before.","accounts_in_message":[],"_revision_number":1},{"id":"d33be3db03c838f11cb430930ed0fc3de46efb7d","author":{"_account_id":1001127,"name":"Steven Stallion","email":"sstallion@gmail.com","username":"sstallion"},"real_author":{"_account_id":1001127,"name":"Steven Stallion","email":"sstallion@gmail.com","username":"sstallion"},"date":"2021-04-21 19:23:51.000000000","message":"Patch Set 1:\n\nHey Karl! I actually have some changes to the side to support Series 2 SoC\u0027s as well - I\u0027ve been meaning to get it polished up for submission. If you like, I can send you the diff to merge into your changes. LMK!","accounts_in_message":[],"_revision_number":1},{"id":"f770888430a54a8c41b6d905a2724cca05c4ee3c","author":{"_account_id":1001127,"name":"Steven Stallion","email":"sstallion@gmail.com","username":"sstallion"},"real_author":{"_account_id":1001127,"name":"Steven Stallion","email":"sstallion@gmail.com","username":"sstallion"},"date":"2021-04-21 19:25:12.000000000","message":"Patch Set 1:\n\n\u003e Hey Karl! I actually have some changes to the side to support\n \u003e Series 2 SoC\u0027s as well - I\u0027ve been meaning to get it polished up\n \u003e for submission. If you like, I can send you the diff to merge into\n \u003e your changes. LMK!\n\nI almost forgot - I have a fix for dealing with the core not halting problem as well. It\u0027s a bit of a pain, but has to do with jumping around the secure boot ROM a bit before continuing execution.","accounts_in_message":[],"_revision_number":1},{"id":"781e385d8087d86a82686f9192f280ee670ecfbb","author":{"_account_id":1000697,"name":"Fredrik Hederstierna","email":"fredrik.hederstierna@gmail.com"},"real_author":{"_account_id":1000697,"name":"Fredrik Hederstierna","email":"fredrik.hederstierna@gmail.com"},"date":"2021-10-29 08:18:09.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"bc8cce7181cc7111bf73ce9945d5e30e5e21562e","author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"real_author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"date":"2021-10-31 13:30:16.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"8c02052f5cd22c11205911c2293ae0d4cc9f9752","author":{"_account_id":1000697,"name":"Fredrik Hederstierna","email":"fredrik.hederstierna@gmail.com"},"real_author":{"_account_id":1000697,"name":"Fredrik Hederstierna","email":"fredrik.hederstierna@gmail.com"},"date":"2021-11-03 06:42:07.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"78f610dec559bb3e5f512d974e45853325a250e5","author":{"_account_id":1001127,"name":"Steven Stallion","email":"sstallion@gmail.com","username":"sstallion"},"real_author":{"_account_id":1001127,"name":"Steven Stallion","email":"sstallion@gmail.com","username":"sstallion"},"date":"2021-11-03 18:12:55.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f5d7a5c612714873b70869105cbe7e2c1051e3d5","author":{"_account_id":1001959,"name":"Michael T","username":"knieriem"},"real_author":{"_account_id":1001959,"name":"Michael T","username":"knieriem"},"date":"2022-02-08 23:11:30.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"9bc41a793ec45d58e5070f6b28fa397857496a4c","author":{"_account_id":1001962,"name":"Henrik Persson","email":"henrik.persson@mikrodust.com","username":"mikrodust-henrikp"},"real_author":{"_account_id":1001962,"name":"Henrik Persson","email":"henrik.persson@mikrodust.com","username":"mikrodust-henrikp"},"date":"2022-03-10 08:20:30.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"6588b0e35fc414940cc8c2f8fa15f12016ae9094","author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"real_author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"date":"2022-03-12 17:46:09.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"cbc36054761ae2eef07d1c94f0e48745a7204b5e","author":{"_account_id":1002145,"name":"Ben Campbell","username":"benjacam"},"real_author":{"_account_id":1002145,"name":"Ben Campbell","username":"benjacam"},"date":"2023-05-22 11:33:02.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"d0a41e4c0c6179499ee48cd068b292bce17e1160","author":{"_account_id":1000697,"name":"Fredrik Hederstierna","email":"fredrik.hederstierna@gmail.com"},"real_author":{"_account_id":1000697,"name":"Fredrik Hederstierna","email":"fredrik.hederstierna@gmail.com"},"date":"2023-06-08 13:14:34.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f2c85c2a3e063f22f5da06e98bc1948b8cf6f915","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2026-01-25 15:40:40.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1}],"current_revision":"60dc0ddee971e5b26b77b6cc195cba259c8cb6e4","revisions":{"60dc0ddee971e5b26b77b6cc195cba259c8cb6e4":{"kind":"REWORK","_number":1,"created":"2021-04-20 23:08:27.000000000","uploader":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"ref":"refs/changes/73/6173/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/73/6173/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/73/6173/1 \u0026\u0026 git checkout -b change-6173 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/73/6173/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/73/6173/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/73/6173/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/73/6173/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/73/6173/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ff755a575ebf0218c2eb8745eff8050f8f02a53d","subject":"drivers/cmsis-dap: flush read"}],"author":{"name":"Karl Palsson","email":"karlp@tweak.net.au","date":"2021-04-20 23:04:56.000000000","tz":0},"committer":{"name":"Karl Palsson","email":"karlp@tweak.net.au","date":"2021-04-20 23:04:56.000000000","tz":0},"subject":"WIP: support EFM32 series 2 devices","message":"WIP: support EFM32 series 2 devices\n\nPreliminary support for, at least, the EFR32xG22 Series 2 devices from\nSiLabs.  These are Cortex-M33, and have a very different \"MSC\"\nblock.  At this stage, debugging is supported, and most of what should\nbe necessary for flash operations is supported, but I run into problems\nwith the core not halting before it even tries flash operations :(\n\nThe offsets of MSC registers have changed, so the existing loader cannot\nwork, and has been set to fallback to word by word for now.\n\nLock bits reading is implemented for normal pages, but not for any of\nthe special pages, and lock bits writing is completely unsupported.\n\nPrinting out nice part names is not finished, unsure how to chain the\ndescriptors.\n\nChange-Id: If9fd09b002e6c531a76963054847580b65180371\nSigned-off-by: Karl Palsson \u003ckarlp@tweak.net.au\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Verified","status":"REJECT","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"NEED"}]}],"submit_requirements":[{"name":"Verified","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"]}},{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}}]}