)]}'
{"id":"openocd~master~I10d91371b5a89d2a3c8599bce766f97eac44f0d9","project":"openocd","branch":"master","topic":"for_jim0.81","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2021-11-07 22:21:03.000000000","reason":"Antonio Borneo replied on the change"}},"hashtags":[],"change_id":"I10d91371b5a89d2a3c8599bce766f97eac44f0d9","subject":"Makefile: remove workaround for jimtcl 0.80","status":"MERGED","created":"2021-05-08 22:14:39.000000000","updated":"2021-11-07 22:21:20.000000000","submitted":"2021-11-07 22:21:20.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6227-for_jim0.81","meta_rev_id":"93f9e52f1f09bcc5c41fd95b0d08dd4a712e0467","_number":6227,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-07 22:21:20.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-07 22:21:20.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-11-07 22:21:20.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-05-13 18:40:59.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-08-31 04:20:13.000000000","updated_by":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"reviewer":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"state":"REVIEWER"}],"messages":[{"id":"40c2f0a4fb51af5efb5f54c847b31bd72162ac17","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-05-08 22:14:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"bcde9a70a3e6d062eb7ce76a3cc6e47749c34874","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-05-09 01:44:08.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14486/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/13740/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"99ff60d8021eafb027f5039bd7fcbeb0086cfd2c","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-05-13 14:17:15.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"31030c439ef0273ed2d7510cadb364426858859b","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-05-13 18:40:59.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14522/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/13776/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"ed925dd990642e41e4130497186afc2a8796a8f1","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-08-31 04:20:13.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"f231577bc7e375c349fcfabba2a2f6b1a6be1c0d","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-07 22:21:03.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"93f9e52f1f09bcc5c41fd95b0d08dd4a712e0467","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-07 22:21:20.000000000","message":"Change has been successfully cherry-picked as 8b1ee1b1f6d41a0f7d588b128a22e8d5abeb85a7","accounts_in_message":[],"_revision_number":3}],"current_revision":"8b1ee1b1f6d41a0f7d588b128a22e8d5abeb85a7","revisions":{"2b178d0d524b63889292c1d7f7c699a209f99c6c":{"kind":"REWORK","_number":1,"created":"2021-05-08 22:14:39.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/27/6227/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/27/6227/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/27/6227/1 \u0026\u0026 git checkout -b change-6227 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/27/6227/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/27/6227/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/27/6227/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/27/6227/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/27/6227/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"51054ae90fac69a548d9177dd7665c54b7969400","subject":"jimtcl: update to master branch 20210411"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-04-11 21:58:57.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-05-08 22:11:54.000000000","tz":120},"subject":"Makefile: remove workaround for jimtcl 0.80","message":"Makefile: remove workaround for jimtcl 0.80\n\nCommit 266a945ad3e8 (\"jimtcl: update to version 0.80 (2020-10-29)\")\nadds a workaround to permit \u0027make distcheck\u0027 with jimtcl 0.80.\nThis has been fixed in jimtcl with commit d224c9a2b7b2 (\"Makefile:\nremove examples.api/Makefile while \u0027distclean\u0027\").\n\nBy using jimtcl from latest master branch, the workaround is not\nrequired anymore.\n\nRemove the workaround.\n\nChange-Id: I10d91371b5a89d2a3c8599bce766f97eac44f0d9\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"8b1ee1b1f6d41a0f7d588b128a22e8d5abeb85a7":{"kind":"REWORK","_number":3,"created":"2021-11-07 22:21:20.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/27/6227/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/27/6227/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/27/6227/3 \u0026\u0026 git checkout -b change-6227 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/27/6227/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/27/6227/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/27/6227/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/27/6227/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/27/6227/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5148a1324aeef62d85aaeaa1c061df8e874e4c12","subject":"rtos: use struct member names instead of comments"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-04-11 21:58:57.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-11-07 22:21:20.000000000","tz":0},"subject":"Makefile: remove workaround for jimtcl 0.80","message":"Makefile: remove workaround for jimtcl 0.80\n\nCommit 266a945ad3e8 (\"jimtcl: update to version 0.80 (2020-10-29)\")\nadds a workaround to permit \u0027make distcheck\u0027 with jimtcl 0.80.\nThis has been fixed in jimtcl with commit d224c9a2b7b2 (\"Makefile:\nremove examples.api/Makefile while \u0027distclean\u0027\").\n\nBy using jimtcl from latest master branch, the workaround is not\nrequired anymore.\n\nRemove the workaround.\n\nChange-Id: I10d91371b5a89d2a3c8599bce766f97eac44f0d9\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6227\nTested-by: jenkins\nReviewed-by: Oleksij Rempel \u003clinux@rempel-privat.de\u003e\n"}},"89006e4c00c7e4f9229bd2f6232cd8992424495c":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2021-05-13 14:17:15.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/27/6227/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/27/6227/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/27/6227/2 \u0026\u0026 git checkout -b change-6227 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/27/6227/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/27/6227/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/27/6227/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/27/6227/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/27/6227/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"755f8acf61677346967b6803aa579022676bf610","subject":"jimtcl: update to master branch 20210411"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-04-11 21:58:57.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-05-13 14:15:28.000000000","tz":120},"subject":"Makefile: remove workaround for jimtcl 0.80","message":"Makefile: remove workaround for jimtcl 0.80\n\nCommit 266a945ad3e8 (\"jimtcl: update to version 0.80 (2020-10-29)\")\nadds a workaround to permit \u0027make distcheck\u0027 with jimtcl 0.80.\nThis has been fixed in jimtcl with commit d224c9a2b7b2 (\"Makefile:\nremove examples.api/Makefile while \u0027distclean\u0027\").\n\nBy using jimtcl from latest master branch, the workaround is not\nrequired anymore.\n\nRemove the workaround.\n\nChange-Id: I10d91371b5a89d2a3c8599bce766f97eac44f0d9\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}