)]}'
{"id":"openocd~master~I4e3866fe3b3d5c09628e3c900ca36874504fe6c0","project":"openocd","branch":"master","attention_set":{"1000160":{"account":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"last_update":"2022-06-01 23:05:17.000000000","reason":"Radivoje Jovanovic replied on the change"},"1001661":{"account":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"last_update":"2022-06-01 23:05:17.000000000","reason":"Radivoje Jovanovic replied on the change"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I4e3866fe3b3d5c09628e3c900ca36874504fe6c0","subject":"jtag: JTAG Driver remote debug support","status":"NEW","created":"2021-05-13 15:24:57.000000000","updated":"2022-06-01 23:05:17.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"09a5708dd18601f1d764f1ab2edaa990af6cb205","_number":6244,"owner":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"actions":{},"labels":{"Verified":{"rejected":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2021-05-13 19:22:50.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"value":-1,"date":"2021-05-13 23:30:38.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"date":"2021-05-13 19:20:31.000000000","_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0,"blocking":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"value":0,"date":"2021-05-13 16:56:57.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"}],"CC":[{"_account_id":1001996,"name":"Radivoje Jovanovic","email":"radivojejovanovic@gmail.com"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-05-13 16:56:57.000000000","updated_by":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"reviewer":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"state":"REVIEWER"},{"updated":"2021-05-13 19:22:50.000000000","updated_by":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"reviewer":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"state":"REVIEWER"},{"updated":"2021-05-13 23:30:38.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-06-01 23:05:17.000000000","updated_by":{"_account_id":1001996,"name":"Radivoje Jovanovic","email":"radivojejovanovic@gmail.com"},"reviewer":{"_account_id":1001996,"name":"Radivoje Jovanovic","email":"radivojejovanovic@gmail.com"},"state":"CC"}],"messages":[{"id":"41791d8d639e9fd3faf208ae4df1224f49bc098d","author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"real_author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"date":"2021-05-13 15:24:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f36c300da9641f080dc0d06ca3a659e47867f8b6","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2021-05-13 17:58:45.000000000","message":"Patch Set 1:\n\nHello Daniel,\nHave you seen http://openocd.zylin.com/#/c/5975/ , is this related? I\u0027m surprised you didn\u0027t notice my review for the kernel patch series.","accounts_in_message":[],"_revision_number":1},{"id":"4ca3efbfce63463281ea9dbe2e266a3498445953","author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"real_author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"date":"2021-05-13 18:41:46.000000000","message":"Patch Set 1:\n\nHi Paul,\n\nOffhand I\u0027m not sure if it is related but I\u0027ll review your submission. I wasn\u0027t aware of your review until now. The driver I upstreamed interfaces OpenOCD to the following Linux AST2500/AST2600 JTAG driver: \n\nhttps://lkml.org/lkml/2020/4/13/784\nhttps://github.com/facebook/openbmc-linux/blob/dev-5.6/\n\nDoes your driver interface with that OS driver?","accounts_in_message":[],"_revision_number":1},{"id":"1644833f040bb54189fddb60dddf95ee745842bb","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2021-05-13 18:44:54.000000000","message":"Patch Set 1:\n\nOf course, that\u0027s the one. My comments are all visible in kernel patchwork along with the full testing methodology. I\u0027m surprised you didn\u0027t face the issues with the driver (at least the probe failing).","accounts_in_message":[],"_revision_number":1},{"id":"8be6d1da123953885a62bf5566b6a793e505fb94","author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"real_author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"date":"2021-05-13 19:00:08.000000000","message":"Patch Set 1:\n\nPaul, thanks for bringing your OS JTAG driver to my attention and I wasn\u0027t aware of it until now. With my driver SW mode worked for me with no issues. I did have problems with HW mode but I was able to work around them in the interface driver I submitted and get it working. My driver works with the Facebook dev-5.6 branch.\nhttps://github.com/facebook/openbmc-linux\n\nI\u0027ll review your driver and get back to you. Give me a few weeks. Thanks.","accounts_in_message":[],"_revision_number":1},{"id":"084abf765fec1bc8bf1b8f6b929f5c43452e78ab","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2021-05-13 19:06:21.000000000","message":"Patch Set 1:\n\nI\u0027m rather surprised the kernel driver was able to probe for you, probably their branch is not exactly the same as v29 as posted :/\n\nIn any case neither yours nor mine implementations are going to be directly useful as the kernel JTAG driver (and its API) will be seriously changed before getting upstream.\n\nBTW, you didn\u0027t mention what kind of usecases were tested on your platform with this current implementation.","accounts_in_message":[],"_revision_number":1},{"id":"77fcd9ab6770014d2d7e94005461c0b96772df96","author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"real_author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"date":"2021-05-13 19:13:48.000000000","message":"Patch Set 1:\n\nIt\u0027s been tested with OpenBMC on Ampere Altra and Altra Max servers. The servers use an AST2500 BMC. We\u0027re able to run OpenOCD inside OpenBMC running on the AST2500 and connect to Ampere Altra/Altra Max parts. I imported the Facebook dev-5.6 OS JTAG driver into OpenBMC and connect OpenOCD (running into OpenBMC) to it.","accounts_in_message":[],"_revision_number":1},{"id":"b76f669d80f575ad1f0ef89e0ec3248227d63d60","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2021-05-13 19:15:59.000000000","message":"Patch Set 1:\n\nFor debugging or just playing back SVF?","accounts_in_message":[],"_revision_number":1},{"id":"f130e56dcecf012462070ce6f921d889e5e749b1","author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"real_author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"date":"2021-05-13 19:20:31.000000000","message":"Patch Set 1:\n\nDebugging - Invasive external debug. Although with the right configuration file SVF could be supported as well I suppose.","accounts_in_message":[],"_revision_number":1},{"id":"e14b6a50f6f8307fc25e6dd79abaede43eac0d2b","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2021-05-13 19:22:50.000000000","message":"Patch Set 1:\n\nThank you, that\u0027s an interesting data point.","accounts_in_message":[],"_revision_number":1},{"id":"ebca21a6d21878e978e372c85f27b191b5a1282c","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-05-13 23:30:38.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttp://build.openocd.org/job/openocd-gerrit-build/13787/ : FAILURE\n\nhttp://build.openocd.org/job/openocd-gerrit/14533/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"09a5708dd18601f1d764f1ab2edaa990af6cb205","author":{"_account_id":1001996,"name":"Radivoje Jovanovic","email":"radivojejovanovic@gmail.com"},"real_author":{"_account_id":1001996,"name":"Radivoje Jovanovic","email":"radivojejovanovic@gmail.com"},"date":"2022-06-01 23:05:17.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1}],"current_revision":"723a20e6f860ac6968493ce626bdb0938ee824c5","revisions":{"723a20e6f860ac6968493ce626bdb0938ee824c5":{"kind":"REWORK","_number":1,"created":"2021-05-13 15:24:57.000000000","uploader":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"ref":"refs/changes/44/6244/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/44/6244/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/44/6244/1 \u0026\u0026 git checkout -b change-6244 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/44/6244/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/44/6244/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/44/6244/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/44/6244/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/44/6244/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"77b28ced14321fbedb9493729a377856bab28144","subject":"rtos: Add support for Zephyr RTOS"}],"author":{"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","date":"2021-03-04 17:30:00.000000000","tz":-300},"committer":{"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","date":"2021-05-13 15:23:28.000000000","tz":-240},"subject":"jtag: JTAG Driver remote debug support","message":"jtag: JTAG Driver remote debug support\n\nAdd remote debug support for the upstream community OS JTAG driver.\n\nBoth software and hardware accelerated remote debug modes for the\nupstream community OS JTAG driver are supported.\n\nTested on an Ampere dual socket Mt. Jade system with an AST2500 BMC\n\nChange-Id: I4e3866fe3b3d5c09628e3c900ca36874504fe6c0\nSigned-off-by: Daniel Goehring \u003cdgoehrin@os.amperecomputing.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Verified","status":"REJECT","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"NEED"}]}],"submit_requirements":[{"name":"Verified","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"]}},{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}}]}