)]}'
{"id":"openocd~master~I76dba9e54a647d3b9fbf1b7e9ae1844e3d7adc9a","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2021-08-30 13:52:04.000000000","reason":"Antonio Borneo replied on the change"}},"hashtags":[],"change_id":"I76dba9e54a647d3b9fbf1b7e9ae1844e3d7adc9a","subject":"Makefile: drop warning suppression on win build","status":"MERGED","created":"2021-05-15 23:09:16.000000000","updated":"2021-08-30 13:52:12.000000000","submitted":"2021-08-30 13:52:12.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6254","meta_rev_id":"18136530dbddeac63f7d75fedb5ca2f6340314d2","_number":6254,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000019,"name":"Xiaofan Chen","email":"xiaofanc@gmail.com","username":"xiaofan"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-08-30 13:52:12.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-08-30 13:52:12.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000019,"name":"Xiaofan Chen","email":"xiaofanc@gmail.com","username":"xiaofan"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-08-30 13:52:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000019,"name":"Xiaofan Chen","email":"xiaofanc@gmail.com","username":"xiaofan"},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-05-16 00:46:12.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-08-23 09:04:23.000000000","updated_by":{"_account_id":1000019,"name":"Xiaofan Chen","email":"xiaofanc@gmail.com","username":"xiaofan"},"reviewer":{"_account_id":1000019,"name":"Xiaofan Chen","email":"xiaofanc@gmail.com","username":"xiaofan"},"state":"REVIEWER"}],"messages":[{"id":"e2cf937a5fe0197a2fd784c25b458a4f9ef9d7cd","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-05-15 23:09:16.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3ab3d0e9c9815a18cf737817d03ac628aaa713fd","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-05-16 00:46:12.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14560/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/13812/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"09b564fa10c0fd54f28b9d503a527edc95918d40","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-05-16 09:18:32.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"504aa0446a08b938ac8932ee103292e26294f41e","author":{"_account_id":1000019,"name":"Xiaofan Chen","email":"xiaofanc@gmail.com","username":"xiaofan"},"real_author":{"_account_id":1000019,"name":"Xiaofan Chen","email":"xiaofanc@gmail.com","username":"xiaofan"},"date":"2021-08-23 09:04:23.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"2b06da6ac066be2e2470e4edf9f243cc74b919bb","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-30 13:52:04.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"18136530dbddeac63f7d75fedb5ca2f6340314d2","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-30 13:52:12.000000000","message":"Change has been successfully cherry-picked as 12e2dfd31ff07d9d13c7f66b799fad90a2698428","accounts_in_message":[],"_revision_number":2}],"current_revision":"12e2dfd31ff07d9d13c7f66b799fad90a2698428","revisions":{"12e2dfd31ff07d9d13c7f66b799fad90a2698428":{"kind":"REWORK","_number":2,"created":"2021-08-30 13:52:12.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/54/6254/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/54/6254/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/54/6254/2 \u0026\u0026 git checkout -b change-6254 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/54/6254/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/54/6254/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/54/6254/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/54/6254/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/54/6254/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b3a51bbb590cca6d6536532d8c0965748410f277","subject":"helper: remove fix for libusb pre-v1.0.9"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-05-15 21:14:18.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-08-30 13:52:12.000000000","tz":0},"subject":"Makefile: drop warning suppression on win build","message":"Makefile: drop warning suppression on win build\n\nCommit dcdf71c21b99 (\"- fix signed/unsigned build errors under\nwin32. Thanks Zach Welch \u003czw@superlucidity.net\u003e\") in 2009 prevents\ngcc warnings on sign/unsigned comparisons while building for Win\non folders \u0027helper\u0027 and \u0027server\u0027.\nIn 2011, commit b69119668ed8 (\"RTOS Thread awareness support wip\")\nuses the same method on the new folder \u0027rtos\u0027.\n\nIn mean time, all the incorrect sign/unsigned comparisons has been\nfixed and no warning is present with the default -Wextra flag that\nimplies -Wsign-compare.\nThe comment:\n\t# FD_* macros are sloppy with their signs on MinGW32 platform\nseems linked to some old implementation of MinGW32 include file\nthat doesn\u0027t apply on current versions.\n\nRemove the obsolete hacks to suppress the warnings.\n\nChange-Id: I76dba9e54a647d3b9fbf1b7e9ae1844e3d7adc9a\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6254\nTested-by: jenkins\nReviewed-by: Xiaofan Chen \u003cxiaofanc@gmail.com\u003e\n"}},"f8ac92c075b2625ce79e5feaee700879db4fa7ec":{"kind":"REWORK","_number":1,"created":"2021-05-15 23:09:16.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/54/6254/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/54/6254/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/54/6254/1 \u0026\u0026 git checkout -b change-6254 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/54/6254/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/54/6254/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/54/6254/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/54/6254/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/54/6254/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5445862a552665ff2bc58a6e89f2e6b165e9ce36","subject":"helper: remove fix for libusb pre-v1.0.9"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-05-15 21:14:18.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-05-15 23:08:03.000000000","tz":120},"subject":"Makefile: drop warning suppression on win build","message":"Makefile: drop warning suppression on win build\n\nCommit dcdf71c21b99 (\"- fix signed/unsigned build errors under\nwin32. Thanks Zach Welch \u003czw@superlucidity.net\u003e\") in 2009 prevents\ngcc warnings on sign/unsigned comparisons while building for Win\non folders \u0027helper\u0027 and \u0027server\u0027.\nIn 2011, commit b69119668ed8 (\"RTOS Thread awareness support wip\")\nuses the same method on the new folder \u0027rtos\u0027.\n\nIn mean time, all the incorrect sign/unsigned comparisons has been\nfixed and no warning is present with the default -Wextra flag that\nimplies -Wsign-compare.\nThe comment:\n\t# FD_* macros are sloppy with their signs on MinGW32 platform\nseems linked to some old implementation of MinGW32 include file\nthat doesn\u0027t apply on current versions.\n\nRemove the obsolete hacks to suppress the warnings.\n\nChange-Id: I76dba9e54a647d3b9fbf1b7e9ae1844e3d7adc9a\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}