)]}'
{"id":"openocd~master~Id29213c85ee5c7c487cfee21554f5a7ea50db6c9","project":"openocd","branch":"master","topic":"stm32l5x","attention_set":{},"removed_from_attention_set":{"1000863":{"account":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"last_update":"2021-09-11 14:09:35.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"Id29213c85ee5c7c487cfee21554f5a7ea50db6c9","subject":"flash/stm32l4x: introduce flash programming without loader","status":"MERGED","created":"2021-05-25 14:25:03.000000000","updated":"2021-09-15 05:55:08.000000000","submitted":"2021-08-26 06:27:17.000000000","submitter":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"total_comment_count":10,"unresolved_comment_count":2,"has_review_started":true,"submission_id":"6273-stm32l5x","meta_rev_id":"601e4d63b7bd02651be69ffe323677b9a609e986","_number":6273,"owner":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"value":0,"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-08-26 06:27:17.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-08-26 06:27:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-08-26 06:27:17.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-05-25 16:07:59.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2021-08-14 16:01:50.000000000","updated_by":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"reviewer":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"state":"REVIEWER"},{"updated":"2021-08-16 09:01:07.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2021-08-16 14:02:45.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"7cdc385366988e995c2ce5a84013c94ce3e5781b","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-05-25 14:25:03.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"255228ceaef644aa83fa12f614f4cf3ebd88f2f2","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-05-25 15:05:16.000000000","message":"Patch Set 1:\n\nIf I recall correctly (I don\u0027t work in flash framework from ages) there should be a kind of automatic check: if workarea cannot be allocated (not enough memory or workarea not set at all), then the loader is not used and some fallback mechanism is used in place with a warning to the user.\nDo we really need an extra command for this fallback?","accounts_in_message":[],"_revision_number":1},{"id":"eb0935ce08d7c5c42ea1db623a42ce72c39b488e","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-05-25 16:04:06.000000000","message":"Patch Set 1:\n\n(2 comments)\n\n\u003e If I recall correctly (I don\u0027t work in flash framework from ages)\n \u003e there should be a kind of automatic check: if workarea cannot be\n \u003e allocated (not enough memory or workarea not set at all), then the\n \u003e loader is not used and some fallback mechanism is used in place\n \u003e with a warning to the user.\n \u003e Do we really need an extra command for this fallback?\n\nmy understanding is that not all drivers do need a workarea to perform flash programming, as you hinted in another change review (possibly the programming could be done without target using jtag for example)\nso there is no global check on workarea availability before calling the .write() function.\nand this should managed in each driver (if needed)\n\nIn this change the fallback to no-loader mode, is done without the command, please check [2]\n\nthe command is added only to disable the loader in some conditions that could be managed in target configuration files (this could be used in IDE level with STM32L5 in RDP level 0.5, where we are not sure that the configured workarea is non-secure RAM)","accounts_in_message":[],"_revision_number":1},{"id":"cde4c382190dff688a030fc4c7f20e6ab1dcf6ff","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-05-25 17:06:14.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14621/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/13873/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"11b1be4f521c851efb3571d8d43140a14c649d1e","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-05 14:10:54.000000000","message":"Topic set to stm32l5x","accounts_in_message":[],"_revision_number":1},{"id":"9b54147c4af933300448b804703776a5b11b80c8","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-05 14:12:08.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"54389fdd5fa91b0bc80b03f69d16914a51ef1ec6","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-05 15:00:50.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"b3d5c4199cdc96526b243117117d1c1b583ab44d","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-08-05 18:00:49.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14956/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/14191/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"c5505382cdc331eb6de9467f5075251f633a409a","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-12 02:34:59.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"e277b9f0de7f5bef68ba466478686f936e3a0e20","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-08-12 05:15:32.000000000","message":"Patch Set 4: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14994/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/14229/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"e0602e60cc5c11767612b515af5732ba5b82df60","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-13 21:50:03.000000000","message":"Uploaded patch set 5: Patch Set 4 was rebased.","accounts_in_message":[],"_revision_number":5},{"id":"72b70b9c45c93127e7309f7054f1c339668fcb6e","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-13 23:00:23.000000000","message":"Uploaded patch set 6: Patch Set 5 was rebased.","accounts_in_message":[],"_revision_number":6},{"id":"3580875204aaff9d78f06f3a627b59589ff60fe9","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-08-14 00:56:40.000000000","message":"Patch Set 6: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/15007/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/14241/ : SUCCESS","accounts_in_message":[],"_revision_number":6},{"id":"5c6ade1a501b3d5c8fd13a3f3f5b587eb1ad2e26","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-08-14 05:30:49.000000000","message":"Patch Set 6: Code-Review-2\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"a269d96adf955d5d83a21901a87d0c62bd911e36","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-14 13:32:14.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"e81a421f22ab734457da316fa941bbf9d30a13ed","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-14 13:39:41.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"a8e0548ab3b561f26c9a967d67522436518d58ed","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-08-14 15:51:17.000000000","message":"Patch Set 7: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/15019/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/14253/ : SUCCESS","accounts_in_message":[],"_revision_number":7},{"id":"3cb8c56f64a9b9c68389514dd6f1c03897928d25","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-08-14 16:01:50.000000000","message":"Patch Set 7: Code-Review+2","accounts_in_message":[],"_revision_number":7},{"id":"035ca0782be1d34eb41ffd8e482dac27b76adb06","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-15 23:52:52.000000000","message":"Patch Set 7:\n\nBeside the flasher, there are other \u0027generic\u0027 helpers like the erase_check.\nAre these other helpers safe to run on L5?\nOr in specific cases have to be disabled too?","accounts_in_message":[],"_revision_number":7},{"id":"bb6579cd63fbbadc35105aca7455c0d3d6380673","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-16 00:08:21.000000000","message":"Patch Set 7:\n\n\u003e Beside the flasher, there are other \u0027generic\u0027 helpers like the\n \u003e erase_check.\n \u003e Are these other helpers safe to run on L5?\n \u003e Or in specific cases have to be disabled too?\n\nif the user can specify an non-protected RAM, it will work, with no harm even for the flashloader.\nthis feature was mainly introduced for IDE, as we don\u0027t want to prompt the user and ask for non-secure workarea","accounts_in_message":[],"_revision_number":7},{"id":"1184b0ed265eb31795cc8e67c58f9051efda95aa","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-16 09:01:07.000000000","message":"Patch Set 7: Code-Review+1\n\n\u003e if the user can specify an non-protected RAM, it will work, with no\n \u003e harm even for the flashloader.\n\nDo you think it could be helpful, as general openocd improvement, to define a property secure/nonsecure for work-areas?","accounts_in_message":[],"_revision_number":7},{"id":"069094d877764c1ddc34c8da6696e4bd8cfc59e0","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-16 13:22:10.000000000","message":"Uploaded patch set 8: Patch Set 7 was rebased.","accounts_in_message":[],"_revision_number":8},{"id":"3569f147ac65e5ef3016c27986bf6cd7cef64ac6","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-16 13:23:37.000000000","message":"Patch Set 8: Code-Review+1","accounts_in_message":[],"_revision_number":8},{"id":"de282e7434247d8826b60ac38e663c1f7290523c","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-08-16 14:02:45.000000000","message":"Patch Set 8: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/15042/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/14276/ : SUCCESS","accounts_in_message":[],"_revision_number":8},{"id":"4ddad51b7a99c297c998e2c0679cfbdcd0bb85dd","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-08-26 06:10:17.000000000","message":"Patch Set 8: Code-Review+2","accounts_in_message":[],"_revision_number":8},{"id":"c8d9c552ea778cb6d6b6f23a595ab089f539d3c6","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-08-26 06:27:17.000000000","message":"Change has been successfully cherry-picked as 1247eee4e6e55889b14bec8d81c4748767bb67b8","accounts_in_message":[],"_revision_number":9},{"id":"62288227ec89574a47dddeba6b47af44bbcf2136","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-09-11 05:36:42.000000000","message":"Patch Set 9:\n\n(1 comment)","accounts_in_message":[],"_revision_number":9},{"id":"4f82e9796ba469be9a451f7ef84a3fd46ea6a1ff","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-09-11 07:58:32.000000000","message":"Patch Set 9:\n\n(1 comment)","accounts_in_message":[],"_revision_number":9},{"id":"9d02f8e266b350dc0a578088073818202b7ccc1c","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-09-11 09:55:06.000000000","message":"Patch Set 9:\n\n(1 comment)","accounts_in_message":[],"_revision_number":9},{"id":"b03df8d2021c29cda7f9b83b775f9a71cb0b1d2b","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-09-11 11:19:42.000000000","message":"Patch Set 9:\n\n(1 comment)","accounts_in_message":[],"_revision_number":9},{"id":"90a386588349e62ae64b71a8a38a75ff6762a3a4","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-09-11 13:18:29.000000000","message":"Patch Set 9:\n\n(1 comment)","accounts_in_message":[],"_revision_number":9},{"id":"6c66e7779ec650e0061afa75741f84231be96636","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-09-11 13:23:37.000000000","message":"Patch Set 9:\n\n(1 comment)","accounts_in_message":[],"_revision_number":9},{"id":"bf72e7bf04a759856d90b1cbeca95540cc95d0b0","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-09-11 14:09:35.000000000","message":"Patch Set 9:\n\nno objection here.\nI will just add a note that in case of trying to access a secure memory, a secure fault will be triggered and we can recover only by resetting the target. so waiting for loader timeout is not the way to go.\nmeanwhile I feel like setting workarea size to zero should be OK as well.\nthe only missing thing is to document it somewhere either in stm32l4x driver level or flash core level, mentionning that not all flash drivers do have the fall back.\n\nanother thought, I am planning to add this intelligence in stm32l5x.cfg but I was blocked by some issues in flash list command, fortunately I have fixed them and they have been merged already.\n\nI will provide a patch showcasing this and will see if you are happy by the result then we can revert #6273","accounts_in_message":[],"_revision_number":9},{"id":"601e4d63b7bd02651be69ffe323677b9a609e986","tag":"autogenerated:gerrit:revert","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-09-15 05:55:08.000000000","message":"Created a revert of this change as Ibb046c74df354c6067bac978e8ef7efb47d9fd2b","accounts_in_message":[],"_revision_number":9}],"current_revision":"1247eee4e6e55889b14bec8d81c4748767bb67b8","revisions":{"44822d69ce9005c2e7ddc5819f4254847a2809be":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2021-08-13 21:50:03.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/73/6273/5","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/73/6273/5","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/5 \u0026\u0026 git checkout -b change-6273 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/73/6273/5","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"995b057f5e00ca7e61af3cd19c645c5a1944d337","subject":"flash/stm32l4x: STM32L5 support programming when TZEN\u003d1 and RDP\u003d0x55"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-05-25 10:54:50.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-08-13 21:49:44.000000000","tz":60},"subject":"flash/stm32l4x: introduce flash programming without loader","message":"flash/stm32l4x: introduce flash programming without loader\n\nthis capability permits to program the flash if we cannot reserve a workarea.\n\nthe introduction the command \u0027stm32l4x flashloader \u003cbank_id\u003e [enable|disable]\u0027\nhelps to automatically skip using the flashloader if needed.\n\nChange-Id: Id29213c85ee5c7c487cfee21554f5a7ea50db6c9\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}},"e6b9e7cdc69237e5227b31cb234f66ae74d107e1":{"kind":"REWORK","_number":4,"created":"2021-08-12 02:34:59.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/73/6273/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/73/6273/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/4 \u0026\u0026 git checkout -b change-6273 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/73/6273/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2500be9697d7ba0e80c56fa450fe9a6a3b5ec79a","subject":"flash/stm32l4x: STM32L5 support programming when TZEN\u003d1 and RDP\u003d0x55"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-05-25 10:54:50.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-08-12 02:20:50.000000000","tz":60},"subject":"flash/stm32l4x: introduce flash programming without loader","message":"flash/stm32l4x: introduce flash programming without loader\n\nthis capability permits to program the flash if we cannot reserve a workarea.\n\nthe introduction the command \u0027stm32l4x flashloader \u003cbank_id\u003e [enable|disable]\u0027\nhelps to automatically skip using the flashloader if needed.\n\nChange-Id: Id29213c85ee5c7c487cfee21554f5a7ea50db6c9\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}},"b26a376ebbd84aef9e79621a61183bcba29180a5":{"kind":"REWORK","_number":7,"created":"2021-08-14 13:39:41.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/73/6273/7","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/73/6273/7","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/7 \u0026\u0026 git checkout -b change-6273 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/73/6273/7","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/7 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e5631512530dfbf81b02425d030c2e4e2c0aeb74","subject":"flash/stm32l4x: STM32L5 support programming when TZEN\u003d1 and RDP\u003d0x55"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-05-25 10:54:50.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-08-14 12:34:36.000000000","tz":60},"subject":"flash/stm32l4x: introduce flash programming without loader","message":"flash/stm32l4x: introduce flash programming without loader\n\nthis capability permits to program the flash if we cannot reserve a workarea.\n\nthe introduction the command \u0027stm32l4x flashloader \u003cbank_id\u003e [enable|disable]\u0027\nhelps to automatically skip using the flashloader if needed.\n\nChange-Id: Id29213c85ee5c7c487cfee21554f5a7ea50db6c9\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}},"f6656351f95ec3068005cd3ff4b6d68335d688a5":{"kind":"TRIVIAL_REBASE","_number":6,"created":"2021-08-13 23:00:23.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/73/6273/6","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/73/6273/6","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/6 \u0026\u0026 git checkout -b change-6273 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/73/6273/6","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e5631512530dfbf81b02425d030c2e4e2c0aeb74","subject":"flash/stm32l4x: STM32L5 support programming when TZEN\u003d1 and RDP\u003d0x55"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-05-25 10:54:50.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-08-13 23:00:13.000000000","tz":60},"subject":"flash/stm32l4x: introduce flash programming without loader","message":"flash/stm32l4x: introduce flash programming without loader\n\nthis capability permits to program the flash if we cannot reserve a workarea.\n\nthe introduction the command \u0027stm32l4x flashloader \u003cbank_id\u003e [enable|disable]\u0027\nhelps to automatically skip using the flashloader if needed.\n\nChange-Id: Id29213c85ee5c7c487cfee21554f5a7ea50db6c9\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}},"1d4465880ba6281c2cc117fdbb4e23128a766ddd":{"kind":"REWORK","_number":1,"created":"2021-05-25 14:25:03.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/73/6273/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/73/6273/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/1 \u0026\u0026 git checkout -b change-6273 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/73/6273/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"41d87a48d93d275b5846ec911470fd27e230c4ea","subject":"flash/stm32l4x: STM32L5 support programming when TZEN\u003d1 and RDP\u003d0x55 [WIP]"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-05-25 10:54:50.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-05-25 14:24:36.000000000","tz":60},"subject":"flash/stm32l4x: introduce flash programming without loader [WIP]","message":"flash/stm32l4x: introduce flash programming without loader [WIP]\n\nthis capability permits to program the flash if we cannot reserve a workarea.\n\nthe introduction the command \u0027stm32l4x flashloader \u003cbank_id\u003e [enable|disable]\u0027\nhelps to automatically skip using the flashloader if needed.\n\nChange-Id: Id29213c85ee5c7c487cfee21554f5a7ea50db6c9\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}},"6c7d7fec8ec0c1f7b9a3b5e2512187576df7760a":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2021-08-05 15:00:50.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/73/6273/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/73/6273/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/3 \u0026\u0026 git checkout -b change-6273 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/73/6273/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b23ce10af13881e588430e3c254a15bf4060c6d4","subject":"flash/stm32l4x: STM32L5 support programming when TZEN\u003d1 and RDP\u003d0x55 [WIP]"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-05-25 10:54:50.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-07-29 09:36:08.000000000","tz":60},"subject":"flash/stm32l4x: introduce flash programming without loader [WIP]","message":"flash/stm32l4x: introduce flash programming without loader [WIP]\n\nthis capability permits to program the flash if we cannot reserve a workarea.\n\nthe introduction the command \u0027stm32l4x flashloader \u003cbank_id\u003e [enable|disable]\u0027\nhelps to automatically skip using the flashloader if needed.\n\nChange-Id: Id29213c85ee5c7c487cfee21554f5a7ea50db6c9\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}},"d0e4e21722867a5e9487c161fcdbaabcdfa41bd5":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2021-08-05 14:12:08.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/73/6273/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/73/6273/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/2 \u0026\u0026 git checkout -b change-6273 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/73/6273/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"927d1a0129bf71d591984e19487f31ec6c85cbdc","subject":"flash/stm32l4x: STM32L5 support programming when TZEN\u003d1 and RDP\u003d0x55 [WIP]"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-05-25 10:54:50.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-07-29 08:43:46.000000000","tz":60},"subject":"flash/stm32l4x: introduce flash programming without loader [WIP]","message":"flash/stm32l4x: introduce flash programming without loader [WIP]\n\nthis capability permits to program the flash if we cannot reserve a workarea.\n\nthe introduction the command \u0027stm32l4x flashloader \u003cbank_id\u003e [enable|disable]\u0027\nhelps to automatically skip using the flashloader if needed.\n\nChange-Id: Id29213c85ee5c7c487cfee21554f5a7ea50db6c9\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}},"1247eee4e6e55889b14bec8d81c4748767bb67b8":{"kind":"REWORK","_number":9,"created":"2021-08-26 06:27:17.000000000","uploader":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"ref":"refs/changes/73/6273/9","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/73/6273/9","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/9 \u0026\u0026 git checkout -b change-6273 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/73/6273/9","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/9 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e609d5a5de84b3daf8b9524143e41a6c0713fd8f","subject":"flash/stm32l4x: STM32L5 support programming when TZEN\u003d1 and RDP\u003d0x55"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-05-25 10:54:50.000000000","tz":60},"committer":{"name":"Oleksij Rempel","email":"linux@rempel-privat.de","date":"2021-08-26 06:27:17.000000000","tz":0},"subject":"flash/stm32l4x: introduce flash programming without loader","message":"flash/stm32l4x: introduce flash programming without loader\n\nthis capability permits to program the flash if we cannot reserve a workarea.\n\nthe introduction the command \u0027stm32l4x flashloader \u003cbank_id\u003e [enable|disable]\u0027\nhelps to automatically skip using the flashloader if needed.\n\nChange-Id: Id29213c85ee5c7c487cfee21554f5a7ea50db6c9\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6273\nReviewed-by: Oleksij Rempel \u003clinux@rempel-privat.de\u003e\nTested-by: jenkins\n"}},"1b7fe05b0dce105bbb94cc28b6cf841e33f3c913":{"kind":"TRIVIAL_REBASE","_number":8,"created":"2021-08-16 13:22:10.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/73/6273/8","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/73/6273/8","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/8 \u0026\u0026 git checkout -b change-6273 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/73/6273/8","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/73/6273/8 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a71282826c9313343345bcd8f14004bc03465433","subject":"flash/stm32l4x: STM32L5 support programming when TZEN\u003d1 and RDP\u003d0x55"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-05-25 10:54:50.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-08-16 12:41:28.000000000","tz":60},"subject":"flash/stm32l4x: introduce flash programming without loader","message":"flash/stm32l4x: introduce flash programming without loader\n\nthis capability permits to program the flash if we cannot reserve a workarea.\n\nthe introduction the command \u0027stm32l4x flashloader \u003cbank_id\u003e [enable|disable]\u0027\nhelps to automatically skip using the flashloader if needed.\n\nChange-Id: Id29213c85ee5c7c487cfee21554f5a7ea50db6c9\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}