)]}'
{"id":"openocd~master~Ib3a36877326eeb56595cbca55e21b9e59a59c98a","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-10-08 21:16:43.000000000","reason":"Antonio Borneo replied on the change"},"1001881":{"account":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"last_update":"2023-01-15 14:51:21.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ib3a36877326eeb56595cbca55e21b9e59a59c98a","subject":"src/rtos/eCos : Support per-build configuration specific structure layouts","status":"MERGED","created":"2021-05-26 09:44:14.000000000","updated":"2023-01-15 14:51:21.000000000","submitted":"2023-01-15 14:51:21.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":81,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6275","meta_rev_id":"24aa7d5355137eeef64bf7217003885efc67f582","_number":6275,"owner":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1002048,"name":"Alex Schuilenburg","email":"alex.schuilenburg@gmail.com"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-01-15 14:51:21.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-01-15 14:51:21.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002048,"name":"Alex Schuilenburg","email":"alex.schuilenburg@gmail.com"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-01-15 14:51:21.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-01-15 14:51:21.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},{"_account_id":1002048,"name":"Alex Schuilenburg","email":"alex.schuilenburg@gmail.com"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-07-02 16:23:44.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2021-07-02 16:54:55.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-09-28 13:16:09.000000000","updated_by":{"_account_id":1002048,"name":"Alex Schuilenburg","email":"alex.schuilenburg@gmail.com"},"reviewer":{"_account_id":1002048,"name":"Alex Schuilenburg","email":"alex.schuilenburg@gmail.com"},"state":"REVIEWER"}],"messages":[{"id":"b6b9ec11b90c2a3d5236f1b43aa8a24a8d2c6c63","author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"real_author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"date":"2021-05-26 09:44:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"48efa688feeaade8b7b5940392e95d2c3d7b8ba6","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-05-26 09:45:06.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttp://build.openocd.org/job/openocd-gerrit/14624/ : FAILURE\n\nhttp://build.openocd.org/job/openocd-gerrit-build/13876/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"6e83a5d90dd2254a7b448ace2baf8357a3903984","author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"real_author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"date":"2021-05-26 11:09:00.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"6977f19a1ed8213481636729bc35fe7a382f8e6f","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-05-26 11:40:50.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14625/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/13877/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"593f5ca149fb23c29e5aed87acfedbca7dfdcf05","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-05-26 16:50:19.000000000","message":"Patch Set 2: Code-Review-1\n\n(28 comments)\n\nJust a light review. Also I\u0027m not expert on this rtos framework.\nDo you think this patch could be split in a series of smaller and self contained changes?","accounts_in_message":[],"_revision_number":2},{"id":"e2b5a976b72c75e032199542b4f4243bba54f1d1","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-05-26 16:59:32.000000000","message":"Patch Set 2:\n\nDo you think I can merge http://openocd.zylin.com/6261/\nand you rebase your next version on top of it?\nI will hold-on on the camelcase fixes because are too invasive and will require too much rework for your patch.","accounts_in_message":[],"_revision_number":2},{"id":"7de24ff0f3bc361fc0ba0984576ed1ea03a4f549","author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"real_author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"date":"2021-05-26 19:50:35.000000000","message":"Patch Set 2:\n\n\u003e Do you think I can merge http://openocd.zylin.com/6261/\n \u003e and you rebase your next version on top of it?\n \nThat would probably be easiest. I will watch for the merge of 6261 and rebase as well as address the review comments.","accounts_in_message":[],"_revision_number":2},{"id":"7fc70d123dec1df3b44d378bb83786571b2d4c7f","author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"real_author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"date":"2021-05-26 19:56:44.000000000","message":"Patch Set 2:\n\n\u003e Do you think this patch could be split in a series of smaller and\n \u003e self contained changes?\n\nNot really, since it only provides the single piece of functionality to support returning the correct core registers for a specific application build. It could be split to provide the correct thread state support; but that would still leave the majority of the changeset that deals with the target arch eCos CDL specific thread descriptor layout.","accounts_in_message":[],"_revision_number":2},{"id":"ae92bf9f66fc3d35527902b38ec4e0b3ea56d883","author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"real_author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"date":"2021-05-26 20:16:30.000000000","message":"Patch Set 2:\n\n(5 comments)","accounts_in_message":[],"_revision_number":2},{"id":"2f88bf7a3d29dad52b820a8a32b419265f286a69","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-05-26 22:31:18.000000000","message":"Patch Set 2:\n\n(3 comments)\n\nI will merge 6261 in the weekend\nYou can already cherry-pick it locally in your work branch","accounts_in_message":[],"_revision_number":2},{"id":"81d940b7e98532b952b6618e374e541e198a0ebf","author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"real_author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"date":"2021-05-26 22:52:34.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"c02639383742bce4b5f798beec61d8180e6727e7","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-05-27 08:25:39.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"8bf9a1425cd2b44a38ff85699363fffb7bf4adac","author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"real_author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"date":"2021-05-27 10:10:06.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"8f6f5ccddee3374162a3bad875ecae0ea8ab7046","author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"real_author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"date":"2021-05-27 10:13:34.000000000","message":"Patch Set 3:\n\nAaarrgh. Looks like I screwed up the cherry-pick of your 6261 changeset and update of mine.","accounts_in_message":[],"_revision_number":3},{"id":"60059377b713e426e0f55a0bd07cc204632e963c","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-05-27 11:22:27.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14642/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/13894/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"e4a6986b1a52efd60c34d66f9808a0b4c70d92dd","author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"real_author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"date":"2021-05-27 11:53:54.000000000","message":"Uploaded patch set 4: Commit message was updated.","accounts_in_message":[],"_revision_number":4},{"id":"51d7e471d2990012b7cd9f6d509a698b3536ecaa","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-05-27 12:28:08.000000000","message":"Patch Set 4: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14643/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/13895/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"83e03d965cd98c05f764b2ce19bb83429f64d029","author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"real_author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"date":"2021-05-30 08:11:48.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"faacfada89539a4ce5dacde8d8d363e7e67e6718","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-05-30 08:44:30.000000000","message":"Patch Set 5: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14668/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/13918/ : SUCCESS","accounts_in_message":[],"_revision_number":5},{"id":"c063ae29df00d8e15be307e7ba51a3894fc2ffbb","author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"real_author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"date":"2021-05-30 08:53:04.000000000","message":"Patch Set 5:\n\nRebased to avoid cannot merge warning.","accounts_in_message":[],"_revision_number":5},{"id":"91c26353f65be0317de52a4734c4ef8cc5e88837","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-05-31 21:21:11.000000000","message":"Patch Set 5: Code-Review-1\n\n(23 comments)\n\nStill only trivial review. I/m sorry but the change is big and I don\u0027t know the rtos framework.\nI strongly suggest you again to split this patch","accounts_in_message":[],"_revision_number":5},{"id":"ecdb69f5ae67840c453513227e80ac1fb19035ee","author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"real_author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"date":"2021-05-31 21:53:59.000000000","message":"Patch Set 5:\n\n(3 comments)\n\n\u003e sorry but the change is big and I don\u0027t know the rtos\n\u003e framework. I strongly suggest you again to split this patch\n\nI will do the cosmetic style changes you have highlighted; and then abandon this changeset in favour of the obvious split for a changeset for the fix to correct the eCos thread state bitmask reporting, and the support for the fact eCos can have per-application-build thread descriptor layout differences as a separate patch. However, as I mentioned before, that per-app-offsets changeset is still likely to be large since it is one piece of functionality.  I will try and split it; since it may be possible to do some NOP changes that do not affect the existing implementation but provide groundwork for the actual fix.","accounts_in_message":[],"_revision_number":5},{"id":"cb53bbcf2d5a30b3b9759127d3dc365fa82a4e67","author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"real_author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"date":"2021-06-01 07:35:54.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"6968e0367ff901701945ed2d0594f103d28f6ad1","author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"real_author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"date":"2021-06-01 07:37:14.000000000","message":"Patch Set 6:\n\nThis is just an updated with the review comments from patchset#5 changed.","accounts_in_message":[],"_revision_number":6},{"id":"c667d3ddab6774d041308fd3a724d95b6e955467","author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"real_author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"date":"2021-06-01 07:53:46.000000000","message":"Patch Set 6:\n\n\u003e I strongly suggest you again to split this patch\n\nAntonio.\n\nThe patch is \"big\" because unfortunately it has some large enum and struct entries that are what they are (e.g. ecos_reglist_cortexm, rtos_ecos_regoff_cortexm, rtos_ecos_regoff_arm, eCos_symbol_values, eCos_symbol_list) and the new functions to support the new single piece of functionality being added (e.g. ecos_value, eCos_escape_string, eCos_check_app_info, eCos_stack_layout_cortexm, eCos_stack_layout_arm).\n\nSo if I extract the small changeset to fix the existing code to correctly treat the thread reason as a bitmask; the patchset to provide the support for the fact that different eCos builds of the same architecture can have different thread descriptor layouts (plus different stacked thread contexts within a single build in the case of Cortex-M with lazy FPU) will still be 95% of this changeset (since the status reporting to fix the bitmask will only have the sleep reason stuff added as part of the second \"large\" changeset so will be a small partial step).\n\nThe number of lines in the changeset could be reduced by me removing my \"help the developer\" comments if it is a case of reducing the diff line count :-)","accounts_in_message":[],"_revision_number":6},{"id":"da728de107152417244a15a6613cf3e206480804","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-06-01 08:07:03.000000000","message":"Patch Set 6: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14669/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/13919/ : SUCCESS","accounts_in_message":[],"_revision_number":6},{"id":"50a95c3c757e8c04212d31762b16ac968b70bc5d","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-06-06 22:55:20.000000000","message":"Patch Set 6:\n\nJames, I have sent out http://openocd.zylin.com/6306/ to cleanup the coding style of eCos code. But it conflicts with the work you are doing here.\nI don\u0027t want to add to much troubles to you, so this is my proposal to proceed smoothly, let me know what do you think about it.\nYou go ahead on this change 6275, ignoring my change 6306.\nOnce 6306 is approved and ready for merge, I will check with you if you have a new version of 6275; in that case I will wait that you push it on gerrit.\nWith your latest 6275 in gerrit, I merge 6306, then I rebase 6275 on top of 6306, remove all the camelcase and push this new 6275 on gerrit. I have already a set of scripts for these fixes, it would not take me too much time.\nFrom that point you can download the modified 6275 and go ahead.","accounts_in_message":[],"_revision_number":6},{"id":"3703e3942bfec8d289ddc0ffda94ad372960a0ec","author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"real_author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"date":"2021-06-07 08:54:11.000000000","message":"Patch Set 6:\n\n\u003e ... so this is my proposal to proceed smoothly,\n \u003e let me know what do you think about it.\n \nFine from my end.\n\nThis changeset had already grown in size since I had added changes to the original source (unmodified by the original 6275 changeset) to get to the goal of style-confirming code :-)\n\n \u003e ... I will check with you if you have a new version of 6275 ...\n\nI am *not* planning any changes at the moment, so there should be no issue with you rebasing once 6306 is committed (since I assume that is likely to happen in the shorter term).\n\nCheers!","accounts_in_message":[],"_revision_number":6},{"id":"41682f38554879026711439a6c6f27b5ef73827a","author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"real_author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"date":"2021-06-14 16:20:26.000000000","message":"Patch Set 6:\n\nAntonio,\n\nJust noticed a silly piece of (unnecessary) optimisation on my part that will fail for some eCos configurations (noticed on an eCosPro stm32f746g_eval perm). I foolishly had just set aside unsigned char values for the thread descriptor offsets, but for some CDL configurations the necessary fields of the descriptor can be more than 8-bits away. Ho hum.\n\nSince you do not yet seem to have committed your camelcase changeset and re-based I will spin another patchset.","accounts_in_message":[],"_revision_number":6},{"id":"af5e3319b728e163e67265264b4220877aabd81e","author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"real_author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"date":"2021-06-14 16:23:04.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"ab9bd72511b940957a6ab6c960f2dfc61e8f2dc4","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-06-14 16:53:18.000000000","message":"Patch Set 7: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14753/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/13999/ : SUCCESS","accounts_in_message":[],"_revision_number":7},{"id":"ed134e17817e4582098710ffc97017fa079b1bce","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-07-02 16:19:43.000000000","message":"Uploaded patch set 8.","accounts_in_message":[],"_revision_number":8},{"id":"feeb7dd551e94575d239f41255ad03354a589ae0","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-07-02 16:21:07.000000000","message":"Patch Set 8:\n\nas promised, this is your patch rebased on new HEAD and with the symbol names adjusted to the proper case","accounts_in_message":[],"_revision_number":8},{"id":"7ce5fe109c6a3c41fa27b055f1dd9f40fe4baef4","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-07-02 16:21:53.000000000","message":"Uploaded patch set 9.","accounts_in_message":[],"_revision_number":9},{"id":"0f6022114f3ed808a0399268ec2a6f3830008a03","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-07-02 16:21:59.000000000","message":"Patch Set 8: Verified-1\n\nBuild Failed \n\nhttp://build.openocd.org/job/openocd-gerrit/14805/ : ABORTED\n\nhttp://build.openocd.org/job/openocd-gerrit-build/14051/ : ABORTED","accounts_in_message":[],"_revision_number":8},{"id":"6d0074c5567c49f0d8cebeac1502a0bf4957c1be","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-07-02 16:23:44.000000000","message":"Patch Set 9:\n\nand this new version fixes some other minor issue like useless parenthesis and order of operands in comparisons","accounts_in_message":[],"_revision_number":9},{"id":"be40d4d3a020860024b9e598fe8aac9de1ee6e81","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-07-02 16:54:55.000000000","message":"Patch Set 9: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14806/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/14052/ : SUCCESS","accounts_in_message":[],"_revision_number":9},{"id":"c1da1a7660f253a05cfd63b031564860fc0383d6","author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"real_author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"date":"2021-07-02 17:00:19.000000000","message":"Patch Set 9:\n\nThanks. I will check it check it locally.","accounts_in_message":[],"_revision_number":9},{"id":"181aabadfc3dd42c4018543d01265678d3ea3b78","author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"real_author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"date":"2021-07-04 11:45:38.000000000","message":"Patch Set 9:\n\nSo now we just wait until someone gives a positive review :-)","accounts_in_message":[],"_revision_number":9},{"id":"7e7ae7c2132e589687e207767acc11b193b822c9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"real_author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"date":"2022-09-28 10:15:12.000000000","message":"Uploaded patch set 10.","accounts_in_message":[],"_revision_number":10},{"id":"1f776c59a6ac87fafeab7e06c48fda0d01e95a84","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-09-28 10:39:07.000000000","message":"Patch Set 10: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16008/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit/16798/ : SUCCESS","accounts_in_message":[],"_revision_number":10},{"id":"fede0cfa4050f3fee73935e4867c7243a3e6e6c0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"real_author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"date":"2022-09-28 10:59:33.000000000","message":"Uploaded patch set 11.","accounts_in_message":[],"_revision_number":11},{"id":"49a2d53c2dd5c0cc903663fe31df1d421ea6d5e6","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-09-28 11:35:39.000000000","message":"Patch Set 11: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16009/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16799/ : SUCCESS","accounts_in_message":[],"_revision_number":11},{"id":"b30a476c013138128ec111c910407c0c340801ae","author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"real_author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"date":"2022-09-28 12:09:05.000000000","message":"Patch Set 11:\n\n(1 comment)","accounts_in_message":[],"_revision_number":11},{"id":"2f2caa6567c3937228995e5870afc095494fffee","author":{"_account_id":1002048,"name":"Alex Schuilenburg","email":"alex.schuilenburg@gmail.com"},"real_author":{"_account_id":1002048,"name":"Alex Schuilenburg","email":"alex.schuilenburg@gmail.com"},"date":"2022-09-28 13:16:09.000000000","message":"Patch Set 11: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":11},{"id":"7f94121aa678977531b8aa5892f2cbb5dfebb49a","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-10-08 14:32:40.000000000","message":"Patch Set 11:\n\n(6 comments)","accounts_in_message":[],"_revision_number":11},{"id":"f81d8ff22a6b7d89a462f44e22144c673a4531f1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"real_author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"date":"2022-10-08 16:28:51.000000000","message":"Uploaded patch set 12.","accounts_in_message":[],"_revision_number":12},{"id":"4656daf92266b78cbe1a64cf2da55cf74d0a9428","author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"real_author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"date":"2022-10-08 16:32:12.000000000","message":"Patch Set 12: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":12},{"id":"b883cd92d0ad933ccd32f3c7c685550bf776dc9b","author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"real_author":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"date":"2022-10-08 16:43:34.000000000","message":"Patch Set 12:\n\n(6 comments)","accounts_in_message":[],"_revision_number":12},{"id":"201b82a5d87606c78a70a00f600aeed8e6b61aa1","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-10-08 17:20:02.000000000","message":"Patch Set 12: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16064/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16853/ : SUCCESS","accounts_in_message":[],"_revision_number":12},{"id":"98da1c0bfd0140c86b18e40d9c3be44e5238c7f7","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-10-08 21:16:43.000000000","message":"Patch Set 12: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":12},{"id":"62a2c0e7e682fc3dd72de87cfd784f34119573a1","author":{"_account_id":1002048,"name":"Alex Schuilenburg","email":"alex.schuilenburg@gmail.com"},"real_author":{"_account_id":1002048,"name":"Alex Schuilenburg","email":"alex.schuilenburg@gmail.com"},"date":"2022-10-11 10:41:56.000000000","message":"Patch Set 12: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":12},{"id":"eb4114ef543923c03ed16eebd67848035d965b2d","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-01-15 13:25:11.000000000","message":"Patch Set 12: Code-Review+2","accounts_in_message":[],"_revision_number":12},{"id":"24aa7d5355137eeef64bf7217003885efc67f582","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-01-15 14:51:21.000000000","message":"Change has been successfully cherry-picked as d96dc47ef67e427cd64a07d9825fd297e3a81633","accounts_in_message":[],"_revision_number":13}],"current_revision":"d96dc47ef67e427cd64a07d9825fd297e3a81633","revisions":{"9971d82a1efa2140eac5d2ecca0f4614fa9b3586":{"kind":"REWORK","_number":12,"created":"2022-10-08 16:28:51.000000000","uploader":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"ref":"refs/changes/75/6275/12","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/75/6275/12","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/12 \u0026\u0026 git checkout -b change-6275 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/12 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/12 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/12 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/75/6275/12","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/12 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ae937791d35b0820e0bc9bf0ab134c2bebd113e4","subject":"flash/nor/rp2040: remove new line from error message"}],"author":{"name":"James G. Smith","email":"jsmith@rallysmith.co.uk","date":"2021-05-26 09:08:26.000000000","tz":60},"committer":{"name":"James Smith","email":"jsmith@rallysmith.co.uk","date":"2022-10-08 16:27:25.000000000","tz":60},"subject":"src/rtos/eCos : Support per-build configuration specific structure layouts","message":"src/rtos/eCos : Support per-build configuration specific structure layouts\n\nExtended feature. This is a large patch, but is self-contained to the\neCos support and does not affect any other openocd functionality. It\ndoes NOT affect existing eCos RTOS plugin users where their\napplications do not provide the extended symbolic helper\ninformation. If the helper symbols are not available the rtos support\ncode will behave as before. This \"dynamic\" functionality is *required*\nbecause eCos does NOT have a fixed/hardwired, known, layout for the\nthread descriptor structure. The per-application build eCos\nconfiguration can affect the shape of the thread descriptor structure\n(field presence, and hence offsets of subsequent fields) such that\nconstant values cannot be used to consistently interpret all possible\neCos application configurations. For historical reasons, there is not\nyet a consistent namespace for the helper symbols across eCos HALs\nhence the support is currently limited to specific architectures\n(Cortex-M and ARM/Cortex-A). No new Clang analyser warnings are raised\nby this changeset.\n\nChange-Id: Ib3a36877326eeb56595cbca55e21b9e59a59c98a\nSigned-off-by: James G. Smith \u003cjsmith@rallysmith.co.uk\u003e\n"}},"d96dc47ef67e427cd64a07d9825fd297e3a81633":{"kind":"REWORK","_number":13,"created":"2023-01-15 14:51:21.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/75/6275/13","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/75/6275/13","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/13 \u0026\u0026 git checkout -b change-6275 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/13 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/13 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/13 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/75/6275/13","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/13 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9a7781ff8c9dea6ef5998238b1932094b8a226da","subject":"flash/nor/spi: Add issi is25lq040b to device list"}],"author":{"name":"James G. Smith","email":"jsmith@rallysmith.co.uk","date":"2021-05-26 09:08:26.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-01-15 14:51:21.000000000","tz":0},"subject":"src/rtos/eCos : Support per-build configuration specific structure layouts","message":"src/rtos/eCos : Support per-build configuration specific structure layouts\n\nExtended feature. This is a large patch, but is self-contained to the\neCos support and does not affect any other openocd functionality. It\ndoes NOT affect existing eCos RTOS plugin users where their\napplications do not provide the extended symbolic helper\ninformation. If the helper symbols are not available the rtos support\ncode will behave as before. This \"dynamic\" functionality is *required*\nbecause eCos does NOT have a fixed/hardwired, known, layout for the\nthread descriptor structure. The per-application build eCos\nconfiguration can affect the shape of the thread descriptor structure\n(field presence, and hence offsets of subsequent fields) such that\nconstant values cannot be used to consistently interpret all possible\neCos application configurations. For historical reasons, there is not\nyet a consistent namespace for the helper symbols across eCos HALs\nhence the support is currently limited to specific architectures\n(Cortex-M and ARM/Cortex-A). No new Clang analyser warnings are raised\nby this changeset.\n\nChange-Id: Ib3a36877326eeb56595cbca55e21b9e59a59c98a\nSigned-off-by: James G. Smith \u003cjsmith@rallysmith.co.uk\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6275\nReviewed-by: Alex Schuilenburg \u003calex.schuilenburg@gmail.com\u003e\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\n"}},"e5f598ea78ef099f3bb47868255d904be3645e23":{"kind":"REWORK","_number":8,"created":"2021-07-02 16:19:43.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/75/6275/8","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/75/6275/8","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/8 \u0026\u0026 git checkout -b change-6275 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/75/6275/8","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/8 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"28c91b8f80937e6ec6521496f363038d9a5f9a04","subject":"tcl: Update Flyswatter product links"}],"author":{"name":"James G. Smith","email":"jsmith@rallysmith.co.uk","date":"2021-05-26 09:08:26.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-07-02 16:18:40.000000000","tz":120},"subject":"src/rtos/eCos : Support per-build configuration specific structure layouts","message":"src/rtos/eCos : Support per-build configuration specific structure layouts\n\nExtended feature. This is a large patch, but is self-contained to the\neCos support and does not affect any other openocd functionality. It\ndoes NOT affect existing eCos RTOS plugin users where their\napplications do not provide the extended symbolic helper\ninformation. If the helper symbols are not available the rtos support\ncode will behave as before. This \"dynamic\" functionality is *required*\nbecause eCos does NOT have a fixed/hardwired, known, layout for the\nthread descriptor structure. The per-application build eCos\nconfiguration can affect the shape of the thread descriptor structure\n(field presence, and hence offsets of subsequent fields) such that\nconstant values cannot be used to consistently interpret all possible\neCos application configurations. For historical reasons, there is not\nyet a consistent namespace for the helper symbols across eCos HALs\nhence the support is currently limited to specific architectures\n(Cortex-M and ARM/Cortex-A). No new Clang analyser warnings are raised\nby this changeset. The decision has been taken to initially minimise\nthe diff/patch size by not re-formatting the original non-conforming\ncoding-style of the eCos support to the newer openocd\ncoding-style. The aim being that when/if this feature changeset is\napproved/merged the source can then be updated to reflect the current\nopenocd coding-style for completeness.\n\nChange-Id: Ib3a36877326eeb56595cbca55e21b9e59a59c98a\nSigned-off-by: James G. Smith \u003cjsmith@rallysmith.co.uk\u003e\n"}},"7e9075cdc27e25f3d232d888ae5be8dc894ea6c2":{"kind":"REWORK","_number":9,"created":"2021-07-02 16:21:53.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/75/6275/9","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/75/6275/9","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/9 \u0026\u0026 git checkout -b change-6275 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/75/6275/9","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/9 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"28c91b8f80937e6ec6521496f363038d9a5f9a04","subject":"tcl: Update Flyswatter product links"}],"author":{"name":"James G. Smith","email":"jsmith@rallysmith.co.uk","date":"2021-05-26 09:08:26.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-07-02 16:21:21.000000000","tz":120},"subject":"src/rtos/eCos : Support per-build configuration specific structure layouts","message":"src/rtos/eCos : Support per-build configuration specific structure layouts\n\nExtended feature. This is a large patch, but is self-contained to the\neCos support and does not affect any other openocd functionality. It\ndoes NOT affect existing eCos RTOS plugin users where their\napplications do not provide the extended symbolic helper\ninformation. If the helper symbols are not available the rtos support\ncode will behave as before. This \"dynamic\" functionality is *required*\nbecause eCos does NOT have a fixed/hardwired, known, layout for the\nthread descriptor structure. The per-application build eCos\nconfiguration can affect the shape of the thread descriptor structure\n(field presence, and hence offsets of subsequent fields) such that\nconstant values cannot be used to consistently interpret all possible\neCos application configurations. For historical reasons, there is not\nyet a consistent namespace for the helper symbols across eCos HALs\nhence the support is currently limited to specific architectures\n(Cortex-M and ARM/Cortex-A). No new Clang analyser warnings are raised\nby this changeset. The decision has been taken to initially minimise\nthe diff/patch size by not re-formatting the original non-conforming\ncoding-style of the eCos support to the newer openocd\ncoding-style. The aim being that when/if this feature changeset is\napproved/merged the source can then be updated to reflect the current\nopenocd coding-style for completeness.\n\nChange-Id: Ib3a36877326eeb56595cbca55e21b9e59a59c98a\nSigned-off-by: James G. Smith \u003cjsmith@rallysmith.co.uk\u003e\n"}},"a0be9f2f11b8b9bb0641b2eb75b2f1292dd75326":{"kind":"REWORK","_number":10,"created":"2022-09-28 10:15:12.000000000","uploader":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"ref":"refs/changes/75/6275/10","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/75/6275/10","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/10 \u0026\u0026 git checkout -b change-6275 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/10 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/10 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/10 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/75/6275/10","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/10 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ae937791d35b0820e0bc9bf0ab134c2bebd113e4","subject":"flash/nor/rp2040: remove new line from error message"}],"author":{"name":"James G. Smith","email":"jsmith@rallysmith.co.uk","date":"2021-05-26 09:08:26.000000000","tz":60},"committer":{"name":"James Smith","email":"jsmith@rallysmith.co.uk","date":"2022-09-28 10:14:48.000000000","tz":60},"subject":"src/rtos/eCos : Support per-build configuration specific structure layouts","message":"src/rtos/eCos : Support per-build configuration specific structure layouts\n\nExtended feature. This is a large patch, but is self-contained to the\neCos support and does not affect any other openocd functionality. It\ndoes NOT affect existing eCos RTOS plugin users where their\napplications do not provide the extended symbolic helper\ninformation. If the helper symbols are not available the rtos support\ncode will behave as before. This \"dynamic\" functionality is *required*\nbecause eCos does NOT have a fixed/hardwired, known, layout for the\nthread descriptor structure. The per-application build eCos\nconfiguration can affect the shape of the thread descriptor structure\n(field presence, and hence offsets of subsequent fields) such that\nconstant values cannot be used to consistently interpret all possible\neCos application configurations. For historical reasons, there is not\nyet a consistent namespace for the helper symbols across eCos HALs\nhence the support is currently limited to specific architectures\n(Cortex-M and ARM/Cortex-A). No new Clang analyser warnings are raised\nby this changeset.\n\nChange-Id: Ib3a36877326eeb56595cbca55e21b9e59a59c98a\nSigned-off-by: James G. Smith \u003cjsmith@rallysmith.co.uk\u003e\n"}},"30509f417ebed151b5236e0b78147de5a3ac830a":{"kind":"REWORK","_number":11,"created":"2022-09-28 10:59:33.000000000","uploader":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"ref":"refs/changes/75/6275/11","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/75/6275/11","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/11 \u0026\u0026 git checkout -b change-6275 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/11 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/11 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/11 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/75/6275/11","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/11 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ae937791d35b0820e0bc9bf0ab134c2bebd113e4","subject":"flash/nor/rp2040: remove new line from error message"}],"author":{"name":"James G. Smith","email":"jsmith@rallysmith.co.uk","date":"2021-05-26 09:08:26.000000000","tz":60},"committer":{"name":"James Smith","email":"jsmith@rallysmith.co.uk","date":"2022-09-28 10:59:19.000000000","tz":60},"subject":"src/rtos/eCos : Support per-build configuration specific structure layouts","message":"src/rtos/eCos : Support per-build configuration specific structure layouts\n\nExtended feature. This is a large patch, but is self-contained to the\neCos support and does not affect any other openocd functionality. It\ndoes NOT affect existing eCos RTOS plugin users where their\napplications do not provide the extended symbolic helper\ninformation. If the helper symbols are not available the rtos support\ncode will behave as before. This \"dynamic\" functionality is *required*\nbecause eCos does NOT have a fixed/hardwired, known, layout for the\nthread descriptor structure. The per-application build eCos\nconfiguration can affect the shape of the thread descriptor structure\n(field presence, and hence offsets of subsequent fields) such that\nconstant values cannot be used to consistently interpret all possible\neCos application configurations. For historical reasons, there is not\nyet a consistent namespace for the helper symbols across eCos HALs\nhence the support is currently limited to specific architectures\n(Cortex-M and ARM/Cortex-A). No new Clang analyser warnings are raised\nby this changeset.\n\nChange-Id: Ib3a36877326eeb56595cbca55e21b9e59a59c98a\nSigned-off-by: James G. Smith \u003cjsmith@rallysmith.co.uk\u003e\n"}},"27d8350284914d404541117c7d18db7eb3f8d2b1":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2021-05-27 11:53:54.000000000","uploader":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"ref":"refs/changes/75/6275/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/75/6275/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/4 \u0026\u0026 git checkout -b change-6275 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/75/6275/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ab420a770b4b90d55132c7a6a4257ac720c07991","subject":"rtos: use ARRAY_SIZE() and simplify rtos_type.create()"}],"author":{"name":"James G. Smith","email":"jsmith@rallysmith.co.uk","date":"2021-05-26 09:08:26.000000000","tz":60},"committer":{"name":"James Smith","email":"jsmith@rallysmith.co.uk","date":"2021-05-27 11:52:59.000000000","tz":60},"subject":"src/rtos/eCos : Support per-build configuration specific structure layouts","message":"src/rtos/eCos : Support per-build configuration specific structure layouts\n\nExtended feature. This is a large patch, but is self-contained to the\neCos support and does not affect any other openocd functionality. It\ndoes NOT affect existing eCos RTOS plugin users where their\napplications do not provide the extended symbolic helper\ninformation. If the helper symbols are not available the rtos support\ncode will behave as before. This \"dynamic\" functionality is *required*\nbecause eCos does NOT have a fixed/hardwired, known, layout for the\nthread descriptor structure. The per-application build eCos\nconfiguration can affect the shape of the thread descriptor structure\n(field presence, and hence offsets of subsequent fields) such that\nconstant values cannot be used to consistently interpret all possible\neCos application configurations. For historical reasons, there is not\nyet a consistent namespace for the helper symbols across eCos HALs\nhence the support is currently limited to specific architectures\n(Cortex-M and ARM/Cortex-A). No new Clang analyser warnings are raised\nby this changeset. The decision has been taken to initially minimise\nthe diff/patch size by not re-formatting the original non-conforming\ncoding-style of the eCos support to the newer openocd\ncoding-style. The aim being that when/if this feature changeset is\napproved/merged the source can then be updated to reflect the current\nopenocd coding-style for completeness. Cherry-picked changeset 6261.\n\nChange-Id: Ib3a36877326eeb56595cbca55e21b9e59a59c98a\nSigned-off-by: James G. Smith \u003cjsmith@rallysmith.co.uk\u003e\n"}},"8be47a3bd30ee4eb6f9ca78f515f1469e39b06d9":{"kind":"REWORK","_number":5,"created":"2021-05-30 08:11:48.000000000","uploader":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"ref":"refs/changes/75/6275/5","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/75/6275/5","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/5 \u0026\u0026 git checkout -b change-6275 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/75/6275/5","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3b4e40120bc9c56442d1e177ecfbc8c4faa0ac7f","subject":"tcl/board: Add ST NUCLEO-8S208RB"}],"author":{"name":"James G. Smith","email":"jsmith@rallysmith.co.uk","date":"2021-05-26 09:08:26.000000000","tz":60},"committer":{"name":"James Smith","email":"jsmith@rallysmith.co.uk","date":"2021-05-30 08:06:38.000000000","tz":60},"subject":"src/rtos/eCos : Support per-build configuration specific structure layouts","message":"src/rtos/eCos : Support per-build configuration specific structure layouts\n\nExtended feature. This is a large patch, but is self-contained to the\neCos support and does not affect any other openocd functionality. It\ndoes NOT affect existing eCos RTOS plugin users where their\napplications do not provide the extended symbolic helper\ninformation. If the helper symbols are not available the rtos support\ncode will behave as before. This \"dynamic\" functionality is *required*\nbecause eCos does NOT have a fixed/hardwired, known, layout for the\nthread descriptor structure. The per-application build eCos\nconfiguration can affect the shape of the thread descriptor structure\n(field presence, and hence offsets of subsequent fields) such that\nconstant values cannot be used to consistently interpret all possible\neCos application configurations. For historical reasons, there is not\nyet a consistent namespace for the helper symbols across eCos HALs\nhence the support is currently limited to specific architectures\n(Cortex-M and ARM/Cortex-A). No new Clang analyser warnings are raised\nby this changeset. The decision has been taken to initially minimise\nthe diff/patch size by not re-formatting the original non-conforming\ncoding-style of the eCos support to the newer openocd\ncoding-style. The aim being that when/if this feature changeset is\napproved/merged the source can then be updated to reflect the current\nopenocd coding-style for completeness.\n\nChange-Id: Ib3a36877326eeb56595cbca55e21b9e59a59c98a\nSigned-off-by: James G. Smith \u003cjsmith@rallysmith.co.uk\u003e\n"}},"42ea6a42dae02917520ce6151bc7076a8c27726f":{"kind":"REWORK","_number":6,"created":"2021-06-01 07:35:54.000000000","uploader":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"ref":"refs/changes/75/6275/6","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/75/6275/6","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/6 \u0026\u0026 git checkout -b change-6275 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/75/6275/6","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b40dc09dd9e05497bf956ca91f7153aa34b24854","subject":"target/arm_adi_v5: Fix clear sticky overrun flag during replay of commands"}],"author":{"name":"James G. Smith","email":"jsmith@rallysmith.co.uk","date":"2021-05-26 09:08:26.000000000","tz":60},"committer":{"name":"James Smith","email":"jsmith@rallysmith.co.uk","date":"2021-06-01 07:34:19.000000000","tz":60},"subject":"src/rtos/eCos : Support per-build configuration specific structure layouts","message":"src/rtos/eCos : Support per-build configuration specific structure layouts\n\nExtended feature. This is a large patch, but is self-contained to the\neCos support and does not affect any other openocd functionality. It\ndoes NOT affect existing eCos RTOS plugin users where their\napplications do not provide the extended symbolic helper\ninformation. If the helper symbols are not available the rtos support\ncode will behave as before. This \"dynamic\" functionality is *required*\nbecause eCos does NOT have a fixed/hardwired, known, layout for the\nthread descriptor structure. The per-application build eCos\nconfiguration can affect the shape of the thread descriptor structure\n(field presence, and hence offsets of subsequent fields) such that\nconstant values cannot be used to consistently interpret all possible\neCos application configurations. For historical reasons, there is not\nyet a consistent namespace for the helper symbols across eCos HALs\nhence the support is currently limited to specific architectures\n(Cortex-M and ARM/Cortex-A). No new Clang analyser warnings are raised\nby this changeset. The decision has been taken to initially minimise\nthe diff/patch size by not re-formatting the original non-conforming\ncoding-style of the eCos support to the newer openocd\ncoding-style. The aim being that when/if this feature changeset is\napproved/merged the source can then be updated to reflect the current\nopenocd coding-style for completeness.\n\nChange-Id: Ib3a36877326eeb56595cbca55e21b9e59a59c98a\nSigned-off-by: James G. Smith \u003cjsmith@rallysmith.co.uk\u003e\n"}},"1a6b9a8d6bac2c055a7e298d086833b490f7fa96":{"kind":"REWORK","_number":7,"created":"2021-06-14 16:23:04.000000000","uploader":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"ref":"refs/changes/75/6275/7","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/75/6275/7","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/7 \u0026\u0026 git checkout -b change-6275 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/75/6275/7","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/7 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cb5d9e0098a62b388fcfc7c89ddb6cda2be77a38","subject":"armv4_5: do not read/write non-existent registers"}],"author":{"name":"James G. Smith","email":"jsmith@rallysmith.co.uk","date":"2021-05-26 09:08:26.000000000","tz":60},"committer":{"name":"James Smith","email":"jsmith@rallysmith.co.uk","date":"2021-06-14 16:22:35.000000000","tz":60},"subject":"src/rtos/eCos : Support per-build configuration specific structure layouts","message":"src/rtos/eCos : Support per-build configuration specific structure layouts\n\nExtended feature. This is a large patch, but is self-contained to the\neCos support and does not affect any other openocd functionality. It\ndoes NOT affect existing eCos RTOS plugin users where their\napplications do not provide the extended symbolic helper\ninformation. If the helper symbols are not available the rtos support\ncode will behave as before. This \"dynamic\" functionality is *required*\nbecause eCos does NOT have a fixed/hardwired, known, layout for the\nthread descriptor structure. The per-application build eCos\nconfiguration can affect the shape of the thread descriptor structure\n(field presence, and hence offsets of subsequent fields) such that\nconstant values cannot be used to consistently interpret all possible\neCos application configurations. For historical reasons, there is not\nyet a consistent namespace for the helper symbols across eCos HALs\nhence the support is currently limited to specific architectures\n(Cortex-M and ARM/Cortex-A). No new Clang analyser warnings are raised\nby this changeset. The decision has been taken to initially minimise\nthe diff/patch size by not re-formatting the original non-conforming\ncoding-style of the eCos support to the newer openocd\ncoding-style. The aim being that when/if this feature changeset is\napproved/merged the source can then be updated to reflect the current\nopenocd coding-style for completeness.\n\nChange-Id: Ib3a36877326eeb56595cbca55e21b9e59a59c98a\nSigned-off-by: James G. Smith \u003cjsmith@rallysmith.co.uk\u003e\n"}},"d7a9eebd3e43a64f0b4357614fa95699b040821a":{"kind":"REWORK","_number":1,"created":"2021-05-26 09:44:14.000000000","uploader":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"ref":"refs/changes/75/6275/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/75/6275/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/1 \u0026\u0026 git checkout -b change-6275 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/75/6275/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4e872a797f81595d5de790138bdec62f2bf175f0","subject":"target/zynqmp : Add AXI AP access port"}],"author":{"name":"James G. Smith","email":"jsmith@rallysmith.co.uk","date":"2021-05-26 09:08:26.000000000","tz":60},"committer":{"name":"James G. Smith","email":"jsmith@rallysmith.co.uk","date":"2021-05-26 09:43:05.000000000","tz":60},"subject":"src/rtos/eCos : Support per-build configuration specific structure layouts","message":"src/rtos/eCos : Support per-build configuration specific structure layouts\n\nExtended feature. This is a large patch, but is self-contained to the\neCos support and does not affect any other openocd functionality. It\ndoes NOT affect existing eCos RTOS plugin users where their\napplications do not provide the extended symbolic helper\ninformation. If the helper symbols are not available the rtos support\ncode will behave as before. This \"dynamic\" functionality is *required*\nbecause eCos does NOT have a fixed/hardwired, known, layout for the\nthread descriptor structure. The per-application build eCos\nconfiguration can affect the shape of the thread descriptor structure\n(field presence, and hence offsets of subsequent fields) such that\nconstant values cannot be used to consistently interpret all possible\neCos application configurations. For historical reasons, there is not\nyet a consistent namespace for the helper symbols across eCos HALs\nhence the support is currently limited to specific architectures\n(Cortex-M and ARM/Cortex-A). No new Clang analyser warnings are raised\nby this changeset. The decision has been taken to initially minimise\nthe diff/patch size by not re-formatting the original non-conforming\ncoding-style of the eCos support to the newer openocd\ncoding-style. The aim being that when/if this feature changeset is\napproved/merged the source can then be updated to reflect the current\nopenocd coding-style for completeness.\n\nChange-Id: Ib3a36877326eeb56595cbca55e21b9e59a59c98a\nSigned-off-by: James G. Smith \u003cjsmith@rallysmith.co.uk\u003e\n"}},"719f75ce8e3f4da3c15fa117ab17568d6eabc958":{"kind":"REWORK","_number":2,"created":"2021-05-26 11:09:00.000000000","uploader":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"ref":"refs/changes/75/6275/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/75/6275/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/2 \u0026\u0026 git checkout -b change-6275 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/75/6275/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4e872a797f81595d5de790138bdec62f2bf175f0","subject":"target/zynqmp : Add AXI AP access port"}],"author":{"name":"James G. Smith","email":"jsmith@rallysmith.co.uk","date":"2021-05-26 09:08:26.000000000","tz":60},"committer":{"name":"James G. Smith","email":"jsmith@rallysmith.co.uk","date":"2021-05-26 11:08:35.000000000","tz":60},"subject":"src/rtos/eCos : Support per-build configuration specific structure layouts","message":"src/rtos/eCos : Support per-build configuration specific structure layouts\n\nExtended feature. This is a large patch, but is self-contained to the\neCos support and does not affect any other openocd functionality. It\ndoes NOT affect existing eCos RTOS plugin users where their\napplications do not provide the extended symbolic helper\ninformation. If the helper symbols are not available the rtos support\ncode will behave as before. This \"dynamic\" functionality is *required*\nbecause eCos does NOT have a fixed/hardwired, known, layout for the\nthread descriptor structure. The per-application build eCos\nconfiguration can affect the shape of the thread descriptor structure\n(field presence, and hence offsets of subsequent fields) such that\nconstant values cannot be used to consistently interpret all possible\neCos application configurations. For historical reasons, there is not\nyet a consistent namespace for the helper symbols across eCos HALs\nhence the support is currently limited to specific architectures\n(Cortex-M and ARM/Cortex-A). No new Clang analyser warnings are raised\nby this changeset. The decision has been taken to initially minimise\nthe diff/patch size by not re-formatting the original non-conforming\ncoding-style of the eCos support to the newer openocd\ncoding-style. The aim being that when/if this feature changeset is\napproved/merged the source can then be updated to reflect the current\nopenocd coding-style for completeness.\n\nChange-Id: Ib3a36877326eeb56595cbca55e21b9e59a59c98a\nSigned-off-by: James G. Smith \u003cjsmith@rallysmith.co.uk\u003e\n"}},"c41610d80c9910ac9d2dfb046821be0c9ee83cc5":{"kind":"REWORK","_number":3,"created":"2021-05-27 10:10:06.000000000","uploader":{"_account_id":1001881,"name":"James Smith","email":"jsmith@rallysmith.co.uk","username":"RallySmith"},"ref":"refs/changes/75/6275/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/75/6275/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/3 \u0026\u0026 git checkout -b change-6275 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/75/6275/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/75/6275/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ab420a770b4b90d55132c7a6a4257ac720c07991","subject":"rtos: use ARRAY_SIZE() and simplify rtos_type.create()"}],"author":{"name":"James G. Smith","email":"jsmith@rallysmith.co.uk","date":"2021-05-26 09:08:26.000000000","tz":60},"committer":{"name":"James Smith","email":"jsmith@rallysmith.co.uk","date":"2021-05-27 10:05:41.000000000","tz":60},"subject":"src/rtos/eCos : Support per-build configuration specific structure layouts","message":"src/rtos/eCos : Support per-build configuration specific structure layouts\n\nExtended feature. This is a large patch, but is self-contained to the\neCos support and does not affect any other openocd functionality. It\ndoes NOT affect existing eCos RTOS plugin users where their\napplications do not provide the extended symbolic helper\ninformation. If the helper symbols are not available the rtos support\ncode will behave as before. This \"dynamic\" functionality is *required*\nbecause eCos does NOT have a fixed/hardwired, known, layout for the\nthread descriptor structure. The per-application build eCos\nconfiguration can affect the shape of the thread descriptor structure\n(field presence, and hence offsets of subsequent fields) such that\nconstant values cannot be used to consistently interpret all possible\neCos application configurations. For historical reasons, there is not\nyet a consistent namespace for the helper symbols across eCos HALs\nhence the support is currently limited to specific architectures\n(Cortex-M and ARM/Cortex-A). No new Clang analyser warnings are raised\nby this changeset. The decision has been taken to initially minimise\nthe diff/patch size by not re-formatting the original non-conforming\ncoding-style of the eCos support to the newer openocd\ncoding-style. The aim being that when/if this feature changeset is\napproved/merged the source can then be updated to reflect the current\nopenocd coding-style for completeness.\n\nChange-Id: Ib3a36877326eeb56595cbca55e21b9e59a59c98a\nSigned-off-by: James G. Smith \u003cjsmith@rallysmith.co.uk\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}