)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"5dfac6a15bf0db755a36e4a853d476e360356545","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fc626b12_199a5048","updated":"2021-11-01 13:46:18.000000000","message":"This minor change just adds/extends several debug prints, intended to help with troubleshooting OpenOCD\u0027s network connection to GDB.\n\nPlease let me know if you have any suggestions or if we can merge this.","commit_id":"6b1038c1f67be63d500a402b1944fc6879b7afab"}],"src/server/gdb_server.c":[{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"e7c0a8a6df7525fa7e1d326094f07cba4f431e28","unresolved":false,"context_lines":[{"line_number":353,"context_line":"\t\treturn ERROR_SERVER_REMOTE_CLOSED;"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"\tif (connection_write(connection, data, len) \u003d\u003d len) {"},{"line_number":356,"context_line":"\t\tLOG_DEBUG(\"GDB socket marked as closed, cannot write to it.\");"},{"line_number":357,"context_line":"\t\treturn ERROR_OK;"},{"line_number":358,"context_line":"\t}"},{"line_number":359,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"aedf27f1_5bb146db","line":356,"range":{"start_line":356,"start_character":2,"end_line":356,"end_character":64},"updated":"2021-06-03 15:29:12.000000000","message":"this seems to be incorrect, maybe should be 2 lines above ;)","commit_id":"3e1d95e8bb97618701aaf573d25d17ebea200a3c"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"a394a837799bb199e35d21683ff4b48bf5738a90","unresolved":false,"context_lines":[{"line_number":353,"context_line":"\t\treturn ERROR_SERVER_REMOTE_CLOSED;"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"\tif (connection_write(connection, data, len) \u003d\u003d len) {"},{"line_number":356,"context_line":"\t\tLOG_DEBUG(\"GDB socket marked as closed, cannot write to it.\");"},{"line_number":357,"context_line":"\t\treturn ERROR_OK;"},{"line_number":358,"context_line":"\t}"},{"line_number":359,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"aedf27f1_bb515267","line":356,"range":{"start_line":356,"start_character":2,"end_line":356,"end_character":64},"in_reply_to":"aedf27f1_5bb146db","updated":"2021-06-04 05:30:33.000000000","message":"You\u0027re right. Thanks for the catch.","commit_id":"3e1d95e8bb97618701aaf573d25d17ebea200a3c"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"bd896e1bdec02fc963b860b5058bb15cd7264ebc","unresolved":false,"context_lines":[{"line_number":350,"context_line":"{"},{"line_number":351,"context_line":"\tstruct gdb_connection *gdb_con \u003d connection-\u003epriv;"},{"line_number":352,"context_line":"\tif (gdb_con-\u003eclosed) {"},{"line_number":353,"context_line":"\t\tLOG_DEBUG(\"GDB socket marked as closed, cannot write to it.\");"},{"line_number":354,"context_line":"\t\treturn ERROR_SERVER_REMOTE_CLOSED;"},{"line_number":355,"context_line":"\t}"},{"line_number":356,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"aedf27f1_fbd6fac7","line":353,"updated":"2021-06-04 06:02:29.000000000","message":"maybe LOG_ERROR, sorry i forgot to mention it earlier","commit_id":"858672490fff353af36ee9303fd70598c2436ded"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"7549453bf73272fe8ba344f99e553384421b97fe","unresolved":false,"context_lines":[{"line_number":350,"context_line":"{"},{"line_number":351,"context_line":"\tstruct gdb_connection *gdb_con \u003d connection-\u003epriv;"},{"line_number":352,"context_line":"\tif (gdb_con-\u003eclosed) {"},{"line_number":353,"context_line":"\t\tLOG_DEBUG(\"GDB socket marked as closed, cannot write to it.\");"},{"line_number":354,"context_line":"\t\treturn ERROR_SERVER_REMOTE_CLOSED;"},{"line_number":355,"context_line":"\t}"},{"line_number":356,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"aedf27f1_bbf71256","line":353,"in_reply_to":"aedf27f1_fbd6fac7","updated":"2021-06-04 06:27:19.000000000","message":"In this case, the DEBUG level seems sufficient to me. If the connection got closed, an appropriate error message (if any) got printed at the point where gdb_con-\u003eclose\u003dtrue was set.\n\nBut let me know if you still believe this should be WARNING or ERROR.","commit_id":"858672490fff353af36ee9303fd70598c2436ded"}]}