)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"c54242db9a1b3ee6caa97ce1fd6e8183d06b5b6c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5d908a0a_8002c708","updated":"2022-03-20 14:40:18.000000000","message":"Antonio, please let us merge this ASAP. It works perfectly on EFM32 (J-Link) and makes using TPIU way easier.","commit_id":"2a3a2fef6659b33a63725efce3d6941eeae9d267"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f0ce11bbb3d4d26a596ec4b118b05983210432cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"002e4ea8_feabfd68","updated":"2022-03-20 21:53:01.000000000","message":"Completely forgot this. Thanks for testing it. Queued for next weekend!","commit_id":"2a3a2fef6659b33a63725efce3d6941eeae9d267"}],"src/target/arm_tpiu_swo.c":[{"author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"change_message_id":"bdb13e05e626152e0459f501a589f9663ad43fef","unresolved":false,"context_lines":[{"line_number":720,"context_line":""},{"line_number":721,"context_line":"\t\tif (obj-\u003epin_protocol \u003d\u003d TPIU_SPPR_PROTOCOL_MANCHESTER || obj-\u003epin_protocol \u003d\u003d TPIU_SPPR_PROTOCOL_UART)"},{"line_number":722,"context_line":"\t\t\tif (!swo_pin_freq) {"},{"line_number":723,"context_line":"\t\t\t\tLOG_ERROR(\"SWO pin frequency not set\");"},{"line_number":724,"context_line":"\t\t\t\treturn JIM_ERR;"},{"line_number":725,"context_line":"\t\t\t}"},{"line_number":726,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"aedf27f1_0e6e1e2b","line":723,"updated":"2021-06-09 10:49:34.000000000","message":"Could we say anything else here to help steer users?  WHat was tried, does the adapter not provide a default? can the adapter provide a list of what would be allowed? is this actually even an allowed path for the adapter to _succeed_ at adapter_config_trace(), but return 0 into swo_pin_freq?  _should_ adapters be allowed to do so?  Could we make them fail the call if they can\u0027t autodetect, and it wasn\u0027t provided instead of trying to generically catch it here where we have less info available as to why?","commit_id":"f5521d5e9c87d63ee2a8f8fb99f2f30930bedba1"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"def5023f2a811e718819cd7db80b4e5ea2d76bea","unresolved":false,"context_lines":[{"line_number":720,"context_line":""},{"line_number":721,"context_line":"\t\tif (obj-\u003epin_protocol \u003d\u003d TPIU_SPPR_PROTOCOL_MANCHESTER || obj-\u003epin_protocol \u003d\u003d TPIU_SPPR_PROTOCOL_UART)"},{"line_number":722,"context_line":"\t\t\tif (!swo_pin_freq) {"},{"line_number":723,"context_line":"\t\t\t\tLOG_ERROR(\"SWO pin frequency not set\");"},{"line_number":724,"context_line":"\t\t\t\treturn JIM_ERR;"},{"line_number":725,"context_line":"\t\t\t}"},{"line_number":726,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"aedf27f1_ce77b6fc","line":723,"in_reply_to":"aedf27f1_0e6e1e2b","updated":"2021-06-09 13:00:27.000000000","message":"What adapter does is really up to the adapter driver.\nCMSIS-DAP return error for freq\u003d0\nST-Link set it to max_trace_freq\nJ-Link tries an autodetect\nI don\u0027t think we can standardize the behavior among all the adapters.\n\nFor the error message, maybe even a more wide check. What about:\nif (!swo_pin_freq) {\n  if (obj-\u003eswo_pin_freq)\n    LOG_ERROR(\"Adapter rejected SWO pin frequency %d Hz\", obj-\u003eswo_pin_freq);\n  else\n    LOG_ERROR(\"Adapter does not support auto-detection of SWO pin frequency nor a default value.\");\n  return JIM_ERR;\n}","commit_id":"f5521d5e9c87d63ee2a8f8fb99f2f30930bedba1"}]}