)]}'
{"id":"openocd~master~I3dfbe3256e8887ef4f03512769b06381cdc9db0d","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-03-20 21:53:01.000000000","reason":"Antonio Borneo replied on the change"}},"hashtags":[],"change_id":"I3dfbe3256e8887ef4f03512769b06381cdc9db0d","subject":"arm_tpiu_swo: fix autodetection of SWO pin frequency","status":"MERGED","created":"2021-06-09 09:45:36.000000000","updated":"2022-03-26 13:23:40.000000000","submitted":"2022-03-26 13:23:40.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6310","meta_rev_id":"4646c0d95089cd2eb689179e51b58cfa0c70f419","_number":6310,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-03-26 13:23:40.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-03-26 13:23:40.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-03-26 13:23:40.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-06-09 10:49:34.000000000","updated_by":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"reviewer":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"state":"REVIEWER"},{"updated":"2021-06-09 17:33:07.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-06-17 17:32:16.000000000","updated_by":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"reviewer":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"REVIEWER"}],"messages":[{"id":"b1869d7d840a6923773de2770a3030ddbba5f2ea","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-06-09 09:45:36.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"412e52347412afd78da40f3771d82dda89325171","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-06-09 10:17:25.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14733/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/13978/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"bdb13e05e626152e0459f501a589f9663ad43fef","author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"real_author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"date":"2021-06-09 10:49:34.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"def5023f2a811e718819cd7db80b4e5ea2d76bea","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-06-09 13:00:27.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"70af77f054eb3db7e1cddc8e18f7f2ca8f56a8a7","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2021-06-09 16:24:26.000000000","message":"Patch Set 1:\n\nAuto-detection works for me. Tested with EFM32PG12 with an external J-Link. However, it\u0027s not really reliable but I\u0027m not sure what exactly is the problem.\n\nPlease do not use LOG_ERROR() for the first message. It\u0027s more an INFO or WARNING.","accounts_in_message":[],"_revision_number":1},{"id":"b7aafc4c24aa274240dafa334f44e5eea3b1f974","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-06-09 16:55:55.000000000","message":"Patch Set 1:\n\n\u003e Auto-detection works for me. Tested with EFM32PG12 with an external\n \u003e J-Link. However, it\u0027s not really reliable but I\u0027m not sure what\n \u003e exactly is the problem.\n\nWhat you mean it\u0027s not reliable? Is the SWO data flow that get corrupted or is the detected frequency that changes at every run? \n\n \u003e Please do not use LOG_ERROR() for the first message. It\u0027s more an\n \u003e INFO or WARNING.\n\nI consider both as error conditions that cause return JIM_ERR.\nMaybe they are both useless, because the adapter should have returned error already from adapter_config_trace() two lines above. It\u0027s just an additional check after adapter_config_trace().\n\nBy the way, it\u0027s missing\narm_tpiu_swo_close_output(obj);\nbefore\nreturn JIM_ERR;","accounts_in_message":[],"_revision_number":1},{"id":"98f8b3f465ac583668521ca7be1b8058818477ad","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-06-09 17:01:52.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"7a8a0b225f5fcc7a7b2e1408fd4b605bd2dce290","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-06-09 17:33:07.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14734/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/13979/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"7139d42770026b3c55caf37c6831b6b2de1fb6bd","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2021-06-16 17:49:29.000000000","message":"Patch Set 2:\n\n\u003e What you mean it\u0027s not reliable? Is the SWO data flow that get corrupted or is the detected frequency that changes at every run? \n\nIt work\u0027s only when I enable the TPIU while the target is running. Not sure if that\u0027s related to the target I use or not.","accounts_in_message":[],"_revision_number":2},{"id":"ea69a8cd7e83a3e32120d7de0e24fd8c98686663","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-06-16 20:00:44.000000000","message":"Patch Set 2:\n\n\u003e It work\u0027s only when I enable the TPIU while the target is running.\n \u003e Not sure if that\u0027s related to the target I use or not.\n\nautodetection is requested \"before\" enabling the SWO.\nOn UART based communication, the receiver (J-Link) requires the transmitter (SWO) to send a pattern in order to detect the length of the start bit and compute the bitrate.\nI suspect that J-Link programs something on the target to force it to send a pattern on SWO.\nProbably this mechanism fails when target is halted.\nDon\u0027t know if makes sense to capture the SWD communication with a logic analyzer.","accounts_in_message":[],"_revision_number":2},{"id":"80dae893258340fdc396c4952938e36764e9cb39","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2021-06-17 17:32:16.000000000","message":"Patch Set 2: Code-Review+1\n\n\u003e I suspect that J-Link programs something on the target to force it to send a pattern on SWO.\n\nNo there is no unintended SWD communication since we use the low-level API for J-Link devices.\n\nAnyway, checked with 0.10.0 and it\u0027s the same behaviour. Hence, no regression as suspected initially .","accounts_in_message":[],"_revision_number":2},{"id":"91138403934a4b0fcac43aaca8f9a162574299b3","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-06-18 07:55:35.000000000","message":"Patch Set 2: Code-Review+1\n\nThanks for your tests.\nI have checked the jlink driver. The auto-detection is based on the values returned in struct jaylink_swo_speed. I would expect it\u0027s a static set of values returned by jlink whatever the status of the target is.\nStrange this fails on halted targets!","accounts_in_message":[],"_revision_number":2},{"id":"c54242db9a1b3ee6caa97ce1fd6e8183d06b5b6c","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2022-03-20 14:40:18.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"f0ce11bbb3d4d26a596ec4b118b05983210432cd","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-20 21:53:01.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"4646c0d95089cd2eb689179e51b58cfa0c70f419","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-26 13:23:40.000000000","message":"Change has been successfully cherry-picked as 00d4699d0b559a0bb3e739a78f3ce1c5731f8dea","accounts_in_message":[],"_revision_number":3}],"current_revision":"00d4699d0b559a0bb3e739a78f3ce1c5731f8dea","revisions":{"f5521d5e9c87d63ee2a8f8fb99f2f30930bedba1":{"kind":"REWORK","_number":1,"created":"2021-06-09 09:45:36.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/10/6310/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/10/6310/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/10/6310/1 \u0026\u0026 git checkout -b change-6310 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/10/6310/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/10/6310/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/10/6310/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/10/6310/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/10/6310/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bb81ec8bf00f2d8cc0719cef802a367b4dc286e6","subject":"target/startup.tcl: Do not use \u0027Yoda conditions\u0027"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-06-09 09:27:57.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-06-09 09:27:57.000000000","tz":120},"subject":"arm_tpiu_swo: fix autodetection of SWO pin frequency","message":"arm_tpiu_swo: fix autodetection of SWO pin frequency\n\nWhile the documentation reports that SWO pin frequency can be\nomitted to let the adapter autodetect the value, the code wrongly\ndrops an error when pin frequency is not specified.\n\nDon\u0027t require the pin frequency to be set at \"enable\", but verify\nthat the adapter has properly changes it to a valid value.\n\nChange-Id: I3dfbe3256e8887ef4f03512769b06381cdc9db0d\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReported-by: Karl Palsson \u003ckarlp@tweak.net.au\u003e\nFixes: 184724d14e12 (\"arm_tpiu_swo: add support for independent TPIU and SWO\")\n"}},"00d4699d0b559a0bb3e739a78f3ce1c5731f8dea":{"kind":"REWORK","_number":3,"created":"2022-03-26 13:23:40.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/10/6310/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/10/6310/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/10/6310/3 \u0026\u0026 git checkout -b change-6310 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/10/6310/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/10/6310/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/10/6310/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/10/6310/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/10/6310/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1b716b9d0d42409f5ee8855f084720ff579a7737","subject":"tcl/tools: Add function to measure the speed of ARM Cortex-M devices"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-06-09 09:27:57.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-03-26 13:23:40.000000000","tz":0},"subject":"arm_tpiu_swo: fix autodetection of SWO pin frequency","message":"arm_tpiu_swo: fix autodetection of SWO pin frequency\n\nWhile the documentation reports that SWO pin frequency can be\nomitted to let the adapter autodetect the value, the code wrongly\ndrops an error when pin frequency is not specified.\n\nDon\u0027t require the pin frequency to be set at \"enable\", but verify\nthat the adapter has properly changes it to a valid value.\n\nChange-Id: I3dfbe3256e8887ef4f03512769b06381cdc9db0d\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReported-by: Karl Palsson \u003ckarlp@tweak.net.au\u003e\nFixes: 184724d14e12 (\"arm_tpiu_swo: add support for independent TPIU and SWO\")\nReviewed-on: https://review.openocd.org/c/openocd/+/6310\nTested-by: jenkins\nReviewed-by: zapb \u003cdev@zapb.de\u003e\n"}},"2a3a2fef6659b33a63725efce3d6941eeae9d267":{"kind":"REWORK","_number":2,"created":"2021-06-09 17:01:52.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/10/6310/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/10/6310/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/10/6310/2 \u0026\u0026 git checkout -b change-6310 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/10/6310/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/10/6310/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/10/6310/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/10/6310/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/10/6310/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bb81ec8bf00f2d8cc0719cef802a367b4dc286e6","subject":"target/startup.tcl: Do not use \u0027Yoda conditions\u0027"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-06-09 09:27:57.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-06-09 17:01:27.000000000","tz":120},"subject":"arm_tpiu_swo: fix autodetection of SWO pin frequency","message":"arm_tpiu_swo: fix autodetection of SWO pin frequency\n\nWhile the documentation reports that SWO pin frequency can be\nomitted to let the adapter autodetect the value, the code wrongly\ndrops an error when pin frequency is not specified.\n\nDon\u0027t require the pin frequency to be set at \"enable\", but verify\nthat the adapter has properly changes it to a valid value.\n\nChange-Id: I3dfbe3256e8887ef4f03512769b06381cdc9db0d\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReported-by: Karl Palsson \u003ckarlp@tweak.net.au\u003e\nFixes: 184724d14e12 (\"arm_tpiu_swo: add support for independent TPIU and SWO\")\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}