)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"7735138ede9fe709fb81590ad22a12d5253bce00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c40637b2_d7ee2bda","updated":"2021-11-15 22:05:54.000000000","message":"Marc, I like the change, the mess in the current breakpoint code is really horrible.\n\nSurprisingly it merges with only 3 trivial conflicts with some of \u0027remove NULL comparisons\u0027 commits.\nUnfortunately also Yasushi is right. At least one target has\n\n  breakpoint-\u003enumber \u003d ...\n\nbut\n\n  breakpoint-\u003eis_set \u003d true;\n\nis missing. Marc please double check all places where breakpoint-\u003enumber was originally set to non-zero.","commit_id":"622c009d3b1d76debe940a71149ce2fad0711ce2"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"7ff1c5c87035c6c699ffb67624979e10521309f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3cdeff82_ba8f1ac6","updated":"2022-02-25 21:46:32.000000000","message":"Seems functional, just minor issues.","commit_id":"8f8bceed0346ec4b823d1456f03debf681642013"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"db08f3dedbbe2af33efea1e5dd045f44f5c4c30a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"8ade28fb_2826f051","updated":"2022-03-12 09:55:07.000000000","message":"Marc, after merge of https://review.openocd.org/6672/ this cannot be merged anymore.\nWould you mind rebasing this?\nOnly src/target/cortex_m.c is conflicting","commit_id":"7e8e9b630b3eb9bf6dcb9e74078274424658b053"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e7b37137c96539f6e484a8111dc724b3712a6bd4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"41c8eb68_2ee57db4","updated":"2022-03-12 16:42:59.000000000","message":"Thanks!","commit_id":"5ebe803eec1204731515f1691e4b6517fab4d187"}],"src/target/aarch64.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"62da8cef2aa7c70e69d8d1a9a5bb99fd0783931b","unresolved":false,"context_lines":[{"line_number":1331,"context_line":"\t\t\t\tbreakpoint-\u003eaddress \u0026 0xFFFFFFFFFFFFFFFE,"},{"line_number":1332,"context_line":"\t\t\t\tbreakpoint-\u003elength);"},{"line_number":1333,"context_line":""},{"line_number":1334,"context_line":"\t\tbreakpoint-\u003eset \u003d true;"},{"line_number":1335,"context_line":"\t}"},{"line_number":1336,"context_line":""},{"line_number":1337,"context_line":"\t/* Ensure that halting debug mode is enable */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"aedf27f1_719f8bba","line":1334,"updated":"2021-06-14 21:42:44.000000000","message":"In general case, I\u0027m not sure it\u0027s ok to left -\u003enumber not initialized.\nShould we use this?\n#define SOFTWARE_BREAKPOINT_NUMBER UINT_MAX","commit_id":"b5f80d8b795489dfa2dc71d3768feee1d38f3cf2"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"62da8cef2aa7c70e69d8d1a9a5bb99fd0783931b","unresolved":false,"context_lines":[{"line_number":1499,"context_line":"\t\tif ((breakpoint-\u003eaddress !\u003d 0) \u0026\u0026 (breakpoint-\u003easid !\u003d 0)) {"},{"line_number":1500,"context_line":"\t\t\tconst int brp_i \u003d breakpoint-\u003enumber;"},{"line_number":1501,"context_line":"\t\t\tint brp_j \u003d breakpoint-\u003elinked_brp;"},{"line_number":1502,"context_line":"\t\t\tif ((brp_i \u003c 0) || (brp_i \u003e\u003d aarch64-\u003ebrp_num)) {"},{"line_number":1503,"context_line":"\t\t\t\tLOG_DEBUG(\"Invalid BRP number in breakpoint\");"},{"line_number":1504,"context_line":"\t\t\t\treturn ERROR_OK;"},{"line_number":1505,"context_line":"\t\t\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"aedf27f1_51212799","line":1502,"updated":"2021-06-14 21:42:44.000000000","message":"here the check \"\u003c 0\" was an hack to check for \"set\u003d\u003dfalse\" or, better, \"set\u003d\u003d0\".\nI think it should be rewritten, also considering that \"number\" is now unsigned int.\nDon\u0027t know what to do with \"\u003e\u003d\"! It should never happen, apart for the crap assignment that was in line 1333. To be checked better.","commit_id":"b5f80d8b795489dfa2dc71d3768feee1d38f3cf2"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"62da8cef2aa7c70e69d8d1a9a5bb99fd0783931b","unresolved":false,"context_lines":[{"line_number":1554,"context_line":""},{"line_number":1555,"context_line":"\t\t} else {"},{"line_number":1556,"context_line":"\t\t\tconst int brp_i \u003d breakpoint-\u003enumber;"},{"line_number":1557,"context_line":"\t\t\tif ((brp_i \u003c 0) || (brp_i \u003e\u003d aarch64-\u003ebrp_num)) {"},{"line_number":1558,"context_line":"\t\t\t\tLOG_DEBUG(\"Invalid BRP number in breakpoint\");"},{"line_number":1559,"context_line":"\t\t\t\treturn ERROR_OK;"},{"line_number":1560,"context_line":"\t\t\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"aedf27f1_f135bbd8","line":1557,"updated":"2021-06-14 21:42:44.000000000","message":"same here","commit_id":"b5f80d8b795489dfa2dc71d3768feee1d38f3cf2"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"62da8cef2aa7c70e69d8d1a9a5bb99fd0783931b","unresolved":false,"context_lines":[{"line_number":1785,"context_line":"\t}"},{"line_number":1786,"context_line":""},{"line_number":1787,"context_line":"\twp_i \u003d watchpoint-\u003enumber;"},{"line_number":1788,"context_line":"\tif ((wp_i \u003c 0) || (wp_i \u003e\u003d aarch64-\u003ewp_num)) {"},{"line_number":1789,"context_line":"\t\tLOG_DEBUG(\"Invalid WP number in watchpoint\");"},{"line_number":1790,"context_line":"\t\treturn ERROR_OK;"},{"line_number":1791,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"aedf27f1_11339ff4","line":1788,"updated":"2021-06-14 21:42:44.000000000","message":"same here","commit_id":"b5f80d8b795489dfa2dc71d3768feee1d38f3cf2"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c59d848b7566ca1930768edfcc02008587c700bc","unresolved":false,"context_lines":[{"line_number":1254,"context_line":"\t\t\t| (1 \u003c\u003c 13)"},{"line_number":1255,"context_line":"\t\t\t| (byte_addr_select \u003c\u003c 5)"},{"line_number":1256,"context_line":"\t\t\t| (3 \u003c\u003c 1) | 1;"},{"line_number":1257,"context_line":"\t\tbrp_list[brp_i].used \u003d 1;"},{"line_number":1258,"context_line":"\t\tbrp_list[brp_i].value \u003d breakpoint-\u003eaddress \u0026 0xFFFFFFFFFFFFFFFC;"},{"line_number":1259,"context_line":"\t\tbrp_list[brp_i].control \u003d control;"},{"line_number":1260,"context_line":"\t\tbpt_value \u003d brp_list[brp_i].value;"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"aedf27f1_513e0728","line":1257,"updated":"2021-06-19 21:39:18.000000000","message":"Not in this same patch, but also this should be a bool!","commit_id":"6d1623e7bf5f087517595bbb88722a93eee1a082"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"3766d3e194259e845d54b0b12c2e244c831bf9c6","unresolved":false,"context_lines":[{"line_number":1254,"context_line":"\t\t\t| (1 \u003c\u003c 13)"},{"line_number":1255,"context_line":"\t\t\t| (byte_addr_select \u003c\u003c 5)"},{"line_number":1256,"context_line":"\t\t\t| (3 \u003c\u003c 1) | 1;"},{"line_number":1257,"context_line":"\t\tbrp_list[brp_i].used \u003d 1;"},{"line_number":1258,"context_line":"\t\tbrp_list[brp_i].value \u003d breakpoint-\u003eaddress \u0026 0xFFFFFFFFFFFFFFFC;"},{"line_number":1259,"context_line":"\t\tbrp_list[brp_i].control \u003d control;"},{"line_number":1260,"context_line":"\t\tbpt_value \u003d brp_list[brp_i].value;"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"4eceab4c_8fbc591c","line":1257,"in_reply_to":"aedf27f1_513e0728","updated":"2021-07-15 08:21:14.000000000","message":"Yep","commit_id":"6d1623e7bf5f087517595bbb88722a93eee1a082"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"c41fb0e487e7ea89ecfdbfb12b97fbeb3de713be","unresolved":true,"context_lines":[{"line_number":1246,"context_line":"\t\t\tLOG_ERROR(\"ERROR Can not find free Breakpoint Register Pair\");"},{"line_number":1247,"context_line":"\t\t\treturn ERROR_TARGET_RESOURCE_NOT_AVAILABLE;"},{"line_number":1248,"context_line":"\t\t}"},{"line_number":1249,"context_line":"\t\tbreakpoint-\u003eis_set \u003d true;"},{"line_number":1250,"context_line":"\t\tbreakpoint-\u003enumber \u003d brp_i;"},{"line_number":1251,"context_line":"\t\tif (breakpoint-\u003elength \u003d\u003d 2)"},{"line_number":1252,"context_line":"\t\t\tbyte_addr_select \u003d (3 \u003c\u003c (breakpoint-\u003eaddress \u0026 0x02));"},{"line_number":1253,"context_line":"\t\tcontrol \u003d ((matchmode \u0026 0x7) \u003c\u003c 20)"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"65dd4241_c42a4451","line":1250,"range":{"start_line":1249,"start_character":2,"end_line":1250,"end_character":29},"updated":"2021-11-15 22:35:58.000000000","message":"What about replacing all setting of breakpoint-\u003enumber by calling sth like:\n\n  inline void breakpoint_hw_set(struct breakpoint *breakpoint, unsigned int hw_number)\n  {\n    breakpoint-\u003enumber \u003d hw_number;\n    breakpoint-\u003eis_set \u003d true;\n  }","commit_id":"622c009d3b1d76debe940a71149ce2fad0711ce2"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"a8ba8ef64b88e3d3ed36f56565507e888fca0250","unresolved":false,"context_lines":[{"line_number":1246,"context_line":"\t\t\tLOG_ERROR(\"ERROR Can not find free Breakpoint Register Pair\");"},{"line_number":1247,"context_line":"\t\t\treturn ERROR_TARGET_RESOURCE_NOT_AVAILABLE;"},{"line_number":1248,"context_line":"\t\t}"},{"line_number":1249,"context_line":"\t\tbreakpoint-\u003eis_set \u003d true;"},{"line_number":1250,"context_line":"\t\tbreakpoint-\u003enumber \u003d brp_i;"},{"line_number":1251,"context_line":"\t\tif (breakpoint-\u003elength \u003d\u003d 2)"},{"line_number":1252,"context_line":"\t\t\tbyte_addr_select \u003d (3 \u003c\u003c (breakpoint-\u003eaddress \u0026 0x02));"},{"line_number":1253,"context_line":"\t\tcontrol \u003d ((matchmode \u0026 0x7) \u003c\u003c 20)"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"9c819f0b_390cca3b","line":1250,"range":{"start_line":1249,"start_character":2,"end_line":1250,"end_character":29},"in_reply_to":"65dd4241_c42a4451","updated":"2022-02-12 10:45:55.000000000","message":"Done","commit_id":"622c009d3b1d76debe940a71149ce2fad0711ce2"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"7735138ede9fe709fb81590ad22a12d5253bce00","unresolved":true,"context_lines":[{"line_number":1497,"context_line":""},{"line_number":1498,"context_line":"\tif (breakpoint-\u003etype \u003d\u003d BKPT_HARD) {"},{"line_number":1499,"context_line":"\t\tif ((breakpoint-\u003eaddress !\u003d 0) \u0026\u0026 (breakpoint-\u003easid !\u003d 0)) {"},{"line_number":1500,"context_line":"\t\t\tconst int brp_i \u003d breakpoint-\u003enumber;"},{"line_number":1501,"context_line":"\t\t\tint brp_j \u003d breakpoint-\u003elinked_brp;"},{"line_number":1502,"context_line":"\t\t\tif (brp_i \u003e\u003d aarch64-\u003ebrp_num) {"},{"line_number":1503,"context_line":"\t\t\t\tLOG_DEBUG(\"Invalid BRP number in breakpoint\");"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"6c45e326_a5f9192e","line":1500,"range":{"start_line":1500,"start_character":3,"end_line":1500,"end_character":9},"updated":"2021-11-15 22:05:54.000000000","message":"Yes, brp_i is really const during its life time. But do we need to declare it explicitly?\nI\u0027m sure the optimizing C compiler is smart enough to know this from code analysis.\n\nDo we need to prevent the code from changing brp_i? I hope we don\u0027t.\n\nIf we really wanted to mark all variables unchanged during their life time, we should write absurdities like:\n\n  {\n    const int retval \u003d aarch64_dap_write...\n    if (retval !\u003d ERROR_OK)\n\treturn retval;\n  }\n  {\n    const int retval \u003d another_aarch64_dap_write...\n    if (retval !\u003d ERROR_OK)\n\treturn retval;\n  }\n\nDo you like it? I propose to keep the code simple and use const only when it is really important.","commit_id":"622c009d3b1d76debe940a71149ce2fad0711ce2"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"a8ba8ef64b88e3d3ed36f56565507e888fca0250","unresolved":false,"context_lines":[{"line_number":1497,"context_line":""},{"line_number":1498,"context_line":"\tif (breakpoint-\u003etype \u003d\u003d BKPT_HARD) {"},{"line_number":1499,"context_line":"\t\tif ((breakpoint-\u003eaddress !\u003d 0) \u0026\u0026 (breakpoint-\u003easid !\u003d 0)) {"},{"line_number":1500,"context_line":"\t\t\tconst int brp_i \u003d breakpoint-\u003enumber;"},{"line_number":1501,"context_line":"\t\t\tint brp_j \u003d breakpoint-\u003elinked_brp;"},{"line_number":1502,"context_line":"\t\t\tif (brp_i \u003e\u003d aarch64-\u003ebrp_num) {"},{"line_number":1503,"context_line":"\t\t\t\tLOG_DEBUG(\"Invalid BRP number in breakpoint\");"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"6a26b87d_0c8703b9","line":1500,"range":{"start_line":1500,"start_character":3,"end_line":1500,"end_character":9},"in_reply_to":"6c45e326_a5f9192e","updated":"2022-02-12 10:45:55.000000000","message":"Done","commit_id":"622c009d3b1d76debe940a71149ce2fad0711ce2"}],"src/target/arm7_9_common.c":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"7ff1c5c87035c6c699ffb67624979e10521309f1","unresolved":true,"context_lines":[{"line_number":93,"context_line":"{"},{"line_number":94,"context_line":"\tif (!arm7_9-\u003ewp0_used) {"},{"line_number":95,"context_line":"\t\tarm7_9-\u003ewp0_used \u003d 1;"},{"line_number":96,"context_line":"\t\tbreakpoint_hw_set(breakpoint, 1);"},{"line_number":97,"context_line":"\t\tarm7_9-\u003ewp_available--;"},{"line_number":98,"context_line":"\t} else if (!arm7_9-\u003ewp1_used) {"},{"line_number":99,"context_line":"\t\tarm7_9-\u003ewp1_used \u003d 1;"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"57c3169f_626341a2","line":96,"range":{"start_line":96,"start_character":32,"end_line":96,"end_character":33},"updated":"2022-02-25 21:46:32.000000000","message":"Just cosmetic nit: wouldn\u0027t be better to follow wp num 0 as we can?","commit_id":"8f8bceed0346ec4b823d1456f03debf681642013"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"92d8f6826e5f7020636552eef1243eb6563ca464","unresolved":false,"context_lines":[{"line_number":93,"context_line":"{"},{"line_number":94,"context_line":"\tif (!arm7_9-\u003ewp0_used) {"},{"line_number":95,"context_line":"\t\tarm7_9-\u003ewp0_used \u003d 1;"},{"line_number":96,"context_line":"\t\tbreakpoint_hw_set(breakpoint, 1);"},{"line_number":97,"context_line":"\t\tarm7_9-\u003ewp_available--;"},{"line_number":98,"context_line":"\t} else if (!arm7_9-\u003ewp1_used) {"},{"line_number":99,"context_line":"\t\tarm7_9-\u003ewp1_used \u003d 1;"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"14a2aa02_41fe3820","line":96,"range":{"start_line":96,"start_character":32,"end_line":96,"end_character":33},"in_reply_to":"57c3169f_626341a2","updated":"2022-03-06 20:48:26.000000000","message":"Done","commit_id":"8f8bceed0346ec4b823d1456f03debf681642013"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"7ff1c5c87035c6c699ffb67624979e10521309f1","unresolved":true,"context_lines":[{"line_number":97,"context_line":"\t\tarm7_9-\u003ewp_available--;"},{"line_number":98,"context_line":"\t} else if (!arm7_9-\u003ewp1_used) {"},{"line_number":99,"context_line":"\t\tarm7_9-\u003ewp1_used \u003d 1;"},{"line_number":100,"context_line":"\t\tbreakpoint_hw_set(breakpoint, 2);"},{"line_number":101,"context_line":"\t\tarm7_9-\u003ewp_available--;"},{"line_number":102,"context_line":"\t} else {"},{"line_number":103,"context_line":"\t\tLOG_ERROR(\"BUG: no hardware comparator available\");"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"ff8940c4_56dfcb1a","line":100,"range":{"start_line":100,"start_character":32,"end_line":100,"end_character":33},"updated":"2022-02-25 21:46:32.000000000","message":"1","commit_id":"8f8bceed0346ec4b823d1456f03debf681642013"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"92d8f6826e5f7020636552eef1243eb6563ca464","unresolved":false,"context_lines":[{"line_number":97,"context_line":"\t\tarm7_9-\u003ewp_available--;"},{"line_number":98,"context_line":"\t} else if (!arm7_9-\u003ewp1_used) {"},{"line_number":99,"context_line":"\t\tarm7_9-\u003ewp1_used \u003d 1;"},{"line_number":100,"context_line":"\t\tbreakpoint_hw_set(breakpoint, 2);"},{"line_number":101,"context_line":"\t\tarm7_9-\u003ewp_available--;"},{"line_number":102,"context_line":"\t} else {"},{"line_number":103,"context_line":"\t\tLOG_ERROR(\"BUG: no hardware comparator available\");"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"e1096fe7_b6656bc8","line":100,"range":{"start_line":100,"start_character":32,"end_line":100,"end_character":33},"in_reply_to":"ff8940c4_56dfcb1a","updated":"2022-03-06 20:48:26.000000000","message":"Done","commit_id":"8f8bceed0346ec4b823d1456f03debf681642013"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"7ff1c5c87035c6c699ffb67624979e10521309f1","unresolved":true,"context_lines":[{"line_number":207,"context_line":"\t\tif (!breakpoint-\u003eis_set)"},{"line_number":208,"context_line":"\t\t\tarm7_9_assign_wp(arm7_9, breakpoint);"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"\t\tif (breakpoint-\u003enumber \u003d\u003d 1) {"},{"line_number":211,"context_line":"\t\t\tembeddedice_set_reg(\u0026arm7_9-\u003eeice_cache-\u003ereg_list[EICE_W0_ADDR_VALUE], breakpoint-\u003eaddress);"},{"line_number":212,"context_line":"\t\t\tembeddedice_set_reg(\u0026arm7_9-\u003eeice_cache-\u003ereg_list[EICE_W0_ADDR_MASK], mask);"},{"line_number":213,"context_line":"\t\t\tembeddedice_set_reg(\u0026arm7_9-\u003eeice_cache-\u003ereg_list[EICE_W0_DATA_MASK], 0xffffffffu);"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"b8a6bebc_0ceafa09","line":210,"range":{"start_line":210,"start_character":28,"end_line":210,"end_character":29},"updated":"2022-02-25 21:46:32.000000000","message":"0","commit_id":"8f8bceed0346ec4b823d1456f03debf681642013"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"92d8f6826e5f7020636552eef1243eb6563ca464","unresolved":false,"context_lines":[{"line_number":207,"context_line":"\t\tif (!breakpoint-\u003eis_set)"},{"line_number":208,"context_line":"\t\t\tarm7_9_assign_wp(arm7_9, breakpoint);"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"\t\tif (breakpoint-\u003enumber \u003d\u003d 1) {"},{"line_number":211,"context_line":"\t\t\tembeddedice_set_reg(\u0026arm7_9-\u003eeice_cache-\u003ereg_list[EICE_W0_ADDR_VALUE], breakpoint-\u003eaddress);"},{"line_number":212,"context_line":"\t\t\tembeddedice_set_reg(\u0026arm7_9-\u003eeice_cache-\u003ereg_list[EICE_W0_ADDR_MASK], mask);"},{"line_number":213,"context_line":"\t\t\tembeddedice_set_reg(\u0026arm7_9-\u003eeice_cache-\u003ereg_list[EICE_W0_DATA_MASK], 0xffffffffu);"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"bbcf4f04_685c9af9","line":210,"range":{"start_line":210,"start_character":28,"end_line":210,"end_character":29},"in_reply_to":"b8a6bebc_0ceafa09","updated":"2022-03-06 20:48:26.000000000","message":"Done","commit_id":"8f8bceed0346ec4b823d1456f03debf681642013"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"7ff1c5c87035c6c699ffb67624979e10521309f1","unresolved":true,"context_lines":[{"line_number":213,"context_line":"\t\t\tembeddedice_set_reg(\u0026arm7_9-\u003eeice_cache-\u003ereg_list[EICE_W0_DATA_MASK], 0xffffffffu);"},{"line_number":214,"context_line":"\t\t\tembeddedice_set_reg(\u0026arm7_9-\u003eeice_cache-\u003ereg_list[EICE_W0_CONTROL_MASK], ~EICE_W_CTRL_NOPC \u0026 0xff);"},{"line_number":215,"context_line":"\t\t\tembeddedice_set_reg(\u0026arm7_9-\u003eeice_cache-\u003ereg_list[EICE_W0_CONTROL_VALUE], EICE_W_CTRL_ENABLE);"},{"line_number":216,"context_line":"\t\t} else if (breakpoint-\u003enumber \u003d\u003d 2) {"},{"line_number":217,"context_line":"\t\t\tembeddedice_set_reg(\u0026arm7_9-\u003eeice_cache-\u003ereg_list[EICE_W1_ADDR_VALUE], breakpoint-\u003eaddress);"},{"line_number":218,"context_line":"\t\t\tembeddedice_set_reg(\u0026arm7_9-\u003eeice_cache-\u003ereg_list[EICE_W1_ADDR_MASK], mask);"},{"line_number":219,"context_line":"\t\t\tembeddedice_set_reg(\u0026arm7_9-\u003eeice_cache-\u003ereg_list[EICE_W1_DATA_MASK], 0xffffffffu);"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"b08d7118_d4a22c1c","line":216,"range":{"start_line":216,"start_character":35,"end_line":216,"end_character":36},"updated":"2022-02-25 21:46:32.000000000","message":"1","commit_id":"8f8bceed0346ec4b823d1456f03debf681642013"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"92d8f6826e5f7020636552eef1243eb6563ca464","unresolved":false,"context_lines":[{"line_number":213,"context_line":"\t\t\tembeddedice_set_reg(\u0026arm7_9-\u003eeice_cache-\u003ereg_list[EICE_W0_DATA_MASK], 0xffffffffu);"},{"line_number":214,"context_line":"\t\t\tembeddedice_set_reg(\u0026arm7_9-\u003eeice_cache-\u003ereg_list[EICE_W0_CONTROL_MASK], ~EICE_W_CTRL_NOPC \u0026 0xff);"},{"line_number":215,"context_line":"\t\t\tembeddedice_set_reg(\u0026arm7_9-\u003eeice_cache-\u003ereg_list[EICE_W0_CONTROL_VALUE], EICE_W_CTRL_ENABLE);"},{"line_number":216,"context_line":"\t\t} else if (breakpoint-\u003enumber \u003d\u003d 2) {"},{"line_number":217,"context_line":"\t\t\tembeddedice_set_reg(\u0026arm7_9-\u003eeice_cache-\u003ereg_list[EICE_W1_ADDR_VALUE], breakpoint-\u003eaddress);"},{"line_number":218,"context_line":"\t\t\tembeddedice_set_reg(\u0026arm7_9-\u003eeice_cache-\u003ereg_list[EICE_W1_ADDR_MASK], mask);"},{"line_number":219,"context_line":"\t\t\tembeddedice_set_reg(\u0026arm7_9-\u003eeice_cache-\u003ereg_list[EICE_W1_DATA_MASK], 0xffffffffu);"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"5688f4cd_9a82e099","line":216,"range":{"start_line":216,"start_character":35,"end_line":216,"end_character":36},"in_reply_to":"b08d7118_d4a22c1c","updated":"2022-03-06 20:48:26.000000000","message":"Done","commit_id":"8f8bceed0346ec4b823d1456f03debf681642013"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"7ff1c5c87035c6c699ffb67624979e10521309f1","unresolved":true,"context_lines":[{"line_number":278,"context_line":""},{"line_number":279,"context_line":"\t\tarm7_9-\u003esw_breakpoint_count++;"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"\t\tbreakpoint_hw_set(breakpoint, 1);"},{"line_number":282,"context_line":"\t}"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"\treturn retval;"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"63e72b05_c059d84f","line":281,"range":{"start_line":281,"start_character":2,"end_line":281,"end_character":35},"updated":"2022-02-25 21:46:32.000000000","message":"Soft breakpoint, bkpt number has no meaning","commit_id":"8f8bceed0346ec4b823d1456f03debf681642013"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"92d8f6826e5f7020636552eef1243eb6563ca464","unresolved":false,"context_lines":[{"line_number":278,"context_line":""},{"line_number":279,"context_line":"\t\tarm7_9-\u003esw_breakpoint_count++;"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"\t\tbreakpoint_hw_set(breakpoint, 1);"},{"line_number":282,"context_line":"\t}"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"\treturn retval;"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"659a04d4_8f8266df","line":281,"range":{"start_line":281,"start_character":2,"end_line":281,"end_character":35},"in_reply_to":"63e72b05_c059d84f","updated":"2022-03-06 20:48:26.000000000","message":"Done","commit_id":"8f8bceed0346ec4b823d1456f03debf681642013"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"7ff1c5c87035c6c699ffb67624979e10521309f1","unresolved":true,"context_lines":[{"line_number":314,"context_line":"\t\tLOG_DEBUG(\"BPID: %\" PRIu32 \" Releasing hw wp: %d\","},{"line_number":315,"context_line":"\t\t\tbreakpoint-\u003eunique_id,"},{"line_number":316,"context_line":"\t\t\tbreakpoint-\u003eis_set);"},{"line_number":317,"context_line":"\t\tif (breakpoint-\u003enumber \u003d\u003d 1) {"},{"line_number":318,"context_line":"\t\t\tembeddedice_set_reg(\u0026arm7_9-\u003eeice_cache-\u003ereg_list[EICE_W0_CONTROL_VALUE], 0x0);"},{"line_number":319,"context_line":"\t\t\tarm7_9-\u003ewp0_used \u003d 0;"},{"line_number":320,"context_line":"\t\t\tarm7_9-\u003ewp_available++;"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"249ee5e0_61de655d","line":317,"range":{"start_line":317,"start_character":28,"end_line":317,"end_character":29},"updated":"2022-02-25 21:46:32.000000000","message":"0","commit_id":"8f8bceed0346ec4b823d1456f03debf681642013"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"92d8f6826e5f7020636552eef1243eb6563ca464","unresolved":false,"context_lines":[{"line_number":314,"context_line":"\t\tLOG_DEBUG(\"BPID: %\" PRIu32 \" Releasing hw wp: %d\","},{"line_number":315,"context_line":"\t\t\tbreakpoint-\u003eunique_id,"},{"line_number":316,"context_line":"\t\t\tbreakpoint-\u003eis_set);"},{"line_number":317,"context_line":"\t\tif (breakpoint-\u003enumber \u003d\u003d 1) {"},{"line_number":318,"context_line":"\t\t\tembeddedice_set_reg(\u0026arm7_9-\u003eeice_cache-\u003ereg_list[EICE_W0_CONTROL_VALUE], 0x0);"},{"line_number":319,"context_line":"\t\t\tarm7_9-\u003ewp0_used \u003d 0;"},{"line_number":320,"context_line":"\t\t\tarm7_9-\u003ewp_available++;"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"c8b2661e_60f67866","line":317,"range":{"start_line":317,"start_character":28,"end_line":317,"end_character":29},"in_reply_to":"249ee5e0_61de655d","updated":"2022-03-06 20:48:26.000000000","message":"Done","commit_id":"8f8bceed0346ec4b823d1456f03debf681642013"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"7ff1c5c87035c6c699ffb67624979e10521309f1","unresolved":true,"context_lines":[{"line_number":318,"context_line":"\t\t\tembeddedice_set_reg(\u0026arm7_9-\u003eeice_cache-\u003ereg_list[EICE_W0_CONTROL_VALUE], 0x0);"},{"line_number":319,"context_line":"\t\t\tarm7_9-\u003ewp0_used \u003d 0;"},{"line_number":320,"context_line":"\t\t\tarm7_9-\u003ewp_available++;"},{"line_number":321,"context_line":"\t\t} else if (breakpoint-\u003enumber \u003d\u003d 2) {"},{"line_number":322,"context_line":"\t\t\tembeddedice_set_reg(\u0026arm7_9-\u003eeice_cache-\u003ereg_list[EICE_W1_CONTROL_VALUE], 0x0);"},{"line_number":323,"context_line":"\t\t\tarm7_9-\u003ewp1_used \u003d 0;"},{"line_number":324,"context_line":"\t\t\tarm7_9-\u003ewp_available++;"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"de37bc12_a047af83","line":321,"range":{"start_line":321,"start_character":35,"end_line":321,"end_character":36},"updated":"2022-02-25 21:46:32.000000000","message":"1","commit_id":"8f8bceed0346ec4b823d1456f03debf681642013"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"92d8f6826e5f7020636552eef1243eb6563ca464","unresolved":false,"context_lines":[{"line_number":318,"context_line":"\t\t\tembeddedice_set_reg(\u0026arm7_9-\u003eeice_cache-\u003ereg_list[EICE_W0_CONTROL_VALUE], 0x0);"},{"line_number":319,"context_line":"\t\t\tarm7_9-\u003ewp0_used \u003d 0;"},{"line_number":320,"context_line":"\t\t\tarm7_9-\u003ewp_available++;"},{"line_number":321,"context_line":"\t\t} else if (breakpoint-\u003enumber \u003d\u003d 2) {"},{"line_number":322,"context_line":"\t\t\tembeddedice_set_reg(\u0026arm7_9-\u003eeice_cache-\u003ereg_list[EICE_W1_CONTROL_VALUE], 0x0);"},{"line_number":323,"context_line":"\t\t\tarm7_9-\u003ewp1_used \u003d 0;"},{"line_number":324,"context_line":"\t\t\tarm7_9-\u003ewp_available++;"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"567fc6b9_198dd6f8","line":321,"range":{"start_line":321,"start_character":35,"end_line":321,"end_character":36},"in_reply_to":"de37bc12_a047af83","updated":"2022-03-06 20:48:26.000000000","message":"Done","commit_id":"8f8bceed0346ec4b823d1456f03debf681642013"}],"src/target/cortex_m.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c59d848b7566ca1930768edfcc02008587c700bc","unresolved":false,"context_lines":[{"line_number":1341,"context_line":"\t\tbreakpoint-\u003eis_set \u003d true;"},{"line_number":1342,"context_line":"\t}"},{"line_number":1343,"context_line":""},{"line_number":1344,"context_line":"\tLOG_DEBUG(\"BPID: %\" PRIu32 \", Type: %d, Address: \" TARGET_ADDR_FMT \" Length: %d (set\u003d%u)\","},{"line_number":1345,"context_line":"\t\tbreakpoint-\u003eunique_id,"},{"line_number":1346,"context_line":"\t\t(int)(breakpoint-\u003etype),"},{"line_number":1347,"context_line":"\t\tbreakpoint-\u003eaddress,"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"aedf27f1_f1429bb1","line":1344,"range":{"start_line":1344,"start_character":82,"end_line":1344,"end_character":89},"updated":"2021-06-19 21:39:18.000000000","message":"Should change \"(set\u003d%u)\" with \"(n\u003d%u)\" ?\nIt\u0027s just a dbg message, but there is no reason to keep \"set\" here","commit_id":"6d1623e7bf5f087517595bbb88722a93eee1a082"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"3766d3e194259e845d54b0b12c2e244c831bf9c6","unresolved":false,"context_lines":[{"line_number":1341,"context_line":"\t\tbreakpoint-\u003eis_set \u003d true;"},{"line_number":1342,"context_line":"\t}"},{"line_number":1343,"context_line":""},{"line_number":1344,"context_line":"\tLOG_DEBUG(\"BPID: %\" PRIu32 \", Type: %d, Address: \" TARGET_ADDR_FMT \" Length: %d (set\u003d%u)\","},{"line_number":1345,"context_line":"\t\tbreakpoint-\u003eunique_id,"},{"line_number":1346,"context_line":"\t\t(int)(breakpoint-\u003etype),"},{"line_number":1347,"context_line":"\t\tbreakpoint-\u003eaddress,"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"4eceab4c_afb9152b","line":1344,"range":{"start_line":1344,"start_character":82,"end_line":1344,"end_character":89},"in_reply_to":"aedf27f1_f1429bb1","updated":"2021-07-15 08:21:14.000000000","message":"Done","commit_id":"6d1623e7bf5f087517595bbb88722a93eee1a082"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c59d848b7566ca1930768edfcc02008587c700bc","unresolved":false,"context_lines":[{"line_number":1362,"context_line":"\t\treturn ERROR_OK;"},{"line_number":1363,"context_line":"\t}"},{"line_number":1364,"context_line":""},{"line_number":1365,"context_line":"\tLOG_DEBUG(\"BPID: %\" PRIu32 \", Type: %d, Address: \" TARGET_ADDR_FMT \" Length: %d (set\u003d%u)\","},{"line_number":1366,"context_line":"\t\tbreakpoint-\u003eunique_id,"},{"line_number":1367,"context_line":"\t\t(int)(breakpoint-\u003etype),"},{"line_number":1368,"context_line":"\t\tbreakpoint-\u003eaddress,"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"aedf27f1_11407fa7","line":1365,"range":{"start_line":1365,"start_character":82,"end_line":1365,"end_character":85},"updated":"2021-06-19 21:39:18.000000000","message":"same here","commit_id":"6d1623e7bf5f087517595bbb88722a93eee1a082"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"3766d3e194259e845d54b0b12c2e244c831bf9c6","unresolved":false,"context_lines":[{"line_number":1362,"context_line":"\t\treturn ERROR_OK;"},{"line_number":1363,"context_line":"\t}"},{"line_number":1364,"context_line":""},{"line_number":1365,"context_line":"\tLOG_DEBUG(\"BPID: %\" PRIu32 \", Type: %d, Address: \" TARGET_ADDR_FMT \" Length: %d (set\u003d%u)\","},{"line_number":1366,"context_line":"\t\tbreakpoint-\u003eunique_id,"},{"line_number":1367,"context_line":"\t\t(int)(breakpoint-\u003etype),"},{"line_number":1368,"context_line":"\t\tbreakpoint-\u003eaddress,"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"4eceab4c_4f86716c","line":1365,"range":{"start_line":1365,"start_character":82,"end_line":1365,"end_character":85},"in_reply_to":"aedf27f1_11407fa7","updated":"2021-07-15 08:21:14.000000000","message":"Done","commit_id":"6d1623e7bf5f087517595bbb88722a93eee1a082"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"7ff1c5c87035c6c699ffb67624979e10521309f1","unresolved":true,"context_lines":[{"line_number":1651,"context_line":"\t\t(int)(breakpoint-\u003etype),"},{"line_number":1652,"context_line":"\t\tbreakpoint-\u003eaddress,"},{"line_number":1653,"context_line":"\t\tbreakpoint-\u003elength,"},{"line_number":1654,"context_line":"\t\tbreakpoint-\u003enumber);"},{"line_number":1655,"context_line":""},{"line_number":1656,"context_line":"\treturn ERROR_OK;"},{"line_number":1657,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"49f944cd_6ec59185","line":1654,"range":{"start_line":1654,"start_character":14,"end_line":1654,"end_character":20},"updated":"2022-02-25 21:46:32.000000000","message":"Uninitialised if type \u003d\u003d SOFT","commit_id":"8f8bceed0346ec4b823d1456f03debf681642013"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"92d8f6826e5f7020636552eef1243eb6563ca464","unresolved":false,"context_lines":[{"line_number":1651,"context_line":"\t\t(int)(breakpoint-\u003etype),"},{"line_number":1652,"context_line":"\t\tbreakpoint-\u003eaddress,"},{"line_number":1653,"context_line":"\t\tbreakpoint-\u003elength,"},{"line_number":1654,"context_line":"\t\tbreakpoint-\u003enumber);"},{"line_number":1655,"context_line":""},{"line_number":1656,"context_line":"\treturn ERROR_OK;"},{"line_number":1657,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"55070274_851230fd","line":1654,"range":{"start_line":1654,"start_character":14,"end_line":1654,"end_character":20},"in_reply_to":"49f944cd_6ec59185","updated":"2022-03-06 20:48:26.000000000","message":"Done","commit_id":"8f8bceed0346ec4b823d1456f03debf681642013"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"7ff1c5c87035c6c699ffb67624979e10521309f1","unresolved":true,"context_lines":[{"line_number":1672,"context_line":"\t\t(int)(breakpoint-\u003etype),"},{"line_number":1673,"context_line":"\t\tbreakpoint-\u003eaddress,"},{"line_number":1674,"context_line":"\t\tbreakpoint-\u003elength,"},{"line_number":1675,"context_line":"\t\tbreakpoint-\u003enumber);"},{"line_number":1676,"context_line":""},{"line_number":1677,"context_line":"\tif (breakpoint-\u003etype \u003d\u003d BKPT_HARD) {"},{"line_number":1678,"context_line":"\t\tunsigned int fp_num \u003d breakpoint-\u003enumber;"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"1afc6c78_ecee2ef8","line":1675,"range":{"start_line":1675,"start_character":14,"end_line":1675,"end_character":20},"updated":"2022-02-25 21:46:32.000000000","message":"Uninitialised if type \u003d\u003d SOFT","commit_id":"8f8bceed0346ec4b823d1456f03debf681642013"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"92d8f6826e5f7020636552eef1243eb6563ca464","unresolved":false,"context_lines":[{"line_number":1672,"context_line":"\t\t(int)(breakpoint-\u003etype),"},{"line_number":1673,"context_line":"\t\tbreakpoint-\u003eaddress,"},{"line_number":1674,"context_line":"\t\tbreakpoint-\u003elength,"},{"line_number":1675,"context_line":"\t\tbreakpoint-\u003enumber);"},{"line_number":1676,"context_line":""},{"line_number":1677,"context_line":"\tif (breakpoint-\u003etype \u003d\u003d BKPT_HARD) {"},{"line_number":1678,"context_line":"\t\tunsigned int fp_num \u003d breakpoint-\u003enumber;"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"58e04948_c7a593c1","line":1675,"range":{"start_line":1675,"start_character":14,"end_line":1675,"end_character":20},"in_reply_to":"1afc6c78_ecee2ef8","updated":"2022-03-06 20:48:26.000000000","message":"Done","commit_id":"8f8bceed0346ec4b823d1456f03debf681642013"}],"src/target/mips_mips64.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c59d848b7566ca1930768edfcc02008587c700bc","unresolved":false,"context_lines":[{"line_number":451,"context_line":"\t}"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"\tc \u003d \u0026cl[wp_num];"},{"line_number":454,"context_line":"\twatchpoint-\u003enumber \u003d wp_num;"},{"line_number":455,"context_line":"\tc-\u003eused \u003d true;"},{"line_number":456,"context_line":"\tc-\u003ebp_value \u003d watchpoint-\u003eaddress;"},{"line_number":457,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":4,"id":"aedf27f1_b14c13e6","line":454,"updated":"2021-06-19 21:39:18.000000000","message":"do we need also\nwatchpoint-\u003eis_set \u003d true;\n???","commit_id":"6d1623e7bf5f087517595bbb88722a93eee1a082"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"3766d3e194259e845d54b0b12c2e244c831bf9c6","unresolved":false,"context_lines":[{"line_number":451,"context_line":"\t}"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"\tc \u003d \u0026cl[wp_num];"},{"line_number":454,"context_line":"\twatchpoint-\u003enumber \u003d wp_num;"},{"line_number":455,"context_line":"\tc-\u003eused \u003d true;"},{"line_number":456,"context_line":"\tc-\u003ebp_value \u003d watchpoint-\u003eaddress;"},{"line_number":457,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":4,"id":"4eceab4c_6f8b2d73","line":454,"in_reply_to":"aedf27f1_b14c13e6","updated":"2021-07-15 08:21:14.000000000","message":"Done","commit_id":"6d1623e7bf5f087517595bbb88722a93eee1a082"}],"src/target/nds32.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"62da8cef2aa7c70e69d8d1a9a5bb99fd0783931b","unresolved":false,"context_lines":[{"line_number":1656,"context_line":""},{"line_number":1657,"context_line":"\tnds32-\u003esyscall_break.asid \u003d 0;"},{"line_number":1658,"context_line":"\tnds32-\u003esyscall_break.length \u003d 4;"},{"line_number":1659,"context_line":"\tnds32-\u003esyscall_break.set \u003d 0;"},{"line_number":1660,"context_line":"\tnds32-\u003esyscall_break.orig_instr \u003d NULL;"},{"line_number":1661,"context_line":"\tnds32-\u003esyscall_break.next \u003d NULL;"},{"line_number":1662,"context_line":"\tnds32-\u003esyscall_break.unique_id \u003d 0x515CAll + target-\u003etarget_number;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"aedf27f1_91a46f06","line":1659,"updated":"2021-06-14 21:42:44.000000000","message":"\u003d false;\nIf you rename it \"is_set\" or \"is_used\" you will not risk to miss any of them","commit_id":"e1e058b6d43939d331cd45dd841bbd131d53739c"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"7ff1c5c87035c6c699ffb67624979e10521309f1","unresolved":true,"context_lines":[{"line_number":1654,"context_line":"\tnds32-\u003esyscall_break.asid \u003d 0;"},{"line_number":1655,"context_line":"\tnds32-\u003esyscall_break.length \u003d 4;"},{"line_number":1656,"context_line":"\tnds32-\u003esyscall_break.is_set \u003d false;"},{"line_number":1657,"context_line":"\tnds32-\u003esyscall_break.number \u003d 0;"},{"line_number":1658,"context_line":"\tnds32-\u003esyscall_break.orig_instr \u003d NULL;"},{"line_number":1659,"context_line":"\tnds32-\u003esyscall_break.next \u003d NULL;"},{"line_number":1660,"context_line":"\tnds32-\u003esyscall_break.unique_id \u003d 0x515CAll + target-\u003etarget_number;"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"5534e0a8_fbec9a52","line":1657,"range":{"start_line":1657,"start_character":1,"end_line":1657,"end_character":33},"updated":"2022-02-25 21:46:32.000000000","message":"Isn\u0027t unused on all nds targets?","commit_id":"8f8bceed0346ec4b823d1456f03debf681642013"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"92d8f6826e5f7020636552eef1243eb6563ca464","unresolved":false,"context_lines":[{"line_number":1654,"context_line":"\tnds32-\u003esyscall_break.asid \u003d 0;"},{"line_number":1655,"context_line":"\tnds32-\u003esyscall_break.length \u003d 4;"},{"line_number":1656,"context_line":"\tnds32-\u003esyscall_break.is_set \u003d false;"},{"line_number":1657,"context_line":"\tnds32-\u003esyscall_break.number \u003d 0;"},{"line_number":1658,"context_line":"\tnds32-\u003esyscall_break.orig_instr \u003d NULL;"},{"line_number":1659,"context_line":"\tnds32-\u003esyscall_break.next \u003d NULL;"},{"line_number":1660,"context_line":"\tnds32-\u003esyscall_break.unique_id \u003d 0x515CAll + target-\u003etarget_number;"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"7454eb3e_3141dcee","line":1657,"range":{"start_line":1657,"start_character":1,"end_line":1657,"end_character":33},"in_reply_to":"5534e0a8_fbec9a52","updated":"2022-03-06 20:48:26.000000000","message":"Done","commit_id":"8f8bceed0346ec4b823d1456f03debf681642013"}],"src/target/nds32_v3_common.c":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"7ff1c5c87035c6c699ffb67624979e10521309f1","unresolved":true,"context_lines":[{"line_number":210,"context_line":"\t\tsyscall_break-\u003eaddress \u003d syscall_address;"},{"line_number":211,"context_line":"\t\tsyscall_break-\u003etype \u003d BKPT_SOFT;"},{"line_number":212,"context_line":"\t\tsyscall_break-\u003eis_set \u003d true;"},{"line_number":213,"context_line":"\t\tsyscall_break-\u003enumber \u003d 0;"},{"line_number":214,"context_line":"\t\ttarget_add_breakpoint(target, syscall_break);"},{"line_number":215,"context_line":"\t}"},{"line_number":216,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":7,"id":"2b0b3a96_71751925","line":213,"range":{"start_line":213,"start_character":2,"end_line":213,"end_character":28},"updated":"2022-02-25 21:46:32.000000000","message":"Isn\u0027t unused on all nds targets?","commit_id":"8f8bceed0346ec4b823d1456f03debf681642013"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"92d8f6826e5f7020636552eef1243eb6563ca464","unresolved":false,"context_lines":[{"line_number":210,"context_line":"\t\tsyscall_break-\u003eaddress \u003d syscall_address;"},{"line_number":211,"context_line":"\t\tsyscall_break-\u003etype \u003d BKPT_SOFT;"},{"line_number":212,"context_line":"\t\tsyscall_break-\u003eis_set \u003d true;"},{"line_number":213,"context_line":"\t\tsyscall_break-\u003enumber \u003d 0;"},{"line_number":214,"context_line":"\t\ttarget_add_breakpoint(target, syscall_break);"},{"line_number":215,"context_line":"\t}"},{"line_number":216,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":7,"id":"fc367c6a_14daf050","line":213,"range":{"start_line":213,"start_character":2,"end_line":213,"end_character":28},"in_reply_to":"2b0b3a96_71751925","updated":"2022-03-06 20:48:26.000000000","message":"Done","commit_id":"8f8bceed0346ec4b823d1456f03debf681642013"}],"src/target/openrisc/or1k.c":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"7ff1c5c87035c6c699ffb67624979e10521309f1","unresolved":true,"context_lines":[{"line_number":925,"context_line":""},{"line_number":926,"context_line":"\tLOG_DEBUG(\"Adding breakpoint: addr 0x%08\" TARGET_PRIxADDR \", len %d, type %d, number: %u, id: %\" PRIu32,"},{"line_number":927,"context_line":"\t\t  breakpoint-\u003eaddress, breakpoint-\u003elength, breakpoint-\u003etype,"},{"line_number":928,"context_line":"\t\t  breakpoint-\u003enumber, breakpoint-\u003eunique_id);"},{"line_number":929,"context_line":""},{"line_number":930,"context_line":"\t/* Only support SW breakpoints for now. */"},{"line_number":931,"context_line":"\tif (breakpoint-\u003etype \u003d\u003d BKPT_HARD)"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"c3b4ee64_557d27f0","line":928,"range":{"start_line":928,"start_character":4,"end_line":928,"end_character":22},"updated":"2022-02-25 21:46:32.000000000","message":"BKPT_HARD are not supported, is any point in putting unset number to log?","commit_id":"8f8bceed0346ec4b823d1456f03debf681642013"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"92d8f6826e5f7020636552eef1243eb6563ca464","unresolved":false,"context_lines":[{"line_number":925,"context_line":""},{"line_number":926,"context_line":"\tLOG_DEBUG(\"Adding breakpoint: addr 0x%08\" TARGET_PRIxADDR \", len %d, type %d, number: %u, id: %\" PRIu32,"},{"line_number":927,"context_line":"\t\t  breakpoint-\u003eaddress, breakpoint-\u003elength, breakpoint-\u003etype,"},{"line_number":928,"context_line":"\t\t  breakpoint-\u003enumber, breakpoint-\u003eunique_id);"},{"line_number":929,"context_line":""},{"line_number":930,"context_line":"\t/* Only support SW breakpoints for now. */"},{"line_number":931,"context_line":"\tif (breakpoint-\u003etype \u003d\u003d BKPT_HARD)"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"3ba04ddc_46963992","line":928,"range":{"start_line":928,"start_character":4,"end_line":928,"end_character":22},"in_reply_to":"c3b4ee64_557d27f0","updated":"2022-03-06 20:48:26.000000000","message":"Done","commit_id":"8f8bceed0346ec4b823d1456f03debf681642013"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"7ff1c5c87035c6c699ffb67624979e10521309f1","unresolved":true,"context_lines":[{"line_number":983,"context_line":""},{"line_number":984,"context_line":"\tLOG_DEBUG(\"Removing breakpoint: addr 0x%08\" TARGET_PRIxADDR \", len %d, type %d, number: %u, id: %\" PRIu32,"},{"line_number":985,"context_line":"\t\t  breakpoint-\u003eaddress, breakpoint-\u003elength, breakpoint-\u003etype,"},{"line_number":986,"context_line":"\t\t  breakpoint-\u003enumber, breakpoint-\u003eunique_id);"},{"line_number":987,"context_line":""},{"line_number":988,"context_line":"\t/* Only support SW breakpoints for now. */"},{"line_number":989,"context_line":"\tif (breakpoint-\u003etype \u003d\u003d BKPT_HARD)"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"474aa720_a12dadc4","line":986,"range":{"start_line":986,"start_character":4,"end_line":986,"end_character":22},"updated":"2022-02-25 21:46:32.000000000","message":"Same as above","commit_id":"8f8bceed0346ec4b823d1456f03debf681642013"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"92d8f6826e5f7020636552eef1243eb6563ca464","unresolved":false,"context_lines":[{"line_number":983,"context_line":""},{"line_number":984,"context_line":"\tLOG_DEBUG(\"Removing breakpoint: addr 0x%08\" TARGET_PRIxADDR \", len %d, type %d, number: %u, id: %\" PRIu32,"},{"line_number":985,"context_line":"\t\t  breakpoint-\u003eaddress, breakpoint-\u003elength, breakpoint-\u003etype,"},{"line_number":986,"context_line":"\t\t  breakpoint-\u003enumber, breakpoint-\u003eunique_id);"},{"line_number":987,"context_line":""},{"line_number":988,"context_line":"\t/* Only support SW breakpoints for now. */"},{"line_number":989,"context_line":"\tif (breakpoint-\u003etype \u003d\u003d BKPT_HARD)"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"e4726af7_d09e32d8","line":986,"range":{"start_line":986,"start_character":4,"end_line":986,"end_character":22},"in_reply_to":"474aa720_a12dadc4","updated":"2022-03-06 20:48:26.000000000","message":"Done","commit_id":"8f8bceed0346ec4b823d1456f03debf681642013"}],"src/target/riscv/riscv.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c59d848b7566ca1930768edfcc02008587c700bc","unresolved":false,"context_lines":[{"line_number":1197,"context_line":"\t\tstruct watchpoint *watchpoint \u003d target-\u003ewatchpoints;"},{"line_number":1198,"context_line":"\t\tint i \u003d 0;"},{"line_number":1199,"context_line":"\t\twhile (watchpoint) {"},{"line_number":1200,"context_line":"\t\t\tLOG_DEBUG(\"watchpoint %d: set\u003d%d\", i, watchpoint-\u003eis_set);"},{"line_number":1201,"context_line":"\t\t\tstate[i] \u003d watchpoint-\u003eis_set;"},{"line_number":1202,"context_line":"\t\t\tif (watchpoint-\u003eis_set) {"},{"line_number":1203,"context_line":"\t\t\t\tif (riscv_remove_watchpoint(target, watchpoint) !\u003d ERROR_OK)"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"aedf27f1_911b0fd4","line":1200,"updated":"2021-06-19 21:39:18.000000000","message":"use %d for a bool is not detected as an error.\nShould we left it like this?","commit_id":"6d1623e7bf5f087517595bbb88722a93eee1a082"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"3766d3e194259e845d54b0b12c2e244c831bf9c6","unresolved":false,"context_lines":[{"line_number":1197,"context_line":"\t\tstruct watchpoint *watchpoint \u003d target-\u003ewatchpoints;"},{"line_number":1198,"context_line":"\t\tint i \u003d 0;"},{"line_number":1199,"context_line":"\t\twhile (watchpoint) {"},{"line_number":1200,"context_line":"\t\t\tLOG_DEBUG(\"watchpoint %d: set\u003d%d\", i, watchpoint-\u003eis_set);"},{"line_number":1201,"context_line":"\t\t\tstate[i] \u003d watchpoint-\u003eis_set;"},{"line_number":1202,"context_line":"\t\t\tif (watchpoint-\u003eis_set) {"},{"line_number":1203,"context_line":"\t\t\t\tif (riscv_remove_watchpoint(target, watchpoint) !\u003d ERROR_OK)"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"4eceab4c_0f80694a","line":1200,"in_reply_to":"aedf27f1_911b0fd4","updated":"2021-07-15 08:21:14.000000000","message":"I think %d is fine for a bool","commit_id":"6d1623e7bf5f087517595bbb88722a93eee1a082"}],"src/target/target.c":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"7ff1c5c87035c6c699ffb67624979e10521309f1","unresolved":true,"context_lines":[{"line_number":3957,"context_line":"\t\t\tcommand_print(cmd, \"IVA breakpoint: \" TARGET_ADDR_FMT \", 0x%x, %u, 0x%s\","},{"line_number":3958,"context_line":"\t\t\t\t\tbreakpoint-\u003eaddress,"},{"line_number":3959,"context_line":"\t\t\t\t\tbreakpoint-\u003elength,"},{"line_number":3960,"context_line":"\t\t\t\t\tbreakpoint-\u003enumber, buf);"},{"line_number":3961,"context_line":"\t\t\tfree(buf);"},{"line_number":3962,"context_line":"\t\t} else {"},{"line_number":3963,"context_line":"\t\t\tif ((breakpoint-\u003eaddress \u003d\u003d 0) \u0026\u0026 (breakpoint-\u003easid !\u003d 0))"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"8d8d24e1_91e7a6b6","line":3960,"range":{"start_line":3960,"start_character":5,"end_line":3960,"end_character":23},"updated":"2022-02-25 21:46:32.000000000","message":"Unset for BKPT_SOFT","commit_id":"8f8bceed0346ec4b823d1456f03debf681642013"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"92d8f6826e5f7020636552eef1243eb6563ca464","unresolved":false,"context_lines":[{"line_number":3957,"context_line":"\t\t\tcommand_print(cmd, \"IVA breakpoint: \" TARGET_ADDR_FMT \", 0x%x, %u, 0x%s\","},{"line_number":3958,"context_line":"\t\t\t\t\tbreakpoint-\u003eaddress,"},{"line_number":3959,"context_line":"\t\t\t\t\tbreakpoint-\u003elength,"},{"line_number":3960,"context_line":"\t\t\t\t\tbreakpoint-\u003enumber, buf);"},{"line_number":3961,"context_line":"\t\t\tfree(buf);"},{"line_number":3962,"context_line":"\t\t} else {"},{"line_number":3963,"context_line":"\t\t\tif ((breakpoint-\u003eaddress \u003d\u003d 0) \u0026\u0026 (breakpoint-\u003easid !\u003d 0))"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"a39269e4_7e4db79c","line":3960,"range":{"start_line":3960,"start_character":5,"end_line":3960,"end_character":23},"in_reply_to":"8d8d24e1_91e7a6b6","updated":"2022-03-06 20:48:26.000000000","message":"Done","commit_id":"8f8bceed0346ec4b823d1456f03debf681642013"}],"src/target/x86_32_common.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c59d848b7566ca1930768edfcc02008587c700bc","unresolved":false,"context_lines":[{"line_number":1234,"context_line":"\t\t\tLOG_ERROR(\"%s only \u0027access\u0027 or \u0027write\u0027 watchpoints are supported\", __func__);"},{"line_number":1235,"context_line":"\t\t\tbreak;"},{"line_number":1236,"context_line":"\t}"},{"line_number":1237,"context_line":"\twp-\u003enumber \u003d wp_num;"},{"line_number":1238,"context_line":"\tdebug_reg_list[wp_num].used \u003d 1;"},{"line_number":1239,"context_line":"\tdebug_reg_list[wp_num].bp_value \u003d wp-\u003eaddress;"},{"line_number":1240,"context_line":"\tLOG_USER(\"\u0027%s\u0027 watchpoint %d set at \" TARGET_ADDR_FMT \" with length %\" PRIu32 \" (hwreg\u003d%d)\","}],"source_content_type":"text/x-csrc","patch_set":4,"id":"aedf27f1_311023ad","line":1237,"updated":"2021-06-19 21:39:18.000000000","message":"I think you need to add\nwp-\u003eis_set \u003d true;","commit_id":"6d1623e7bf5f087517595bbb88722a93eee1a082"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"3766d3e194259e845d54b0b12c2e244c831bf9c6","unresolved":false,"context_lines":[{"line_number":1234,"context_line":"\t\t\tLOG_ERROR(\"%s only \u0027access\u0027 or \u0027write\u0027 watchpoints are supported\", __func__);"},{"line_number":1235,"context_line":"\t\t\tbreak;"},{"line_number":1236,"context_line":"\t}"},{"line_number":1237,"context_line":"\twp-\u003enumber \u003d wp_num;"},{"line_number":1238,"context_line":"\tdebug_reg_list[wp_num].used \u003d 1;"},{"line_number":1239,"context_line":"\tdebug_reg_list[wp_num].bp_value \u003d wp-\u003eaddress;"},{"line_number":1240,"context_line":"\tLOG_USER(\"\u0027%s\u0027 watchpoint %d set at \" TARGET_ADDR_FMT \" with length %\" PRIu32 \" (hwreg\u003d%d)\","}],"source_content_type":"text/x-csrc","patch_set":4,"id":"4eceab4c_2f85255b","line":1237,"in_reply_to":"aedf27f1_311023ad","updated":"2021-07-15 08:21:14.000000000","message":"Done","commit_id":"6d1623e7bf5f087517595bbb88722a93eee1a082"}],"src/target/xscale.c":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"7ff1c5c87035c6c699ffb67624979e10521309f1","unresolved":true,"context_lines":[{"line_number":2099,"context_line":"\t\t\txscale_set_reg_u32(\u0026xscale-\u003ereg_cache-\u003ereg_list[XSCALE_IBCR0], value);"},{"line_number":2100,"context_line":"\t\t\txscale-\u003eibcr0_used \u003d 1;"},{"line_number":2101,"context_line":"\t\t\t/* breakpoint set on first breakpoint register */"},{"line_number":2102,"context_line":"\t\t\tbreakpoint_hw_set(breakpoint, 1);"},{"line_number":2103,"context_line":"\t\t} else if (!xscale-\u003eibcr1_used) {"},{"line_number":2104,"context_line":"\t\t\txscale_set_reg_u32(\u0026xscale-\u003ereg_cache-\u003ereg_list[XSCALE_IBCR1], value);"},{"line_number":2105,"context_line":"\t\t\txscale-\u003eibcr1_used \u003d 1;"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"fab4a50e_7b08384a","line":2102,"range":{"start_line":2102,"start_character":33,"end_line":2102,"end_character":34},"updated":"2022-02-25 21:46:32.000000000","message":"Also may better follow IBCR num","commit_id":"8f8bceed0346ec4b823d1456f03debf681642013"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"92d8f6826e5f7020636552eef1243eb6563ca464","unresolved":false,"context_lines":[{"line_number":2099,"context_line":"\t\t\txscale_set_reg_u32(\u0026xscale-\u003ereg_cache-\u003ereg_list[XSCALE_IBCR0], value);"},{"line_number":2100,"context_line":"\t\t\txscale-\u003eibcr0_used \u003d 1;"},{"line_number":2101,"context_line":"\t\t\t/* breakpoint set on first breakpoint register */"},{"line_number":2102,"context_line":"\t\t\tbreakpoint_hw_set(breakpoint, 1);"},{"line_number":2103,"context_line":"\t\t} else if (!xscale-\u003eibcr1_used) {"},{"line_number":2104,"context_line":"\t\t\txscale_set_reg_u32(\u0026xscale-\u003ereg_cache-\u003ereg_list[XSCALE_IBCR1], value);"},{"line_number":2105,"context_line":"\t\t\txscale-\u003eibcr1_used \u003d 1;"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"4d710607_26fec340","line":2102,"range":{"start_line":2102,"start_character":33,"end_line":2102,"end_character":34},"in_reply_to":"fab4a50e_7b08384a","updated":"2022-03-06 20:48:26.000000000","message":"Done","commit_id":"8f8bceed0346ec4b823d1456f03debf681642013"}]}