)]}'
{"id":"openocd~master~I2193f5639247cce6b80580d4c1c6afee916aeb82","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2022-03-19 09:14:39.000000000","reason":"Change was submitted"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2022-03-19 09:14:39.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I2193f5639247cce6b80580d4c1c6afee916aeb82","subject":"target: Rework \u0027set\u0027 variable of break-/watchpoints","status":"MERGED","created":"2021-06-14 13:09:26.000000000","updated":"2022-03-19 09:14:39.000000000","submitted":"2022-03-19 09:14:39.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":55,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6319","meta_rev_id":"619afd8f89ced53035330b3065c195a7c08338fa","_number":6319,"owner":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"value":0,"_account_id":1001851,"name":"Yasushi SHOJI","email":"yasushi.shoji@gmail.com","username":"yashi"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-03-19 09:14:39.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-03-19 09:14:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"value":0,"_account_id":1001851,"name":"Yasushi SHOJI","email":"yasushi.shoji@gmail.com","username":"yashi"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"_account_id":1001851,"name":"Yasushi SHOJI","email":"yasushi.shoji@gmail.com","username":"yashi"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-06-15 03:19:07.000000000","updated_by":{"_account_id":1001851,"name":"Yasushi SHOJI","email":"yasushi.shoji@gmail.com","username":"yashi"},"reviewer":{"_account_id":1001851,"name":"Yasushi SHOJI","email":"yasushi.shoji@gmail.com","username":"yashi"},"state":"REVIEWER"},{"updated":"2021-06-19 21:39:18.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2021-07-15 08:51:17.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-11-15 22:05:54.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"0741da7d88bc4e4229f93cea954e816119fafa60","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2021-06-14 13:09:26.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"375a11ba3bcf4e2c816c03f079fb4edb489168a3","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-06-14 13:44:34.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14752/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/13998/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"adb94c30611ab92a4a4b2e01b09a48b00de41064","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2021-06-14 19:57:08.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"76b9b9ee1536b0ee3605b1caa85853a01ad6ccc1","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2021-06-14 19:58:01.000000000","message":"Uploaded patch set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"fc050713b549c8af53434341c3000a3ddbf33725","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-06-14 19:58:02.000000000","message":"Patch Set 2: Verified-1\n\nBuild Failed \n\nhttp://build.openocd.org/job/openocd-gerrit/14757/ : ABORTED\n\nhttp://build.openocd.org/job/openocd-gerrit-build/14003/ : ABORTED","accounts_in_message":[],"_revision_number":2},{"id":"3fd8cd73d544474809bc99ab49e29b2bafdad605","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-06-14 20:28:05.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14758/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/14004/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"62da8cef2aa7c70e69d8d1a9a5bb99fd0783931b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-06-14 21:42:44.000000000","message":"Patch Set 3:\n\n(5 comments)\n\njust some initial check.\nBy renaming \"set\" to \"is_set\" or \"is_used\" will make the patch review self-consistent. I mean, every use of \"set\" will be visible in the patch; no need to look for the use cases, no risk to miss one.","accounts_in_message":[],"_revision_number":3},{"id":"06e5da2b109b6638b850c21a9c521f9a9d9063d4","author":{"_account_id":1001851,"name":"Yasushi SHOJI","email":"yasushi.shoji@gmail.com","username":"yashi"},"real_author":{"_account_id":1001851,"name":"Yasushi SHOJI","email":"yasushi.shoji@gmail.com","username":"yashi"},"date":"2021-06-15 03:19:07.000000000","message":"Patch Set 3:\n\nHi, I\u0027m not an expert on OpenOCD per set but this change smells.  My comment is from my experience working on C code but not from OpenOCD so please bear with me.\n\nYour change makes programmers take care of two variables when you change a breakpoint.  This is troublesome, IMHO.  Someone will forget about either variable and we get bug reports.\n\nYou pointed out three issues associated with the variable `set`.\n\n1) name suggests the boolean type\n2) multiple meaning associated with it\n3) index mismatch\n\nLet\u0027s start with 2.\n\nWe have the exact kind of value in the UNIX C world for a few decades, API return value; 0 or positive means good, bad if negative.   For `set`, because 0 means false as in boolean, you can\u0027t use 0 as the actual value.  What if you make negative values mean false or bad.  And positives, including 0, to hold comparator value?  Just like `open(2)` returns a file descriptor.\n\nThis solves (3) index mismatch you pointed out as well.  The check now becomes:\n\nif (breakpoint-\u003eset \u003c 0)\n\ninstead of\n\nif (breakpoint-\u003eset)\n\nA downside of this is that if you need multiple offset values, this scheme doesn\u0027t work well.  But it seems like you only have 0-index comparators (just glance at your diff, so I might be wrong).\n\nNow, the last one, the name.  But that\u0027s an easy one to fix.\n\nMy two cents.","accounts_in_message":[],"_revision_number":3},{"id":"4f661cde1b2bdd5d50eaaabf8e21c6c348d124e6","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2021-06-15 16:09:28.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"a5f8bc2ea9cc6092547ce75026e89b99d47a6f9d","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-06-15 16:43:10.000000000","message":"Patch Set 4: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14762/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/14008/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"c59d848b7566ca1930768edfcc02008587c700bc","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-06-19 21:39:18.000000000","message":"Patch Set 4: Code-Review-1\n\n(6 comments)\n\nstill something to fix\n\nI agree with Yasushi Shoji that it is possible to use a single variable, but to keep the code clean across different architecture I prefer the split.\nI was even considering to change the name \"-\u003enumber\" with \"-\u003ehw_index\" or \"-\u003ehw_number\" to make it even more clear that it is required for HW breakpoint/watchpoint only. Maybe not really needed.\nPlus, we should add some doxygen comment for the fields of struct breakpoint and struct watchpoint. Maybe in a following patch.\n\nI would like to merge http://openocd.zylin.com/5576/ before this patch. The two are in conflict, but minor issues.\nWould it be fine for you to rebase this after the merge of 5576?","accounts_in_message":[],"_revision_number":4},{"id":"f61a8ccc9af36ba73467ebe93fec0991b7977f67","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2021-07-15 08:18:35.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"3103a23b56e230608ed87cfaeeebf62df8c26996","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2021-07-15 08:18:55.000000000","message":"Patch Set 5:\n\nIndeed, this can be encoded in a single variable but, as Antonio already pointed out, the name is misleading and the \u0027number\u0027 is only associated to hardware breakpoints.\n\n\u003e Your change makes programmers take care of two variables when you change a breakpoint.  This is troublesome, IMHO.  Someone will forget about either variable and we get bug reports.\n\nFor that reason we need clear variable names and types. I took my a while to get that the \u0027number\u0027 is only used for hardware breakpoints.\n\n\u003e I was even considering to change the name \"-\u003enumber\" with \"-\u003ehw_index\" or \"-\u003ehw_number\" to make it even more clear that it is required for HW breakpoint/watchpoint only. Maybe not really needed.\n\nMakes sense, but this can easily be done in different patch.\n\n\u003eI would like to merge http://openocd.zylin.com/5576/ before this patch. The two are in conflict, but minor issues.\n\u003e Would it be fine for you to rebase this after the merge of 5576?\n\nSure, already done.","accounts_in_message":[],"_revision_number":5},{"id":"3766d3e194259e845d54b0b12c2e244c831bf9c6","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2021-07-15 08:21:14.000000000","message":"Patch Set 4:\n\n(6 comments)","accounts_in_message":[],"_revision_number":4},{"id":"9f5c7637779bbba4ba419b5b9472e946efa17dc9","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-07-15 08:51:17.000000000","message":"Patch Set 5: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14851/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/14097/ : SUCCESS","accounts_in_message":[],"_revision_number":5},{"id":"364ee203894dc25890fe4ae70ccbd4d6731043db","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2021-09-22 09:38:28.000000000","message":"Patch Set 5: Code-Review+1","accounts_in_message":[],"_revision_number":5},{"id":"7735138ede9fe709fb81590ad22a12d5253bce00","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-15 22:05:54.000000000","message":"Patch Set 5: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":5},{"id":"c41fb0e487e7ea89ecfdbfb12b97fbeb3de713be","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-15 22:35:58.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"abbe22580d53430f34b6e94be7f6244422bc7e13","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2022-02-05 21:32:33.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"b6cc6daef5dd2c08c40728ed5c12fe660943e58c","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-02-05 21:33:52.000000000","message":"Patch Set 6: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/15846/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15058/ : FAILURE","accounts_in_message":[],"_revision_number":6},{"id":"88652d6717ca06662bc4dfa56bd76fd363e44772","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2022-02-05 22:39:20.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"f3c0b331df05d3a92d9cbcfba1a5b3d31903a0a9","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-02-06 00:18:21.000000000","message":"Patch Set 7: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15847/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15059/ : SUCCESS","accounts_in_message":[],"_revision_number":7},{"id":"a8ba8ef64b88e3d3ed36f56565507e888fca0250","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2022-02-12 10:45:55.000000000","message":"Patch Set 7: Code-Review+1\n\n(2 comments)","accounts_in_message":[],"_revision_number":7},{"id":"7ff1c5c87035c6c699ffb67624979e10521309f1","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-02-25 21:46:32.000000000","message":"Patch Set 7: Code-Review-1\n\n(16 comments)","accounts_in_message":[],"_revision_number":7},{"id":"6dbf5735c66749c0e7bd39331848be6f9af083b0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2022-03-06 20:41:37.000000000","message":"Uploaded patch set 8.","accounts_in_message":[],"_revision_number":8},{"id":"92d8f6826e5f7020636552eef1243eb6563ca464","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2022-03-06 20:48:26.000000000","message":"Patch Set 8:\n\n(15 comments)","accounts_in_message":[],"_revision_number":8},{"id":"9bb2115129a5eddf2e5650204217341b9188b916","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-03-06 21:08:22.000000000","message":"Patch Set 8: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15958/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15168/ : SUCCESS","accounts_in_message":[],"_revision_number":8},{"id":"b190d0174a845e1e586e6d916c50006743eae23b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-08 16:49:19.000000000","message":"Patch Set 8: Code-Review+1","accounts_in_message":[],"_revision_number":8},{"id":"db08f3dedbbe2af33efea1e5dd045f44f5c4c30a","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-12 09:55:07.000000000","message":"Patch Set 8:\n\n(1 comment)","accounts_in_message":[],"_revision_number":8},{"id":"9e98b6c45fe6c40a66b7e89c74fe69de6f65e727","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2022-03-12 14:50:41.000000000","message":"Uploaded patch set 9.","accounts_in_message":[],"_revision_number":9},{"id":"a3f3f5691d07862f743f0e21716e2ca81391d8da","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-03-12 15:10:36.000000000","message":"Patch Set 9: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15968/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15178/ : SUCCESS","accounts_in_message":[],"_revision_number":9},{"id":"e7b37137c96539f6e484a8111dc724b3712a6bd4","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-12 16:42:59.000000000","message":"Patch Set 9: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":9},{"id":"4154ad7c10e1e04fa5efb1ab845b9fc0e08a981b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-19 09:14:32.000000000","message":"Patch Set 9: Code-Review+2","accounts_in_message":[],"_revision_number":9},{"id":"619afd8f89ced53035330b3065c195a7c08338fa","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-19 09:14:39.000000000","message":"Change has been successfully cherry-picked as fb43f1ff4e2f0638110ffcc4e63bee8b5361db64","accounts_in_message":[],"_revision_number":10}],"current_revision":"fb43f1ff4e2f0638110ffcc4e63bee8b5361db64","revisions":{"5ebe803eec1204731515f1691e4b6517fab4d187":{"kind":"REWORK","_number":9,"created":"2022-03-12 14:50:41.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/19/6319/9","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/19/6319/9","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/9 \u0026\u0026 git checkout -b change-6319 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/19/6319/9","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/9 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"be0d68eb66b513ef406ffa83102f89a8f4602914","subject":"Remove all occurrences of \u0027mem2array\u0027 and \u0027array2mem\u0027"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2021-06-13 09:21:18.000000000","tz":120},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2022-03-12 14:49:40.000000000","tz":60},"subject":"target: Rework \u0027set\u0027 variable of break-/watchpoints","message":"target: Rework \u0027set\u0027 variable of break-/watchpoints\n\nThe \u0027set\u0027 variable name suggests a boolean data type which determines\nwhether a breakpoint (or watchpoint) is active. However, it is also\nused to store the number of the breakpoint.\n\nThis encoding leads to inconsistent value assignments: boolean and\ninteger values are mixed. Also, associated hardware comparator\nnumbers, which are usually numbered from 0, cannot be used directly.\nAn additional offset is required to store the comparator numbers.\n\nIn order to make the code more readable and the value assignment more\nconsistent, change the variable name to \u0027is_set\u0027, its data type to \u0027bool\u0027\nand introduce a dedicated variable for the break-/watchpoint\nnumber.\n\nIn order to make the review easier, the data types of various related\nvariables (e.g. number of breakpoints) are not changed.\n\nWhile at it, fix a few coding style issues.\n\nChange-Id: I2193f5639247cce6b80580d4c1c6afee916aeb82\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}},"7e8e9b630b3eb9bf6dcb9e74078274424658b053":{"kind":"REWORK","_number":8,"created":"2022-03-06 20:41:37.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/19/6319/8","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/19/6319/8","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/8 \u0026\u0026 git checkout -b change-6319 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/19/6319/8","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/8 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2586fec922ae9ea9bea345f40598e0367934d22c","subject":"target/arm_tpiu: Fix usage of \u0027tpiu create\u0027"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2021-06-13 09:21:18.000000000","tz":120},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2022-03-06 20:40:28.000000000","tz":60},"subject":"target: Rework \u0027set\u0027 variable of break-/watchpoints","message":"target: Rework \u0027set\u0027 variable of break-/watchpoints\n\nThe \u0027set\u0027 variable name suggests a boolean data type which determines\nwhether a breakpoint (or watchpoint) is active. However, it is also\nused to store the number of the breakpoint.\n\nThis encoding leads to inconsistent value assignments: boolean and\ninteger values are mixed. Also, associated hardware comparator\nnumbers, which are usually numbered from 0, cannot be used directly.\nAn additional offset is required to store the comparator numbers.\n\nIn order to make the code more readable and the value assignment more\nconsistent, change the variable name to \u0027is_set\u0027, its data type to \u0027bool\u0027\nand introduce a dedicated variable for the break-/watchpoint\nnumber.\n\nIn order to make the review easier, the data types of various related\nvariables (e.g. number of breakpoints) are not changed.\n\nWhile at it, fix a few coding style issues.\n\nChange-Id: I2193f5639247cce6b80580d4c1c6afee916aeb82\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}},"fb43f1ff4e2f0638110ffcc4e63bee8b5361db64":{"kind":"REWORK","_number":10,"created":"2022-03-19 09:14:39.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/19/6319/10","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/19/6319/10","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/10 \u0026\u0026 git checkout -b change-6319 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/10 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/10 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/10 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/19/6319/10","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/10 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ab43721be6ff7470ff8b9771c95c1d5661a5a689","subject":"flash/stm32l4x: fix auto-probe when RDP is promoted from 0 to 0.5"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2021-06-13 09:21:18.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-03-19 09:14:39.000000000","tz":0},"subject":"target: Rework \u0027set\u0027 variable of break-/watchpoints","message":"target: Rework \u0027set\u0027 variable of break-/watchpoints\n\nThe \u0027set\u0027 variable name suggests a boolean data type which determines\nwhether a breakpoint (or watchpoint) is active. However, it is also\nused to store the number of the breakpoint.\n\nThis encoding leads to inconsistent value assignments: boolean and\ninteger values are mixed. Also, associated hardware comparator\nnumbers, which are usually numbered from 0, cannot be used directly.\nAn additional offset is required to store the comparator numbers.\n\nIn order to make the code more readable and the value assignment more\nconsistent, change the variable name to \u0027is_set\u0027, its data type to \u0027bool\u0027\nand introduce a dedicated variable for the break-/watchpoint\nnumber.\n\nIn order to make the review easier, the data types of various related\nvariables (e.g. number of breakpoints) are not changed.\n\nWhile at it, fix a few coding style issues.\n\nChange-Id: I2193f5639247cce6b80580d4c1c6afee916aeb82\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6319\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"b5f80d8b795489dfa2dc71d3768feee1d38f3cf2":{"kind":"REWORK","_number":1,"created":"2021-06-14 13:09:26.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/19/6319/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/19/6319/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/1 \u0026\u0026 git checkout -b change-6319 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/19/6319/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b7506291f923f13fdf8e93007bac6898d2d824b0","subject":"target: Rename \u0027linked_BRP\u0027 to \u0027linked_brp\u0027"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2021-06-13 09:21:18.000000000","tz":120},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2021-06-14 13:04:14.000000000","tz":120},"subject":"target: Rework \u0027set\u0027 variable of break-/watchpoints","message":"target: Rework \u0027set\u0027 variable of break-/watchpoints\n\nThe \u0027set\u0027 variable name suggests a boolean data type which determines whether a\nbreakpoint (or watchpoint) is active. However, it is also used to store the\nnumber of the breakpoint.\n\nThis encoding leads to inconsistent value assignments: boolean and integer\nvalues are mixed. Also, associated hardware comparator numbers, which are\nusually numbered from 0, cannot be used directly. An additional offset is\nrequired to store the comparator numbers.\n\nIn order to make the code more readable and the value assignment more\nconsistent, change the data type of \u0027set\u0027 to \u0027bool\u0027 and introduce a dedicated\nvariable for the break-/watchpoint number.\n\nIn order to make the review easier, the data types of various related\nvariables (e.g. number of breakpoints) are not changed.\n\nWhile at it, fix a few coding style issues.\n\nChange-Id: I2193f5639247cce6b80580d4c1c6afee916aeb82\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}},"e1e058b6d43939d331cd45dd841bbd131d53739c":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2021-06-14 19:58:01.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/19/6319/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/19/6319/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/3 \u0026\u0026 git checkout -b change-6319 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/19/6319/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b7506291f923f13fdf8e93007bac6898d2d824b0","subject":"target: Rename \u0027linked_BRP\u0027 to \u0027linked_brp\u0027"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2021-06-13 09:21:18.000000000","tz":120},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2021-06-14 19:57:22.000000000","tz":120},"subject":"target: Rework \u0027set\u0027 variable of break-/watchpoints","message":"target: Rework \u0027set\u0027 variable of break-/watchpoints\n\nThe \u0027set\u0027 variable name suggests a boolean data type which determines\nwhether a breakpoint (or watchpoint) is active. However, it is also\nused to store the number of the breakpoint.\n\nThis encoding leads to inconsistent value assignments: boolean and\ninteger values are mixed. Also, associated hardware comparator\nnumbers, which are usually numbered from 0, cannot be used directly.\nAn additional offset is required to store the comparator numbers.\n\nIn order to make the code more readable and the value assignment more\nconsistent, change the data type of \u0027set\u0027 to \u0027bool\u0027 and introduce a\ndedicated variable for the break-/watchpoint number.\n\nIn order to make the review easier, the data types of various related\nvariables (e.g. number of breakpoints) are not changed.\n\nWhile at it, fix a few coding style issues.\n\nChange-Id: I2193f5639247cce6b80580d4c1c6afee916aeb82\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}},"0dd05ede8e56b734a9db1033fd644650f9686ff7":{"kind":"REWORK","_number":2,"created":"2021-06-14 19:57:08.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/19/6319/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/19/6319/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/2 \u0026\u0026 git checkout -b change-6319 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/19/6319/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b7506291f923f13fdf8e93007bac6898d2d824b0","subject":"target: Rename \u0027linked_BRP\u0027 to \u0027linked_brp\u0027"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2021-06-13 09:21:18.000000000","tz":120},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2021-06-14 19:57:00.000000000","tz":120},"subject":"target: Rework \u0027set\u0027 variable of break-/watchpoints","message":"target: Rework \u0027set\u0027 variable of break-/watchpoints\n\nThe \u0027set\u0027 variable name suggests a boolean data type which determines whether a\nbreakpoint (or watchpoint) is active. However, it is also used to store the\nnumber of the breakpoint.\n\nThis encoding leads to inconsistent value assignments: boolean and integer\nvalues are mixed. Also, associated hardware comparator numbers, which are\nusually numbered from 0, cannot be used directly. An additional offset is\nrequired to store the comparator numbers.\n\nIn order to make the code more readable and the value assignment more\nconsistent, change the data type of \u0027set\u0027 to \u0027bool\u0027 and introduce a dedicated\nvariable for the break-/watchpoint number.\n\nIn order to make the review easier, the data types of various related\nvariables (e.g. number of breakpoints) are not changed.\n\nWhile at it, fix a few coding style issues.\n\nChange-Id: I2193f5639247cce6b80580d4c1c6afee916aeb82\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}},"622c009d3b1d76debe940a71149ce2fad0711ce2":{"kind":"REWORK","_number":5,"created":"2021-07-15 08:18:35.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/19/6319/5","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/19/6319/5","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/5 \u0026\u0026 git checkout -b change-6319 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/19/6319/5","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"65c9653cc768f77a5e8cf2af73e0f40d614bdec2","subject":"target: add support for 64bit data in mem2array and array2mem"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2021-06-13 09:21:18.000000000","tz":120},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2021-07-15 08:03:36.000000000","tz":120},"subject":"target: Rework \u0027set\u0027 variable of break-/watchpoints","message":"target: Rework \u0027set\u0027 variable of break-/watchpoints\n\nThe \u0027set\u0027 variable name suggests a boolean data type which determines\nwhether a breakpoint (or watchpoint) is active. However, it is also\nused to store the number of the breakpoint.\n\nThis encoding leads to inconsistent value assignments: boolean and\ninteger values are mixed. Also, associated hardware comparator\nnumbers, which are usually numbered from 0, cannot be used directly.\nAn additional offset is required to store the comparator numbers.\n\nIn order to make the code more readable and the value assignment more\nconsistent, change the variable name to \u0027is_set\u0027, its data type to \u0027bool\u0027\nand introduce a dedicated variable for the break-/watchpoint\nnumber.\n\nIn order to make the review easier, the data types of various related\nvariables (e.g. number of breakpoints) are not changed.\n\nWhile at it, fix a few coding style issues.\n\nChange-Id: I2193f5639247cce6b80580d4c1c6afee916aeb82\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}},"6d1623e7bf5f087517595bbb88722a93eee1a082":{"kind":"REWORK","_number":4,"created":"2021-06-15 16:09:28.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/19/6319/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/19/6319/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/4 \u0026\u0026 git checkout -b change-6319 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/19/6319/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b7506291f923f13fdf8e93007bac6898d2d824b0","subject":"target: Rename \u0027linked_BRP\u0027 to \u0027linked_brp\u0027"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2021-06-13 09:21:18.000000000","tz":120},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2021-06-15 14:00:53.000000000","tz":120},"subject":"target: Rework \u0027set\u0027 variable of break-/watchpoints","message":"target: Rework \u0027set\u0027 variable of break-/watchpoints\n\nThe \u0027set\u0027 variable name suggests a boolean data type which determines\nwhether a breakpoint (or watchpoint) is active. However, it is also\nused to store the number of the breakpoint.\n\nThis encoding leads to inconsistent value assignments: boolean and\ninteger values are mixed. Also, associated hardware comparator\nnumbers, which are usually numbered from 0, cannot be used directly.\nAn additional offset is required to store the comparator numbers.\n\nIn order to make the code more readable and the value assignment more\nconsistent, change the data type of \u0027set\u0027 to \u0027bool\u0027 and introduce a\ndedicated variable for the break-/watchpoint number.\n\nIn order to make the review easier, the data types of various related\nvariables (e.g. number of breakpoints) are not changed.\n\nWhile at it, fix a few coding style issues.\n\nChange-Id: I2193f5639247cce6b80580d4c1c6afee916aeb82\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}},"8f8bceed0346ec4b823d1456f03debf681642013":{"kind":"REWORK","_number":7,"created":"2022-02-05 22:39:20.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/19/6319/7","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/19/6319/7","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/7 \u0026\u0026 git checkout -b change-6319 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/19/6319/7","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/7 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"dbbac5f11d662ab0827a997aa5d173fd62c51708","subject":"semihosting: use open mode flags from GDB, not from sys/stat.h"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2021-06-13 09:21:18.000000000","tz":120},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2022-02-05 22:38:53.000000000","tz":60},"subject":"target: Rework \u0027set\u0027 variable of break-/watchpoints","message":"target: Rework \u0027set\u0027 variable of break-/watchpoints\n\nThe \u0027set\u0027 variable name suggests a boolean data type which determines\nwhether a breakpoint (or watchpoint) is active. However, it is also\nused to store the number of the breakpoint.\n\nThis encoding leads to inconsistent value assignments: boolean and\ninteger values are mixed. Also, associated hardware comparator\nnumbers, which are usually numbered from 0, cannot be used directly.\nAn additional offset is required to store the comparator numbers.\n\nIn order to make the code more readable and the value assignment more\nconsistent, change the variable name to \u0027is_set\u0027, its data type to \u0027bool\u0027\nand introduce a dedicated variable for the break-/watchpoint\nnumber.\n\nIn order to make the review easier, the data types of various related\nvariables (e.g. number of breakpoints) are not changed.\n\nWhile at it, fix a few coding style issues.\n\nChange-Id: I2193f5639247cce6b80580d4c1c6afee916aeb82\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}},"23b10c2f689e062e38d0afaa028419b0a49dc093":{"kind":"REWORK","_number":6,"created":"2022-02-05 21:32:33.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/19/6319/6","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/19/6319/6","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/6 \u0026\u0026 git checkout -b change-6319 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/19/6319/6","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/19/6319/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"dbbac5f11d662ab0827a997aa5d173fd62c51708","subject":"semihosting: use open mode flags from GDB, not from sys/stat.h"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2021-06-13 09:21:18.000000000","tz":120},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2022-02-05 21:31:26.000000000","tz":60},"subject":"target: Rework \u0027set\u0027 variable of break-/watchpoints","message":"target: Rework \u0027set\u0027 variable of break-/watchpoints\n\nThe \u0027set\u0027 variable name suggests a boolean data type which determines\nwhether a breakpoint (or watchpoint) is active. However, it is also\nused to store the number of the breakpoint.\n\nThis encoding leads to inconsistent value assignments: boolean and\ninteger values are mixed. Also, associated hardware comparator\nnumbers, which are usually numbered from 0, cannot be used directly.\nAn additional offset is required to store the comparator numbers.\n\nIn order to make the code more readable and the value assignment more\nconsistent, change the variable name to \u0027is_set\u0027, its data type to \u0027bool\u0027\nand introduce a dedicated variable for the break-/watchpoint\nnumber.\n\nIn order to make the review easier, the data types of various related\nvariables (e.g. number of breakpoints) are not changed.\n\nWhile at it, fix a few coding style issues.\n\nChange-Id: I2193f5639247cce6b80580d4c1c6afee916aeb82\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}