)]}'
{"id":"openocd~master~Idddc31e34a67641c32d041c89d01fe2126ec5ddb","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2022-03-05 13:23:00.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-02-27 22:14:30.000000000","reason":"Antonio Borneo replied on the change"}},"hashtags":[],"change_id":"Idddc31e34a67641c32d041c89d01fe2126ec5ddb","subject":"target/arm_tpiu: Make error message easier to understand","status":"MERGED","created":"2021-06-22 11:18:53.000000000","updated":"2022-03-05 13:23:00.000000000","submitted":"2022-03-05 13:23:00.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6328","meta_rev_id":"b468553624da57af117a2e5111432a6a067915ad","_number":6328,"owner":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-03-05 13:23:00.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-03-05 13:23:00.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-03-05 13:23:00.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-06-22 11:51:57.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-07-15 08:24:32.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"bd4eff5236d6d09939ae2a71e937e7e88084e72e","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2021-06-22 11:18:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d97197937efa7fd69df7d1794e44a61e617da452","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-06-22 11:51:57.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14790/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/14036/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"0e594a1808387d857a167077ce5411b28c815e55","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2021-09-22 09:39:01.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"a12675123d986f47d54c54035772439e9a643303","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2022-02-26 13:47:53.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"0bf9520fea8f8f77363e39b80f80def4f5d2b35c","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-02-26 14:27:55.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15894/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15106/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"47916e83d36575a3e582e731f9e42d9ae1cbe9e8","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-02-27 20:53:06.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"f8f46800cfedabad39175a5f7feb991e52884fd3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2022-02-27 21:17:52.000000000","message":"Uploaded patch set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"b7ab488c80345b13c2d596eee8889f7cb9790b97","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-02-27 21:39:24.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15907/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15119/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"5195f21c9b6bc08402dc3c670449ecd71fb9c34e","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2022-02-27 21:41:34.000000000","message":"Patch Set 3: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"60a126625d7f3762e03f097c036036d6ea8f7297","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-02-27 22:14:30.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"b468553624da57af117a2e5111432a6a067915ad","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-05 13:23:00.000000000","message":"Change has been successfully cherry-picked as 29e2a7451638d5706daf13b12211b49baafa3c42","accounts_in_message":[],"_revision_number":4}],"current_revision":"29e2a7451638d5706daf13b12211b49baafa3c42","revisions":{"29e2a7451638d5706daf13b12211b49baafa3c42":{"kind":"REWORK","_number":4,"created":"2022-03-05 13:23:00.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/28/6328/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/28/6328/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/28/6328/4 \u0026\u0026 git checkout -b change-6328 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/28/6328/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/28/6328/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/28/6328/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/28/6328/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/28/6328/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e8e62c5aca494fa17a5e543831b8eef3740c9b1d","subject":"target/tcl: Add get_reg function"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2021-06-22 09:47:26.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-03-05 13:23:00.000000000","tz":0},"subject":"target/arm_tpiu: Make error message easier to understand","message":"target/arm_tpiu: Make error message easier to understand\n\nChange-Id: Idddc31e34a67641c32d041c89d01fe2126ec5ddb\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6328\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"2907fe4371c1c1453dd0c7f43e517173b0b5c817":{"kind":"REWORK","_number":1,"created":"2021-06-22 11:18:53.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/28/6328/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/28/6328/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/28/6328/1 \u0026\u0026 git checkout -b change-6328 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/28/6328/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/28/6328/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/28/6328/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/28/6328/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/28/6328/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"42a0bf3c360c1eae418223f0ab535b4d7accae83","subject":"Doc fix: echo writes to the log, and not to stdout"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2021-06-22 09:47:26.000000000","tz":120},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2021-06-22 10:50:19.000000000","tz":120},"subject":"target/arm_tpiu: Remove error message in \u0027tpiu create\u0027","message":"target/arm_tpiu: Remove error message in \u0027tpiu create\u0027\n\nThe current implementation prints the Tcl error message\n\n \u003e invalid command name \"target.tpiu\"\n\nwhen successfully created a TPIU object.\n\nRemove this confusing error message by passing JIM_NONE instead of\nJIM_ERRMSG to Jim_GetCommand().\n\nWhile at it, make the error message for already existing commands\neasier to understand.\n\nChange-Id: Idddc31e34a67641c32d041c89d01fe2126ec5ddb\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}},"fec8ba16361d9cdf963206ad762362c0778e9136":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2022-02-27 21:17:52.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/28/6328/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/28/6328/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/28/6328/3 \u0026\u0026 git checkout -b change-6328 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/28/6328/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/28/6328/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/28/6328/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/28/6328/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/28/6328/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"13cd75b6ecfd8d9cf04e56b182b6a162ad50247c","subject":"flash/nor/stm32xx: fix segfault accessing Cortex-M part number"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2021-06-22 09:47:26.000000000","tz":120},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2022-02-27 21:15:16.000000000","tz":60},"subject":"target/arm_tpiu: Make error message easier to understand","message":"target/arm_tpiu: Make error message easier to understand\n\nChange-Id: Idddc31e34a67641c32d041c89d01fe2126ec5ddb\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}},"1f6e5fe07d550077ec0d2ba195138aed42b8bb1c":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2022-02-26 13:47:53.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/28/6328/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/28/6328/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/28/6328/2 \u0026\u0026 git checkout -b change-6328 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/28/6328/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/28/6328/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/28/6328/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/28/6328/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/28/6328/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"13cd75b6ecfd8d9cf04e56b182b6a162ad50247c","subject":"flash/nor/stm32xx: fix segfault accessing Cortex-M part number"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2021-06-22 09:47:26.000000000","tz":120},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2022-02-26 13:32:33.000000000","tz":60},"subject":"target/arm_tpiu: Remove error message in \u0027tpiu create\u0027","message":"target/arm_tpiu: Remove error message in \u0027tpiu create\u0027\n\nThe current implementation prints the Tcl error message\n\n \u003e invalid command name \"target.tpiu\"\n\nwhen successfully created a TPIU object.\n\nRemove this confusing error message by passing JIM_NONE instead of\nJIM_ERRMSG to Jim_GetCommand().\n\nWhile at it, make the error message for already existing commands\neasier to understand.\n\nChange-Id: Idddc31e34a67641c32d041c89d01fe2126ec5ddb\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}