)]}'
{"id":"openocd~master~Ib2b233f8556934af61608ae93d6405585c2c40b7","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2022-03-05 13:23:33.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-02-27 22:15:01.000000000","reason":"Antonio Borneo replied on the change"}},"hashtags":[],"change_id":"Ib2b233f8556934af61608ae93d6405585c2c40b7","subject":"target/arm_tpiu: Fix \u0027tpiu create\u0027 parameter check","status":"MERGED","created":"2021-06-22 11:18:53.000000000","updated":"2022-03-05 13:23:33.000000000","submitted":"2022-03-05 13:23:33.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6329","meta_rev_id":"1424814b5a7b73573abffbf43df1d6e12d24b729","_number":6329,"owner":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-03-05 13:23:33.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-03-05 13:23:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-03-05 13:23:33.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-06-22 12:18:27.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-07-15 08:25:10.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"e9b6b6402740f1445c3f1f5dc5796dc734f335ee","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2021-06-22 11:18:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"88086d8b8b847da84f27367e1da5e54c15a8909a","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-06-22 12:18:27.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14791/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/14037/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"d60dd625122cb9ac0023359842c7ee643977b923","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2021-09-22 09:39:16.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"458a1e48998bfc8543562886c374d31137cb3dfe","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2022-02-26 13:47:53.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"fc0f25f3c55ee342628ff9f610ce18b6589ac3c2","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-02-26 14:58:50.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15895/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15107/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"fae32506ab09226df0878936a249597b683e746e","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-02-27 20:55:11.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"ec0b850792558c023a727844fb2ea5069b878565","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2022-02-27 21:17:52.000000000","message":"Uploaded patch set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"3929e6f5ab31b9a8708df34fe52ccbe12794ee7d","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2022-02-27 21:39:43.000000000","message":"Patch Set 3: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"a3210d19554fec76d0125c5f6b768a5b060457eb","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-02-27 21:58:07.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15908/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15120/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"6365fe1be30695b8b5559554506edd5cb35ff668","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-02-27 22:15:01.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"1424814b5a7b73573abffbf43df1d6e12d24b729","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-05 13:23:33.000000000","message":"Change has been successfully cherry-picked as 4a4ca07da7b53e589afe2f79d03787d89faf1d33","accounts_in_message":[],"_revision_number":4}],"current_revision":"4a4ca07da7b53e589afe2f79d03787d89faf1d33","revisions":{"4a4ca07da7b53e589afe2f79d03787d89faf1d33":{"kind":"REWORK","_number":4,"created":"2022-03-05 13:23:33.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/29/6329/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/29/6329/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/29/6329/4 \u0026\u0026 git checkout -b change-6329 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/29/6329/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/29/6329/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/29/6329/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/29/6329/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/29/6329/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"29e2a7451638d5706daf13b12211b49baafa3c42","subject":"target/arm_tpiu: Make error message easier to understand"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2021-06-22 10:59:01.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-03-05 13:23:33.000000000","tz":0},"subject":"target/arm_tpiu: Fix \u0027tpiu create\u0027 parameter check","message":"target/arm_tpiu: Fix \u0027tpiu create\u0027 parameter check\n\nThe current implementation crashes when executing \u0027tpiu create\u0027\nwithout an object name due to an invalid memory access. Pass \u0027argv\u0027\ninstead \u0027goi.argv\u0027 to fix the problem.\n\nWhile at it, match the style of the error message to the style used for\nother Tcl commands. Especially, make the \u0027name\u0027 parameter mandatory.\n\nChange-Id: Ib2b233f8556934af61608ae93d6405585c2c40b7\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6329\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\n"}},"57c1e177200c181935fcd7fc8c9cd182203747b8":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2022-02-26 13:47:53.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/29/6329/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/29/6329/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/29/6329/2 \u0026\u0026 git checkout -b change-6329 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/29/6329/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/29/6329/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/29/6329/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/29/6329/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/29/6329/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1f6e5fe07d550077ec0d2ba195138aed42b8bb1c","subject":"target/arm_tpiu: Remove error message in \u0027tpiu create\u0027"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2021-06-22 10:59:01.000000000","tz":120},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2022-02-26 13:32:33.000000000","tz":60},"subject":"target/arm_tpiu: Fix \u0027tpiu create\u0027 parameter check","message":"target/arm_tpiu: Fix \u0027tpiu create\u0027 parameter check\n\nThe current implementation crashes when executing \u0027tpiu create\u0027\nwithout an object name due to an invalid memory access. Pass \u0027argv\u0027\ninstead \u0027goi.argv\u0027 to fix the problem.\n\nWhile at it, match the style of the error mesage to the style used for\nother Tcl commands. Especially, make the \u0027name\u0027 parameter mandatory.\n\nChange-Id: Ib2b233f8556934af61608ae93d6405585c2c40b7\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}},"83e08cede557693ef981fedb62c2f54bbfd32c31":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2022-02-27 21:17:52.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/29/6329/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/29/6329/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/29/6329/3 \u0026\u0026 git checkout -b change-6329 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/29/6329/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/29/6329/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/29/6329/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/29/6329/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/29/6329/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"fec8ba16361d9cdf963206ad762362c0778e9136","subject":"target/arm_tpiu: Make error message easier to understand"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2021-06-22 10:59:01.000000000","tz":120},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2022-02-27 21:16:22.000000000","tz":60},"subject":"target/arm_tpiu: Fix \u0027tpiu create\u0027 parameter check","message":"target/arm_tpiu: Fix \u0027tpiu create\u0027 parameter check\n\nThe current implementation crashes when executing \u0027tpiu create\u0027\nwithout an object name due to an invalid memory access. Pass \u0027argv\u0027\ninstead \u0027goi.argv\u0027 to fix the problem.\n\nWhile at it, match the style of the error message to the style used for\nother Tcl commands. Especially, make the \u0027name\u0027 parameter mandatory.\n\nChange-Id: Ib2b233f8556934af61608ae93d6405585c2c40b7\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}},"79a44c1aa1b41240ca644b298de670237882fd6a":{"kind":"REWORK","_number":1,"created":"2021-06-22 11:18:53.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/29/6329/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/29/6329/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/29/6329/1 \u0026\u0026 git checkout -b change-6329 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/29/6329/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/29/6329/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/29/6329/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/29/6329/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/29/6329/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2907fe4371c1c1453dd0c7f43e517173b0b5c817","subject":"target/arm_tpiu: Remove error message in \u0027tpiu create\u0027"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2021-06-22 10:59:01.000000000","tz":120},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2021-06-22 11:13:23.000000000","tz":120},"subject":"target/arm_tpiu: Fix \u0027tpiu create\u0027 parameter check","message":"target/arm_tpiu: Fix \u0027tpiu create\u0027 parameter check\n\nThe current implementation crashes when executing \u0027tpiu create\u0027\nwithout an object name due to an invalid memory access. Pass \u0027argv\u0027\ninstead \u0027goi.argv\u0027 to fix the problem.\n\nWhile at it, match the style of the error mesage to the style used for\nother Tcl commands. Especially, make the \u0027name\u0027 parameter mandatory.\n\nChange-Id: Ib2b233f8556934af61608ae93d6405585c2c40b7\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}