)]}'
{"src/rtos/riot.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e9caae05050be9bd43f455337b5752166a9b9a93","unresolved":false,"context_lines":[{"line_number":181,"context_line":"\t\t\triot_symbol_list[RIOT_MAX_THREADS]);"},{"line_number":182,"context_line":"\t\treturn retval;"},{"line_number":183,"context_line":"\t}"},{"line_number":184,"context_line":"\trtos-\u003ethread_count \u003d thread_count;"},{"line_number":185,"context_line":"\tif (rtos-\u003ethread_count \u003e max_threads) {"},{"line_number":186,"context_line":"\t\tLOG_ERROR(\"Thread count is invalid\");"},{"line_number":187,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":188,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"4eceab4c_32590802","line":185,"range":{"start_line":184,"start_character":0,"end_line":185,"end_character":40},"updated":"2021-07-29 22:26:50.000000000","message":"Does it make sense to assign \u0027rtos-\u003ethread_count\u0027 before checking if the value is valid?\nShouldn\u0027t be better writing:\nif (x \u003e max_x) {\n  error;\n}\nrtos-\u003ex \u003d x;\n?","commit_id":"3a1057b20d77358d337c7e2eac107bad209fe97e"}]}