)]}'
{"id":"openocd~master~Ia8dc7e144e0ded6143682eb514c247f27859ff81","project":"openocd","branch":"master","hashtags":[],"change_id":"Ia8dc7e144e0ded6143682eb514c247f27859ff81","subject":"flash/stm32l4x: do not report bank mode before probing [FIX]","status":"MERGED","created":"2021-08-05 15:00:50.000000000","updated":"2021-08-26 06:16:32.000000000","submitted":"2021-08-26 06:16:32.000000000","submitter":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6411","meta_rev_id":"da023c16f256a1b84efcdf5493158f37ae7c972b","_number":6411,"owner":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-08-26 06:16:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"all":[{"value":0,"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-08-26 06:16:32.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-08-26 06:16:32.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-08-26 06:16:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-08-05 15:01:53.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2021-08-06 05:35:49.000000000","updated_by":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"reviewer":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"state":"REVIEWER"},{"updated":"2021-08-13 20:04:28.000000000","updated_by":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"reviewer":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"state":"REVIEWER"},{"updated":"2021-08-13 20:06:11.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-08-15 23:13:45.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"26b092a2476e0474f2a8858c5a96a397217f82a1","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-05 15:00:50.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"92b11c55ba9177579383be6cee4d65ceccf09fa7","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-08-05 18:29:05.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14957/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/14192/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"c294914f4be9aea4f80a7ce5eb1882737310c476","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2021-08-06 05:35:49.000000000","message":"Patch Set 1: Code-Review+1\n\nThank you for spotting this issue.\n\nChecked visually - the change is all right.","accounts_in_message":[],"_revision_number":1},{"id":"81b1f20986075ece727331f1e1a8b0f7a7d37baf","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-06 08:03:18.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"195d2df1b367b43b38e4fd68fc73fb59c24c1134","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-08-13 16:10:49.000000000","message":"Patch Set 1:\n\nI would expect in the commit message description why it is needed. What is the initial problem and why it is bad idea to print this information on this place.","accounts_in_message":[],"_revision_number":1},{"id":"e7f84f7ac09ea3483c8992b6ef67aa42095772d8","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-13 19:33:49.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"2fd16844302e70ef5a8f3a34b2491ed13d242b12","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-13 19:34:33.000000000","message":"Patch Set 2:\n\n\u003e I would expect in the commit message description why it is needed.\n \u003e What is the initial problem and why it is bad idea to print this\n \u003e information on this place.\n\nThanks Oleksij, I have update the commit message accordingly.","accounts_in_message":[],"_revision_number":2},{"id":"66f3c47f801b29347b5c0c471f0585c029b0cf6d","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-08-13 20:04:28.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"210db467865f9d7d6814ac3336a32b65e44950d6","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-08-13 20:06:11.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14998/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/14233/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"9fb2dc8a910c8b865b7902ea65bdf72761672f77","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-15 23:13:45.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"b9635259ff3e66db1fdad612a5aad6fe343093fb","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-16 11:12:31.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"0504be1e2967fd941439283ce53b3bccbf205e3b","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-22 15:27:09.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"da023c16f256a1b84efcdf5493158f37ae7c972b","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-08-26 06:16:32.000000000","message":"Change has been successfully cherry-picked as 1bce8d3d80490d66b56c2283e3ffee81a655a80a","accounts_in_message":[],"_revision_number":3}],"current_revision":"1bce8d3d80490d66b56c2283e3ffee81a655a80a","revisions":{"405de7c71d8ca10439e0e7d2d0bea5949cd451e0":{"kind":"REWORK","_number":1,"created":"2021-08-05 15:00:50.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/11/6411/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/11/6411/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/11/6411/1 \u0026\u0026 git checkout -b change-6411 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/11/6411/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/11/6411/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/11/6411/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/11/6411/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/11/6411/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3d9534b8a85d314f82440ce0e37632571c42245a","subject":"github/workflow: upgrade libraries in windows build to latest versions"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-07-29 09:35:26.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-07-29 09:36:08.000000000","tz":60},"subject":"flash/stm32l4x: do not report bank mode before probing [FIX]","message":"flash/stm32l4x: do not report bank mode before probing [FIX]\n\nFixes: 64c2e03b23d9 (\"flash/nor: improved API of flash_driver.info \u0026 fixed buffer overruns\")\nChange-Id: Ia8dc7e144e0ded6143682eb514c247f27859ff81\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}},"1bce8d3d80490d66b56c2283e3ffee81a655a80a":{"kind":"REWORK","_number":3,"created":"2021-08-26 06:16:32.000000000","uploader":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"ref":"refs/changes/11/6411/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/11/6411/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/11/6411/3 \u0026\u0026 git checkout -b change-6411 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/11/6411/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/11/6411/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/11/6411/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/11/6411/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/11/6411/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"76ba25a8a570d5e465e9ed3afdd36cf837fcb6a1","subject":"tcl: add lattice ECP5 family support"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-07-29 09:35:26.000000000","tz":60},"committer":{"name":"Oleksij Rempel","email":"linux@rempel-privat.de","date":"2021-08-26 06:16:32.000000000","tz":0},"subject":"flash/stm32l4x: do not report bank mode before probing [FIX]","message":"flash/stm32l4x: do not report bank mode before probing [FIX]\n\nin line 1391, get_stm32l4_bank_type_str(bank) will always output the same\nvalue \"Flash single\" since the variable stm32l4_info-\u003edual_bank_mode is false\nby default, stm32l4_info-\u003edual_bank_mode will be set correctly afterward\nin the switch case at line 1467\n\nthus the need to remove the usage of get_stm32l4_bank_type_str(bank) before\nstm32l4_info-\u003edual_bank_mode initialization.\n\nFixes: 64c2e03b23d9 (\"flash/nor: improved API of flash_driver.info \u0026 fixed buffer overruns\")\nChange-Id: Ia8dc7e144e0ded6143682eb514c247f27859ff81\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6411\nReviewed-by: Oleksij Rempel \u003clinux@rempel-privat.de\u003e\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\n"}},"6607514a26dda2d1be6961866e88fd464907c246":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2021-08-13 19:33:49.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/11/6411/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/11/6411/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/11/6411/2 \u0026\u0026 git checkout -b change-6411 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/11/6411/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/11/6411/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/11/6411/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/11/6411/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/11/6411/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3d9534b8a85d314f82440ce0e37632571c42245a","subject":"github/workflow: upgrade libraries in windows build to latest versions"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-07-29 09:35:26.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-08-13 19:33:43.000000000","tz":60},"subject":"flash/stm32l4x: do not report bank mode before probing [FIX]","message":"flash/stm32l4x: do not report bank mode before probing [FIX]\n\nin line 1391, get_stm32l4_bank_type_str(bank) will always output the same\nvalue \"Flash single\" since the variable stm32l4_info-\u003edual_bank_mode is false\nby default, stm32l4_info-\u003edual_bank_mode will be set correctly afterward\nin the switch case at line 1467\n\nthus the need to remove the usage of get_stm32l4_bank_type_str(bank) before\nstm32l4_info-\u003edual_bank_mode initialization.\n\nFixes: 64c2e03b23d9 (\"flash/nor: improved API of flash_driver.info \u0026 fixed buffer overruns\")\nChange-Id: Ia8dc7e144e0ded6143682eb514c247f27859ff81\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}