)]}'
{"id":"openocd~master~I63eb4da9e6801fab25e330f1f6b792d2fd619493","project":"openocd","branch":"master","hashtags":[],"change_id":"I63eb4da9e6801fab25e330f1f6b792d2fd619493","subject":"jep106: use packed jedec manufacturer code","status":"MERGED","created":"2021-08-09 13:43:29.000000000","updated":"2021-08-22 20:26:06.000000000","submitted":"2021-08-22 20:26:06.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6418","meta_rev_id":"250785e886e0a608f9730d3dfbef0b67ef42311b","_number":6418,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-08-22 20:26:06.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-08-22 20:26:06.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-08-09 14:29:32.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f7f0b59a84991744d4d8d1a2fc51502a56043f75","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-09 13:43:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3c642963662ed06038d769ea7af53b8ac27f144a","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-08-09 14:29:32.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14969/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/14204/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"79f4ebf979f005cc9d8a467a8973c9fd0a620422","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-09 22:06:51.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"769fa846b6b1ca2fa6446fab8aa1c3e72d8fbf6e","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-22 20:25:52.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"250785e886e0a608f9730d3dfbef0b67ef42311b","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-22 20:26:06.000000000","message":"Change has been successfully cherry-picked as 7a61a006decf828f0f75e0602cc17d6efb897f57","accounts_in_message":[],"_revision_number":2}],"current_revision":"7a61a006decf828f0f75e0602cc17d6efb897f57","revisions":{"7c7cfd66344d96fd68e7d62fb52ef615296cad29":{"kind":"REWORK","_number":1,"created":"2021-08-09 13:43:29.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/18/6418/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/18/6418/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/18/6418/1 \u0026\u0026 git checkout -b change-6418 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/18/6418/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/18/6418/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/18/6418/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/18/6418/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/18/6418/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3d9534b8a85d314f82440ce0e37632571c42245a","subject":"github/workflow: upgrade libraries in windows build to latest versions"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-08-08 11:51:33.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-08-09 13:39:40.000000000","tz":120},"subject":"jep106: use packed jedec manufacturer code","message":"jep106: use packed jedec manufacturer code\n\nJEP106 encodes JEDEC-assigned manufacture code as:\na) a sequence of zero or more escape codes 0x7f;\nb) an odd-parity bit of the next 7 bits;\nc) 7 bits.\n\nThe same code is often represented as a single value composed by\nthe logical OR between:\n- the number of escape codes in a), shifted left by 7 positions;\n- the 7 bits in c).\nThis is the preferred packed representation used by this change.\n\nCurrently there are only two uses of JEP106 in openocd to get the\nmanufacturer name:\n- to decode the JTAG IDCODE of each TAP, where the JEP106 code is\n  already packed as in the preferred representation above in bits\n  IDCODE[11:1];\n- to decode the ARM CoreSight PIDR register, where the JEP106 code\n  is split in 3 parts:\n  \u003d PIDR3[3:0], corresponding to bits [10:7] of the packed code;\n  \u003d PIDR2[2:0], corresponding to bits [6:4] of the packed code;\n  \u003d PIDR1[7:4], corresponding to bits [3:0] of the packed code.\n\nWrap the existing JEP106 decode function in a simpler API using\nthe packed code.\nSimplify the callers by skipping the bit unpacking.\nChange the manufacturer code in CoreSight table dap_partnums[] to\nmatch the packed representation, by removing the always-one bit 7\nerroneously taken from PIDR bit JEDEC and included in the former\ntable.\n\nChange-Id: I63eb4da9e6801fab25e330f1f6b792d2fd619493\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"7a61a006decf828f0f75e0602cc17d6efb897f57":{"kind":"REWORK","_number":2,"created":"2021-08-22 20:26:06.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/18/6418/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/18/6418/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/18/6418/2 \u0026\u0026 git checkout -b change-6418 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/18/6418/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/18/6418/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/18/6418/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/18/6418/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/18/6418/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"66175577e1f5b89470bafa1e613e10307996a3fb","subject":"arm_adi_v5: update coresight class names"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-08-08 11:51:33.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-08-22 20:26:06.000000000","tz":0},"subject":"jep106: use packed jedec manufacturer code","message":"jep106: use packed jedec manufacturer code\n\nJEP106 encodes JEDEC-assigned manufacture code as:\na) a sequence of zero or more escape codes 0x7f;\nb) an odd-parity bit of the next 7 bits;\nc) 7 bits.\n\nThe same code is often represented as a single value composed by\nthe logical OR between:\n- the number of escape codes in a), shifted left by 7 positions;\n- the 7 bits in c).\nThis is the preferred packed representation used by this change.\n\nCurrently there are only two uses of JEP106 in openocd to get the\nmanufacturer name:\n- to decode the JTAG IDCODE of each TAP, where the JEP106 code is\n  already packed as in the preferred representation above in bits\n  IDCODE[11:1];\n- to decode the ARM CoreSight PIDR register, where the JEP106 code\n  is split in 3 parts:\n  \u003d PIDR3[3:0], corresponding to bits [10:7] of the packed code;\n  \u003d PIDR2[2:0], corresponding to bits [6:4] of the packed code;\n  \u003d PIDR1[7:4], corresponding to bits [3:0] of the packed code.\n\nWrap the existing JEP106 decode function in a simpler API using\nthe packed code.\nSimplify the callers by skipping the bit unpacking.\nChange the manufacturer code in CoreSight table dap_partnums[] to\nmatch the packed representation, by removing the always-one bit 7\nerroneously taken from PIDR bit JEDEC and included in the former\ntable.\n\nChange-Id: I63eb4da9e6801fab25e330f1f6b792d2fd619493\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6418\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}