)]}'
{"id":"openocd~master~Ife9342c6088a241a0a4b77f9bd21f12c9b9862a0","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000863":{"account":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"last_update":"2021-08-22 11:10:26.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ife9342c6088a241a0a4b77f9bd21f12c9b9862a0","subject":"jtag/cmcis_dap: use COMMAND_PARSE_NUMBER in command handlers","status":"MERGED","created":"2021-08-09 21:23:55.000000000","updated":"2021-08-22 11:10:26.000000000","submitted":"2021-08-22 11:10:26.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6420","meta_rev_id":"97cf35e99f2caa04cfae36e6ffb1a119c6e5e8f6","_number":6420,"owner":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},{"value":0,"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-08-22 11:10:26.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":0,"date":"2021-08-22 11:10:26.000000000","permitted_voting_range":{"min":0,"max":2},"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-08-22 11:10:26.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-08-22 11:10:26.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-08-22 11:10:26.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-08-09 21:26:30.000000000","updated_by":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"reviewer":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"REVIEWER"},{"updated":"2021-08-09 22:38:57.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-08-10 06:56:51.000000000","updated_by":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"reviewer":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"state":"REVIEWER"},{"updated":"2021-08-10 07:59:55.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"dbb8224baf9efcb89e1b3f09b81315fb1018b093","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-09 21:23:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"df2f3fbaf65653bcfd3ff38a949e7cd7fdd4b83e","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-08-09 22:38:57.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14971/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/14206/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"34156fd8a014766d57c14f05e1f557c01a6b1729","author":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"real_author":{"_account_id":1001771,"name":"Adrian M Negreanu","email":"adrian.negreanu@nxp.com","username":"groleo"},"date":"2021-08-10 06:56:51.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"176bfa98bdc9951f681caa16f94fda1ed18719bd","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-10 07:59:55.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"66e3e5022c4bd729596289e608cd4dadc0851e92","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-10 09:03:35.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"cbcc81a593ab4ecdc78ffcb1bbee9ddd2cbc9f01","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-22 11:10:02.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"97cf35e99f2caa04cfae36e6ffb1a119c6e5e8f6","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-22 11:10:26.000000000","message":"Change has been successfully cherry-picked as 277b0a5d9770fcf12a6b630df5ffc26f242edf80","accounts_in_message":[],"_revision_number":2}],"current_revision":"277b0a5d9770fcf12a6b630df5ffc26f242edf80","revisions":{"f73893092718d140866bf6e8fd0d0364001542d0":{"kind":"REWORK","_number":1,"created":"2021-08-09 21:23:55.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/20/6420/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/20/6420/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/20/6420/1 \u0026\u0026 git checkout -b change-6420 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/20/6420/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/20/6420/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/20/6420/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/20/6420/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/20/6420/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"20390d916529c0804d60a6704c74b5359eaa4c4f","subject":"flash/stm32l4x: use COMMAND_PARSE_NUMBER in command handlers"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-07-29 22:44:36.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-07-29 22:45:04.000000000","tz":60},"subject":"jtag/cmcis_dap: use COMMAND_PARSE_NUMBER in command handlers","message":"jtag/cmcis_dap: use COMMAND_PARSE_NUMBER in command handlers\n\nthe usage of COMMAND_PARSE_NUMBER is safer in COMMAND_HANDLERs since it provides\nbetter error checking than strto** functions.\n\nChange-Id: Ife9342c6088a241a0a4b77f9bd21f12c9b9862a0\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}},"277b0a5d9770fcf12a6b630df5ffc26f242edf80":{"kind":"REWORK","_number":2,"created":"2021-08-22 11:10:26.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/20/6420/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/20/6420/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/20/6420/2 \u0026\u0026 git checkout -b change-6420 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/20/6420/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/20/6420/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/20/6420/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/20/6420/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/20/6420/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"91b5626e7fa7f30b1c5c8b69cf1decf33e892c42","subject":"flash/stm32l4x: use COMMAND_PARSE_NUMBER in command handlers"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-07-29 22:44:36.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-08-22 11:10:26.000000000","tz":0},"subject":"jtag/cmcis_dap: use COMMAND_PARSE_NUMBER in command handlers","message":"jtag/cmcis_dap: use COMMAND_PARSE_NUMBER in command handlers\n\nthe usage of COMMAND_PARSE_NUMBER is safer in COMMAND_HANDLERs since it provides\nbetter error checking than strto** functions.\n\nChange-Id: Ife9342c6088a241a0a4b77f9bd21f12c9b9862a0\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6420\nReviewed-by: Adrian M Negreanu \u003cadrian.negreanu@nxp.com\u003e\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}
