)]}'
{"id":"openocd~master~Ia7fe9c4017108616f21676f115f151ac62924205","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000863":{"account":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"last_update":"2021-08-22 13:19:16.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ia7fe9c4017108616f21676f115f151ac62924205","subject":"flash/atsame5: use COMMAND_PARSE_NUMBER in command handlers","status":"MERGED","created":"2021-08-09 21:23:55.000000000","updated":"2021-08-22 13:19:16.000000000","submitted":"2021-08-22 13:19:16.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6423","meta_rev_id":"4aecb0272987120f8eeaef82ee6b8de5800f3a91","_number":6423,"owner":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-08-22 13:19:16.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-08-22 13:19:16.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":0,"date":"2021-08-22 13:19:16.000000000","permitted_voting_range":{"min":0,"max":2},"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"tag":"autogenerated:gerrit:merged","value":0,"date":"2021-08-22 13:19:16.000000000","permitted_voting_range":{"min":0,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-08-22 13:19:16.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-08-09 21:29:33.000000000","updated_by":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"reviewer":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"REVIEWER"},{"updated":"2021-08-09 21:29:40.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2021-08-10 00:11:03.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-08-10 08:03:13.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"6f0d44a811928e862d1f829406d49cb57f89cec9","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-09 21:23:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b5a8e55ff884d8ed91c0108a8cadb298acb071b9","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-08-10 00:11:03.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14974/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/14209/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"1aefcd86f245fe70fe27c806081f003685dd8556","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-10 08:03:13.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"f717996bac4065f2b69d15b45aa398df8de2f66d","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-10 09:04:13.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"db151d56e11b3f8620512ae7b8732c764b29060f","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-22 13:01:12.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"4aecb0272987120f8eeaef82ee6b8de5800f3a91","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-22 13:19:16.000000000","message":"Change has been successfully cherry-picked as cbc1dc50490ba7a98778bef352aead754befabca","accounts_in_message":[],"_revision_number":2}],"current_revision":"cbc1dc50490ba7a98778bef352aead754befabca","revisions":{"cbc1dc50490ba7a98778bef352aead754befabca":{"kind":"REWORK","_number":2,"created":"2021-08-22 13:19:16.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/23/6423/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/23/6423/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/23/6423/2 \u0026\u0026 git checkout -b change-6423 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/23/6423/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/23/6423/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/23/6423/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/23/6423/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/23/6423/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3caa18729cde415519824b4f9da16df40c125539","subject":"flash/kinetis: use COMMAND_PARSE_NUMBER in command handlers"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-07-29 22:46:31.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-08-22 13:19:16.000000000","tz":0},"subject":"flash/atsame5: use COMMAND_PARSE_NUMBER in command handlers","message":"flash/atsame5: use COMMAND_PARSE_NUMBER in command handlers\n\nthe usage of COMMAND_PARSE_NUMBER is safer in COMMAND_HANDLERs since it provides\nbetter error checking than strto** functions.\n\nChange-Id: Ia7fe9c4017108616f21676f115f151ac62924205\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6423\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\n"}},"c5391ff3fd4957fafb4cc7af389d4075068c706d":{"kind":"REWORK","_number":1,"created":"2021-08-09 21:23:55.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/23/6423/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/23/6423/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/23/6423/1 \u0026\u0026 git checkout -b change-6423 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/23/6423/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/23/6423/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/23/6423/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/23/6423/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/23/6423/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"aac41906f7d72378fd19d0a01dd3752bd5c74661","subject":"flash/kinetis: use COMMAND_PARSE_NUMBER in command handlers"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-07-29 22:46:31.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-07-29 22:46:31.000000000","tz":60},"subject":"flash/atsame5: use COMMAND_PARSE_NUMBER in command handlers","message":"flash/atsame5: use COMMAND_PARSE_NUMBER in command handlers\n\nthe usage of COMMAND_PARSE_NUMBER is safer in COMMAND_HANDLERs since it provides\nbetter error checking than strto** functions.\n\nChange-Id: Ia7fe9c4017108616f21676f115f151ac62924205\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}