)]}'
{"id":"openocd~master~I14061cb48da6bac13f9d2896190136f5784b8c07","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000863":{"account":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"last_update":"2021-08-22 13:15:24.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I14061cb48da6bac13f9d2896190136f5784b8c07","subject":"flash/at91samd: use COMMAND_PARSE_NUMBER in command handlers","status":"MERGED","created":"2021-08-09 21:23:55.000000000","updated":"2021-08-22 13:15:24.000000000","submitted":"2021-08-22 13:15:24.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6424","meta_rev_id":"f912a4fb0aed9a2918cf496e13b288328428f467","_number":6424,"owner":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"value":0,"_account_id":1001433,"name":"Stefan Arnold","email":"sarnold@sh-sw.de","username":"Rae8eigh"},{"value":0,"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-08-22 13:15:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-08-22 13:15:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"value":0,"_account_id":1001433,"name":"Stefan Arnold","email":"sarnold@sh-sw.de","username":"Rae8eigh"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-08-22 13:15:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"_account_id":1001433,"name":"Stefan Arnold","email":"sarnold@sh-sw.de","username":"Rae8eigh"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-08-09 21:29:55.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2021-08-09 21:30:08.000000000","updated_by":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"reviewer":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"REVIEWER"},{"updated":"2021-08-10 08:13:59.000000000","updated_by":{"_account_id":1001433,"name":"Stefan Arnold","email":"sarnold@sh-sw.de","username":"Rae8eigh"},"reviewer":{"_account_id":1001433,"name":"Stefan Arnold","email":"sarnold@sh-sw.de","username":"Rae8eigh"},"state":"REVIEWER"},{"updated":"2021-08-10 14:06:48.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-08-10 16:31:34.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"480d883043e9b5b67237837b3eed50aed7d51308","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-09 21:23:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"19e176b9a72f6e0822c6656d3e572de2c820d371","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-08-10 00:40:41.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14975/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/14210/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"cc166a0b1750bb49114225bb331f82bd969e086f","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-10 08:14:28.000000000","message":"Patch Set 1:\n\nthe patch is consistent with the whole series, but I\u0027m questioning myself if we should keep this get_u64_from_hexarg()!\nReading the use cases, they are just getting two command arguments: value and mask. Nothing that requires enforcing HEX values.\nThis code was introduced with http://openocd.zylin.com/4260/\nWhy not replacing it completely with a COMMAND_PARSE_NUMBER(u64, ...)?","accounts_in_message":[],"_revision_number":1},{"id":"365a425dcc0e5c6b5a9198199d6994920c88001c","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-10 09:09:21.000000000","message":"Patch Set 1:\n\nI\u0027ve tried to keep it simple, as I cannot test the change\nbut your proposal is correct.\nI will change it ;)","accounts_in_message":[],"_revision_number":1},{"id":"74580a5015170d6d9089013a9cc28b481f9eeb6e","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-10 13:32:57.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"3e9d5d45168f14bc6df1f17d0a6ec10ec50483c7","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-08-10 14:06:48.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14978/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/14213/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"4e7f1bfa059c7911e6cadc7dfbaa87df23218c04","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-10 16:31:34.000000000","message":"Patch Set 2: Code-Review+1\n\nThanks!","accounts_in_message":[],"_revision_number":2},{"id":"7ed6367d22d262f77a52fbf0d1ebd13890647a6c","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-20 22:18:49.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"05d33c49fff7aced8921ba806c84ad8a4321de77","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-22 13:01:24.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"f912a4fb0aed9a2918cf496e13b288328428f467","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-22 13:15:24.000000000","message":"Change has been successfully cherry-picked as dd0ee1fa5b88a4e5015aae6d9527e97bec7f5bc5","accounts_in_message":[],"_revision_number":3}],"current_revision":"dd0ee1fa5b88a4e5015aae6d9527e97bec7f5bc5","revisions":{"d4313143e80f09810da8526a24729027089cbf56":{"kind":"REWORK","_number":2,"created":"2021-08-10 13:32:57.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/24/6424/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/24/6424/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/24/6424/2 \u0026\u0026 git checkout -b change-6424 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/24/6424/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/24/6424/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/24/6424/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/24/6424/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/24/6424/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c5391ff3fd4957fafb4cc7af389d4075068c706d","subject":"flash/atsame5: use COMMAND_PARSE_NUMBER in command handlers"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-07-29 22:47:07.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-07-30 03:15:37.000000000","tz":60},"subject":"flash/at91samd: use COMMAND_PARSE_NUMBER in command handlers","message":"flash/at91samd: use COMMAND_PARSE_NUMBER in command handlers\n\nthe usage of COMMAND_PARSE_NUMBER is safer in COMMAND_HANDLERs since it provides\nbetter error checking than strto** functions.\n\nChange-Id: I14061cb48da6bac13f9d2896190136f5784b8c07\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}},"dd0ee1fa5b88a4e5015aae6d9527e97bec7f5bc5":{"kind":"REWORK","_number":3,"created":"2021-08-22 13:15:24.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/24/6424/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/24/6424/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/24/6424/3 \u0026\u0026 git checkout -b change-6424 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/24/6424/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/24/6424/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/24/6424/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/24/6424/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/24/6424/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"277b0a5d9770fcf12a6b630df5ffc26f242edf80","subject":"jtag/cmcis_dap: use COMMAND_PARSE_NUMBER in command handlers"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-07-29 22:47:07.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-08-22 13:15:24.000000000","tz":0},"subject":"flash/at91samd: use COMMAND_PARSE_NUMBER in command handlers","message":"flash/at91samd: use COMMAND_PARSE_NUMBER in command handlers\n\nthe usage of COMMAND_PARSE_NUMBER is safer in COMMAND_HANDLERs since it provides\nbetter error checking than strto** functions.\n\nChange-Id: I14061cb48da6bac13f9d2896190136f5784b8c07\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6424\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"5b6ac3559495d388ca3fc4a964c566001543fb32":{"kind":"REWORK","_number":1,"created":"2021-08-09 21:23:55.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/24/6424/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/24/6424/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/24/6424/1 \u0026\u0026 git checkout -b change-6424 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/24/6424/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/24/6424/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/24/6424/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/24/6424/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/24/6424/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c5391ff3fd4957fafb4cc7af389d4075068c706d","subject":"flash/atsame5: use COMMAND_PARSE_NUMBER in command handlers"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-07-29 22:47:07.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-07-29 22:47:07.000000000","tz":60},"subject":"flash/at91samd: use COMMAND_PARSE_NUMBER in command handlers","message":"flash/at91samd: use COMMAND_PARSE_NUMBER in command handlers\n\nthe usage of COMMAND_PARSE_NUMBER is safer in COMMAND_HANDLERs since it provides\nbetter error checking than strto** functions.\n\nChange-Id: I14061cb48da6bac13f9d2896190136f5784b8c07\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}