)]}'
{"id":"openocd~master~Ic39e44914e34bb62991783762e5a65ef8871e82f","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000863":{"account":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"last_update":"2021-09-04 07:26:10.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ic39e44914e34bb62991783762e5a65ef8871e82f","subject":"flash/nor/tcl: \u0027flash list\u0027 command: add the flash bank target","status":"MERGED","created":"2021-08-10 20:44:42.000000000","updated":"2021-09-04 07:26:10.000000000","submitted":"2021-09-04 07:26:10.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6426","meta_rev_id":"a66a8a920496001fcfe17313181db0f3fc7bdb80","_number":6426,"owner":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"value":0,"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-09-04 07:26:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-09-04 07:26:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-09-04 07:26:10.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-09-04 07:26:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-08-11 00:52:11.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-08-11 18:02:12.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2021-08-16 19:08:41.000000000","updated_by":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"reviewer":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"REVIEWER"}],"messages":[{"id":"8ff9a611c433aa0f97c39c5050d74e2af85b012f","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-10 20:44:42.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9c38ccb8d4192431ac8161f79cc2f68a0ae42423","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-08-10 21:17:21.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14979/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/14214/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"25639d3bdc4f171965a5c79b6209387b3d29db78","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-10 22:59:00.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"15abbcfa6e06737ff7f34450e72d766fac3e5c3f","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-11 00:16:00.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"7e940a67bb19a06af04193e579d24ccbcc02c4b5","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-11 00:16:54.000000000","message":"Patch Set 2:\n\n(1 comment)\n\nthanks !","accounts_in_message":[],"_revision_number":2},{"id":"35f4b5a515502d972fb3e9f3a674b94a91b354cc","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-08-11 00:52:11.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14980/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/14215/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"256ab4f0f02f448756e3ef2aba7907452444a0f0","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-11 13:53:21.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"cfc9a0cadc119746328f1ac388fa8a6920a6852b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-11 18:02:12.000000000","message":"Patch Set 2: Code-Review+1\n\nThanks!","accounts_in_message":[],"_revision_number":2},{"id":"5b7a8805a09a017e9ad41916445612b46838bc50","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2021-08-16 19:08:41.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"57d395a2fe3bde4109d75a3d06e8ebccfc3df4bc","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-04 07:26:07.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"a66a8a920496001fcfe17313181db0f3fc7bdb80","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-04 07:26:10.000000000","message":"Change has been successfully cherry-picked as f24a283ac7765df6f09694a4cee99150cb645ac1","accounts_in_message":[],"_revision_number":3}],"current_revision":"f24a283ac7765df6f09694a4cee99150cb645ac1","revisions":{"f24a283ac7765df6f09694a4cee99150cb645ac1":{"kind":"REWORK","_number":3,"created":"2021-09-04 07:26:10.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/26/6426/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/26/6426/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/26/6426/3 \u0026\u0026 git checkout -b change-6426 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/26/6426/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/26/6426/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/26/6426/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/26/6426/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/26/6426/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9f733ba2f274c425178780812d1c44fa44e464e4","subject":"flash/nor/tcl: fix the flash name returned by \u0027flash list\u0027 command"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-08-10 14:32:37.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-09-04 07:26:10.000000000","tz":0},"subject":"flash/nor/tcl: \u0027flash list\u0027 command: add the flash bank target","message":"flash/nor/tcl: \u0027flash list\u0027 command: add the flash bank target\n\nadd the target assigned to the flash bank at creation\nthis is useful in daisy chains, to filter out the target banks.\n\nChange-Id: Ic39e44914e34bb62991783762e5a65ef8871e82f\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6426\nTested-by: jenkins\nReviewed-by: zapb \u003cdev@zapb.de\u003e\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"85fb860b63f3c9ba3272311e95c7c708952b9516":{"kind":"REWORK","_number":2,"created":"2021-08-11 00:16:00.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/26/6426/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/26/6426/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/26/6426/2 \u0026\u0026 git checkout -b change-6426 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/26/6426/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/26/6426/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/26/6426/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/26/6426/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/26/6426/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"464cdaf7d2d22222d90ef2d0eae23920c007bd40","subject":"flash/nor/tcl: fix the flash name returned by \u0027flash list\u0027 command"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-08-10 14:32:37.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-08-11 00:15:45.000000000","tz":60},"subject":"flash/nor/tcl: \u0027flash list\u0027 command: add the flash bank target","message":"flash/nor/tcl: \u0027flash list\u0027 command: add the flash bank target\n\nadd the target assigned to the flash bank at creation\nthis is useful in daisy chains, to filter out the target banks.\n\nChange-Id: Ic39e44914e34bb62991783762e5a65ef8871e82f\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}},"a9d041d03adbc979095ff257e428b6f36c38a5f3":{"kind":"REWORK","_number":1,"created":"2021-08-10 20:44:42.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/26/6426/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/26/6426/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/26/6426/1 \u0026\u0026 git checkout -b change-6426 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/26/6426/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/26/6426/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/26/6426/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/26/6426/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/26/6426/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"464cdaf7d2d22222d90ef2d0eae23920c007bd40","subject":"flash/nor/tcl: fix the flash name returned by \u0027flash list\u0027 command"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-08-10 14:32:37.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-08-10 14:32:37.000000000","tz":60},"subject":"flash/nor/tcl: \u0027flash list\u0027 command: add the flash bank target","message":"flash/nor/tcl: \u0027flash list\u0027 command: add the flash bank target\n\nadd the target assigned to the flash bank at creation\nthis is useful in daisy chains, to filter out the target banks.\n\nChange-Id: Ic39e44914e34bb62991783762e5a65ef8871e82f\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}