)]}'
{"src/rtos/riot.c":[{"author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"change_message_id":"2cf9af99522a88fde59c06dd5b892bfeaf124683","unresolved":false,"context_lines":[{"line_number":373,"context_line":"\t\t(*symbol_list)[i].symbol_name \u003d riot_symbol_list[i];"},{"line_number":374,"context_line":"\t\t(*symbol_list)[i].optional \u003d false;"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"\t\t/* Lookup if symbol is optional */"},{"line_number":377,"context_line":"\t\tfor (unsigned int k \u003d 0; k \u003c ARRAY_SIZE(riot_optional_symbols); k++) {"},{"line_number":378,"context_line":"\t\t\tif (i \u003d\u003d riot_optional_symbols[k]) {"},{"line_number":379,"context_line":"\t\t\t\t(*symbol_list)[i].optional \u003d true;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"2ecb373e_ab64a9af","line":376,"updated":"2021-08-11 13:55:01.000000000","message":"Fix is good but the original design is horrible, which is why it needs the fix in the first place. Bonus points if you care to instead make riot_symbol_list an array of struct consisting of the \u0027name\u0027 and the \u0027optional\u0027 boolean and just copy these into the new array and skip the nested lookup and the separate array?\n\nThe other dozen or so uses of riot_symbol_list[] of course needs to use the .name field instead of the element directly.","commit_id":"7c996a93a84e0eed0c05522cfa4550af5686e4f7"}]}