)]}'
{"id":"openocd~master~I0455a26b234cb4f5e239a6ba90023d28380e9464","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001908":{"account":{"_account_id":1001908,"name":"Sebastiaan de Schaetzen","email":"sebastiaan.de.schaetzen@gmail.com","username":"seeseemelk"},"last_update":"2021-08-26 06:38:45.000000000","reason":"Change was submitted"},"1000863":{"account":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"last_update":"2021-08-26 06:38:45.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I0455a26b234cb4f5e239a6ba90023d28380e9464","subject":"flash/stm32l4x: prevent undefined behavior warnings caused by signed integer operations","status":"MERGED","created":"2021-08-11 13:10:01.000000000","updated":"2021-08-26 06:38:45.000000000","submitted":"2021-08-26 06:38:45.000000000","submitter":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"total_comment_count":9,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6429","meta_rev_id":"27b06706e3b18a542d1f428af28462823c84a741","_number":6429,"owner":{"_account_id":1001908,"name":"Sebastiaan de Schaetzen","email":"sebastiaan.de.schaetzen@gmail.com","username":"seeseemelk"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"value":0,"_account_id":1001908,"name":"Sebastiaan de Schaetzen","email":"sebastiaan.de.schaetzen@gmail.com","username":"seeseemelk"},{"value":0,"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"value":0,"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-08-26 06:38:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-08-26 06:38:45.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"value":0,"_account_id":1001908,"name":"Sebastiaan de Schaetzen","email":"sebastiaan.de.schaetzen@gmail.com","username":"seeseemelk"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-08-26 06:38:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-08-26 06:38:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"_account_id":1001908,"name":"Sebastiaan de Schaetzen","email":"sebastiaan.de.schaetzen@gmail.com","username":"seeseemelk"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-08-16 13:54:29.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2021-08-16 14:16:44.000000000","updated_by":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"reviewer":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"state":"REVIEWER"},{"updated":"2021-08-16 15:32:19.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-08-16 18:07:31.000000000","updated_by":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"reviewer":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"state":"REVIEWER"},{"updated":"2021-08-26 06:14:14.000000000","updated_by":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"reviewer":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"state":"REVIEWER"}],"messages":[{"id":"b032a30c56768dfabc48ab90a1fe986cbc80df34","author":{"_account_id":1001908,"name":"Sebastiaan de Schaetzen","email":"sebastiaan.de.schaetzen@gmail.com","username":"seeseemelk"},"real_author":{"_account_id":1001908,"name":"Sebastiaan de Schaetzen","email":"sebastiaan.de.schaetzen@gmail.com","username":"seeseemelk"},"date":"2021-08-11 13:10:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"07457378b079bf0a130e88d69f2c99d5d0d912ec","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2021-08-11 14:02:19.000000000","message":"Patch Set 1: Code-Review+1\n\nIn theory, (1U \u003c\u003c 31) could still overflow the unsigned int (if it\u0027s less than 32 bits) which, although not UB, would still give the wrong result. Not a likely problem in practice these days but I guess UL is slightly more correct. I don\u0027t care either way, someone else can decide.","accounts_in_message":[],"_revision_number":1},{"id":"43819657aac13a61177e44dab9dcd385aee9bb86","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-08-11 14:37:08.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14984/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/14219/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"9198b3f5cccb57911e558524c810125399be1fa5","author":{"_account_id":1001908,"name":"Sebastiaan de Schaetzen","email":"sebastiaan.de.schaetzen@gmail.com","username":"seeseemelk"},"real_author":{"_account_id":1001908,"name":"Sebastiaan de Schaetzen","email":"sebastiaan.de.schaetzen@gmail.com","username":"seeseemelk"},"date":"2021-08-11 15:19:58.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"0a1e0b6f773aeda1fe4b5041b020d4b01167035d","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-08-11 16:23:14.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/14986/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/14221/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"f799391771c79f8c50fed23bff13c7076d386bf4","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2021-08-11 17:12:31.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"d3d8ea26ffece21dbfe28f1ca70d4427c3407efa","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-11 18:00:29.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"f453d3e876c074b7b7b00d12ca97028d5847ae7d","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-11 23:18:24.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"38b118ce593515579cd026b6ddad393923b33844","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-15 22:54:38.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"8734b2a649271d5e23adc1900775680595f3f861","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-15 22:57:39.000000000","message":"Patch Set 3:\n\nHi Sebastiaan, I have updated your change and rebased it on top of the approved patches (related to flash/stm32l4x) to avoid rebasing them while (of course) keeping you as author.\nif you are happy with my changes please give your +1, otherwise please let us know.","accounts_in_message":[],"_revision_number":3},{"id":"6afe86fd2aeaea5d177f5ca374603b549b3c94e6","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-08-15 23:30:44.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/15030/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/14264/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"a3cfc997053ecb1faf1cc41683757a7f9a74136e","author":{"_account_id":1001908,"name":"Sebastiaan de Schaetzen","email":"sebastiaan.de.schaetzen@gmail.com","username":"seeseemelk"},"real_author":{"_account_id":1001908,"name":"Sebastiaan de Schaetzen","email":"sebastiaan.de.schaetzen@gmail.com","username":"seeseemelk"},"date":"2021-08-16 08:39:06.000000000","message":"Patch Set 3: Code-Review+1\n\nThanks for updating it!","accounts_in_message":[],"_revision_number":3},{"id":"85eea74b32ea6ba8d6d46b1fbaccd0d532e016d6","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-16 09:19:09.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"dfa0d45a1fcabbbfce88a3e5c1a47ab9fd9bc400","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-16 13:14:29.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"cbb9bc21dc40cf2f1045ccd11a2c5eec0babd6ff","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-16 13:22:10.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"d60d25a6f45e8340ffef0086854710824e2df8be","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-16 13:54:29.000000000","message":"Patch Set 4: Code-Review+1\n\n(1 comment)\n\nthanks","accounts_in_message":[],"_revision_number":4},{"id":"5abebe7a7d053acc46692587fea1ff3719b1ed45","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-16 14:16:44.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"e67e6c22580c3c7d161a329cb2e9728b43d05c2f","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-08-16 15:32:19.000000000","message":"Patch Set 4: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/15045/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/14279/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"ffe41c0539e809dc6ee69231f0544a9e4fca037f","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2021-08-16 18:07:31.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"bbb756ecccb803a6cf34c26fe506aabaa32454dd","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-17 12:50:44.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"3e132be1d132c994c52fd545399266b376636b80","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-08-26 06:14:14.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"27b06706e3b18a542d1f428af28462823c84a741","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-08-26 06:38:45.000000000","message":"Change has been successfully cherry-picked as 64fbd607874bbe9726cf1d09c2cbf547bd9d804c","accounts_in_message":[],"_revision_number":5}],"current_revision":"64fbd607874bbe9726cf1d09c2cbf547bd9d804c","revisions":{"e011a78672a8f4ec02b3dedc3b03fc1e79ce884b":{"kind":"REWORK","_number":4,"created":"2021-08-16 13:22:10.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/29/6429/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/29/6429/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/29/6429/4 \u0026\u0026 git checkout -b change-6429 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/29/6429/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/29/6429/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/29/6429/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/29/6429/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/29/6429/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6be2e98318fca074ce8a9815ba741c42968407f7","subject":"flash/stm32l4x: add support of STM32G0Bx/G0Cx devices"}],"author":{"name":"Sebastiaan de Schaetzen","email":"sebastiaan.de.schaetzen@gmail.com","date":"2021-08-15 22:26:23.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-08-16 13:21:54.000000000","tz":60},"subject":"flash/stm32l4x: prevent undefined behavior warnings caused by signed integer operations","message":"flash/stm32l4x: prevent undefined behavior warnings caused by signed integer operations\n\nWhen running OpenOCD with -fsanitize\u003dundefined, a warning is emitted\nfor an bit-shifting operation whose result cannot be stored in a\nsigned integer.\n\nThis is because (1 \u003c\u003c 31) overflows a signed integer, which is\nundefined behavior. By making each of the bit masks act on an\nunsigned number, the warning is avoided.\n\nWhether this warning emitted by UBSan would ever manifest into a real\nerror is debatable, but fixing this does make UBSan happy.\n\nChange-Id: I0455a26b234cb4f5e239a6ba90023d28380e9464\nSigned-off-by: Sebastiaan de Schaetzen \u003csebastiaan.de.schaetzen@gmail.com\u003e\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}},"64fbd607874bbe9726cf1d09c2cbf547bd9d804c":{"kind":"REWORK","_number":5,"created":"2021-08-26 06:38:45.000000000","uploader":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"ref":"refs/changes/29/6429/5","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/29/6429/5","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/29/6429/5 \u0026\u0026 git checkout -b change-6429 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/29/6429/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/29/6429/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/29/6429/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/29/6429/5","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/29/6429/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"43d31a8fd507a7d15083b487cf06d3f934e25843","subject":"flash/stm32l4x: add support of STM32G0Bx/G0Cx devices"}],"author":{"name":"Sebastiaan de Schaetzen","email":"sebastiaan.de.schaetzen@gmail.com","date":"2021-08-15 22:26:23.000000000","tz":60},"committer":{"name":"Oleksij Rempel","email":"linux@rempel-privat.de","date":"2021-08-26 06:38:45.000000000","tz":0},"subject":"flash/stm32l4x: prevent undefined behavior warnings caused by signed integer operations","message":"flash/stm32l4x: prevent undefined behavior warnings caused by signed integer operations\n\nWhen running OpenOCD with -fsanitize\u003dundefined, a warning is emitted\nfor an bit-shifting operation whose result cannot be stored in a\nsigned integer.\n\nThis is because (1 \u003c\u003c 31) overflows a signed integer, which is\nundefined behavior. By making each of the bit masks act on an\nunsigned number, the warning is avoided.\n\nWhether this warning emitted by UBSan would ever manifest into a real\nerror is debatable, but fixing this does make UBSan happy.\n\nChange-Id: I0455a26b234cb4f5e239a6ba90023d28380e9464\nSigned-off-by: Sebastiaan de Schaetzen \u003csebastiaan.de.schaetzen@gmail.com\u003e\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6429\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-by: Oleksij Rempel \u003clinux@rempel-privat.de\u003e\nTested-by: jenkins\n"}},"2ca493b4532ec15374f84da6b401368a4849f402":{"kind":"REWORK","_number":1,"created":"2021-08-11 13:10:01.000000000","uploader":{"_account_id":1001908,"name":"Sebastiaan de Schaetzen","email":"sebastiaan.de.schaetzen@gmail.com","username":"seeseemelk"},"ref":"refs/changes/29/6429/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/29/6429/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/29/6429/1 \u0026\u0026 git checkout -b change-6429 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/29/6429/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/29/6429/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/29/6429/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/29/6429/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/29/6429/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3d9534b8a85d314f82440ce0e37632571c42245a","subject":"github/workflow: upgrade libraries in windows build to latest versions"}],"author":{"name":"Sebastiaan de Schaetzen","email":"sebastiaan.de.schaetzen@gmail.com","date":"2021-08-11 13:04:34.000000000","tz":120},"committer":{"name":"Sebastiaan de Schaetzen","email":"sebastiaan.de.schaetzen@gmail.com","date":"2021-08-11 13:09:49.000000000","tz":120},"subject":"flash/stm32l4x: prevent undefined behaviour warnings caused by signed integer operations","message":"flash/stm32l4x: prevent undefined behaviour warnings caused by signed integer operations\n\nWhen running OpenOCD with -fsanitize\u003dundefined, a warning is emitted\nfor an bit-shifting operation whose result cannot be stored in a\nsigned integer.\n\nThis is because (1 \u003c\u003c 31) overflows a signed integer, which is\nundefined behaviour. By making each of the bit masks act on an\nunsigned number, the warning is avoided.\n\nWhether this warning emitted by UBSan would ever manifest into a real\nerror is debatable, but fixing this does make UBSan happy.\n\nChange-Id: I0455a26b234cb4f5e239a6ba90023d28380e9464\nSigned-off-by: Sebastiaan de Schaetzen \u003csebastiaan.de.schaetzen@gmail.com\u003e\n"}},"43e6920714de4f7aa6893fe555c540071a529170":{"kind":"REWORK","_number":2,"created":"2021-08-11 15:19:58.000000000","uploader":{"_account_id":1001908,"name":"Sebastiaan de Schaetzen","email":"sebastiaan.de.schaetzen@gmail.com","username":"seeseemelk"},"ref":"refs/changes/29/6429/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/29/6429/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/29/6429/2 \u0026\u0026 git checkout -b change-6429 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/29/6429/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/29/6429/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/29/6429/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/29/6429/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/29/6429/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3d9534b8a85d314f82440ce0e37632571c42245a","subject":"github/workflow: upgrade libraries in windows build to latest versions"}],"author":{"name":"Sebastiaan de Schaetzen","email":"sebastiaan.de.schaetzen@gmail.com","date":"2021-08-11 13:04:34.000000000","tz":120},"committer":{"name":"Sebastiaan de Schaetzen","email":"sebastiaan.de.schaetzen@gmail.com","date":"2021-08-11 15:19:50.000000000","tz":120},"subject":"flash/stm32l4x: prevent undefined behaviour warnings caused by signed integer operations","message":"flash/stm32l4x: prevent undefined behaviour warnings caused by signed integer operations\n\nWhen running OpenOCD with -fsanitize\u003dundefined, a warning is emitted\nfor an bit-shifting operation whose result cannot be stored in a\nsigned integer.\n\nThis is because (1 \u003c\u003c 31) overflows a signed integer, which is\nundefined behaviour. By making each of the bit masks act on an\nunsigned number, the warning is avoided.\n\nWhether this warning emitted by UBSan would ever manifest into a real\nerror is debatable, but fixing this does make UBSan happy.\n\nChange-Id: I0455a26b234cb4f5e239a6ba90023d28380e9464\nSigned-off-by: Sebastiaan de Schaetzen \u003csebastiaan.de.schaetzen@gmail.com\u003e\n"}},"d46f627b7d938357f5827be961cca38d10b87f5e":{"kind":"REWORK","_number":3,"created":"2021-08-15 22:54:38.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/29/6429/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/29/6429/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/29/6429/3 \u0026\u0026 git checkout -b change-6429 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/29/6429/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/29/6429/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/29/6429/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/29/6429/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/29/6429/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d90d477056a7a82296aa6a85a9bd76bb49693dfb","subject":"flash/stm32l4x: add support of STM32G0Bx/G0Cx devices"}],"author":{"name":"Sebastiaan de Schaetzen","email":"sebastiaan.de.schaetzen@gmail.com","date":"2021-08-15 22:26:23.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-08-15 22:53:35.000000000","tz":60},"subject":"flash/stm32l4x: prevent undefined behavior warnings caused by signed integer operations","message":"flash/stm32l4x: prevent undefined behavior warnings caused by signed integer operations\n\nWhen running OpenOCD with -fsanitize\u003dundefined, a warning is emitted\nfor an bit-shifting operation whose result cannot be stored in a\nsigned integer.\n\nThis is because (1 \u003c\u003c 31) overflows a signed integer, which is\nundefined behavior. By making each of the bit masks act on an\nunsigned number, the warning is avoided.\n\nWhether this warning emitted by UBSan would ever manifest into a real\nerror is debatable, but fixing this does make UBSan happy.\n\nChange-Id: I0455a26b234cb4f5e239a6ba90023d28380e9464\nSigned-off-by: Sebastiaan de Schaetzen \u003csebastiaan.de.schaetzen@gmail.com\u003e\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}