)]}'
{"id":"openocd~master~I3b67a6f558d9350f609a22524012b6fceb7de7c2","project":"openocd","branch":"master","topic":"stm32l5x","attention_set":{},"removed_from_attention_set":{"1000863":{"account":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"last_update":"2021-08-26 06:37:38.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I3b67a6f558d9350f609a22524012b6fceb7de7c2","subject":"flash/stm32l4x: remove stm32l4_part_info.default_flash_regs","status":"MERGED","created":"2021-08-13 23:09:43.000000000","updated":"2021-08-26 06:37:38.000000000","submitted":"2021-08-26 06:37:38.000000000","submitter":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6435-stm32l5x","meta_rev_id":"16beefb1426b322b324ee41b6bf67758e0f8f031","_number":6435,"owner":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"value":0,"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-08-26 06:37:38.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-08-26 06:37:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-08-26 06:37:38.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-08-14 16:35:51.000000000","updated_by":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"reviewer":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"state":"REVIEWER"},{"updated":"2021-08-16 09:03:19.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2021-08-16 14:34:34.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e125656a47f7610b98d8d637e020c70f0dc10ea4","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-13 23:09:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c4aab0b9672431086bcf9484d844ba63b511aaff","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-08-14 01:31:55.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/15008/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/14242/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"5d303870085b51ca285bef9af9ee3e0747de8969","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-08-14 05:34:03.000000000","message":"Patch Set 1: Code-Review-2\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"e59f11cc0d1f9507c6e31e626c53b8f658aa552f","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-14 13:32:19.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"0f53a7aed03d07a2ef00208672146af995f245a3","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-14 13:39:41.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"78d0097fe8140a56b4f43b32b9ae84f43437156e","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-08-14 16:29:44.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/15020/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/14254/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"5f8c7bbcdec14358e0cccd17a0b81759f0d506e9","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-08-14 16:35:51.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"2f921cd18d0c4b0038ef3c5aa9ade872d8bf5451","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-16 09:03:19.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"1ff334fe811e12b89bd86c1aa14426e199c5de40","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-16 13:22:10.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"2d42e6ab9faf43f9bd8787f11130e5f799b68ca7","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-16 13:23:46.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"550cc0934dfb8ef3a3c48bf888442d6df57d96e1","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-08-16 14:34:34.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/15043/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/14277/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"fabf82876580a1338335ed349c8977281dfa3efb","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-22 15:32:07.000000000","message":"Topic set to stm32l5x","accounts_in_message":[],"_revision_number":3},{"id":"3637c390d6fe136cc1830b24e8d765d66cbc34e5","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-08-26 06:11:15.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"16beefb1426b322b324ee41b6bf67758e0f8f031","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-08-26 06:37:38.000000000","message":"Change has been successfully cherry-picked as e7e46ba61e6d0bf06f65f352e8607db1dda83da1","accounts_in_message":[],"_revision_number":4}],"current_revision":"e7e46ba61e6d0bf06f65f352e8607db1dda83da1","revisions":{"e7e46ba61e6d0bf06f65f352e8607db1dda83da1":{"kind":"REWORK","_number":4,"created":"2021-08-26 06:37:38.000000000","uploader":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"ref":"refs/changes/35/6435/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/35/6435/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/35/6435/4 \u0026\u0026 git checkout -b change-6435 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/35/6435/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/35/6435/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/35/6435/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/35/6435/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/35/6435/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1247eee4e6e55889b14bec8d81c4748767bb67b8","subject":"flash/stm32l4x: introduce flash programming without loader"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-08-13 23:09:29.000000000","tz":60},"committer":{"name":"Oleksij Rempel","email":"linux@rempel-privat.de","date":"2021-08-26 06:37:38.000000000","tz":0},"subject":"flash/stm32l4x: remove stm32l4_part_info.default_flash_regs","message":"flash/stm32l4x: remove stm32l4_part_info.default_flash_regs\n\nThis struct element is replaced by the usage of F_HAS_L5_FLASH_REGS flag:\nsince over this driver stm32l4_flash_regs is the default register layout,\nand the only exception is STM32L5 family,\nso it\u0027s simpler to manage it using a flag.\n\nNote: the same flag will be used with STM32U5 devices, as they have\nthe same registers layout, which explains the move of stm32l5_s_flash_regs\nbefore the switch(device_id) in order to not re-write this for STM32U5.\n\nChange-Id: I3b67a6f558d9350f609a22524012b6fceb7de7c2\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6435\nReviewed-by: Oleksij Rempel \u003clinux@rempel-privat.de\u003e\nTested-by: jenkins\n"}},"ffaa6d654dac8d89377dd704f3b09fd3146e3493":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2021-08-16 13:22:10.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/35/6435/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/35/6435/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/35/6435/3 \u0026\u0026 git checkout -b change-6435 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/35/6435/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/35/6435/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/35/6435/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/35/6435/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/35/6435/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1b7fe05b0dce105bbb94cc28b6cf841e33f3c913","subject":"flash/stm32l4x: introduce flash programming without loader"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-08-13 23:09:29.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-08-16 12:41:28.000000000","tz":60},"subject":"flash/stm32l4x: remove stm32l4_part_info.default_flash_regs","message":"flash/stm32l4x: remove stm32l4_part_info.default_flash_regs\n\nThis struct element is replaced by the usage of F_HAS_L5_FLASH_REGS flag:\nsince over this driver stm32l4_flash_regs is the default register layout,\nand the only exception is STM32L5 family,\nso it\u0027s simpler to manage it using a flag.\n\nNote: the same flag will be used with STM32U5 devices, as they have\nthe same registers layout, which explains the move of stm32l5_s_flash_regs\nbefore the switch(device_id) in order to not re-write this for STM32U5.\n\nChange-Id: I3b67a6f558d9350f609a22524012b6fceb7de7c2\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}},"1fe89c3af6bc43007df97238c22f1b2f2d1fa639":{"kind":"REWORK","_number":2,"created":"2021-08-14 13:39:41.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/35/6435/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/35/6435/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/35/6435/2 \u0026\u0026 git checkout -b change-6435 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/35/6435/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/35/6435/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/35/6435/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/35/6435/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/35/6435/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b26a376ebbd84aef9e79621a61183bcba29180a5","subject":"flash/stm32l4x: introduce flash programming without loader"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-08-13 23:09:29.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-08-14 12:44:24.000000000","tz":60},"subject":"flash/stm32l4x: remove stm32l4_part_info.default_flash_regs","message":"flash/stm32l4x: remove stm32l4_part_info.default_flash_regs\n\nThis struct element is replaced by the usage of F_HAS_L5_FLASH_REGS flag:\nsince over this driver stm32l4_flash_regs is the default register layout,\nand the only exception is STM32L5 family,\nso it\u0027s simpler to manage it using a flag.\n\nNote: the same flag will be used with STM32U5 devices, as they have\nthe same registers layout, which explains the move of stm32l5_s_flash_regs\nbefore the switch(device_id) in order to not re-write this for STM32U5.\n\nChange-Id: I3b67a6f558d9350f609a22524012b6fceb7de7c2\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}},"fa38bfe0c91642c1e413824f7f79a624b5aae806":{"kind":"REWORK","_number":1,"created":"2021-08-13 23:09:43.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/35/6435/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/35/6435/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/35/6435/1 \u0026\u0026 git checkout -b change-6435 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/35/6435/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/35/6435/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/35/6435/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/35/6435/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/35/6435/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f6656351f95ec3068005cd3ff4b6d68335d688a5","subject":"flash/stm32l4x: introduce flash programming without loader"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-08-13 23:09:29.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-08-13 23:09:29.000000000","tz":60},"subject":"flash/stm32l4x: remove stm32l4_part_info.default_flash_regs","message":"flash/stm32l4x: remove stm32l4_part_info.default_flash_regs\n\nThis struct element is replaced by the usage of F_HAS_L5_FLASH_REGS flag:\nsince over this driver stm32l4_flash_regs is the default register layout,\nand the only exception is STM32L5 family,\nso it\u0027s simpler to manage it using a flag.\n\nNote: the same flag will be used with STM32U5 devices, as they have\nthe same registers layout, which explains the move of stm32l5_s_flash_regs\nbefore the switch(device_id) in order to not re-write this for STM32U5.\n\nChange-Id: I3b67a6f558d9350f609a22524012b6fceb7de7c2\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}