)]}'
{"id":"openocd~master~Ide4cb01b3b38912e2e24b073c94a9560f92d30bb","project":"openocd","branch":"master","hashtags":[],"change_id":"Ide4cb01b3b38912e2e24b073c94a9560f92d30bb","subject":"command: log the command only when it is executed","status":"MERGED","created":"2021-08-14 13:39:30.000000000","updated":"2021-08-22 20:24:44.000000000","submitted":"2021-08-22 20:24:44.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6436","meta_rev_id":"8cd53c71e1c8f7debcdf0917e17d4aecaad7d349","_number":6436,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"value":0,"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-08-22 20:24:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-08-22 20:24:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-08-22 20:24:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-08-14 15:12:18.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-08-15 09:28:10.000000000","updated_by":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"reviewer":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"state":"REVIEWER"},{"updated":"2021-08-15 12:11:29.000000000","updated_by":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"reviewer":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"state":"REVIEWER"}],"messages":[{"id":"3db80f77dba7d03a647a4559ed6922bfd79395b2","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-14 13:39:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fc29e822e5ed2814419e941882d39e8b6fb0080b","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-08-14 15:12:18.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/15018/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/14252/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"6a9dfb3ed54b4bbbbcd3037e7d74a3627531eabe","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-08-15 09:28:10.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"ac57419bc6d111832e39302c42b730c2e38800bc","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-15 12:11:29.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"8cd53c71e1c8f7debcdf0917e17d4aecaad7d349","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-22 20:24:44.000000000","message":"Change has been successfully cherry-picked as 6933dd0231f5b91a33996c1c013eb2459ffd2e87","accounts_in_message":[],"_revision_number":2}],"current_revision":"6933dd0231f5b91a33996c1c013eb2459ffd2e87","revisions":{"4e615adc8a98ecb2a05ad2ffe464c0306c87d47c":{"kind":"REWORK","_number":1,"created":"2021-08-14 13:39:30.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/36/6436/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/36/6436/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/36/6436/1 \u0026\u0026 git checkout -b change-6436 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/36/6436/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/36/6436/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/36/6436/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/36/6436/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/36/6436/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"53556fcded056aa62ffdc6bf0c97bff87d891dab","subject":"tcl/interface: add Ashling Opella-LD FTDI config files"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-08-11 22:14:29.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-08-14 13:35:59.000000000","tz":120},"subject":"command: log the command only when it is executed","message":"command: log the command only when it is executed\n\nIn case of multi-word commands, the command dispatcher is nested\ncalled at each word during command name parsing.\nThe improper position of the call to script_debug() causes the\ncommand line to be logged once at each parsed word.\nIn the example of command \"cpu arm disassemble 0\" the full command\nis logged three times for \"cpu\", \"arm\" and \"disassemble\":\n\n\tDebug: 656617 61843 command.c:201 script_debug(): command - cpu arm disassemble 0\n\tDebug: 656618 61843 command.c:201 script_debug(): command - cpu arm disassemble 0\n\tDebug: 656619 61843 command.c:201 script_debug(): command - cpu arm disassemble 0\n\nCall script_debug() only when the parsing is terminated and the\ncommand handler is going to be executed.\n\nChange-Id: Ide4cb01b3b38912e2e24b073c94a9560f92d30bb\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"6933dd0231f5b91a33996c1c013eb2459ffd2e87":{"kind":"REWORK","_number":2,"created":"2021-08-22 20:24:44.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/36/6436/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/36/6436/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/36/6436/2 \u0026\u0026 git checkout -b change-6436 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/36/6436/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/36/6436/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/36/6436/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/36/6436/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/36/6436/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6f28ac8fdef91b665b3edf5132c03f73fd4e1d1d","subject":"cortex_m: fix command \u0027step address\u0027"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-08-11 22:14:29.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-08-22 20:24:44.000000000","tz":0},"subject":"command: log the command only when it is executed","message":"command: log the command only when it is executed\n\nIn case of multi-word commands, the command dispatcher is nested\ncalled at each word during command name parsing.\nThe improper position of the call to script_debug() causes the\ncommand line to be logged once at each parsed word.\nIn the example of command \"cpu arm disassemble 0\" the full command\nis logged three times for \"cpu\", \"arm\" and \"disassemble\":\n\n\tDebug: 656617 61843 command.c:201 script_debug(): command - cpu arm disassemble 0\n\tDebug: 656618 61843 command.c:201 script_debug(): command - cpu arm disassemble 0\n\tDebug: 656619 61843 command.c:201 script_debug(): command - cpu arm disassemble 0\n\nCall script_debug() only when the parsing is terminated and the\ncommand handler is going to be executed.\n\nChange-Id: Ide4cb01b3b38912e2e24b073c94a9560f92d30bb\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6436\nTested-by: jenkins\nReviewed-by: Oleksij Rempel \u003clinux@rempel-privat.de\u003e\nReviewed-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}