)]}'
{"id":"openocd~master~Ie5f67288511d46fa196bc9f41e6af5504244adaa","project":"openocd","branch":"master","topic":"telnet","attention_set":{},"removed_from_attention_set":{"1000863":{"account":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"last_update":"2021-08-30 13:53:32.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ie5f67288511d46fa196bc9f41e6af5504244adaa","subject":"server/telnet: cleanup the if statement mixed style","status":"MERGED","created":"2021-08-17 12:30:09.000000000","updated":"2021-08-30 13:53:32.000000000","submitted":"2021-08-30 13:53:32.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6438-telnet","meta_rev_id":"e8d8daa1e1478b67ecead865c089045ae68edb9e","_number":6438,"owner":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"value":0,"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-08-30 13:53:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-08-30 13:53:32.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":0,"date":"2021-08-30 13:53:32.000000000","permitted_voting_range":{"min":0,"max":2},"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-08-30 13:53:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-08-17 12:31:38.000000000","updated_by":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"reviewer":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"state":"REVIEWER"},{"updated":"2021-08-17 13:05:01.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-08-17 16:52:00.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"cb3460b29f8ea0371bd5fb87e7ee6597e9937079","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-17 12:30:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7735b00134e5cb9405f649a97fbcef1040e83aa9","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-08-17 13:05:01.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/15066/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/14295/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"35390bd07ae2cf1b40cbb9be35f31b83c78165b7","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-17 16:52:00.000000000","message":"Patch Set 1: Code-Review+1\n\nYes, following the coding style.\nI\u0027m more in favor of switch/case than long sequence of elif, but just personal taste.\nInstead I think we should loop at splitting that huge function. It has already 10 level of indentation! There must be a way to make it more readable!","accounts_in_message":[],"_revision_number":1},{"id":"a803bb8c5d5a94007fe780a8d7d25e98d7d786fb","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-17 17:15:05.000000000","message":"Patch Set 1:\n\nI fully agree on reworking this function.\nI will check if I can come up with an idea..","accounts_in_message":[],"_revision_number":1},{"id":"dbe6de8617380d7745ad60a0afc315dec8ffa065","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-19 11:12:05.000000000","message":"Patch Set 1: Code-Review+1\n\nplease check #6440","accounts_in_message":[],"_revision_number":1},{"id":"97de25eb53cdee0336be8284f04a3dc91c1cfab3","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-22 15:23:45.000000000","message":"Topic set to telnet","accounts_in_message":[],"_revision_number":1},{"id":"74dc008d36ed7e8fe023a5635530d63adab35e29","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-30 13:53:27.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"e8d8daa1e1478b67ecead865c089045ae68edb9e","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-30 13:53:32.000000000","message":"Change has been successfully cherry-picked as efe944dfc9fa9041ec2e006b702e9830f60f04bc","accounts_in_message":[],"_revision_number":2}],"current_revision":"efe944dfc9fa9041ec2e006b702e9830f60f04bc","revisions":{"efe944dfc9fa9041ec2e006b702e9830f60f04bc":{"kind":"REWORK","_number":2,"created":"2021-08-30 13:53:32.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/38/6438/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/38/6438/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/38/6438/2 \u0026\u0026 git checkout -b change-6438 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/38/6438/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/38/6438/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/38/6438/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/38/6438/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/38/6438/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"12e2dfd31ff07d9d13c7f66b799fad90a2698428","subject":"Makefile: drop warning suppression on win build"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-08-17 12:24:56.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-08-30 13:53:32.000000000","tz":0},"subject":"server/telnet: cleanup the if statement mixed style","message":"server/telnet: cleanup the if statement mixed style\n\nChange-Id: Ie5f67288511d46fa196bc9f41e6af5504244adaa\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6438\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\n"}},"a3e196ee87337cfd8bdbc5271088e55814ca568e":{"kind":"REWORK","_number":1,"created":"2021-08-17 12:30:09.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/38/6438/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/38/6438/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/38/6438/1 \u0026\u0026 git checkout -b change-6438 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/38/6438/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/38/6438/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/38/6438/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/38/6438/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/38/6438/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"53556fcded056aa62ffdc6bf0c97bff87d891dab","subject":"tcl/interface: add Ashling Opella-LD FTDI config files"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-08-17 12:24:56.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-08-17 12:24:56.000000000","tz":60},"subject":"server/telnet: cleanup the if statement mixed style","message":"server/telnet: cleanup the if statement mixed style\n\nChange-Id: Ie5f67288511d46fa196bc9f41e6af5504244adaa\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}