)]}'
{"id":"openocd~master~Ib784c827d64fdc439a35db461d8387a62d3bfbbf","project":"openocd","branch":"master","topic":"telnet","attention_set":{},"removed_from_attention_set":{"1000863":{"account":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"last_update":"2021-08-30 13:53:48.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ib784c827d64fdc439a35db461d8387a62d3bfbbf","subject":"server/telnet: support \u0027CTRL+C\u0027","status":"MERGED","created":"2021-08-17 12:30:09.000000000","updated":"2021-08-30 13:53:48.000000000","submitted":"2021-08-30 13:53:48.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6439-telnet","meta_rev_id":"15a9c7bb3f884f657e93ec1d71a2ddd873d7f0bb","_number":6439,"owner":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-08-30 13:53:48.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-08-30 13:53:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":0,"date":"2021-08-30 13:53:48.000000000","permitted_voting_range":{"min":0,"max":2},"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-08-17 12:31:49.000000000","updated_by":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"reviewer":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"state":"REVIEWER"},{"updated":"2021-08-17 13:37:06.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-08-17 16:46:22.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"0762ed9e035927ded34371830d5f93575f786d06","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-17 12:30:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f832f00b19a4145d772b80d793dbe3149186db8e","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-08-17 13:37:06.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/15067/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/14296/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"54f2bbfd3752a5b134b90b1e67730efeab44cb90","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-17 16:46:22.000000000","message":"Patch Set 1: Code-Review+1\n\nNot tested yet, but nice improvement. Thanks","accounts_in_message":[],"_revision_number":1},{"id":"d01d60bed3bba3fb283fc430922672d2ccafb7ed","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-22 15:23:55.000000000","message":"Topic set to telnet","accounts_in_message":[],"_revision_number":1},{"id":"9431a9b9fdde15af4acebbbe37778a686d6de626","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-30 13:53:44.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"15a9c7bb3f884f657e93ec1d71a2ddd873d7f0bb","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-30 13:53:48.000000000","message":"Change has been successfully cherry-picked as 70cd395f3f0b7f7974125ce6e728980e855626ea","accounts_in_message":[],"_revision_number":2}],"current_revision":"70cd395f3f0b7f7974125ce6e728980e855626ea","revisions":{"70cd395f3f0b7f7974125ce6e728980e855626ea":{"kind":"REWORK","_number":2,"created":"2021-08-30 13:53:48.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/39/6439/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/39/6439/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/39/6439/2 \u0026\u0026 git checkout -b change-6439 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/39/6439/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/39/6439/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/39/6439/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/39/6439/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/39/6439/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"efe944dfc9fa9041ec2e006b702e9830f60f04bc","subject":"server/telnet: cleanup the if statement mixed style"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-08-17 12:29:56.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-08-30 13:53:48.000000000","tz":0},"subject":"server/telnet: support \u0027CTRL+C\u0027","message":"server/telnet: support \u0027CTRL+C\u0027\n\nlike in terminal \u0027CTRL+C\u0027:\n - keeps the line content so the user can refer to it (like copy/paste)\n - marks the line with \u0027^C\u0027, as hint that the command was not executed\n - permit the user to write a new command\n\nChange-Id: Ib784c827d64fdc439a35db461d8387a62d3bfbbf\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6439\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\n"}},"0f85b9bbeadc8ab8b9fdbb45a60f2f89885d8d2f":{"kind":"REWORK","_number":1,"created":"2021-08-17 12:30:09.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/39/6439/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/39/6439/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/39/6439/1 \u0026\u0026 git checkout -b change-6439 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/39/6439/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/39/6439/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/39/6439/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/39/6439/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/39/6439/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a3e196ee87337cfd8bdbc5271088e55814ca568e","subject":"server/telnet: cleanup the if statement mixed style"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-08-17 12:29:56.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-08-17 12:29:56.000000000","tz":60},"subject":"server/telnet: support \u0027CTRL+C\u0027","message":"server/telnet: support \u0027CTRL+C\u0027\n\nlike in terminal \u0027CTRL+C\u0027:\n - keeps the line content so the user can refer to it (like copy/paste)\n - marks the line with \u0027^C\u0027, as hint that the command was not executed\n - permit the user to write a new command\n\nChange-Id: Ib784c827d64fdc439a35db461d8387a62d3bfbbf\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}