)]}'
{"id":"openocd~master~I64ecb0c54da83c27a343f2a1df99fc8f9484572a","project":"openocd","branch":"master","topic":"telnet","attention_set":{},"removed_from_attention_set":{"1000863":{"account":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"last_update":"2021-08-31 04:12:52.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I64ecb0c54da83c27a343f2a1df99fc8f9484572a","subject":"server/telnet: simplify telnet_input function","status":"MERGED","created":"2021-08-18 17:44:01.000000000","updated":"2021-08-31 04:12:52.000000000","submitted":"2021-08-31 04:12:52.000000000","submitter":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6440-telnet","meta_rev_id":"c0c8aaba59f83bd8e39f0a912dd21edbb31043f6","_number":6440,"owner":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"value":0,"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"value":0,"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-08-31 04:12:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-08-31 04:12:52.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-08-31 04:12:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-08-31 04:12:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-08-18 17:44:21.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2021-08-18 17:44:39.000000000","updated_by":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"reviewer":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"REVIEWER"},{"updated":"2021-08-18 20:07:01.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-08-30 18:35:47.000000000","updated_by":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"reviewer":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"state":"REVIEWER"}],"messages":[{"id":"028f047bbfd54d2c0b83a8430a7d41c38b468ad3","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-18 17:44:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0a2684ef868a8a61dc43ca815d382268dcd4ea46","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-08-18 18:16:44.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/15068/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/14297/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"0a47923d5952bb3884d55a5493ff5f5204bd0d4c","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-18 19:00:13.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ed6b94f0d884856df95e8fbd1db485e8dfb42fa8","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-18 19:04:11.000000000","message":"Uploaded patch set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"2a28cd033d532c565d8714e8454dc82ea62d2372","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-18 19:04:31.000000000","message":"Patch Set 3:\n\nnow complexity reports:\n\n complexity -c src/server/telnet_server.c\nNOTE: proc telnet_input in file src/server/telnet_server.c line 737\n\tnesting depth reached level 7\n\u003d\u003d\u003e\t*seriously consider rewriting the procedure*.\nComplexity Scores\nScore | ln-ct | nc-lns| file-name(line): proc-name\n  109     152     142   src/server/telnet_server.c(737): telnet_input\ntotal nc-lns      142\n\nthe complexity score is down from 319 to 109","accounts_in_message":[],"_revision_number":3},{"id":"b94f29216eb59574aaa0751edbab20dac8e95332","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-18 19:14:43.000000000","message":"Patch Set 3:\n\n(3 comments)","accounts_in_message":[],"_revision_number":3},{"id":"899cb9549dd55d02f4c9b13ecee62c04946f1fee","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-08-18 20:07:01.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/15070/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/14299/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"9ba1f1b59b15ea25317d4370e9add212c5428c54","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-19 11:10:23.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"74ceb6aed00114e1d1afc940854070e97696f669","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-22 15:24:11.000000000","message":"Topic set to telnet","accounts_in_message":[],"_revision_number":3},{"id":"4803ea457284e8a0399462fd45008d19ba001cde","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-08-30 18:35:47.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"b05c98a418a21f69178e9202893f4ab0ed77f0b6","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-30 22:28:31.000000000","message":"Patch Set 3: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"c0c8aaba59f83bd8e39f0a912dd21edbb31043f6","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-08-31 04:12:52.000000000","message":"Change has been successfully cherry-picked as 259e400276e939f7c8503068312e940dc25bdf46","accounts_in_message":[],"_revision_number":4}],"current_revision":"259e400276e939f7c8503068312e940dc25bdf46","revisions":{"1d219937929c90896ab791cc2e6f40deb1737cb6":{"kind":"REWORK","_number":2,"created":"2021-08-18 19:00:13.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/40/6440/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/40/6440/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/40/6440/2 \u0026\u0026 git checkout -b change-6440 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/40/6440/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/40/6440/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/40/6440/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/40/6440/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/40/6440/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d221c8b539461f161b1d6eb75b7e9d4362cd84aa","subject":"server/telnet: enhance telnet_move_cursor"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-08-18 17:41:49.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-08-18 18:58:44.000000000","tz":60},"subject":"server/telnet: simplify telnet_input function [WIP/RFC]","message":"server/telnet: simplify telnet_input function [WIP/RFC]\n\nrunning complexity on this file tells that:\nNOTE: proc telnet_input in file telnet_server.c line 576\n\tnesting depth reached level 8\n\u003d\u003d\u003e\t*seriously consider rewriting the procedure*.\nComplexity Scores\nScore | ln-ct | nc-lns| file-name(line): proc-name\n  319     272     226   src/server/telnet_server.c(576): telnet_input\ntotal nc-lns      226\n\nso try to reduce the nesting depth of telnet_input function\n\nChange-Id: I64ecb0c54da83c27a343f2a1df99fc8f9484572a\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}},"d57d141e92e105e200d2413629b0cb97fcfc7591":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2021-08-18 19:04:11.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/40/6440/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/40/6440/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/40/6440/3 \u0026\u0026 git checkout -b change-6440 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/40/6440/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/40/6440/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/40/6440/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/40/6440/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/40/6440/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d221c8b539461f161b1d6eb75b7e9d4362cd84aa","subject":"server/telnet: enhance telnet_move_cursor"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-08-18 17:41:49.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-08-18 19:04:06.000000000","tz":60},"subject":"server/telnet: simplify telnet_input function","message":"server/telnet: simplify telnet_input function\n\nrunning complexity on this file tells that:\nNOTE: proc telnet_input in file telnet_server.c line 576\n\tnesting depth reached level 8\n\u003d\u003d\u003e\t*seriously consider rewriting the procedure*.\nComplexity Scores\nScore | ln-ct | nc-lns| file-name(line): proc-name\n  319     272     226   src/server/telnet_server.c(576): telnet_input\ntotal nc-lns      226\n\nso try to reduce the complexity score of telnet_input function\n\nChange-Id: I64ecb0c54da83c27a343f2a1df99fc8f9484572a\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}},"1bfb402a5f66fff99cda256f0e2a18324363913e":{"kind":"REWORK","_number":1,"created":"2021-08-18 17:44:01.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/40/6440/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/40/6440/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/40/6440/1 \u0026\u0026 git checkout -b change-6440 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/40/6440/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/40/6440/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/40/6440/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/40/6440/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/40/6440/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0f85b9bbeadc8ab8b9fdbb45a60f2f89885d8d2f","subject":"server/telnet: support \u0027CTRL+C\u0027"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-08-18 17:41:49.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-08-18 17:43:49.000000000","tz":60},"subject":"server/telnet: simplify telnet_input function [WIP/RFC]","message":"server/telnet: simplify telnet_input function [WIP/RFC]\n\nrunning complexity on this file tells that:\nNOTE: proc telnet_input in file telnet_server.c line 576\n\tnesting depth reached level 8\n\u003d\u003d\u003e\t*seriously consider rewriting the procedure*.\n\nso try to reduce the nesting depth of telnet_input function\n\nChange-Id: I64ecb0c54da83c27a343f2a1df99fc8f9484572a\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}},"259e400276e939f7c8503068312e940dc25bdf46":{"kind":"REWORK","_number":4,"created":"2021-08-31 04:12:52.000000000","uploader":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"ref":"refs/changes/40/6440/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/40/6440/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/40/6440/4 \u0026\u0026 git checkout -b change-6440 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/40/6440/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/40/6440/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/40/6440/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/40/6440/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/40/6440/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9a9e9e2c666dcb4987421f89d3b09ff9951cb0a1","subject":"server/telnet: enhance telnet_move_cursor"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-08-18 17:41:49.000000000","tz":60},"committer":{"name":"Oleksij Rempel","email":"linux@rempel-privat.de","date":"2021-08-31 04:12:52.000000000","tz":0},"subject":"server/telnet: simplify telnet_input function","message":"server/telnet: simplify telnet_input function\n\nrunning complexity on this file tells that:\nNOTE: proc telnet_input in file telnet_server.c line 576\n\tnesting depth reached level 8\n\u003d\u003d\u003e\t*seriously consider rewriting the procedure*.\nComplexity Scores\nScore | ln-ct | nc-lns| file-name(line): proc-name\n  319     272     226   src/server/telnet_server.c(576): telnet_input\ntotal nc-lns      226\n\nso try to reduce the complexity score of telnet_input function\n\nChange-Id: I64ecb0c54da83c27a343f2a1df99fc8f9484572a\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6440\nTested-by: jenkins\nReviewed-by: Oleksij Rempel \u003clinux@rempel-privat.de\u003e\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}