)]}'
{"id":"openocd~master~I24da877e538a458da6d2f8ddc2a681eee404d2cb","project":"openocd","branch":"master","topic":"telnet","attention_set":{},"removed_from_attention_set":{"1000863":{"account":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"last_update":"2021-08-30 13:54:06.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I24da877e538a458da6d2f8ddc2a681eee404d2cb","subject":"server/telnet: enhance telnet_move_cursor","status":"MERGED","created":"2021-08-18 19:00:13.000000000","updated":"2021-08-30 13:54:06.000000000","submitted":"2021-08-30 13:54:06.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6441-telnet","meta_rev_id":"41b2509399e37488c4a6eae37b06d1b23e4e0967","_number":6441,"owner":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-08-30 13:54:06.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-08-30 13:54:06.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-08-30 13:54:06.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-08-18 19:35:54.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-08-18 21:30:26.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"4b06a2ce8d85110675c64a145ba926a4c34e6810","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-18 19:00:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e820460c7a6f3acfdcd6d68fcb484db51a1ed7cf","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-08-18 19:35:54.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/15069/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/14298/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"f2d79c4356a86061e7b78854abf6a693e8ca32cd","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-18 21:30:26.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"9164e91bdc1612dcc44b33a14727afaffd7cc7ac","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-19 11:11:00.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"541e9c20aded2491825b53fa37e42659fc5d8997","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-22 15:24:02.000000000","message":"Topic set to telnet","accounts_in_message":[],"_revision_number":1},{"id":"fd20c686dc7c056fea3ee7bdf756e790ffe098c1","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-30 13:54:01.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"41b2509399e37488c4a6eae37b06d1b23e4e0967","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-30 13:54:06.000000000","message":"Change has been successfully cherry-picked as 9a9e9e2c666dcb4987421f89d3b09ff9951cb0a1","accounts_in_message":[],"_revision_number":2}],"current_revision":"9a9e9e2c666dcb4987421f89d3b09ff9951cb0a1","revisions":{"d221c8b539461f161b1d6eb75b7e9d4362cd84aa":{"kind":"REWORK","_number":1,"created":"2021-08-18 19:00:13.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/41/6441/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/41/6441/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/41/6441/1 \u0026\u0026 git checkout -b change-6441 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/41/6441/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/41/6441/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/41/6441/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/41/6441/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/41/6441/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0f85b9bbeadc8ab8b9fdbb45a60f2f89885d8d2f","subject":"server/telnet: support \u0027CTRL+C\u0027"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-08-18 18:55:48.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-08-18 18:56:39.000000000","tz":60},"subject":"server/telnet: enhance telnet_move_cursor","message":"server/telnet: enhance telnet_move_cursor\n\ninstrument the telnet_move_cursor to detect when there is no change\nof cursor position and if the requested new position is out of bounds.\n\nChange-Id: I24da877e538a458da6d2f8ddc2a681eee404d2cb\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}},"9a9e9e2c666dcb4987421f89d3b09ff9951cb0a1":{"kind":"REWORK","_number":2,"created":"2021-08-30 13:54:06.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/41/6441/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/41/6441/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/41/6441/2 \u0026\u0026 git checkout -b change-6441 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/41/6441/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/41/6441/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/41/6441/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/41/6441/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/41/6441/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"70cd395f3f0b7f7974125ce6e728980e855626ea","subject":"server/telnet: support \u0027CTRL+C\u0027"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-08-18 18:55:48.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-08-30 13:54:06.000000000","tz":0},"subject":"server/telnet: enhance telnet_move_cursor","message":"server/telnet: enhance telnet_move_cursor\n\ninstrument the telnet_move_cursor to detect when there is no change\nof cursor position and if the requested new position is out of bounds.\n\nChange-Id: I24da877e538a458da6d2f8ddc2a681eee404d2cb\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6441\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}