)]}'
{"id":"openocd~master~Iab42cd9d72ecfac14c7e17bae74e0dee2218b235","project":"openocd","branch":"master","hashtags":[],"change_id":"Iab42cd9d72ecfac14c7e17bae74e0dee2218b235","subject":"stlink: fix SWIM mode on stlink-v3","status":"MERGED","created":"2021-08-19 14:32:04.000000000","updated":"2021-08-22 20:22:34.000000000","submitted":"2021-08-22 20:22:34.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6443","meta_rev_id":"0c99d8375163238de42c7c5863109b9da40515e9","_number":6443,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-08-22 20:22:34.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-08-22 20:22:34.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-08-22 20:22:34.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-08-19 15:05:13.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-08-19 16:45:30.000000000","updated_by":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"reviewer":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"state":"REVIEWER"}],"messages":[{"id":"db273e0bdc76b5981078e8902955cc4c55a49c78","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-19 14:32:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7826d54461573ab407ca43802ea4c8fdca122d1e","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-08-19 15:05:13.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/15072/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/14301/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"4655454e0eb30cdb0b0e7c4a8b081b548fd50349","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-19 15:20:01.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"26c0ebd59e30e4a4796eb7a69ea25eacc113eeec","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-08-19 16:45:30.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"45bf1bf265e2a5e35c754d1f7c39987fc1d84c09","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-22 20:22:27.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"0c99d8375163238de42c7c5863109b9da40515e9","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-22 20:22:34.000000000","message":"Change has been successfully cherry-picked as 044e0f8c9aec9fe94d77199e64c813fb4336984b","accounts_in_message":[],"_revision_number":2}],"current_revision":"044e0f8c9aec9fe94d77199e64c813fb4336984b","revisions":{"a6f31f0f53cd0ec649958cce07b1f2345a5c3690":{"kind":"REWORK","_number":1,"created":"2021-08-19 14:32:04.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/43/6443/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/43/6443/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/43/6443/1 \u0026\u0026 git checkout -b change-6443 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/43/6443/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/43/6443/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/43/6443/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/43/6443/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/43/6443/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"53556fcded056aa62ffdc6bf0c97bff87d891dab","subject":"tcl/interface: add Ashling Opella-LD FTDI config files"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-08-19 14:07:21.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-08-19 14:21:29.000000000","tz":120},"subject":"stlink: fix SWIM mode on stlink-v3","message":"stlink: fix SWIM mode on stlink-v3\n\nCommit 89f07325f2e7 (\"stlink: Set speed before entering JTAG/SWD\nmode\") anticipates setting the adapter speed just before entering\nin the JTAG/SWD mode. This to initiate the communication with the\nspeed selected by the user.\nBut SWIM doesn\u0027t allow setting the speed before entering in SWIM\nmode. The resulting error causes OpenOCD to quit.\nThe problem only happens with stlink-v3, due to the different way\nto set the adapter speed on different stlink versions.\n\nSet the speed before entering in the mode only for JTAG and SWD\nmodes.\n\nChange-Id: Iab42cd9d72ecfac14c7e17bae74e0dee2218b235\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: 89f07325f2e7 (\"stlink: Set speed before entering JTAG/SWD mode\")\n"}},"044e0f8c9aec9fe94d77199e64c813fb4336984b":{"kind":"REWORK","_number":2,"created":"2021-08-22 20:22:34.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/43/6443/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/43/6443/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/43/6443/2 \u0026\u0026 git checkout -b change-6443 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/43/6443/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/43/6443/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/43/6443/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/43/6443/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/43/6443/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"013a0e88d2a6e4626987e9fbe056ee1d40026933","subject":"rtos/riot: fix out-of-bounds writes when target is corrupted"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-08-19 14:07:21.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-08-22 20:22:34.000000000","tz":0},"subject":"stlink: fix SWIM mode on stlink-v3","message":"stlink: fix SWIM mode on stlink-v3\n\nCommit 89f07325f2e7 (\"stlink: Set speed before entering JTAG/SWD\nmode\") anticipates setting the adapter speed just before entering\nin the JTAG/SWD mode. This to initiate the communication with the\nspeed selected by the user.\nBut SWIM doesn\u0027t allow setting the speed before entering in SWIM\nmode. The resulting error causes OpenOCD to quit.\nThe problem only happens with stlink-v3, due to the different way\nto set the adapter speed on different stlink versions.\n\nSet the speed before entering in the mode only for JTAG and SWD\nmodes.\n\nChange-Id: Iab42cd9d72ecfac14c7e17bae74e0dee2218b235\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: 89f07325f2e7 (\"stlink: Set speed before entering JTAG/SWD mode\")\nReviewed-on: https://review.openocd.org/c/openocd/+/6443\nTested-by: jenkins\nReviewed-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}