)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"change_message_id":"2acadf07740aec78edf4e538901f0d12104ce738","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4341a8b6_f53a9d06","updated":"2021-09-07 18:04:37.000000000","message":"Visually inspected the code and it looks good. Just one minor comment.","commit_id":"ef21d7608b58ad449dad9b1cf4814bb55baea167"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7e9d585f9b1eb7d702f705c0f2a23a124dc01399","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5e3f2b88_675ea6cd","updated":"2021-09-20 18:07:15.000000000","message":"just rebased on changed 6446","commit_id":"1239896c46cd87351e3087685396973e1b9484f9"}],"src/target/arm_adi_v5.c":[{"author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"change_message_id":"2acadf07740aec78edf4e538901f0d12104ce738","unresolved":true,"context_lines":[{"line_number":893,"context_line":"};"},{"line_number":894,"context_line":""},{"line_number":895,"context_line":"static const struct {"},{"line_number":896,"context_line":"\tuint32_t type;"},{"line_number":897,"context_line":"\tconst char *description;"},{"line_number":898,"context_line":"} ap_types[] \u003d {"},{"line_number":899,"context_line":"\t{ AP_TYPE_JTAG_AP,  \"JTAG-AP\" },"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"58fdf4b1_c998f35c","line":896,"updated":"2021-09-07 18:04:37.000000000","message":"Instead of \"uint32_t\", could make \"enum ap_type\"?","commit_id":"ef21d7608b58ad449dad9b1cf4814bb55baea167"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"88850cc20ee8425b349288dfff75c901664ae81b","unresolved":true,"context_lines":[{"line_number":893,"context_line":"};"},{"line_number":894,"context_line":""},{"line_number":895,"context_line":"static const struct {"},{"line_number":896,"context_line":"\tuint32_t type;"},{"line_number":897,"context_line":"\tconst char *description;"},{"line_number":898,"context_line":"} ap_types[] \u003d {"},{"line_number":899,"context_line":"\t{ AP_TYPE_JTAG_AP,  \"JTAG-AP\" },"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"f716048f_97b2d0ee","line":896,"in_reply_to":"58fdf4b1_c998f35c","updated":"2021-09-08 20:31:44.000000000","message":"Agree! Will fix it","commit_id":"ef21d7608b58ad449dad9b1cf4814bb55baea167"},{"author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"change_message_id":"b4a91b9a09e5aa7156f8eec0294bfd30ed671788","unresolved":false,"context_lines":[{"line_number":893,"context_line":"};"},{"line_number":894,"context_line":""},{"line_number":895,"context_line":"static const struct {"},{"line_number":896,"context_line":"\tuint32_t type;"},{"line_number":897,"context_line":"\tconst char *description;"},{"line_number":898,"context_line":"} ap_types[] \u003d {"},{"line_number":899,"context_line":"\t{ AP_TYPE_JTAG_AP,  \"JTAG-AP\" },"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"76615527_fc97acfa","line":896,"in_reply_to":"f716048f_97b2d0ee","updated":"2021-09-16 00:47:07.000000000","message":"Ack","commit_id":"ef21d7608b58ad449dad9b1cf4814bb55baea167"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"87da88fa48f14afee7eb260ff87fc0cf0cd8ddde","unresolved":true,"context_lines":[{"line_number":1505,"context_line":"\t/* NOTE: a MEM-AP may have a single CoreSight component that\u0027s"},{"line_number":1506,"context_line":"\t * not a ROM table ... or have no such components at all."},{"line_number":1507,"context_line":"\t */"},{"line_number":1508,"context_line":"\tunsigned int class \u003d (apid \u0026 AP_REG_IDR_CLASS_MASK) \u003e\u003e AP_REG_IDR_CLASS_SHIFT;"},{"line_number":1509,"context_line":""},{"line_number":1510,"context_line":"\tif (class \u003d\u003d AP_REG_IDR_CLASS_MEM_AP) {"},{"line_number":1511,"context_line":"\t\tif (is_64bit_ap(ap))"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"8dc0f258_80acf6d6","line":1508,"updated":"2021-08-29 13:23:24.000000000","message":"Could be \u0027const\u0027","commit_id":"ef21d7608b58ad449dad9b1cf4814bb55baea167"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f7576f047fd2e0b83f4f3bd04537dd9d41447238","unresolved":false,"context_lines":[{"line_number":1505,"context_line":"\t/* NOTE: a MEM-AP may have a single CoreSight component that\u0027s"},{"line_number":1506,"context_line":"\t * not a ROM table ... or have no such components at all."},{"line_number":1507,"context_line":"\t */"},{"line_number":1508,"context_line":"\tunsigned int class \u003d (apid \u0026 AP_REG_IDR_CLASS_MASK) \u003e\u003e AP_REG_IDR_CLASS_SHIFT;"},{"line_number":1509,"context_line":""},{"line_number":1510,"context_line":"\tif (class \u003d\u003d AP_REG_IDR_CLASS_MEM_AP) {"},{"line_number":1511,"context_line":"\t\tif (is_64bit_ap(ap))"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"2266e4bd_cd2cc191","line":1508,"in_reply_to":"7f2a2e65_b73f9e2e","updated":"2021-09-16 13:09:29.000000000","message":"Done","commit_id":"ef21d7608b58ad449dad9b1cf4814bb55baea167"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"84619d290f8ca6b82e102691007f09698a231202","unresolved":true,"context_lines":[{"line_number":1505,"context_line":"\t/* NOTE: a MEM-AP may have a single CoreSight component that\u0027s"},{"line_number":1506,"context_line":"\t * not a ROM table ... or have no such components at all."},{"line_number":1507,"context_line":"\t */"},{"line_number":1508,"context_line":"\tunsigned int class \u003d (apid \u0026 AP_REG_IDR_CLASS_MASK) \u003e\u003e AP_REG_IDR_CLASS_SHIFT;"},{"line_number":1509,"context_line":""},{"line_number":1510,"context_line":"\tif (class \u003d\u003d AP_REG_IDR_CLASS_MEM_AP) {"},{"line_number":1511,"context_line":"\t\tif (is_64bit_ap(ap))"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"7f2a2e65_b73f9e2e","line":1508,"in_reply_to":"8dc0f258_80acf6d6","updated":"2021-09-04 07:56:16.000000000","message":"yes! will fix it in v2","commit_id":"ef21d7608b58ad449dad9b1cf4814bb55baea167"}],"src/target/arm_adi_v5.h":[{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"d06f944a543fc853372b336d057841462aac2324","unresolved":true,"context_lines":[{"line_number":370,"context_line":"/*"},{"line_number":371,"context_line":" * Access Port types"},{"line_number":372,"context_line":" */"},{"line_number":373,"context_line":"enum ap_type {"},{"line_number":374,"context_line":"\tAP_TYPE_JTAG_AP  \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_NONE,   0),  /* JTAG-AP */"},{"line_number":375,"context_line":"\tAP_TYPE_COM_AP   \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_COM,    0),  /* COM-AP */"},{"line_number":376,"context_line":"\tAP_TYPE_AHB3_AP  \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_MEM_AP, 1),  /* AHB3 Memory-AP */"},{"line_number":377,"context_line":"\tAP_TYPE_APB_AP   \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_MEM_AP, 2),  /* APB2 or APB3 Memory-AP */"},{"line_number":378,"context_line":"\tAP_TYPE_AXI_AP   \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_MEM_AP, 4),  /* AXI3 or AXI4 Memory-AP */"},{"line_number":379,"context_line":"\tAP_TYPE_AHB5_AP  \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_MEM_AP, 5),  /* AHB5 Memory-AP */"},{"line_number":380,"context_line":"\tAP_TYPE_APB4_AP  \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_MEM_AP, 6),  /* APB4 Memory-AP */"},{"line_number":381,"context_line":"\tAP_TYPE_AXI5_AP  \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_MEM_AP, 7),  /* AXI5 Memory-AP */"},{"line_number":382,"context_line":"\tAP_TYPE_AHB5H_AP \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_MEM_AP, 8),  /* AHB5 with enhanced HPROT Memory-AP */"},{"line_number":383,"context_line":"};"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"/* Check the ap-\u003ecfg_reg Long Address field (bit 1)"},{"line_number":386,"context_line":" *"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"5ec11b57_e4d026b0","line":383,"range":{"start_line":373,"start_character":0,"end_line":383,"end_character":2},"updated":"2021-08-29 19:44:51.000000000","message":"is it possible to use defines for the type ?","commit_id":"ef21d7608b58ad449dad9b1cf4814bb55baea167"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"3b0c366eb3f900f0efde811f933a108a94af0a97","unresolved":false,"context_lines":[{"line_number":370,"context_line":"/*"},{"line_number":371,"context_line":" * Access Port types"},{"line_number":372,"context_line":" */"},{"line_number":373,"context_line":"enum ap_type {"},{"line_number":374,"context_line":"\tAP_TYPE_JTAG_AP  \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_NONE,   0),  /* JTAG-AP */"},{"line_number":375,"context_line":"\tAP_TYPE_COM_AP   \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_COM,    0),  /* COM-AP */"},{"line_number":376,"context_line":"\tAP_TYPE_AHB3_AP  \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_MEM_AP, 1),  /* AHB3 Memory-AP */"},{"line_number":377,"context_line":"\tAP_TYPE_APB_AP   \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_MEM_AP, 2),  /* APB2 or APB3 Memory-AP */"},{"line_number":378,"context_line":"\tAP_TYPE_AXI_AP   \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_MEM_AP, 4),  /* AXI3 or AXI4 Memory-AP */"},{"line_number":379,"context_line":"\tAP_TYPE_AHB5_AP  \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_MEM_AP, 5),  /* AHB5 Memory-AP */"},{"line_number":380,"context_line":"\tAP_TYPE_APB4_AP  \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_MEM_AP, 6),  /* APB4 Memory-AP */"},{"line_number":381,"context_line":"\tAP_TYPE_AXI5_AP  \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_MEM_AP, 7),  /* AXI5 Memory-AP */"},{"line_number":382,"context_line":"\tAP_TYPE_AHB5H_AP \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_MEM_AP, 8),  /* AHB5 with enhanced HPROT Memory-AP */"},{"line_number":383,"context_line":"};"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"/* Check the ap-\u003ecfg_reg Long Address field (bit 1)"},{"line_number":386,"context_line":" *"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"5057fca6_4e9d1472","line":383,"range":{"start_line":373,"start_character":0,"end_line":383,"end_character":2},"in_reply_to":"3484fabb_757288fc","updated":"2021-09-20 15:52:52.000000000","message":"crystal clear, Thanks Antonio.\nThen, please ignore my comment.","commit_id":"ef21d7608b58ad449dad9b1cf4814bb55baea167"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"84619d290f8ca6b82e102691007f09698a231202","unresolved":true,"context_lines":[{"line_number":370,"context_line":"/*"},{"line_number":371,"context_line":" * Access Port types"},{"line_number":372,"context_line":" */"},{"line_number":373,"context_line":"enum ap_type {"},{"line_number":374,"context_line":"\tAP_TYPE_JTAG_AP  \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_NONE,   0),  /* JTAG-AP */"},{"line_number":375,"context_line":"\tAP_TYPE_COM_AP   \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_COM,    0),  /* COM-AP */"},{"line_number":376,"context_line":"\tAP_TYPE_AHB3_AP  \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_MEM_AP, 1),  /* AHB3 Memory-AP */"},{"line_number":377,"context_line":"\tAP_TYPE_APB_AP   \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_MEM_AP, 2),  /* APB2 or APB3 Memory-AP */"},{"line_number":378,"context_line":"\tAP_TYPE_AXI_AP   \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_MEM_AP, 4),  /* AXI3 or AXI4 Memory-AP */"},{"line_number":379,"context_line":"\tAP_TYPE_AHB5_AP  \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_MEM_AP, 5),  /* AHB5 Memory-AP */"},{"line_number":380,"context_line":"\tAP_TYPE_APB4_AP  \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_MEM_AP, 6),  /* APB4 Memory-AP */"},{"line_number":381,"context_line":"\tAP_TYPE_AXI5_AP  \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_MEM_AP, 7),  /* AXI5 Memory-AP */"},{"line_number":382,"context_line":"\tAP_TYPE_AHB5H_AP \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_MEM_AP, 8),  /* AHB5 with enhanced HPROT Memory-AP */"},{"line_number":383,"context_line":"};"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"/* Check the ap-\u003ecfg_reg Long Address field (bit 1)"},{"line_number":386,"context_line":" *"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"61df623c_110c9f74","line":383,"range":{"start_line":373,"start_character":0,"end_line":383,"end_character":2},"in_reply_to":"5ec11b57_e4d026b0","updated":"2021-09-04 07:56:16.000000000","message":"Yes, from general coding point of view there is no difference.\nBut in the future I would like to address the static check on enum values. These are passed as arguments to dap_find_ap() as enum ap_type and will be checked.\nIf you don\u0027t mind, I would keep this as is.","commit_id":"ef21d7608b58ad449dad9b1cf4814bb55baea167"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"84540ca7d4b5943eb79afdee758cfff48b58f50b","unresolved":true,"context_lines":[{"line_number":370,"context_line":"/*"},{"line_number":371,"context_line":" * Access Port types"},{"line_number":372,"context_line":" */"},{"line_number":373,"context_line":"enum ap_type {"},{"line_number":374,"context_line":"\tAP_TYPE_JTAG_AP  \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_NONE,   0),  /* JTAG-AP */"},{"line_number":375,"context_line":"\tAP_TYPE_COM_AP   \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_COM,    0),  /* COM-AP */"},{"line_number":376,"context_line":"\tAP_TYPE_AHB3_AP  \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_MEM_AP, 1),  /* AHB3 Memory-AP */"},{"line_number":377,"context_line":"\tAP_TYPE_APB_AP   \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_MEM_AP, 2),  /* APB2 or APB3 Memory-AP */"},{"line_number":378,"context_line":"\tAP_TYPE_AXI_AP   \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_MEM_AP, 4),  /* AXI3 or AXI4 Memory-AP */"},{"line_number":379,"context_line":"\tAP_TYPE_AHB5_AP  \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_MEM_AP, 5),  /* AHB5 Memory-AP */"},{"line_number":380,"context_line":"\tAP_TYPE_APB4_AP  \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_MEM_AP, 6),  /* APB4 Memory-AP */"},{"line_number":381,"context_line":"\tAP_TYPE_AXI5_AP  \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_MEM_AP, 7),  /* AXI5 Memory-AP */"},{"line_number":382,"context_line":"\tAP_TYPE_AHB5H_AP \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_MEM_AP, 8),  /* AHB5 with enhanced HPROT Memory-AP */"},{"line_number":383,"context_line":"};"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"/* Check the ap-\u003ecfg_reg Long Address field (bit 1)"},{"line_number":386,"context_line":" *"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"d117e48a_4bbdac81","line":383,"range":{"start_line":373,"start_character":0,"end_line":383,"end_character":2},"in_reply_to":"61df623c_110c9f74","updated":"2021-09-20 13:27:25.000000000","message":"maybe I haven\u0027t expressed myself clearly.\nI was talking about the decimal values using as argument \u0027t\u0027 in the macro AP_REG_IDR_VALUE.\n\ncould these values (0, 1, 2, ..., 8) be defines ?","commit_id":"ef21d7608b58ad449dad9b1cf4814bb55baea167"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"4e646eae109d449d7cf163bc4e0b62742baa731e","unresolved":false,"context_lines":[{"line_number":370,"context_line":"/*"},{"line_number":371,"context_line":" * Access Port types"},{"line_number":372,"context_line":" */"},{"line_number":373,"context_line":"enum ap_type {"},{"line_number":374,"context_line":"\tAP_TYPE_JTAG_AP  \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_NONE,   0),  /* JTAG-AP */"},{"line_number":375,"context_line":"\tAP_TYPE_COM_AP   \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_COM,    0),  /* COM-AP */"},{"line_number":376,"context_line":"\tAP_TYPE_AHB3_AP  \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_MEM_AP, 1),  /* AHB3 Memory-AP */"},{"line_number":377,"context_line":"\tAP_TYPE_APB_AP   \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_MEM_AP, 2),  /* APB2 or APB3 Memory-AP */"},{"line_number":378,"context_line":"\tAP_TYPE_AXI_AP   \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_MEM_AP, 4),  /* AXI3 or AXI4 Memory-AP */"},{"line_number":379,"context_line":"\tAP_TYPE_AHB5_AP  \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_MEM_AP, 5),  /* AHB5 Memory-AP */"},{"line_number":380,"context_line":"\tAP_TYPE_APB4_AP  \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_MEM_AP, 6),  /* APB4 Memory-AP */"},{"line_number":381,"context_line":"\tAP_TYPE_AXI5_AP  \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_MEM_AP, 7),  /* AXI5 Memory-AP */"},{"line_number":382,"context_line":"\tAP_TYPE_AHB5H_AP \u003d AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_MEM_AP, 8),  /* AHB5 with enhanced HPROT Memory-AP */"},{"line_number":383,"context_line":"};"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"/* Check the ap-\u003ecfg_reg Long Address field (bit 1)"},{"line_number":386,"context_line":" *"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"3484fabb_757288fc","line":383,"range":{"start_line":373,"start_character":0,"end_line":383,"end_character":2},"in_reply_to":"d117e48a_4bbdac81","updated":"2021-09-20 15:47:08.000000000","message":"Sorry, misunderstanding.\nPersonally I do not see any value defining a symbol for them because the symbol will never be re-used anywhere in the code.\nAn AP-type is fully specified only by the full triplet (designer, class, type), that\u0027s why I introduce this enum; only the values of this enum are supposed to be used in the code.\nDesigner ID is of course reused (thus the macro); the class can be reused even by not-ARM manufacturers (thus the macro), but the specific field will appear only once in one line in this enum declaration.","commit_id":"ef21d7608b58ad449dad9b1cf4814bb55baea167"}]}