)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"93b2c1b8f96b07dbcab735ceef91806e19a46116","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d937c46b_2fad8495","updated":"2021-09-04 07:47:56.000000000","message":"Thanks for the review! I will send a v2","commit_id":"ecf1ebcde70f3c548154717d4e9e9680077124f2"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ddd9cbfcf51b45a123a3f2770db2e523586161cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f2f872cb_199d3a0e","updated":"2021-09-20 18:07:43.000000000","message":"minor modification after change in 6446","commit_id":"c87a4f97f6cc39f945ace2dc7b82496790aa2ff8"}],"src/target/arm_adi_v5.c":[{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"e80fe2692b32b227db0f8d4df5fc35fb1a0b94a6","unresolved":true,"context_lines":[{"line_number":1226,"context_line":"\t{ ANY_ID, 0x343, \"TI DAPCTL\",                  \"\", }, /* from OMAP3 memmap */"},{"line_number":1227,"context_line":"};"},{"line_number":1228,"context_line":""},{"line_number":1229,"context_line":"static int dap_devtype_display(struct command_invocation *cmd, uint32_t devtype)"},{"line_number":1230,"context_line":"{"},{"line_number":1231,"context_line":"\tconst char *major \u003d \"Reserved\", *subtype \u003d \"Reserved\";"},{"line_number":1232,"context_line":"\tunsigned int minor \u003d (devtype \u0026 ARM_CS_C9_DEVTYPE_SUB_MASK) \u003e\u003e ARM_CS_C9_DEVTYPE_SUB_SHIFT;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"dde49b72_d96bfd16","line":1229,"updated":"2021-08-29 13:25:54.000000000","message":"\u0027dev_type\u0027?","commit_id":"ecf1ebcde70f3c548154717d4e9e9680077124f2"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"93b2c1b8f96b07dbcab735ceef91806e19a46116","unresolved":true,"context_lines":[{"line_number":1226,"context_line":"\t{ ANY_ID, 0x343, \"TI DAPCTL\",                  \"\", }, /* from OMAP3 memmap */"},{"line_number":1227,"context_line":"};"},{"line_number":1228,"context_line":""},{"line_number":1229,"context_line":"static int dap_devtype_display(struct command_invocation *cmd, uint32_t devtype)"},{"line_number":1230,"context_line":"{"},{"line_number":1231,"context_line":"\tconst char *major \u003d \"Reserved\", *subtype \u003d \"Reserved\";"},{"line_number":1232,"context_line":"\tunsigned int minor \u003d (devtype \u0026 ARM_CS_C9_DEVTYPE_SUB_MASK) \u003e\u003e ARM_CS_C9_DEVTYPE_SUB_SHIFT;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"05a28f08_541c46a0","line":1229,"in_reply_to":"dde49b72_d96bfd16","updated":"2021-09-04 07:47:56.000000000","message":"The register name is DEVTYPE in arm documentation. I prefer keeping the same name for the argument too.","commit_id":"ecf1ebcde70f3c548154717d4e9e9680077124f2"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"e80fe2692b32b227db0f8d4df5fc35fb1a0b94a6","unresolved":true,"context_lines":[{"line_number":1229,"context_line":"static int dap_devtype_display(struct command_invocation *cmd, uint32_t devtype)"},{"line_number":1230,"context_line":"{"},{"line_number":1231,"context_line":"\tconst char *major \u003d \"Reserved\", *subtype \u003d \"Reserved\";"},{"line_number":1232,"context_line":"\tunsigned int minor \u003d (devtype \u0026 ARM_CS_C9_DEVTYPE_SUB_MASK) \u003e\u003e ARM_CS_C9_DEVTYPE_SUB_SHIFT;"},{"line_number":1233,"context_line":"\tunsigned int devtype_major \u003d (devtype \u0026 ARM_CS_C9_DEVTYPE_MAJOR_MASK) \u003e\u003e ARM_CS_C9_DEVTYPE_MAJOR_SHIFT;"},{"line_number":1234,"context_line":"\tswitch (devtype_major) {"},{"line_number":1235,"context_line":"\tcase 0:"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"a6e74a2d_65f006d4","line":1232,"updated":"2021-08-29 13:25:54.000000000","message":"Could be \u0027const\u0027","commit_id":"ecf1ebcde70f3c548154717d4e9e9680077124f2"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"1740ba01c2e5a79fbc4ccf48a5bd8cc7f6d0eb93","unresolved":false,"context_lines":[{"line_number":1229,"context_line":"static int dap_devtype_display(struct command_invocation *cmd, uint32_t devtype)"},{"line_number":1230,"context_line":"{"},{"line_number":1231,"context_line":"\tconst char *major \u003d \"Reserved\", *subtype \u003d \"Reserved\";"},{"line_number":1232,"context_line":"\tunsigned int minor \u003d (devtype \u0026 ARM_CS_C9_DEVTYPE_SUB_MASK) \u003e\u003e ARM_CS_C9_DEVTYPE_SUB_SHIFT;"},{"line_number":1233,"context_line":"\tunsigned int devtype_major \u003d (devtype \u0026 ARM_CS_C9_DEVTYPE_MAJOR_MASK) \u003e\u003e ARM_CS_C9_DEVTYPE_MAJOR_SHIFT;"},{"line_number":1234,"context_line":"\tswitch (devtype_major) {"},{"line_number":1235,"context_line":"\tcase 0:"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"fe0871f5_60c0bf28","line":1232,"in_reply_to":"86622f41_4968bccd","updated":"2021-09-16 13:10:04.000000000","message":"Done","commit_id":"ecf1ebcde70f3c548154717d4e9e9680077124f2"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"93b2c1b8f96b07dbcab735ceef91806e19a46116","unresolved":true,"context_lines":[{"line_number":1229,"context_line":"static int dap_devtype_display(struct command_invocation *cmd, uint32_t devtype)"},{"line_number":1230,"context_line":"{"},{"line_number":1231,"context_line":"\tconst char *major \u003d \"Reserved\", *subtype \u003d \"Reserved\";"},{"line_number":1232,"context_line":"\tunsigned int minor \u003d (devtype \u0026 ARM_CS_C9_DEVTYPE_SUB_MASK) \u003e\u003e ARM_CS_C9_DEVTYPE_SUB_SHIFT;"},{"line_number":1233,"context_line":"\tunsigned int devtype_major \u003d (devtype \u0026 ARM_CS_C9_DEVTYPE_MAJOR_MASK) \u003e\u003e ARM_CS_C9_DEVTYPE_MAJOR_SHIFT;"},{"line_number":1234,"context_line":"\tswitch (devtype_major) {"},{"line_number":1235,"context_line":"\tcase 0:"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"86622f41_4968bccd","line":1232,"in_reply_to":"a6e74a2d_65f006d4","updated":"2021-09-04 07:47:56.000000000","message":"Agree! Will change it, with the following line too!","commit_id":"ecf1ebcde70f3c548154717d4e9e9680077124f2"}]}